[PATCH] staging: dgnc: update TODO file

2016-12-11 Thread Fernando Apesteguia
Remove reference to checkpatch warnings since its output is now clean. --- drivers/staging/dgnc/TODO | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/dgnc/TODO b/drivers/staging/dgnc/TODO index 0e0825b..0bdfd26 100644 --- a/drivers/staging/dgnc/TODO +++

[PATCH] staging: dgnc: fix blank line after '{' warnings.

2016-12-06 Thread Fernando Apesteguia
Remove blank lines between open brace and comment. Remove blank lines after comment in line with the rest of the comments of the file. Signed-off-by: Fernando Apesteguia <fernando.apesteg...@gmail.com> --- drivers/staging/dgnc/dgnc_tty.c | 6 -- 1 file changed, 6 deletions(-) diff

[PATCH V3] staging: dgnc: Fix lines longer than 80 characters

2016-12-06 Thread Fernando Apesteguia
For two cases (beginning and end of the patch) I opted to create small functions instead of breaking the the lines in a weird way. The other changes are simple ones: either by breaking the line when appropriate or by turning a comment into a multi-line one. Signed-off-by: Fernando Apesteguia

Re: [PATCH V2] staging: dgnc: Fix lines longer than 80 characters

2016-12-06 Thread Fernando Apesteguia
On Tue, Dec 06, 2016 at 10:12:56AM +0100, Greg KH wrote: > On Sun, Dec 04, 2016 at 08:41:04PM +0100, Fernando Apesteguia wrote: > > For the first lines of the patch, I opted to create a small function > > instead of breaking the the line in a weird way. > > > &

[PATCH V2] staging: dgnc: Fix lines longer than 80 characters

2016-12-04 Thread Fernando Apesteguia
For the first lines of the patch, I opted to create a small function instead of breaking the the line in a weird way. This is v2 of the patch with the name of the function changed from v1 The other changes are simple ones. Signed-off-by: Fernando Apesteguia <fernando.apesteg...@gmail.

Re: [PATCH] staging: dgnc: Fix lines longer than 80 characters

2016-12-04 Thread Fernando Apesteguia
On Sat, Dec 03, 2016 at 11:11:23AM +0100, Greg KH wrote: > On Sat, Dec 03, 2016 at 10:56:54AM +0100, Fernando Apesteguia wrote: > > On Sat, Dec 03, 2016 at 09:51:13AM +0100, Greg KH wrote: > > > On Fri, Dec 02, 2016 at 08:13:49PM +0100, Fernando Apesteguia wrote: > >

Re: [PATCH] staging: dgnc: Fix lines longer than 80 characters

2016-12-03 Thread Fernando Apesteguia
On Sat, Dec 03, 2016 at 09:51:13AM +0100, Greg KH wrote: > On Fri, Dec 02, 2016 at 08:13:49PM +0100, Fernando Apesteguia wrote: > > For the first lines of the patch, I opted to create a small function > > instead of breaking the the line in a weird way. > > > > The ot

[PATCH] staging: dgnc: fix unnamed parameter

2016-12-02 Thread Fernando Apesteguia
This patch fixes a checkpatch warning. Signed-off-by: Fernando Apesteguia <fernando.apesteg...@gmail.com> --- drivers/staging/dgnc/dgnc_tty.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_tty.h b/drivers/staging/dgnc/dgnc_tty.h index 8

[PATCH] staging: dgnc: Fix lines longer than 80 characters

2016-12-02 Thread Fernando Apesteguia
For the first lines of the patch, I opted to create a small function instead of breaking the the line in a weird way. The other changes are simple ones. Signed-off-by: Fernando Apesteguia <fernando.apesteg...@gmail.com> --- drivers/staging/dgnc/dgnc_tty.

[PATCH] staging: dgnc: Fix multi-line comment alignment

2016-10-28 Thread Fernando Apesteguia
This fixes a checkpatch warning. Also, change the line above so it is aligned to the others in the same block. Signed-off-by: Fernando Apesteguia <fernando.apesteg...@gmail.com> --- drivers/staging/dgnc/digi.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff

[PATCH] staging: dgnc: Fix lines longer than 80 chars.

2016-10-28 Thread Fernando Apesteguia
Done by either unindenting some comments or converting them to multi line comments. This fixes some checkpatch warnings. Signed-off-by: Fernando Apesteguia <fernando.apesteg...@gmail.com> --- drivers/staging/dgnc/dgnc_neo.h | 32 ++-- 1 file changed, 22 inse

[PATCH] staging: dgnc: replace DGNC_VERIFY_BOARD macro

2016-10-14 Thread Fernando Apesteguia
The patch replaces the macro with a function (dgnc_get_board) and substitutes the macro statement with a call to that function and a comparison on the returned value. This removes a checkpatch warning. Signed-off-by: Fernando Apesteguia <fernando.apesteg...@gmail.com> --- drivers/stagin

[PATCH] staging: dgnc: Fix lines longer than 80 characters

2016-09-28 Thread Fernando Apesteguia
All the chunks of the patch apply to comments save the first one. Signed-off-by: Fernando Apesteguia <fernando.apesteg...@gmail.com> --- drivers/staging/dgnc/dgnc_neo.c | 67 - 1 file changed, 46 insertions(+), 21 deletions(-) diff --git a/drivers/s

[PATCH] [PATCH] staging: dgnc: Fix comment alignment

2016-09-25 Thread Fernando Apesteguia
As reported by checkpatch. Signed-off-by: Fernando Apesteguia <fernando.apesteg...@gmail.com> --- drivers/staging/dgnc/dgnc_cls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c index 4e1e0dc6..aedca66

Re: [PATCH] staging: dgnc: Fix multi line comment alignment

2016-09-06 Thread Fernando Apesteguia
On Mon, Sep 05, 2016 at 11:45:30PM +0300, Andrey Utkin wrote: > On Mon, Sep 05, 2016 at 08:28:32PM +0200, Fernando Apesteguia wrote: > > Fix alignment in multi line comment block. > > > > Remove extra '*' to use the preferred comment style as in > > Documentation/Codi

[PATCH] staging: dgnc: Fix multi line comment alignment

2016-09-05 Thread Fernando Apesteguia
Fix alignment in multi line comment block. Remove extra '*' to use the preferred comment style as in Documentation/CodingStyle Signed-off-by: Fernando Apesteguia <fernando.apesteg...@gmail.com> --- drivers/staging/dgnc/dgnc_driver.c | 50 +++--- 1 file c

[PATCH] staging: rtl8192u: remove unused function.

2014-08-05 Thread fernando . apesteguia
From: Fernando Apesteguia fernando.apesteg...@gmail.com Remove ComputeTxTime since it is not used. Signed-off-by: Fernando Apesteguia fernando.apesteg...@gmail.com --- drivers/staging/rtl8192u/r8192U_core.c | 22 -- 1 file changed, 22 deletions(-) diff --git a/drivers

[PATCH] Staging: vt6655: staticfy variable

2014-07-30 Thread fernando . apesteguia
From: Fernando Apesteguia fernando.apesteg...@gmail.com Add static to variable. Signed-off-by: Fernando Apesteguia fernando.apesteg...@gmail.com --- drivers/staging/vt6655/ioctl.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6655/ioctl.c b/drivers

[PATCH] Staging: rtl8192u: Staticfy debug method.

2014-07-30 Thread fernando . apesteguia
From: Fernando Apesteguia fernando.apesteg...@gmail.com Add static to debug method. Signed-off-by: Fernando Apesteguia fernando.apesteg...@gmail.com --- drivers/staging/rtl8192u/r8192U_core.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u

[PATCH] staging: vt6655: Fix device table definition.

2014-07-29 Thread fernando . apesteguia
From: Fernando Apesteguia fernando.apesteg...@gmail.com Add static to the definition of the pci device table. Signed-off-by: Fernando Apesteguia fernando.apesteg...@gmail.com --- drivers/staging/vt6655/device_main.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH] staging: silicom: add blank line after declarations

2014-05-07 Thread fernando . apesteguia
From: Fernando Apesteguia fernando.apesteg...@gmail.com Add blank line after declarations and delete extra blank line at the beginning of the function Signed-off-by: Fernando Apesteguia fernando.apesteg...@gmail.com --- drivers/staging/silicom/bpctl_mod.c |2 +- 1 file changed, 1 insertion

[PATCH] Add blank line after declarations

2014-05-06 Thread fernando . apesteguia
From: Fernando Apesteguia fernando.apesteg...@gmail.com Add blank line after declarations and delete extra blank line at the beginning of the function Signed-off-by: Fernando Apesteguia fernando.apesteg...@gmail.com --- drivers/staging/silicom/bpctl_mod.c |2 +- 1 file changed, 1 insertion

[PATCH] [staging/silicom] Fixing missing blank line after declarations

2014-05-05 Thread Fernando Apesteguia
Small fix to driver. If these patches are welcomed, more could come in the future. Regards From d8369cba0552c5ea5f4eadc750434e39785e042a Mon Sep 17 00:00:00 2001 From: Fernando Apesteguia fernando.apesteg...@gmail.com Date: Mon, 5 May 2014 18:16:53 +0200 Subject: [PATCH] [staging/silicom] Fixing

Re: [PATCH] [staging/silicom] Fixing missing blank line after declarations

2014-05-05 Thread Fernando Apesteguia
On Mon, May 05, 2014 at 09:57:48AM -0700, Greg KH wrote: On Mon, May 05, 2014 at 06:40:13PM +0200, Fernando Apesteguia wrote: Small fix to driver. If these patches are welcomed, more could come in the future. Regards From d8369cba0552c5ea5f4eadc750434e39785e042a Mon Sep 17 00:00:00

Re: [PATCH] [staging/silicom] Fixing missing blank line after declarations

2014-05-05 Thread Fernando Apesteguia
On Mon, May 05, 2014 at 10:38:37AM -0700, Greg KH wrote: On Mon, May 05, 2014 at 07:10:37PM +0200, Fernando Apesteguia wrote: On Mon, May 05, 2014 at 09:57:48AM -0700, Greg KH wrote: On Mon, May 05, 2014 at 06:40:13PM +0200, Fernando Apesteguia wrote: Small fix to driver