Re: [PATCH] Staging:bcm: Fixes coding style issues in drivers/staging/bcm/Qos.c

2014-04-16 Thread Greg KH
On Wed, Apr 16, 2014 at 07:39:06PM -0400, Marcos A. Di Pietro wrote: > On 04/16/2014 02:25 PM, Greg KH wrote: > > On Wed, Apr 16, 2014 at 02:18:46PM -0400, Marcos Di Pietro wrote: > >> On Wed, Apr 16, 2014 at 11:39 AM, Greg KH wrote: > >>> On Tue, Apr 15, 2014 at 09:37:18PM -0400, Marcos A. Di Pie

Re: [PATCH] Staging:bcm: Fixes coding style issues in drivers/staging/bcm/Qos.c

2014-04-16 Thread Dan Carpenter
Marcos, you're communicating poorly. You actually sent an ok patch earlier, but then you replied to a different thread "hi did you apply my patch?" and everyone gets confused because you replied to the wrong email. Now you are sending a garbage patch which is not a proper v2 patch and cannot be a

Re: [PATCH] Staging:bcm: Fixes coding style issues in drivers/staging/bcm/Qos.c

2014-04-16 Thread Marcos A. Di Pietro
On 04/16/2014 02:25 PM, Greg KH wrote: > On Wed, Apr 16, 2014 at 02:18:46PM -0400, Marcos Di Pietro wrote: >> On Wed, Apr 16, 2014 at 11:39 AM, Greg KH wrote: >>> On Tue, Apr 15, 2014 at 09:37:18PM -0400, Marcos A. Di Pietro wrote: On 04/10/2014 07:56 PM, Greg KH wrote: > On Thu, Apr 10,

Re: [PATCH] Staging:bcm: Fixes coding style issues in drivers/staging/bcm/Qos.c

2014-04-16 Thread Greg KH
On Wed, Apr 16, 2014 at 02:18:46PM -0400, Marcos Di Pietro wrote: > On Wed, Apr 16, 2014 at 11:39 AM, Greg KH wrote: > > On Tue, Apr 15, 2014 at 09:37:18PM -0400, Marcos A. Di Pietro wrote: > >> On 04/10/2014 07:56 PM, Greg KH wrote: > >> > On Thu, Apr 10, 2014 at 07:27:27PM -0400, Marcos A. Di Pi

Re: [PATCH] Staging:bcm: Fixes coding style issues in drivers/staging/bcm/Qos.c

2014-04-16 Thread Marcos Di Pietro
On Wed, Apr 16, 2014 at 11:39 AM, Greg KH wrote: > On Tue, Apr 15, 2014 at 09:37:18PM -0400, Marcos A. Di Pietro wrote: >> On 04/10/2014 07:56 PM, Greg KH wrote: >> > On Thu, Apr 10, 2014 at 07:27:27PM -0400, Marcos A. Di Pietro wrote: >> >>> That's pretty obviously not going to apply properly, yo

Re: [PATCH] Staging:bcm: Fixes coding style issues in drivers/staging/bcm/Qos.c

2014-04-16 Thread Greg KH
On Tue, Apr 15, 2014 at 09:37:18PM -0400, Marcos A. Di Pietro wrote: > On 04/10/2014 07:56 PM, Greg KH wrote: > > On Thu, Apr 10, 2014 at 07:27:27PM -0400, Marcos A. Di Pietro wrote: > >>> That's pretty obviously not going to apply properly, you have line-wrapp > >>> on. You can't cut-and-paste pa

Re: [PATCH] Staging:bcm: Fixes coding style issues in drivers/staging/bcm/Qos.c

2014-04-16 Thread Dan Carpenter
On Tue, Apr 15, 2014 at 09:37:18PM -0400, Marcos A. Di Pietro wrote: > > Greg, > > Where you able to apply the patch successfully? > Silence means Greg hasn't gotten around to it and no one else has an issue with the patch. Silence after 2 weeks means either the merge window was open or maybe

Re: [PATCH] Staging:bcm: Fixes coding style issues in drivers/staging/bcm/Qos.c

2014-04-15 Thread Marcos A. Di Pietro
On 04/10/2014 07:56 PM, Greg KH wrote: > On Thu, Apr 10, 2014 at 07:27:27PM -0400, Marcos A. Di Pietro wrote: >>> That's pretty obviously not going to apply properly, you have line-wrapp >>> on. You can't cut-and-paste patches into gmail, see >>> Documentation/email_clients.txt for details. >>> >>

Re: [PATCH] Staging:bcm: Fixes coding style issues in drivers/staging/bcm/Qos.c

2014-04-11 Thread Dan Carpenter
This isn't the right way to send a v2 patch. Please resend it. https://www.google.com/search?q=how+to+send+a+v2+patch regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/d

Re: [PATCH] Staging:bcm: Fixes coding style issues in drivers/staging/bcm/Qos.c

2014-04-10 Thread Marcos A. Di Pietro
On 04/10/2014 07:27 PM, Greg KH wrote: > On Thu, Apr 10, 2014 at 06:56:01PM -0400, Marcos A. Di Pietro wrote: >> On 04/10/2014 04:55 PM, Greg KH wrote: >>> On Thu, Apr 10, 2014 at 04:22:13PM -0400, Marcos A. Di Pietro wrote: On 04/10/2014 04:14 PM, Greg KH wrote: > On Tue, Mar 25, 2014 at

Re: [PATCH] Staging:bcm: Fixes coding style issues in drivers/staging/bcm/Qos.c

2014-04-10 Thread Marcos A. Di Pietro
On 04/10/2014 07:56 PM, Greg KH wrote: > On Thu, Apr 10, 2014 at 07:27:27PM -0400, Marcos A. Di Pietro wrote: >>> That's pretty obviously not going to apply properly, you have line-wrapp >>> on. You can't cut-and-paste patches into gmail, see >>> Documentation/email_clients.txt for details. >>> >>

Re: [PATCH] Staging:bcm: Fixes coding style issues in drivers/staging/bcm/Qos.c

2014-04-10 Thread Greg KH
On Thu, Apr 10, 2014 at 07:27:27PM -0400, Marcos A. Di Pietro wrote: > > That's pretty obviously not going to apply properly, you have line-wrapp > > on. You can't cut-and-paste patches into gmail, see > > Documentation/email_clients.txt for details. > > > > thanks, > > > > greg k-h > > > I'm s

Re: [PATCH] Staging:bcm: Fixes coding style issues in drivers/staging/bcm/Qos.c

2014-04-10 Thread Marcos A. Di Pietro
On 04/10/2014 07:27 PM, Greg KH wrote: > On Thu, Apr 10, 2014 at 06:56:01PM -0400, Marcos A. Di Pietro wrote: >> On 04/10/2014 04:55 PM, Greg KH wrote: >>> On Thu, Apr 10, 2014 at 04:22:13PM -0400, Marcos A. Di Pietro wrote: On 04/10/2014 04:14 PM, Greg KH wrote: > On Tue, Mar 25, 2014 at

Re: [PATCH] Staging:bcm: Fixes coding style issues in drivers/staging/bcm/Qos.c

2014-04-10 Thread Greg KH
On Thu, Apr 10, 2014 at 06:56:01PM -0400, Marcos A. Di Pietro wrote: > On 04/10/2014 04:55 PM, Greg KH wrote: > > On Thu, Apr 10, 2014 at 04:22:13PM -0400, Marcos A. Di Pietro wrote: > >> On 04/10/2014 04:14 PM, Greg KH wrote: > >>> On Tue, Mar 25, 2014 at 01:55:47PM -0400, Marcos A. Di Pietro wrot

Re: [PATCH] Staging:bcm: Fixes coding style issues in drivers/staging/bcm/Qos.c

2014-04-10 Thread Marcos A. Di Pietro
On 04/10/2014 04:55 PM, Greg KH wrote: > On Thu, Apr 10, 2014 at 04:22:13PM -0400, Marcos A. Di Pietro wrote: >> On 04/10/2014 04:14 PM, Greg KH wrote: >>> On Tue, Mar 25, 2014 at 01:55:47PM -0400, Marcos A. Di Pietro wrote: Fixes code style errors in drivers/staging/bcm/Qos.c Patch

Re: [PATCH] Staging:bcm: Fixes coding style issues in drivers/staging/bcm/Qos.c

2014-04-10 Thread Greg KH
On Thu, Apr 10, 2014 at 04:22:13PM -0400, Marcos A. Di Pietro wrote: > On 04/10/2014 04:14 PM, Greg KH wrote: > > On Tue, Mar 25, 2014 at 01:55:47PM -0400, Marcos A. Di Pietro wrote: > >> Fixes code style errors in drivers/staging/bcm/Qos.c > >> > >> Patch submitted as part of the Eudyptula Challen

Re: [PATCH] Staging:bcm: Fixes coding style issues in drivers/staging/bcm/Qos.c

2014-04-10 Thread Marcos A. Di Pietro
On 04/10/2014 04:14 PM, Greg KH wrote: > On Tue, Mar 25, 2014 at 01:55:47PM -0400, Marcos A. Di Pietro wrote: >> Fixes code style errors in drivers/staging/bcm/Qos.c >> >> Patch submitted as part of the Eudyptula Challenge. >> >> Signed-off-by: Marcos A. Di Pietro >> --- >> drivers/staging/bcm/Qo

Re: [PATCH] Staging:bcm: Fixes coding style issues in drivers/staging/bcm/Qos.c

2014-04-10 Thread Greg KH
On Tue, Mar 25, 2014 at 01:55:47PM -0400, Marcos A. Di Pietro wrote: > Fixes code style errors in drivers/staging/bcm/Qos.c > > Patch submitted as part of the Eudyptula Challenge. > > Signed-off-by: Marcos A. Di Pietro > --- > drivers/staging/bcm/Qos.c | 13 - > 1 file changed, 8 in

Re: [PATCH] Staging:bcm: Fixes coding style issues in drivers/staging/bcm/Qos.c

2014-03-25 Thread Marcos Di Pietro
Thank you for the advise and the heads up. On Tue, Mar 25, 2014 at 2:14 PM, Greg KH wrote: > On Tue, Mar 25, 2014 at 01:55:47PM -0400, Marcos A. Di Pietro wrote: >> Fixes code style errors in drivers/staging/bcm/Qos.c >> >> Patch submitted as part of the Eudyptula Challenge. >> >> Signed-off-by:

Re: [PATCH] Staging:bcm: Fixes coding style issues in drivers/staging/bcm/Qos.c

2014-03-25 Thread Greg KH
On Tue, Mar 25, 2014 at 01:55:47PM -0400, Marcos A. Di Pietro wrote: > Fixes code style errors in drivers/staging/bcm/Qos.c > > Patch submitted as part of the Eudyptula Challenge. > > Signed-off-by: Marcos A. Di Pietro > --- > drivers/staging/bcm/Qos.c | 13 - > 1 file changed, 8 in

[PATCH] Staging:bcm: Fixes coding style issues in drivers/staging/bcm/Qos.c

2014-03-25 Thread Marcos A. Di Pietro
Fixes code style errors in drivers/staging/bcm/Qos.c Patch submitted as part of the Eudyptula Challenge. Signed-off-by: Marcos A. Di Pietro --- drivers/staging/bcm/Qos.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging