Re: [PATCH] bcm/CmHost.c: Fix noisy compile warnings

2014-10-16 Thread Jeff Kirsher
On Thu, 2014-10-16 at 10:48 +0300, Dan Carpenter wrote: > On Wed, Oct 15, 2014 at 01:03:49PM -0700, Joe Perches wrote: > > On Wed, 2014-10-15 at 22:53 +0300, Dan Carpenter wrote: > > > On Wed, Oct 15, 2014 at 09:11:36AM -0700, Joe Perches wrote: > > > > On Wed, 2014-10-15 at 06:03 -0700, Jeff Kirsh

Re: [PATCH] bcm/CmHost.c: Fix noisy compile warnings

2014-10-16 Thread Dan Carpenter
On Wed, Oct 15, 2014 at 01:03:49PM -0700, Joe Perches wrote: > On Wed, 2014-10-15 at 22:53 +0300, Dan Carpenter wrote: > > On Wed, Oct 15, 2014 at 09:11:36AM -0700, Joe Perches wrote: > > > On Wed, 2014-10-15 at 06:03 -0700, Jeff Kirsher wrote: > > > [] > > > > I thought I remember Greg saying some

Re: [PATCH] bcm/CmHost.c: Fix noisy compile warnings

2014-10-15 Thread Jeff Kirsher
On Thu, 2014-10-16 at 00:24 +0200, Matthias Beyer wrote: > On 15-10-2014 15:19:44, Jeff Kirsher wrote: > > I will just go ahead and create a patch to remove the driver. Greg > can > > then decide to either accept the patch to fix the Kconfig or accept > the > > patch to remove the driver. > > Don

Re: [PATCH] bcm/CmHost.c: Fix noisy compile warnings

2014-10-15 Thread Matthias Beyer
On 15-10-2014 15:19:44, Jeff Kirsher wrote: > I will just go ahead and create a patch to remove the driver. Greg can > then decide to either accept the patch to fix the Kconfig or accept the > patch to remove the driver. Don't forget the maintainers file :-) -- Mit freundlichen Grüßen, Kind reg

Re: [PATCH] bcm/CmHost.c: Fix noisy compile warnings

2014-10-15 Thread Jeff Kirsher
On Wed, 2014-10-15 at 23:41 +0200, Matthias Beyer wrote: > On 15-10-2014 06:03:33, Jeff Kirsher wrote: > > > > I thought I remember Greg saying something about getting rid of this > > driver anyway, but I could be wrong. If Greg decides to keep this > > driver around, then I think we should somet

Re: [PATCH] bcm/CmHost.c: Fix noisy compile warnings

2014-10-15 Thread Matthias Beyer
On 15-10-2014 06:03:33, Jeff Kirsher wrote: > > I thought I remember Greg saying something about getting rid of this > driver anyway, but I could be wrong. If Greg decides to keep this > driver around, then I think we should something like your suggestion > above. Let me throw in my comment here

Re: [PATCH] bcm/CmHost.c: Fix noisy compile warnings

2014-10-15 Thread Joe Perches
On Wed, 2014-10-15 at 22:53 +0300, Dan Carpenter wrote: > On Wed, Oct 15, 2014 at 09:11:36AM -0700, Joe Perches wrote: > > On Wed, 2014-10-15 at 06:03 -0700, Jeff Kirsher wrote: > > [] > > > I thought I remember Greg saying something about getting rid of this > > > driver anyway, but I could be wro

Re: [PATCH] bcm/CmHost.c: Fix noisy compile warnings

2014-10-15 Thread Dan Carpenter
On Wed, Oct 15, 2014 at 09:11:36AM -0700, Joe Perches wrote: > On Wed, 2014-10-15 at 06:03 -0700, Jeff Kirsher wrote: > [] > > I thought I remember Greg saying something about getting rid of this > > driver anyway, but I could be wrong. If Greg decides to keep this > > driver around, then I think

Re: [PATCH] bcm/CmHost.c: Fix noisy compile warnings

2014-10-15 Thread Joe Perches
On Wed, 2014-10-15 at 11:54 -0700, Jeff Kirsher wrote: > On Wed, 2014-10-15 at 15:24 -0300, Fabio Estevam wrote: > > On Wed, Oct 15, 2014 at 2:42 PM, Jeff Kirsher > > wrote: > > > > > I like the idea, but won't this exclude other 32 bit systems like MIPS > > > and I am sure there might be others.

Re: [PATCH] bcm/CmHost.c: Fix noisy compile warnings

2014-10-15 Thread Fabio Estevam
On Wed, Oct 15, 2014 at 3:54 PM, Jeff Kirsher wrote: > On Wed, 2014-10-15 at 15:24 -0300, Fabio Estevam wrote: >> On Wed, Oct 15, 2014 at 2:42 PM, Jeff Kirsher >> wrote: >> >> > I like the idea, but won't this exclude other 32 bit systems like MIPS >> > and I am sure there might be others. I cou

Re: [PATCH] bcm/CmHost.c: Fix noisy compile warnings

2014-10-15 Thread Jeff Kirsher
On Wed, 2014-10-15 at 15:24 -0300, Fabio Estevam wrote: > On Wed, Oct 15, 2014 at 2:42 PM, Jeff Kirsher > wrote: > > > I like the idea, but won't this exclude other 32 bit systems like MIPS > > and I am sure there might be others. I could assume that Beceem WIMAX > > was intended for x86 arch's

Re: [PATCH] bcm/CmHost.c: Fix noisy compile warnings

2014-10-15 Thread Fabio Estevam
On Wed, Oct 15, 2014 at 2:42 PM, Jeff Kirsher wrote: > I like the idea, but won't this exclude other 32 bit systems like MIPS > and I am sure there might be others. I could assume that Beceem WIMAX > was intended for x86 arch's that are 32 bit only, which may be a safe > bet. The only thing we

Re: [PATCH] bcm/CmHost.c: Fix noisy compile warnings

2014-10-15 Thread Jeff Kirsher
On Wed, 2014-10-15 at 09:11 -0700, Joe Perches wrote: > On Wed, 2014-10-15 at 06:03 -0700, Jeff Kirsher wrote: > [] > > I thought I remember Greg saying something about getting rid of this > > driver anyway, but I could be wrong. If Greg decides to keep this > > driver around, then I think we shou

Re: [PATCH] bcm/CmHost.c: Fix noisy compile warnings

2014-10-15 Thread Joe Perches
On Wed, 2014-10-15 at 06:03 -0700, Jeff Kirsher wrote: [] > I thought I remember Greg saying something about getting rid of this > driver anyway, but I could be wrong. If Greg decides to keep this > driver around, then I think we should something like your suggestion > above. Or maybe just make t

Re: [PATCH] bcm/CmHost.c: Fix noisy compile warnings

2014-10-15 Thread Jeff Kirsher
On Wed, 2014-10-15 at 15:59 +0300, Dan Carpenter wrote: > Or we could fix it but add a multi-line comment with lots of capital > letters and exclamation marks. I guess we would need to make a > function > since this cast is in several places. > > void *silence_buggy_casting(u32 pointer) > { >

Re: [PATCH] bcm/CmHost.c: Fix noisy compile warnings

2014-10-15 Thread Dan Carpenter
Or we could fix it but add a multi-line comment with lots of capital letters and exclamation marks. I guess we would need to make a function since this cast is in several places. void *silence_buggy_casting(u32 pointer) { /* * DANGER! DANGER! DANGER! DANGER! DANGER! DANGER! DANGE

Re: [PATCH] bcm/CmHost.c: Fix noisy compile warnings

2014-10-15 Thread Dan Carpenter
On Wed, Oct 15, 2014 at 05:26:39AM -0700, Jeff Kirsher wrote: > The Beceem WIMAX was generating compile warnings on 64bit machines, > which were: > > drivers/staging/bcm/CmHost.c: In function ‘StoreCmControlResponseMessage’: > drivers/staging/bcm/CmHost.c:1503:3: warning: cast to pointer from inte

Re: [PATCH] bcm/CmHost.c: Fix noisy compile warnings

2014-10-15 Thread Joe Perches
On Wed, 2014-10-15 at 05:26 -0700, Jeff Kirsher wrote: > The Beceem WIMAX was generating compile warnings on 64bit machines, > which were: > > drivers/staging/bcm/CmHost.c: In function ‘StoreCmControlResponseMessage’: > drivers/staging/bcm/CmHost.c:1503:3: warning: cast to pointer from integer of

[PATCH] bcm/CmHost.c: Fix noisy compile warnings

2014-10-15 Thread Jeff Kirsher
The Beceem WIMAX was generating compile warnings on 64bit machines, which were: drivers/staging/bcm/CmHost.c: In function ‘StoreCmControlResponseMessage’: drivers/staging/bcm/CmHost.c:1503:3: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] (struct bcm_connect_mg