Re: [PATCH] cptm1217: check if interrupts are masked at probe

2015-01-04 Thread devendra.aaru
>>> you are addressing the memory leak which is not mentioned in change-log. >> >> i am pasting part of commit log here: >> >> commit log: "added the check and the failure path". >> >> Is this not enough to understand ? > > you should have mentioned that memory is never released in previous > secti

Re: [PATCH] cptm1217: check if interrupts are masked at probe

2015-01-04 Thread sanjeev sharma
On Mon, Jan 5, 2015 at 11:52 AM, devendra.aaru wrote: > On Mon, Jan 5, 2015 at 1:21 AM, sanjeev sharma > wrote: >> On Mon, Jan 5, 2015 at 11:41 AM, devendra.aaru >> wrote: >>> On Mon, Jan 5, 2015 at 1:04 AM, sanjeev sharma >>> wrote: On Fri, Jan 2, 2015 at 11:47 PM, Devendra Naga w

Re: [PATCH] cptm1217: check if interrupts are masked at probe

2015-01-04 Thread devendra.aaru
On Mon, Jan 5, 2015 at 1:21 AM, sanjeev sharma wrote: > On Mon, Jan 5, 2015 at 11:41 AM, devendra.aaru > wrote: >> On Mon, Jan 5, 2015 at 1:04 AM, sanjeev sharma >> wrote: >>> On Fri, Jan 2, 2015 at 11:47 PM, Devendra Naga >>> wrote: the function cp_tm1217_mask_interrupt can return failu

Re: [PATCH] cptm1217: check if interrupts are masked at probe

2015-01-04 Thread sanjeev sharma
On Mon, Jan 5, 2015 at 11:41 AM, devendra.aaru wrote: > On Mon, Jan 5, 2015 at 1:04 AM, sanjeev sharma > wrote: >> On Fri, Jan 2, 2015 at 11:47 PM, Devendra Naga >> wrote: >>> the function cp_tm1217_mask_interrupt can return failure. >>> added the check and the failure path. >>> >>> Cc: Ramesh

Re: [PATCH] cptm1217: check if interrupts are masked at probe

2015-01-04 Thread devendra.aaru
On Mon, Jan 5, 2015 at 1:04 AM, sanjeev sharma wrote: > On Fri, Jan 2, 2015 at 11:47 PM, Devendra Naga > wrote: >> the function cp_tm1217_mask_interrupt can return failure. >> added the check and the failure path. >> >> Cc: Ramesh Agarwal >> Signed-off-by: Devendra Naga >> --- >> >> build tes

Re: [PATCH] cptm1217: check if interrupts are masked at probe

2015-01-04 Thread sanjeev sharma
On Fri, Jan 2, 2015 at 11:47 PM, Devendra Naga wrote: > the function cp_tm1217_mask_interrupt can return failure. > added the check and the failure path. > > Cc: Ramesh Agarwal > Signed-off-by: Devendra Naga > --- > > build tested only on x86_64. config is allmodconfig. > > drivers/staging/cpt

[PATCH] cptm1217: check if interrupts are masked at probe

2015-01-02 Thread Devendra Naga
the function cp_tm1217_mask_interrupt can return failure. added the check and the failure path. Cc: Ramesh Agarwal Signed-off-by: Devendra Naga --- build tested only on x86_64. config is allmodconfig. drivers/staging/cptm1217/clearpad_tm1217.c | 6 ++ 1 file changed, 6 insertions(+) dif