Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-31 Thread Chris Metcalf
On 7/17/2014 5:05 PM, Arnd Bergmann wrote: On Thursday 17 July 2014 16:41:14 Chris Metcalf wrote: On 7/17/2014 7:28 AM, Chen Gang wrote: According to current source code, tile still has chance to choose NO_IOMEM, for me, welcome the tile's maintainer's ideas or suggestions. I'm not really

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-23 Thread Chen Gang
On 07/17/2014 05:19 PM, Chen Gang wrote: On 07/17/2014 05:16 PM, Dan Carpenter wrote: On Thu, Jul 17, 2014 at 04:59:09PM +0800, Chen Gang wrote: + return (__force void __iomem *)ERR_PTR(-ENXIO); There's apparently an IOMEM_ERR_PTR() for this nowadays... IOMEM_ERR_PTR() is defined

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-23 Thread Dan Carpenter
On Wed, Jul 23, 2014 at 07:09:22PM +0800, Chen Gang wrote: On 07/17/2014 05:19 PM, Chen Gang wrote: On 07/17/2014 05:16 PM, Dan Carpenter wrote: On Thu, Jul 17, 2014 at 04:59:09PM +0800, Chen Gang wrote: + return (__force void __iomem *)ERR_PTR(-ENXIO); There's

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-23 Thread Chen Gang
On 07/23/2014 07:30 PM, Dan Carpenter wrote: On Wed, Jul 23, 2014 at 07:09:22PM +0800, Chen Gang wrote: On 07/17/2014 05:19 PM, Chen Gang wrote: On 07/17/2014 05:16 PM, Dan Carpenter wrote: On Thu, Jul 17, 2014 at 04:59:09PM +0800, Chen Gang wrote: + return (__force void __iomem

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-22 Thread Arnd Bergmann
On Sunday 20 July 2014 17:45:40 Chen Gang wrote: Next, I shall: - Remove HAS_IOMEM and NO_IOMEM from kernel, firstly. - Try to make dummy IOMEM functions for score architecture. - Continue discussing with UML for it. Oh, sorry, I forgot, after remove IOMEM from kernel,

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-22 Thread Chen Gang
On 07/22/2014 06:32 PM, Arnd Bergmann wrote: On Sunday 20 July 2014 17:45:40 Chen Gang wrote: Next, I shall: - Remove HAS_IOMEM and NO_IOMEM from kernel, firstly. - Try to make dummy IOMEM functions for score architecture. - Continue discussing with UML for it. Oh, sorry, I

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-20 Thread Chen Gang
On 07/19/2014 02:02 AM, Chen Gang wrote: 2014-07-18 18:51 GMT+08:00 Richard Weinberger rich...@nod.at: Am 18.07.2014 12:44, schrieb Chen Gang: On 07/18/2014 03:35 PM, Richard Weinberger wrote: Am 18.07.2014 02:36, schrieb Chen Gang: On 07/18/2014 02:09 AM, Richard Weinberger wrote: Am

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-20 Thread Chen Gang
On 07/20/2014 04:38 PM, Chen Gang wrote: On 07/19/2014 02:02 AM, Chen Gang wrote: 2014-07-18 18:51 GMT+08:00 Richard Weinberger rich...@nod.at: Am 18.07.2014 12:44, schrieb Chen Gang: On 07/18/2014 03:35 PM, Richard Weinberger wrote: Am 18.07.2014 02:36, schrieb Chen Gang: On 07/18/2014

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-20 Thread Richard Weinberger
Am 20.07.2014 10:38, schrieb Chen Gang: On 07/19/2014 02:02 AM, Chen Gang wrote: 2014-07-18 18:51 GMT+08:00 Richard Weinberger rich...@nod.at: Am 18.07.2014 12:44, schrieb Chen Gang: On 07/18/2014 03:35 PM, Richard Weinberger wrote: Am 18.07.2014 02:36, schrieb Chen Gang: On 07/18/2014

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-20 Thread Chen Gang
On 07/20/2014 05:45 PM, Richard Weinberger wrote: Am 20.07.2014 10:38, schrieb Chen Gang: On 07/19/2014 02:02 AM, Chen Gang wrote: 2014-07-18 18:51 GMT+08:00 Richard Weinberger rich...@nod.at: Am 18.07.2014 12:44, schrieb Chen Gang: On 07/18/2014 03:35 PM, Richard Weinberger wrote: Am

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-18 Thread Richard Weinberger
Am 18.07.2014 02:36, schrieb Chen Gang: On 07/18/2014 02:09 AM, Richard Weinberger wrote: Am 17.07.2014 12:48, schrieb Arnd Bergmann: AFAICT, NO_IOMEM only has a real purpose on UML these days. Could we take a shortcut here and make COMPILE_TEST depend on !UML? Getting random stuff to build

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-18 Thread Chen Gang
On 07/18/2014 03:35 PM, Richard Weinberger wrote: Am 18.07.2014 02:36, schrieb Chen Gang: On 07/18/2014 02:09 AM, Richard Weinberger wrote: Am 17.07.2014 12:48, schrieb Arnd Bergmann: AFAICT, NO_IOMEM only has a real purpose on UML these days. Could we take a shortcut here and make

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-18 Thread Lennox Wu
Score can provide dummy functions if HAS_IOMEM and NO_IOMEM will be removed, even if we indeed have no IOMEM. Best, Lennox 2014-07-18 18:51 GMT+08:00 Richard Weinberger rich...@nod.at: Am 18.07.2014 12:44, schrieb Chen Gang: On 07/18/2014 03:35 PM, Richard Weinberger wrote: Am 18.07.2014

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-18 Thread Chen Gang
On 07/18/2014 11:37 PM, Lennox Wu wrote: Score can provide dummy functions if HAS_IOMEM and NO_IOMEM will be removed, even if we indeed have no IOMEM. Thank you for your reply, for score, your ideas is OK to me. And for the COMPILE_TEST needs still discussing below: 2014-07-18 18:51

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Thierry Reding
On Thu, Jul 17, 2014 at 09:27:58AM +0800, Chen Gang wrote: [...] diff --git a/include/linux/device.h b/include/linux/device.h index c2421e0..a7500c3 100644 --- a/include/linux/device.h +++ b/include/linux/device.h @@ -630,7 +630,16 @@ extern unsigned long devm_get_free_pages(struct device

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Chen Gang
On 07/17/2014 04:37 PM, Thierry Reding wrote: On Thu, Jul 17, 2014 at 09:27:58AM +0800, Chen Gang wrote: [...] diff --git a/include/linux/device.h b/include/linux/device.h index c2421e0..a7500c3 100644 --- a/include/linux/device.h +++ b/include/linux/device.h @@ -630,7 +630,16 @@ extern

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Dan Carpenter
On Thu, Jul 17, 2014 at 04:59:09PM +0800, Chen Gang wrote: + return (__force void __iomem *)ERR_PTR(-ENXIO); There's apparently an IOMEM_ERR_PTR() for this nowadays... IOMEM_ERR_PTR() is defined within lib/devres.c, not in ./include. But may we move it from lib/devres.c to

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Chen Gang
On 07/17/2014 05:16 PM, Dan Carpenter wrote: On Thu, Jul 17, 2014 at 04:59:09PM +0800, Chen Gang wrote: + return (__force void __iomem *)ERR_PTR(-ENXIO); There's apparently an IOMEM_ERR_PTR() for this nowadays... IOMEM_ERR_PTR() is defined within lib/devres.c, not in ./include. But may

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Arnd Bergmann
On Thursday 17 July 2014 09:27:58 Chen Gang wrote: gfp_t gfp_mask, unsigned int order); extern void devm_free_pages(struct device *dev, unsigned long addr); +#ifdef CONFIG_HAS_IOMEM void __iomem *devm_ioremap_resource(struct device *dev, struct

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Richard Weinberger
Am 17.07.2014 11:20, schrieb Arnd Bergmann: On Thursday 17 July 2014 09:27:58 Chen Gang wrote: gfp_t gfp_mask, unsigned int order); extern void devm_free_pages(struct device *dev, unsigned long addr); +#ifdef CONFIG_HAS_IOMEM void __iomem

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Chen Gang
On 07/17/2014 05:20 PM, Arnd Bergmann wrote: On Thursday 17 July 2014 09:27:58 Chen Gang wrote: gfp_t gfp_mask, unsigned int order); extern void devm_free_pages(struct device *dev, unsigned long addr); +#ifdef CONFIG_HAS_IOMEM void __iomem

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Thierry Reding
On Thu, Jul 17, 2014 at 05:29:31PM +0800, Chen Gang wrote: On 07/17/2014 05:20 PM, Arnd Bergmann wrote: On Thursday 17 July 2014 09:27:58 Chen Gang wrote: gfp_t gfp_mask, unsigned int order); extern void devm_free_pages(struct device *dev,

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Thierry Reding
On Thu, Jul 17, 2014 at 11:20:36AM +0200, Arnd Bergmann wrote: [...] score should set HAS_IOMEM and doesn't even have public compilers This begs an interesting question. Should it be made a requirement to have publicly available compilers for new architectures so that they

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Arnd Bergmann
On Thursday 17 July 2014 11:26:57 Richard Weinberger wrote: Am 17.07.2014 11:20, schrieb Arnd Bergmann: On Thursday 17 July 2014 09:27:58 Chen Gang wrote: gfp_t gfp_mask, unsigned int order); extern void devm_free_pages(struct device *dev,

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Arnd Bergmann
On Thursday 17 July 2014 11:56:58 Thierry Reding wrote: On Thu, Jul 17, 2014 at 11:20:36AM +0200, Arnd Bergmann wrote: [...] score should set HAS_IOMEM and doesn't even have public compilers This begs an interesting question. Should it be made a requirement to have

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Arnd Bergmann
On Thursday 17 July 2014 17:29:31 Chen Gang wrote: COMPILE_TEST is a great tool in general, but it has its limits. In particular, the case for !CONFIG_IOMEM is completely obscure and we won't find any bugs by allowing more drivers to be built in those configurations, but attempting to

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Lars-Peter Clausen
On 07/17/2014 11:20 AM, Arnd Bergmann wrote: On Thursday 17 July 2014 09:27:58 Chen Gang wrote: gfp_t gfp_mask, unsigned int order); extern void devm_free_pages(struct device *dev, unsigned long addr); +#ifdef CONFIG_HAS_IOMEM void __iomem

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Arnd Bergmann
On Thursday 17 July 2014 12:40:25 Lars-Peter Clausen wrote: On 07/17/2014 11:20 AM, Arnd Bergmann wrote: On Thursday 17 July 2014 09:27:58 Chen Gang wrote: gfp_t gfp_mask, unsigned int order); extern void devm_free_pages(struct device *dev,

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Thierry Reding
On Thu, Jul 17, 2014 at 12:33:32PM +0200, Arnd Bergmann wrote: On Thursday 17 July 2014 11:56:58 Thierry Reding wrote: On Thu, Jul 17, 2014 at 11:20:36AM +0200, Arnd Bergmann wrote: [...] score should set HAS_IOMEM and doesn't even have public compilers This

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Richard Weinberger
Am 17.07.2014 12:28, schrieb Arnd Bergmann: On Thursday 17 July 2014 11:26:57 Richard Weinberger wrote: Am 17.07.2014 11:20, schrieb Arnd Bergmann: On Thursday 17 July 2014 09:27:58 Chen Gang wrote: gfp_t gfp_mask, unsigned int order); extern void

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Chen Gang
On 07/17/2014 06:55 PM, Thierry Reding wrote: On Thu, Jul 17, 2014 at 12:33:32PM +0200, Arnd Bergmann wrote: On Thursday 17 July 2014 11:56:58 Thierry Reding wrote: On Thu, Jul 17, 2014 at 11:20:36AM +0200, Arnd Bergmann wrote: [...] score should set HAS_IOMEM and

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Arnd Bergmann
On Thursday 17 July 2014 12:58:55 Richard Weinberger wrote: This is what I got upon trying earlier. I have not attempted to look into why this is happening. Note this is on linux-next from yesterday, not mainline as I incorrectly stated above. In file included from

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Chen Gang
On 07/17/2014 06:48 PM, Arnd Bergmann wrote: On Thursday 17 July 2014 12:40:25 Lars-Peter Clausen wrote: On 07/17/2014 11:20 AM, Arnd Bergmann wrote: On Thursday 17 July 2014 09:27:58 Chen Gang wrote: gfp_t gfp_mask, unsigned int order); extern

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Chen Gang
On 07/17/2014 06:58 PM, Richard Weinberger wrote: Am 17.07.2014 12:28, schrieb Arnd Bergmann: On Thursday 17 July 2014 11:26:57 Richard Weinberger wrote: Am 17.07.2014 11:20, schrieb Arnd Bergmann: On Thursday 17 July 2014 09:27:58 Chen Gang wrote:

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Chen Gang
On 07/17/2014 06:38 PM, Arnd Bergmann wrote: On Thursday 17 July 2014 17:29:31 Chen Gang wrote: COMPILE_TEST is a great tool in general, but it has its limits. In particular, the case for !CONFIG_IOMEM is completely obscure and we won't find any bugs by allowing more drivers to be built in

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Richard Weinberger
Am 17.07.2014 12:48, schrieb Arnd Bergmann: AFAICT, NO_IOMEM only has a real purpose on UML these days. Could we take a shortcut here and make COMPILE_TEST depend on !UML? Getting random stuff to build on UML seems pointless to me and we special-case it in a number of places already. If UML

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Chris Metcalf
On 7/17/2014 7:28 AM, Chen Gang wrote: On 07/17/2014 06:48 PM, Arnd Bergmann wrote: AFAICT, NO_IOMEM only has a real purpose on UML these days. Could we take a shortcut here and make COMPILE_TEST depend on !UML? Getting random stuff to build on UML seems pointless to me and we special-case it

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Arnd Bergmann
On Thursday 17 July 2014 16:41:14 Chris Metcalf wrote: On 7/17/2014 7:28 AM, Chen Gang wrote: On 07/17/2014 06:48 PM, Arnd Bergmann wrote: AFAICT, NO_IOMEM only has a real purpose on UML these days. Could we take a shortcut here and make COMPILE_TEST depend on !UML? Getting random stuff

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Chen Gang
On 07/18/2014 05:05 AM, Arnd Bergmann wrote: On Thursday 17 July 2014 16:41:14 Chris Metcalf wrote: On 7/17/2014 7:28 AM, Chen Gang wrote: On 07/17/2014 06:48 PM, Arnd Bergmann wrote: AFAICT, NO_IOMEM only has a real purpose on UML these days. Could we take a shortcut here and make

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Chen Gang
On 07/18/2014 02:09 AM, Richard Weinberger wrote: Am 17.07.2014 12:48, schrieb Arnd Bergmann: AFAICT, NO_IOMEM only has a real purpose on UML these days. Could we take a shortcut here and make COMPILE_TEST depend on !UML? Getting random stuff to build on UML seems pointless to me and we

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-16 Thread Chen Gang
On 07/15/2014 10:38 PM, Chen Gang wrote: On 07/15/2014 09:11 AM, Chen Gang wrote: On 07/15/2014 08:53 AM, Guenter Roeck wrote: On 07/14/2014 05:34 PM, Chen Gang wrote: On 07/14/2014 05:22 PM, Chen Gang wrote: 在 2014年7月14日,下午4:57,Richard Weinberger rich...@nod.at 写道: Am 14.07.2014

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-16 Thread Guenter Roeck
On 07/16/2014 06:27 PM, Chen Gang wrote: On 07/15/2014 10:38 PM, Chen Gang wrote: On 07/15/2014 09:11 AM, Chen Gang wrote: On 07/15/2014 08:53 AM, Guenter Roeck wrote: On 07/14/2014 05:34 PM, Chen Gang wrote: On 07/14/2014 05:22 PM, Chen Gang wrote: 在 2014年7月14日,下午4:57,Richard

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-15 Thread Chen Gang
On 07/15/2014 09:11 AM, Chen Gang wrote: On 07/15/2014 08:53 AM, Guenter Roeck wrote: On 07/14/2014 05:34 PM, Chen Gang wrote: On 07/14/2014 05:22 PM, Chen Gang wrote: 在 2014年7月14日,下午4:57,Richard Weinberger rich...@nod.at 写道: Am 14.07.2014 10:48, schrieb Lars-Peter Clausen: On

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-14 Thread Thierry Reding
On Sun, Jul 13, 2014 at 12:22:02PM -0700, Greg Kroah-Hartman wrote: On Sun, Jul 13, 2014 at 04:25:06PM +0200, Lars-Peter Clausen wrote: On 07/13/2014 04:03 PM, Richard Weinberger wrote: Am 13.07.2014 15:56, schrieb Lars-Peter Clausen: On 07/13/2014 03:40 PM, Richard Weinberger wrote: Am

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-14 Thread Richard Weinberger
Am 13.07.2014 22:17, schrieb Greg Kroah-Hartman: On Sun, Jul 13, 2014 at 09:33:38PM +0200, Richard Weinberger wrote: Maybe we could add COMPILE_TEST to the version string too? Just to detect such kernels fast in user bug reports... What kind of bug report are you going to get? User manages

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-14 Thread Lars-Peter Clausen
On 07/14/2014 10:31 AM, Richard Weinberger wrote: Am 13.07.2014 22:17, schrieb Greg Kroah-Hartman: On Sun, Jul 13, 2014 at 09:33:38PM +0200, Richard Weinberger wrote: Maybe we could add COMPILE_TEST to the version string too? Just to detect such kernels fast in user bug reports... What kind

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-14 Thread Richard Weinberger
Am 14.07.2014 10:48, schrieb Lars-Peter Clausen: On 07/14/2014 10:31 AM, Richard Weinberger wrote: Am 13.07.2014 22:17, schrieb Greg Kroah-Hartman: On Sun, Jul 13, 2014 at 09:33:38PM +0200, Richard Weinberger wrote: Maybe we could add COMPILE_TEST to the version string too? Just to detect

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-14 Thread Chen Gang
在 2014年7月14日,下午4:57,Richard Weinberger rich...@nod.at 写道: Am 14.07.2014 10:48, schrieb Lars-Peter Clausen: On 07/14/2014 10:31 AM, Richard Weinberger wrote: Am 13.07.2014 22:17, schrieb Greg Kroah-Hartman: On Sun, Jul 13, 2014 at 09:33:38PM +0200, Richard Weinberger wrote: Maybe we could

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-14 Thread Chen Gang
On 07/14/2014 05:22 PM, Chen Gang wrote: 在 2014年7月14日,下午4:57,Richard Weinberger rich...@nod.at 写道: Am 14.07.2014 10:48, schrieb Lars-Peter Clausen: On 07/14/2014 10:31 AM, Richard Weinberger wrote: Am 13.07.2014 22:17, schrieb Greg Kroah-Hartman: On Sun, Jul 13, 2014 at 09:33:38PM +0200,

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-14 Thread Chen Gang
On 07/14/2014 05:22 PM, Chen Gang wrote: 在 2014年7月14日,下午4:57,Richard Weinberger rich...@nod.at 写道: Am 14.07.2014 10:48, schrieb Lars-Peter Clausen: On 07/14/2014 10:31 AM, Richard Weinberger wrote: Am 13.07.2014 22:17, schrieb Greg Kroah-Hartman: On Sun, Jul 13, 2014 at 09:33:38PM +0200,

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-14 Thread Guenter Roeck
On 07/14/2014 05:34 PM, Chen Gang wrote: On 07/14/2014 05:22 PM, Chen Gang wrote: 在 2014年7月14日,下午4:57,Richard Weinberger rich...@nod.at 写道: Am 14.07.2014 10:48, schrieb Lars-Peter Clausen: On 07/14/2014 10:31 AM, Richard Weinberger wrote: Am 13.07.2014 22:17, schrieb Greg Kroah-Hartman:

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-14 Thread Chen Gang
On 07/15/2014 08:53 AM, Guenter Roeck wrote: On 07/14/2014 05:34 PM, Chen Gang wrote: On 07/14/2014 05:22 PM, Chen Gang wrote: 在 2014年7月14日,下午4:57,Richard Weinberger rich...@nod.at 写道: Am 14.07.2014 10:48, schrieb Lars-Peter Clausen: On 07/14/2014 10:31 AM, Richard Weinberger wrote: Am

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-13 Thread Richard Weinberger
Am 13.07.2014 11:27, schrieb Lennox Wu: As I said before, some configurations don't make sense. If such a configuration can be achieved using allmod/yesconfig it has to be fixed. Chen's fixes seem reasonable as not all architectures support iomem. Thanks, //richard

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-13 Thread Chen Gang
On 07/13/2014 05:45 PM, Richard Weinberger wrote: Am 13.07.2014 11:27, schrieb Lennox Wu: As I said before, some configurations don't make sense. If such a configuration can be achieved using allmod/yesconfig it has to be fixed. Chen's fixes seem reasonable as not all architectures support

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-13 Thread Lars-Peter Clausen
On 07/13/2014 11:45 AM, Richard Weinberger wrote: Am 13.07.2014 11:27, schrieb Lennox Wu: As I said before, some configurations don't make sense. If such a configuration can be achieved using allmod/yesconfig it has to be fixed. Chen's fixes seem reasonable as not all architectures support

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-13 Thread Richard Weinberger
Am 13.07.2014 15:26, schrieb Lars-Peter Clausen: On 07/13/2014 11:45 AM, Richard Weinberger wrote: Am 13.07.2014 11:27, schrieb Lennox Wu: As I said before, some configurations don't make sense. If such a configuration can be achieved using allmod/yesconfig it has to be fixed. Chen's fixes

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-13 Thread Lars-Peter Clausen
On 07/13/2014 03:40 PM, Richard Weinberger wrote: Am 13.07.2014 15:26, schrieb Lars-Peter Clausen: On 07/13/2014 11:45 AM, Richard Weinberger wrote: Am 13.07.2014 11:27, schrieb Lennox Wu: As I said before, some configurations don't make sense. If such a configuration can be achieved using

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-13 Thread Richard Weinberger
Am 13.07.2014 15:56, schrieb Lars-Peter Clausen: On 07/13/2014 03:40 PM, Richard Weinberger wrote: Am 13.07.2014 15:26, schrieb Lars-Peter Clausen: On 07/13/2014 11:45 AM, Richard Weinberger wrote: Am 13.07.2014 11:27, schrieb Lennox Wu: As I said before, some configurations don't make sense.

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-13 Thread Chen Gang
On 07/13/2014 11:14 AM, Chen Gang wrote: [...] And also find a compiler issue, I will try to fix it, but shall not notify kernel mailing list, again. The related issue is below (it seems a kernel issue, but in fact, it is a compiler's issue): CC [M]

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-13 Thread Chen Gang
On 07/13/2014 10:25 PM, Lars-Peter Clausen wrote: On 07/13/2014 04:03 PM, Richard Weinberger wrote: Am 13.07.2014 15:56, schrieb Lars-Peter Clausen: On 07/13/2014 03:40 PM, Richard Weinberger wrote: Am 13.07.2014 15:26, schrieb Lars-Peter Clausen: On 07/13/2014 11:45 AM, Richard Weinberger

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-13 Thread Greg Kroah-Hartman
On Sun, Jul 13, 2014 at 04:25:06PM +0200, Lars-Peter Clausen wrote: On 07/13/2014 04:03 PM, Richard Weinberger wrote: Am 13.07.2014 15:56, schrieb Lars-Peter Clausen: On 07/13/2014 03:40 PM, Richard Weinberger wrote: Am 13.07.2014 15:26, schrieb Lars-Peter Clausen: On 07/13/2014 11:45 AM,

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-13 Thread Richard Weinberger
Am 13.07.2014 21:22, schrieb Greg Kroah-Hartman: On Sun, Jul 13, 2014 at 04:25:06PM +0200, Lars-Peter Clausen wrote: On 07/13/2014 04:03 PM, Richard Weinberger wrote: Am 13.07.2014 15:56, schrieb Lars-Peter Clausen: On 07/13/2014 03:40 PM, Richard Weinberger wrote: Am 13.07.2014 15:26,

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-13 Thread Greg Kroah-Hartman
On Sun, Jul 13, 2014 at 09:33:38PM +0200, Richard Weinberger wrote: Am 13.07.2014 21:22, schrieb Greg Kroah-Hartman: On Sun, Jul 13, 2014 at 04:25:06PM +0200, Lars-Peter Clausen wrote: On 07/13/2014 04:03 PM, Richard Weinberger wrote: Am 13.07.2014 15:56, schrieb Lars-Peter Clausen: On

[PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-12 Thread Chen Gang
Several drivers need 'devm_ioremap_resource' which need HAS_IOMEM enabled. So let them depend on HAS_IOMEM. The related error (with allmodconfig under score): MODPOST 1365 modules ERROR: devm_ioremap_resource [drivers/watchdog/tegra_wdt.ko] undefined! ERROR: devm_ioremap_resource

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-12 Thread Chen Gang
After this last patch, score architecture can pass allmodconfig. :-) And also find a compiler issue, I will try to fix it, but shall not notify kernel mailing list, again. The related issue is below (it seems a kernel issue, but in fact, it is a compiler's issue): CC [M]

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-12 Thread Marek Vasut
On Sunday, July 13, 2014 at 05:07:10 AM, Chen Gang wrote: Several drivers need 'devm_ioremap_resource' which need HAS_IOMEM enabled. So let them depend on HAS_IOMEM. The related error (with allmodconfig under score): MODPOST 1365 modules ERROR: devm_ioremap_resource