Re: [PATCH] staging: dgnc: Patch includes the checkpatch fixes

2015-12-12 Thread Dan Carpenter
838d678b338ae Mon Sep 17 00:00:00 2001 > > > From: Sanidhya Solanki <jpage.l...@gmail.com> > > > Date: Fri, 11 Dec 2015 03:08:53 -0500 > > > Subject: [PATCH] staging: dgnc: Patch includes the checkpatch fixes > > > > > > Don't inclu

Re: [PATCH] staging: dgnc: Patch includes the checkpatch fixes

2015-12-12 Thread Sanidhya Solanki
Thank you everyone for your concern regarding my email client. Unfortunately, there is a bug in "git send-email" that leads to the gmail SMTP server rejecting certain patches sent by the git command. If I can replicate and fix the issue for " git am" (which I do apply after emailing to myself) I

Re: [PATCH] staging: dgnc: Patch includes the checkpatch fixes

2015-12-12 Thread Sudip Mukherjee
On Sat, Dec 12, 2015 at 01:12:21AM -0500, Sanidhya Solanki wrote: > Thank you everyone for your concern regarding my email client. > > Unfortunately, there is a bug in "git send-email" that leads to the gmail > SMTP server rejecting certain patches sent by the git command. Is it? I am using git

Re: [PATCH] staging: dgnc: Patch includes the checkpatch fixes

2015-12-12 Thread Sudip Mukherjee
1:49AM -0500, Sanidhya Solanki wrote: > > > > >From 1dbe78ce98037da5467d817a9db838d678b338ae Mon Sep 17 00:00:00 2001 > > > > From: Sanidhya Solanki <jpage.l...@gmail.com> > > > > Date: Fri, 11 Dec 2015 03:08:53 -0500 > > > > Subject:

Re: [PATCH] staging: dgnc: Patch includes the checkpatch fixes

2015-12-12 Thread Sanidhya Solanki
Sorry about Patch 1/3 having the header information. The rest should be fine. I broke up the patches as you requested. I can also confirm that git am gives me an error if the patch to be applied does not contain the header information. Specifically, "Patch format detection failed.". Yes, this

[PATCH] staging: dgnc: Patch includes the checkpatch fixes

2015-12-11 Thread Sanidhya Solanki
>From 1dbe78ce98037da5467d817a9db838d678b338ae Mon Sep 17 00:00:00 2001 From: Sanidhya Solanki <jpage.l...@gmail.com> Date: Fri, 11 Dec 2015 03:08:53 -0500 Subject: [PATCH] staging: dgnc: Patch includes the checkpatch fixes Patch contains the checkpatch fixes as asked by the TODO.

Re: [PATCH] staging: dgnc: Patch includes the checkpatch fixes

2015-12-11 Thread Sanidhya Solanki
On Fri, 11 Dec 2015 16:02:33 +0300 Dan Carpenter wrote: > > Signed-off-by: Sanidhya Solanki > > @@ -110,7 +98,16 @@ static ssize_t dgnc_vpd_show(struct device *p, struct > > device_attribute *attr, > > int count = 0; > > int i = 0; > >

Re: [PATCH] staging: dgnc: Patch includes the checkpatch fixes

2015-12-11 Thread Dan Carpenter
On Fri, Dec 11, 2015 at 03:21:49AM -0500, Sanidhya Solanki wrote: > >From 1dbe78ce98037da5467d817a9db838d678b338ae Mon Sep 17 00:00:00 2001 > From: Sanidhya Solanki <jpage.l...@gmail.com> > Date: Fri, 11 Dec 2015 03:08:53 -0500 > Subject: [PATCH] staging: dgnc: Patch includes

Re: [PATCH] staging: dgnc: Patch includes the checkpatch fixes

2015-12-11 Thread Dan Carpenter
On Fri, Dec 11, 2015 at 05:10:43AM -0500, Sanidhya Solanki wrote: > On Fri, 11 Dec 2015 16:02:33 +0300 > Dan Carpenter wrote: > > > > Signed-off-by: Sanidhya Solanki > > > @@ -110,7 +98,16 @@ static ssize_t dgnc_vpd_show(struct device *p, struct

Re: [PATCH] staging: dgnc: Patch includes the checkpatch fixes

2015-12-11 Thread Sanidhya Solanki
mail.com> > > Date: Fri, 11 Dec 2015 03:08:53 -0500 > > Subject: [PATCH] staging: dgnc: Patch includes the checkpatch fixes > > > Don't include this stuff. Whenever I remove that part, the "git am" command gives me an error that it cannot detect patch format and the