Re: [PATCH] staging: qlge/qlge_ethtool.c: strlcpy -> strscpy

2021-01-29 Thread Kumar Kartikeya Dwivedi
On 0129, Greg Kroah-Hartman wrote: > [SNIP] > > Yes, because it's copying the source strings to fixed size buffers in > > ethtool_drvinfo, so truncation would be fine here (as it's the driver name > > and > > other identity related stuff). > > So there is no need to make this change, or it is

Re: [PATCH] staging: qlge/qlge_ethtool.c: strlcpy -> strscpy

2021-01-29 Thread Greg Kroah-Hartman
On Fri, Jan 29, 2021 at 02:38:33PM +0530, Kumar Kartikeya Dwivedi wrote: > On 0129, Greg Kroah-Hartman wrote: > > On Fri, Jan 29, 2021 at 01:51:55PM +0530, Kumar Kartikeya Dwivedi wrote: > > > [Forgot to reply-all] > > > > > > On 0129, Greg Kroah-Hartman wrote: > > > > On Fri, Jan 29, 2021 at

Re: [PATCH] staging: qlge/qlge_ethtool.c: strlcpy -> strscpy

2021-01-29 Thread Kumar Kartikeya Dwivedi
On 0129, Greg Kroah-Hartman wrote: > On Fri, Jan 29, 2021 at 01:51:55PM +0530, Kumar Kartikeya Dwivedi wrote: > > [Forgot to reply-all] > > > > On 0129, Greg Kroah-Hartman wrote: > > > On Fri, Jan 29, 2021 at 12:15:23PM +0530, Kumar Kartikeya Dwivedi wrote: > > > > Fixes checkpatch warnings for

Re: [PATCH] staging: qlge/qlge_ethtool.c: strlcpy -> strscpy

2021-01-29 Thread Greg Kroah-Hartman
On Fri, Jan 29, 2021 at 01:51:55PM +0530, Kumar Kartikeya Dwivedi wrote: > [Forgot to reply-all] > > On 0129, Greg Kroah-Hartman wrote: > > On Fri, Jan 29, 2021 at 12:15:23PM +0530, Kumar Kartikeya Dwivedi wrote: > > > Fixes checkpatch warnings for usage of strlcpy. > > > > What warning would

Re: [PATCH] staging: qlge/qlge_ethtool.c: strlcpy -> strscpy

2021-01-29 Thread Kumar Kartikeya Dwivedi
[Forgot to reply-all] On 0129, Greg Kroah-Hartman wrote: > On Fri, Jan 29, 2021 at 12:15:23PM +0530, Kumar Kartikeya Dwivedi wrote: > > Fixes checkpatch warnings for usage of strlcpy. > > What warning would that be? > 5dbdb2d87c294401a22e6a6002f08ebc9fbea38b

Re: [PATCH] staging: qlge/qlge_ethtool.c: strlcpy -> strscpy

2021-01-29 Thread Greg Kroah-Hartman
On Fri, Jan 29, 2021 at 12:15:23PM +0530, Kumar Kartikeya Dwivedi wrote: > Fixes checkpatch warnings for usage of strlcpy. What warning would that be? And if we could just search/replace for this, why hasn't that already happened for the whole tree? thanks, greg k-h

[PATCH] staging: qlge/qlge_ethtool.c: strlcpy -> strscpy

2021-01-28 Thread Kumar Kartikeya Dwivedi
Fixes checkpatch warnings for usage of strlcpy. Signed-off-by: Kumar Kartikeya Dwivedi --- drivers/staging/qlge/qlge_ethtool.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/qlge/qlge_ethtool.c b/drivers/staging/qlge/qlge_ethtool.c index