Eric,
On Mon, Sep 29, 2014 at 07:40:11PM -0500, Eric Rost wrote:
> > >I'll be looking to see that no object
> > code has changed (./scripts/objdiff) across your patch series.
>
> Hmm... I'm thinking of digging into it, but I'm not sure the #if's can
> be gotten rid of sans object code changes, si
> >I'll be looking to see that no object
> code has changed (./scripts/objdiff) across your patch series.
Hmm... I'm thinking of digging into it, but I'm not sure the #if's can
be gotten rid of sans object code changes, since its picking codeblocks
in the precompiler stage, right?
___
On Sun, Sep 28, 2014 at 06:14:45PM -0400, Greg KH wrote:
> How about working on getting rid of the #if crap in this driver, that
> will fix up this { } mess automatically.
Yes, I commented on that earlier, it's a rather big job and may not be
appropriate for a beginner.
Eric, if you'd like to tac
On Sun, Sep 28, 2014 at 05:08:28PM -0500, Eric Rost wrote:
> This patch fixes the following checkpatch.pl Warnings:
>
> WARNING: suspect code indent for conditional statements (16, 16)
> + for (r = 1; r < 2 * RCNT; r += 2 * SKEIN_UNROLL_512)
> [...]
> + {
>
> WARNING:
This patch fixes the following checkpatch.pl Warnings:
WARNING: suspect code indent for conditional statements (16, 16)
+ for (r = 1; r < 2 * RCNT; r += 2 * SKEIN_UNROLL_512)
[...]
+ {
WARNING: suspect code indent for conditional statements (16, 16)
+ for