Re: [PATCH 05/28] staging: wilc1000: wilc_handle_isr: add argument wilc to wilc_handle_isr

2015-10-23 Thread Tony Cho
On 2015년 10월 23일 16:52, Dan Carpenter wrote: On Fri, Oct 23, 2015 at 04:36:07PM +0900, Tony Cho wrote: In addition, the function parameter names will be wilc for the variable of struct wilc. The "wl" is local variable naming as well. So if it is a parameter it is wilc but if it is a local va

Re: [PATCH 05/28] staging: wilc1000: wilc_handle_isr: add argument wilc to wilc_handle_isr

2015-10-23 Thread Dan Carpenter
On Fri, Oct 23, 2015 at 04:36:07PM +0900, Tony Cho wrote: > In addition, the function parameter names will be wilc > for the variable of struct wilc. > > The "wl" is local variable naming as well. So if it is a parameter it is wilc but if it is a local variable then it is wl? That seems like an

Re: [PATCH 05/28] staging: wilc1000: wilc_handle_isr: add argument wilc to wilc_handle_isr

2015-10-23 Thread Tony Cho
On 2015년 10월 23일 15:57, Dan Carpenter wrote: On Fri, Oct 23, 2015 at 02:28:21PM +0900, Glen Lee wrote: This patch add new argument wilc to wilc_handle_isr and pass wilc to the function. It's not important enough to redo the patch but why are we sometimes using "wl" and sometimes "wilc"? We

Re: [PATCH 05/28] staging: wilc1000: wilc_handle_isr: add argument wilc to wilc_handle_isr

2015-10-22 Thread Dan Carpenter
On Fri, Oct 23, 2015 at 02:28:21PM +0900, Glen Lee wrote: > This patch add new argument wilc to wilc_handle_isr and pass wilc to > the function. It's not important enough to redo the patch but why are we sometimes using "wl" and sometimes "wilc"? regards, dan carpenter __

[PATCH 05/28] staging: wilc1000: wilc_handle_isr: add argument wilc to wilc_handle_isr

2015-10-22 Thread Glen Lee
This patch add new argument wilc to wilc_handle_isr and pass wilc to the function. It is void type for now because wilc_wlan.c was implemented platform independently at the beginning (linux_wlan.c is implementation of LINUX part) so the struct wilc header file cannot be included at this moment, but