Re: [PATCH 1/2] staging: rtl8188eu: remove empty if statement in rtw_led.c

2018-09-05 Thread Dan Carpenter
On Wed, Sep 05, 2018 at 01:44:43PM +0200, Michael Straube wrote: > On 9/5/18 10:13 AM, Dan Carpenter wrote: > > On Tue, Sep 04, 2018 at 01:16:15PM +0200, Michael Straube wrote: > > > > > > case LED_CTL_SITE_SURVEY: > > > - if ((pmlmepriv->LinkDetectInfo.bBusyTraffic) && > > >

Re: [PATCH 1/2] staging: rtl8188eu: remove empty if statement in rtw_led.c

2018-09-05 Thread Michael Straube
On 9/5/18 10:13 AM, Dan Carpenter wrote: On Tue, Sep 04, 2018 at 01:16:15PM +0200, Michael Straube wrote: case LED_CTL_SITE_SURVEY: - if ((pmlmepriv->LinkDetectInfo.bBusyTraffic) && (check_fwstate(pmlmepriv, _FW_LINKED))) { - ; - }

Re: [PATCH 1/2] staging: rtl8188eu: remove empty if statement in rtw_led.c

2018-09-05 Thread Dan Carpenter
On Tue, Sep 04, 2018 at 01:16:15PM +0200, Michael Straube wrote: > Remove empty if statement from 'if - else if' and replace the > else if with if. Remove the now unused variable pmlmepriv. > Also clears line over 80 characters and CamelCase checkpatch > issues. > > Signed-off-by: Michael Straube