Re: [PATCH 3/5] Staging/iio/adc/touchscreen/MXS: add i.MX23 support to the LRADC driver

2013-09-11 Thread Jürgen Beisert
On Tuesday 10 September 2013 22:54:44 Dan Carpenter wrote: On Tue, Sep 10, 2013 at 09:36:14AM +0200, Jürgen Beisert wrote: This patch seems to combine two things -- register access rework AND adjustment of the driver for MX23 touchscreen. It reworks the register access to avoid the

Re: [PATCH 3/5] Staging/iio/adc/touchscreen/MXS: add i.MX23 support to the LRADC driver

2013-09-10 Thread Jürgen Beisert
Hi Marek, On Monday 09 September 2013 18:04:19 Marek Vasut wrote: Distinguish i.MX23 and i.MX28 at runtime and do the same for both SoC at least for the 4 wire touchscreen. Signed-off-by: Juergen Beisert j...@pengutronix.de CC: linux-arm-ker...@lists.infradead.org CC:

Re: [PATCH 3/5] Staging/iio/adc/touchscreen/MXS: add i.MX23 support to the LRADC driver

2013-09-10 Thread Marek Vasut
Dear Juergen Beisert, Distinguish i.MX23 and i.MX28 at runtime and do the same for both SoC at least for the 4 wire touchscreen. Signed-off-by: Juergen Beisert j...@pengutronix.de CC: linux-arm-ker...@lists.infradead.org CC: de...@driverdev.osuosl.org CC: Marek Vasut ma...@denx.de CC:

Re: [PATCH 3/5] Staging/iio/adc/touchscreen/MXS: add i.MX23 support to the LRADC driver

2013-09-10 Thread Jürgen Beisert
Hi Marek, On Tuesday 10 September 2013 10:22:36 Marek Vasut wrote: On Monday 09 September 2013 18:04:19 Marek Vasut wrote: Distinguish i.MX23 and i.MX28 at runtime and do the same for both SoC at least for the 4 wire touchscreen. Signed-off-by: Juergen Beisert

Re: [PATCH 3/5] Staging/iio/adc/touchscreen/MXS: add i.MX23 support to the LRADC driver

2013-09-10 Thread Marek Vasut
Dear Dan Carpenter, On Tue, Sep 10, 2013 at 09:36:14AM +0200, Jürgen Beisert wrote: This patch seems to combine two things -- register access rework AND adjustment of the driver for MX23 touchscreen. It reworks the register access to avoid the i.MX23/i.MX28 runtime decision all over

Re: [PATCH 3/5] Staging/iio/adc/touchscreen/MXS: add i.MX23 support to the LRADC driver

2013-09-10 Thread Marek Vasut
Dear Jürgen Beisert, Hi Marek, On Tuesday 10 September 2013 10:22:36 Marek Vasut wrote: On Monday 09 September 2013 18:04:19 Marek Vasut wrote: Distinguish i.MX23 and i.MX28 at runtime and do the same for both SoC at least for the 4 wire touchscreen. Signed-off-by:

Re: [PATCH 3/5] Staging/iio/adc/touchscreen/MXS: add i.MX23 support to the LRADC driver

2013-09-10 Thread Marek Vasut
Dear Jürgen Beisert, Hi Marek, On Monday 09 September 2013 18:04:19 Marek Vasut wrote: Distinguish i.MX23 and i.MX28 at runtime and do the same for both SoC at least for the 4 wire touchscreen. Signed-off-by: Juergen Beisert j...@pengutronix.de CC:

Re: [PATCH 3/5] Staging/iio/adc/touchscreen/MXS: add i.MX23 support to the LRADC driver

2013-09-05 Thread Jürgen Beisert
Hi Dan, On Wednesday 04 September 2013 16:27:39 Dan Carpenter wrote: [...] ACTUALLY! When I look at it now the third argument is almost always set, clear or toggle. So we could do: static inline void lradc_reg_set(struct mxs_lradc *lradc, u32 val, size_t

Re: [PATCH 3/5] Staging/iio/adc/touchscreen/MXS: add i.MX23 support to the LRADC driver

2013-09-05 Thread Dan Carpenter
On Thu, Sep 05, 2013 at 12:16:18PM +0200, Jürgen Beisert wrote: I like this simplification, but all the other drivers for the MXS series of SoCs don't use such a method. Do you think this new style will be accepted? My lradc_plate_mask() is basically the same idea as what Marek said about

Re: [PATCH 3/5] Staging/iio/adc/touchscreen/MXS: add i.MX23 support to the LRADC driver

2013-09-05 Thread Marek Vasut
Dear Dan Carpenter, On Thu, Sep 05, 2013 at 12:16:18PM +0200, Jürgen Beisert wrote: I like this simplification, but all the other drivers for the MXS series of SoCs don't use such a method. Do you think this new style will be accepted? My lradc_plate_mask() is basically the same idea as