Re: [PATCH net] hv_netvsc: preserve hw_features on mtu/channels/ringparam changes

2017-11-15 Thread Vitaly Kuznetsov
project.org; KY Srinivasan ; Haiyang >> Zhang ; Stephen Hemminger >> ; Mohammed Gamal >> Subject: Re: [PATCH net] hv_netvsc: preserve hw_features on >> mtu/channels/ringparam changes >> >> Stephen Hemminger writes: >> >> > On Tue, 14 Nov 2017 1

RE: [PATCH net] hv_netvsc: preserve hw_features on mtu/channels/ringparam changes

2017-11-14 Thread Haiyang Zhang
g ; Stephen Hemminger > ; Mohammed Gamal > Subject: Re: [PATCH net] hv_netvsc: preserve hw_features on > mtu/channels/ringparam changes > > Stephen Hemminger writes: > > > On Tue, 14 Nov 2017 16:22:05 +0100 > > Vitaly Kuznetsov wrote: > > > > Y

Re: [PATCH net] hv_netvsc: preserve hw_features on mtu/channels/ringparam changes

2017-11-14 Thread Vitaly Kuznetsov
Stephen Hemminger writes: > On Tue, 14 Nov 2017 16:22:05 +0100 > Vitaly Kuznetsov wrote: > > Yes, this looks like a real issue. > >> +/* Query hardware capabilities if we're called from netvsc_probe() */ >> +if (!net->hw_features) { >> +ret = rndis_netdev_set_hwcaps(net_devic

Re: [PATCH net] hv_netvsc: preserve hw_features on mtu/channels/ringparam changes

2017-11-14 Thread Stephen Hemminger
On Tue, 14 Nov 2017 16:22:05 +0100 Vitaly Kuznetsov wrote: Yes, this looks like a real issue. > + /* Query hardware capabilities if we're called from netvsc_probe() */ > + if (!net->hw_features) { > + ret = rndis_netdev_set_hwcaps(net_device, rndis_device); > +

[PATCH net] hv_netvsc: preserve hw_features on mtu/channels/ringparam changes

2017-11-14 Thread Vitaly Kuznetsov
rndis_filter_device_add() is called both from netvsc_probe() when we initially create the device and from set channels/mtu/ringparam routines where we basically remove the device and add it back. hw_features is reset in rndis_filter_device_add() and filled with host data. However, we lose all addi