Re: [PATCH net-next 6/7] net: bridge: Notify about bridge VLANs

Vivien Didelot writes: > Hi Petr, > > Petr Machata writes: > >> Vivien Didelot writes: >> + } else { + err = br_switchdev_port_obj_add(dev, v->vid, flags); + if (err

Re: [PATCH net-next 6/7] net: bridge: Notify about bridge VLANs

Hi Petr, Petr Machata writes: > Vivien Didelot writes: > >>> + } else { >>> + err = br_switchdev_port_obj_add(dev, v->vid, flags); >>> + if (err && err != -EOPNOTSUPP) >>> + goto out; >>> } >>

Re: [PATCH net-next 6/7] net: bridge: Notify about bridge VLANs

Vivien Didelot writes: >> +} else { >> +err = br_switchdev_port_obj_add(dev, v->vid, flags); >> +if (err && err != -EOPNOTSUPP) >> +goto out; >> } > > Except that br_switchdev_port_obj_add taking vid and

Re: [PATCH net-next 6/7] net: bridge: Notify about bridge VLANs

Hi Petr, Petr Machata writes: > A driver might need to react to changes in settings of brentry VLANs. > Therefore send switchdev port notifications for these as well. Reuse > SWITCHDEV_OBJ_ID_PORT_VLAN for this purpose. Listeners should use > netif_is_bridge_master() on

Re: [PATCH net-next 6/7] net: bridge: Notify about bridge VLANs

On 24/05/18 18:10, Petr Machata wrote: > A driver might need to react to changes in settings of brentry VLANs. > Therefore send switchdev port notifications for these as well. Reuse > SWITCHDEV_OBJ_ID_PORT_VLAN for this purpose. Listeners should use > netif_is_bridge_master() on orig_dev to

[PATCH net-next 6/7] net: bridge: Notify about bridge VLANs

A driver might need to react to changes in settings of brentry VLANs. Therefore send switchdev port notifications for these as well. Reuse SWITCHDEV_OBJ_ID_PORT_VLAN for this purpose. Listeners should use netif_is_bridge_master() on orig_dev to determine whether the notification is about a bridge