Re: [PATCH v2] staging: rtl8192u: add error handling for usb_alloc_urb

2018-06-15 Thread Kees Cook
On Fri, Jun 15, 2018 at 9:47 AM, Kees Cook wrote: > On Fri, Jun 15, 2018 at 9:33 AM, Greg Kroah-Hartman > wrote: >> On Sat, Jun 16, 2018 at 12:25:23AM +0800, Zhouyang Jia wrote: >>> When usb_alloc_urb fails, the lack of error-handling code may >>> cause unexpected results. >>> >>> This patch

Re: [PATCH v2] staging: rtl8192u: add error handling for usb_alloc_urb

2018-06-15 Thread Kees Cook
On Fri, Jun 15, 2018 at 9:33 AM, Greg Kroah-Hartman wrote: > On Sat, Jun 16, 2018 at 12:25:23AM +0800, Zhouyang Jia wrote: >> When usb_alloc_urb fails, the lack of error-handling code may >> cause unexpected results. >> >> This patch adds error-handling code after calling usb_alloc_urb. >> >>

Re: [PATCH v2] staging: rtl8192u: add error handling for usb_alloc_urb

2018-06-15 Thread Greg Kroah-Hartman
On Sat, Jun 16, 2018 at 12:25:23AM +0800, Zhouyang Jia wrote: > When usb_alloc_urb fails, the lack of error-handling code may > cause unexpected results. > > This patch adds error-handling code after calling usb_alloc_urb. > > Signed-off-by: Zhouyang Jia > --- > v1->v2: > - Fix memory leak. >

[PATCH v2] staging: rtl8192u: add error handling for usb_alloc_urb

2018-06-15 Thread Zhouyang Jia
When usb_alloc_urb fails, the lack of error-handling code may cause unexpected results. This patch adds error-handling code after calling usb_alloc_urb. Signed-off-by: Zhouyang Jia --- v1->v2: - Fix memory leak. --- drivers/staging/rtl8192u/r8192U_core.c | 18 +++--- 1 file