Re: [PATCH v2 1/2] timekeeping: add EXPORT_SYMBOL_GPL for do_adjtimex()

2014-10-22 Thread Mike Surcouf
> Mike, can you share me your kernel version and which Linux distro do you use? 2.6.32-504.el6.x86_64 AKA RHEL 6.6 Happened on centos 7 and 6.5 too. #cat /var/lib/ntp/drift -248.869 About 20 secs a day (constant) Its not a new problem I had this in other distros and other kernels. I would say its

RE: [PATCH v2 1/2] timekeeping: add EXPORT_SYMBOL_GPL for do_adjtimex()

2014-10-22 Thread Thomas Shao
on.org; > LKML; de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; > jasow...@redhat.com; KY Srinivasan; John Stultz; Richard Cochran > Subject: Re: [PATCH v2 1/2] timekeeping: add EXPORT_SYMBOL_GPL for > do_adjtimex() > > On Wed, 22 Oct 2014, Mike Surcouf wrote: &g

Re: [PATCH v2 1/2] timekeeping: add EXPORT_SYMBOL_GPL for do_adjtimex()

2014-10-22 Thread Thomas Gleixner
On Wed, 22 Oct 2014, Mike Surcouf wrote: > I get that NTP can be installed locally. This is how I regulate time > on my guests. I agree the admin argument probably doesn't stand up. > > The problem is hyperv_clocksource (pluggable time source used by > hyperv guests) is systematically fast in m

Re: [PATCH v2 1/2] timekeeping: add EXPORT_SYMBOL_GPL for do_adjtimex()

2014-10-22 Thread Mike Surcouf
I get that NTP can be installed locally. This is how I regulate time on my guests. I agree the admin argument probably doesn't stand up. The problem is hyperv_clocksource (pluggable time source used by hyperv guests) is systematically fast in my environment. by around -250 PPM. I get away with N

RE: [PATCH v2 1/2] timekeeping: add EXPORT_SYMBOL_GPL for do_adjtimex()

2014-10-21 Thread Thomas Shao
on.org; LKML; > de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; > jasow...@redhat.com; KY Srinivasan; John Stultz; Richard Cochran > Subject: Re: [PATCH v2 1/2] timekeeping: add EXPORT_SYMBOL_GPL for > do_adjtimex() > > On Mon, Oct 20, 2014 at 11:02:13PM -0500, Jeff Epler wr

RE: [PATCH v2 1/2] timekeeping: add EXPORT_SYMBOL_GPL for do_adjtimex()

2014-10-21 Thread Thomas Shao
sow...@redhat.com; KY Srinivasan; John Stultz; Richard Cochran > Subject: Re: [PATCH v2 1/2] timekeeping: add EXPORT_SYMBOL_GPL for > do_adjtimex() > > On Tue, Oct 21, 2014 at 03:18:58AM +, Thomas Shao wrote: > > > > In some situation, the user is not able to enable g

RE: [PATCH v2 1/2] timekeeping: add EXPORT_SYMBOL_GPL for do_adjtimex()

2014-10-21 Thread Thomas Shao
gt; o...@aepfle.de; a...@canonical.com; jasow...@redhat.com; KY Srinivasan; > John Stultz; Richard Cochran > Subject: RE: [PATCH v2 1/2] timekeeping: add EXPORT_SYMBOL_GPL for > do_adjtimex() > > On Tue, 21 Oct 2014, Thomas Shao wrote: > > > I still do not have a consistent

RE: [PATCH v2 1/2] timekeeping: add EXPORT_SYMBOL_GPL for do_adjtimex()

2014-10-21 Thread Thomas Gleixner
On Tue, 21 Oct 2014, Thomas Shao wrote: > I'm also thinking if NTPd could expose some interface to allow other > application to directly provide time source for it to consume. In my > opinion, emulating the ntp source should be very hard and error > prone. Well, if done right it would be pretty p

RE: [PATCH v2 1/2] timekeeping: add EXPORT_SYMBOL_GPL for do_adjtimex()

2014-10-21 Thread Thomas Gleixner
On Tue, 21 Oct 2014, Thomas Shao wrote: > I didn't find a way to detect whether NTPd is running in the hyper-v module. And you better do not try at all. > In http://doc.ntp.org/4.1.0/ntpd.htm, it mentioned: Normally, the > time is slewed if the offset is less than the step threshold, which > i

Re: [PATCH v2 1/2] timekeeping: add EXPORT_SYMBOL_GPL for do_adjtimex()

2014-10-21 Thread Richard Cochran
On Mon, Oct 20, 2014 at 11:02:13PM -0500, Jeff Epler wrote: > It's interesting to imagine that a virtualization host could present a > time service to the guest *userspace*, even when the guest is not > otherwise exposed to the internet at large. This could take the form of > an NTP server on a pr

RE: [PATCH v2 1/2] timekeeping: add EXPORT_SYMBOL_GPL for do_adjtimex()

2014-10-21 Thread Thomas Gleixner
On Tue, 21 Oct 2014, Thomas Shao wrote: > > I still do not have a consistent argument from you WHY you need to abuse > > do_adjtimex() to do that host - guest synchronization in the first place. > > > > I need a function to gradually slew guest time. do_adjtimex() provides all > the > functiona

Re: [PATCH v2 1/2] timekeeping: add EXPORT_SYMBOL_GPL for do_adjtimex()

2014-10-21 Thread Richard Cochran
On Tue, Oct 21, 2014 at 03:18:58AM +, Thomas Shao wrote: > > In some situation, the user is not able to enable guest VM to sync with > external > time source, like NTP. But the host is still synced with a trusted time > source. But the guest *is* networked, right? (Otherwise syncing the

RE: [PATCH v2 1/2] timekeeping: add EXPORT_SYMBOL_GPL for do_adjtimex()

2014-10-20 Thread Thomas Shao
sow...@redhat.com; KY Srinivasan; John Stultz; Richard Cochran > Subject: Re: [PATCH v2 1/2] timekeeping: add EXPORT_SYMBOL_GPL for > do_adjtimex() > > On Tue, Oct 21, 2014 at 03:18:58AM +, Thomas Shao wrote: > > In some situation, the user is not able to enable guest VM to sync

Re: [PATCH v2 1/2] timekeeping: add EXPORT_SYMBOL_GPL for do_adjtimex()

2014-10-20 Thread Jeff Epler
On Tue, Oct 21, 2014 at 03:18:58AM +, Thomas Shao wrote: > In some situation, the user is not able to enable guest VM to sync with > external > time source, like NTP. But the host is still synced with a trusted time > source. > In this case, host-guest time synchronization is useful. It's

RE: [PATCH v2 1/2] timekeeping: add EXPORT_SYMBOL_GPL for do_adjtimex()

2014-10-20 Thread Thomas Shao
sow...@redhat.com; KY Srinivasan; Richard Cochran > Subject: Re: [PATCH v2 1/2] timekeeping: add EXPORT_SYMBOL_GPL for > do_adjtimex() > > On Mon, Oct 20, 2014 at 8:18 PM, Thomas Shao > wrote: > > > >> -Original Message- > >> From: linux-kernel-ow...@vger

Re: [PATCH v2 1/2] timekeeping: add EXPORT_SYMBOL_GPL for do_adjtimex()

2014-10-20 Thread John Stultz
t;> To: Thomas Shao >> Cc: gre...@linuxfoundation.org; LKML; de...@linuxdriverproject.org; >> o...@aepfle.de; a...@canonical.com; jasow...@redhat.com; KY Srinivasan; >> John Stultz; Richard Cochran >> Subject: Re: [PATCH v2 1/2] timekeeping: add EXPORT_SYMBOL_GPL for >> do_adjtimex() &

RE: [PATCH v2 1/2] timekeeping: add EXPORT_SYMBOL_GPL for do_adjtimex()

2014-10-20 Thread Thomas Shao
gt; o...@aepfle.de; a...@canonical.com; jasow...@redhat.com; KY Srinivasan; > John Stultz; Richard Cochran > Subject: Re: [PATCH v2 1/2] timekeeping: add EXPORT_SYMBOL_GPL for > do_adjtimex() > > On Mon, 20 Oct 2014, Thomas Gleixner wrote: > > > On Wed, 15 Oct 2014, Thoma

RE: [PATCH v2 1/2] timekeeping: add EXPORT_SYMBOL_GPL for do_adjtimex()

2014-10-20 Thread Thomas Shao
Srinivasan; > John Stultz > Subject: Re: [PATCH v2 1/2] timekeeping: add EXPORT_SYMBOL_GPL for > do_adjtimex() > > On Wed, 15 Oct 2014, Thomas Shao wrote: > > And again you forgot to cc John Stultz on this I'll cc John Stultz in the future. Sorry for that. > &

Re: [PATCH v2 1/2] timekeeping: add EXPORT_SYMBOL_GPL for do_adjtimex()

2014-10-20 Thread Thomas Gleixner
On Mon, 20 Oct 2014, Thomas Gleixner wrote: > On Wed, 15 Oct 2014, Thomas Shao wrote: > > And again you forgot to cc John Stultz on this > > > Export do_adjtimex function for hyper-v Time Synchronization component Aside of that, we really want to see the use case for this and how you addres

Re: [PATCH v2 1/2] timekeeping: add EXPORT_SYMBOL_GPL for do_adjtimex()

2014-10-20 Thread Thomas Gleixner
On Wed, 15 Oct 2014, Thomas Shao wrote: And again you forgot to cc John Stultz on this > Export do_adjtimex function for hyper-v Time Synchronization component > > Signed-off-by: Thomas Shao > --- > kernel/time/timekeeping.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > >

[PATCH v2 1/2] timekeeping: add EXPORT_SYMBOL_GPL for do_adjtimex()

2014-10-15 Thread Thomas Shao
Export do_adjtimex function for hyper-v Time Synchronization component Signed-off-by: Thomas Shao --- kernel/time/timekeeping.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c index ec1791f..205a4b3 100644 --- a/kerne