Re: [PATCH v6 4/8] media: platform: Add Cedrus VPU decoder driver

2018-08-08 Thread Paul Kocialkowski
Hi, On Mon, 2018-08-06 at 16:21 +0200, Paul Kocialkowski wrote: > Hi, > > On Fri, 2018-08-03 at 17:49 -0300, Ezequiel Garcia wrote: > > On Wed, 2018-07-25 at 12:02 +0200, Paul Kocialkowski wrote: > > > This introduces the Cedrus VPU driver that supports the VPU found in > > > Allwinner SoCs,

Re: [PATCH v6 4/8] media: platform: Add Cedrus VPU decoder driver

2018-08-07 Thread Tomasz Figa
On Tue, Aug 7, 2018 at 4:20 PM Paul Kocialkowski wrote: > > Hi, > > On Mon, 2018-08-06 at 23:10 +0900, Tomasz Figa wrote: > > Hi Paul, > > > > On Mon, Aug 6, 2018 at 10:50 PM Paul Kocialkowski > > wrote: > > > > > > Hi Hans and thanks for the review! > > > > > > On Sat, 2018-08-04 at 14:18

Re: [linux-sunxi] [PATCH v6 4/8] media: platform: Add Cedrus VPU decoder driver

2018-08-07 Thread Tomasz Figa
On Wed, Aug 8, 2018 at 12:05 AM Jernej Škrabec wrote: > > Dne torek, 07. avgust 2018 ob 14:31:03 CEST je Paul Kocialkowski napisal(a): > > Hi, > > > > On Fri, 2018-07-27 at 16:58 +0200, Jernej Škrabec wrote: > > > Dne petek, 27. julij 2018 ob 16:03:41 CEST je Jernej Škrabec napisal(a): > > > >

Re: [linux-sunxi] [PATCH v6 4/8] media: platform: Add Cedrus VPU decoder driver

2018-08-07 Thread Jernej Škrabec
Dne torek, 07. avgust 2018 ob 14:31:03 CEST je Paul Kocialkowski napisal(a): > Hi, > > On Fri, 2018-07-27 at 16:58 +0200, Jernej Škrabec wrote: > > Dne petek, 27. julij 2018 ob 16:03:41 CEST je Jernej Škrabec napisal(a): > > > Hi! > > > > > > Dne sreda, 25. julij 2018 ob 12:02:52 CEST je Paul

Re: [linux-sunxi] [PATCH v6 4/8] media: platform: Add Cedrus VPU decoder driver

2018-08-07 Thread Paul Kocialkowski
Hi, On Fri, 2018-07-27 at 16:58 +0200, Jernej Škrabec wrote: > Dne petek, 27. julij 2018 ob 16:03:41 CEST je Jernej Škrabec napisal(a): > > Hi! > > > > Dne sreda, 25. julij 2018 ob 12:02:52 CEST je Paul Kocialkowski napisal(a): > > > This introduces the Cedrus VPU driver that supports the VPU

Re: [linux-sunxi] [PATCH v6 4/8] media: platform: Add Cedrus VPU decoder driver

2018-08-07 Thread Paul Kocialkowski
Hi, On Fri, 2018-07-27 at 16:03 +0200, Jernej Škrabec wrote: > Hi! > > Dne sreda, 25. julij 2018 ob 12:02:52 CEST je Paul Kocialkowski napisal(a): > > This introduces the Cedrus VPU driver that supports the VPU found in > > Allwinner SoCs, also known as Video Engine. It is implemented through >

Re: [linux-sunxi] [PATCH v6 4/8] media: platform: Add Cedrus VPU decoder driver

2018-08-07 Thread Paul Kocialkowski
Hi, On Sun, 2018-07-29 at 09:58 +0200, Jernej Škrabec wrote: > Hi! > > Dne sreda, 25. julij 2018 ob 12:02:52 CEST je Paul Kocialkowski napisal(a): > > This introduces the Cedrus VPU driver that supports the VPU found in > > Allwinner SoCs, also known as Video Engine. It is implemented through >

Re: [PATCH v6 4/8] media: platform: Add Cedrus VPU decoder driver

2018-08-07 Thread Paul Kocialkowski
Hi, On Mon, 2018-08-06 at 23:10 +0900, Tomasz Figa wrote: > Hi Paul, > > On Mon, Aug 6, 2018 at 10:50 PM Paul Kocialkowski > wrote: > > > > Hi Hans and thanks for the review! > > > > On Sat, 2018-08-04 at 14:18 +0200, Hans Verkuil wrote: > > > Hi Paul, > > > > > > See below for my review

Re: [PATCH v6 4/8] media: platform: Add Cedrus VPU decoder driver

2018-08-06 Thread Paul Kocialkowski
Hi, On Fri, 2018-08-03 at 17:49 -0300, Ezequiel Garcia wrote: > On Wed, 2018-07-25 at 12:02 +0200, Paul Kocialkowski wrote: > > This introduces the Cedrus VPU driver that supports the VPU found in > > Allwinner SoCs, also known as Video Engine. It is implemented through > > a v4l2 m2m decoder

Re: [PATCH v6 4/8] media: platform: Add Cedrus VPU decoder driver

2018-08-06 Thread Tomasz Figa
Hi Paul, On Mon, Aug 6, 2018 at 10:50 PM Paul Kocialkowski wrote: > > Hi Hans and thanks for the review! > > On Sat, 2018-08-04 at 14:18 +0200, Hans Verkuil wrote: > > Hi Paul, > > > > See below for my review comments. Mostly small fry, the main issue I found > > is > > that there is no support

Re: [PATCH v6 4/8] media: platform: Add Cedrus VPU decoder driver

2018-08-06 Thread Paul Kocialkowski
Hi Hans and thanks for the review! On Sat, 2018-08-04 at 14:18 +0200, Hans Verkuil wrote: > Hi Paul, > > See below for my review comments. Mostly small fry, the main issue I found is > that there is no support for VIDIOC_DECODER_CMD. That's the proper way of > stopping a decoder. Don't rely on

Re: [PATCH v6 4/8] media: platform: Add Cedrus VPU decoder driver

2018-08-04 Thread Hans Verkuil
Hi Paul, See below for my review comments. Mostly small fry, the main issue I found is that there is no support for VIDIOC_DECODER_CMD. That's the proper way of stopping a decoder. Don't rely on the deprecated allow_zero_bytesused field. On 07/25/2018 12:02 PM, Paul Kocialkowski wrote: > This

Re: [PATCH v6 4/8] media: platform: Add Cedrus VPU decoder driver

2018-08-03 Thread Ezequiel Garcia
On Wed, 2018-07-25 at 12:02 +0200, Paul Kocialkowski wrote: > This introduces the Cedrus VPU driver that supports the VPU found in > Allwinner SoCs, also known as Video Engine. It is implemented through > a v4l2 m2m decoder device and a media device (used for media requests). > So far, it only

Re: [linux-sunxi] [PATCH v6 4/8] media: platform: Add Cedrus VPU decoder driver

2018-07-27 Thread Jernej Škrabec
Dne petek, 27. julij 2018 ob 16:03:41 CEST je Jernej Škrabec napisal(a): > Hi! > > Dne sreda, 25. julij 2018 ob 12:02:52 CEST je Paul Kocialkowski napisal(a): > > This introduces the Cedrus VPU driver that supports the VPU found in > > Allwinner SoCs, also known as Video Engine. It is implemented

Re: [linux-sunxi] [PATCH v6 4/8] media: platform: Add Cedrus VPU decoder driver

2018-07-27 Thread Jernej Škrabec
Hi! Dne sreda, 25. julij 2018 ob 12:02:52 CEST je Paul Kocialkowski napisal(a): > This introduces the Cedrus VPU driver that supports the VPU found in > Allwinner SoCs, also known as Video Engine. It is implemented through > a v4l2 m2m decoder device and a media device (used for media requests).

[PATCH v6 4/8] media: platform: Add Cedrus VPU decoder driver

2018-07-25 Thread Paul Kocialkowski
This introduces the Cedrus VPU driver that supports the VPU found in Allwinner SoCs, also known as Video Engine. It is implemented through a v4l2 m2m decoder device and a media device (used for media requests). So far, it only supports MPEG2 decoding. Since this VPU is stateless, synchronization