Re: [PATCH v4] staging: bcm2835-audio: Release resources on module_exit()

2018-03-25 Thread Kirill Marinushkin
On 03/25/18 15:03, Andy Shevchenko wrote: > On Sun, Mar 25, 2018 at 1:44 PM, Kirill Marinushkin > wrote: >> On 03/25/18 12:33, Andy Shevchenko wrote: >>> On Fri, Mar 23, 2018 at 9:22 PM, Kirill Marinushkin >>> wrote: On 03/23/18 17:23, Andy

Re: [PATCH v4] staging: bcm2835-audio: Release resources on module_exit()

2018-03-25 Thread Andy Shevchenko
On Sun, Mar 25, 2018 at 1:44 PM, Kirill Marinushkin wrote: > On 03/25/18 12:33, Andy Shevchenko wrote: >> On Fri, Mar 23, 2018 at 9:22 PM, Kirill Marinushkin >> wrote: >>> On 03/23/18 17:23, Andy Shevchenko wrote: After addressing above,

Re: [PATCH v4] staging: bcm2835-audio: Release resources on module_exit()

2018-03-25 Thread Kirill Marinushkin
On 03/25/18 12:33, Andy Shevchenko wrote: > On Fri, Mar 23, 2018 at 9:22 PM, Kirill Marinushkin > wrote: >> On 03/23/18 17:23, Andy Shevchenko wrote: >>> After addressing above, FWIW, >>> >>> Reviewed-by: Andy Shevchenko > Seems you missed my

Re: [PATCH v4] staging: bcm2835-audio: Release resources on module_exit()

2018-03-25 Thread Andy Shevchenko
On Fri, Mar 23, 2018 at 9:22 PM, Kirill Marinushkin wrote: > On 03/23/18 17:23, Andy Shevchenko wrote: >> After addressing above, FWIW, >> >> Reviewed-by: Andy Shevchenko Seems you missed my tag in new version. When someone gives you a tag

Re: [PATCH v4] staging: bcm2835-audio: Release resources on module_exit()

2018-03-23 Thread Kirill Marinushkin
On 03/23/18 17:23, Andy Shevchenko wrote: > On Thu, Mar 22, 2018 at 11:37 PM, Kirill Marinushkin > wrote: > > >> +static void snd_devm_release(struct device *dev) >> +{ >> + struct bcm2835_chip *chip = dev_get_drvdata(dev); >> + >> + kfree(chip); >> +} >> +

Re: [PATCH v4] staging: bcm2835-audio: Release resources on module_exit()

2018-03-23 Thread Andy Shevchenko
On Thu, Mar 22, 2018 at 11:37 PM, Kirill Marinushkin wrote: > +static void snd_devm_release(struct device *dev) > +{ > + struct bcm2835_chip *chip = dev_get_drvdata(dev); > + > + kfree(chip); > +} > + device->release = snd_devm_release; This is not