Re: doubt about sm7xxfb (was: Re: [PATCH v4 0/7] staging: fsl-mc: New functionality to the MC bus driver)

2015-06-20 Thread Sudip Mukherjee
On Fri, Jun 19, 2015 at 01:29:13PM +0300, Dan Carpenter wrote: On Sat, Jun 13, 2015 at 02:16:18PM +0530, Sudip Mukherjee wrote: can you please have a look (when you are free) at it to see if anything else needs to be done. Remove any unused macros. I will check. Cleanup indenting in the

Re: doubt about sm7xxfb (was: Re: [PATCH v4 0/7] staging: fsl-mc: New functionality to the MC bus driver)

2015-06-19 Thread Dan Carpenter
On Sat, Jun 13, 2015 at 02:16:18PM +0530, Sudip Mukherjee wrote: can you please have a look (when you are free) at it to see if anything else needs to be done. Remove any unused macros. Cleanup indenting in the .h file. drivers/staging/sm7xxfb/sm7xxfb.c:821 smtcfb_pci_probe() warn:

Re: doubt about sm7xxfb (was: Re: [PATCH v4 0/7] staging: fsl-mc: New functionality to the MC bus driver)

2015-06-15 Thread Joe Perches
On Mon, 2015-06-15 at 10:47 +0530, Sudip Mukherjee wrote: On Sat, Jun 13, 2015 at 09:57:05AM -0700, Joe Perches wrote: It's unfortunate there are so many #ifdef __BIG_ENDIAN uses. instead of #ifdef __BIG_ENDIAN can i then use a bool flag to check by if-else? I think that'd be worse. Moving

Re: doubt about sm7xxfb (was: Re: [PATCH v4 0/7] staging: fsl-mc: New functionality to the MC bus driver)

2015-06-14 Thread Sudip Mukherjee
On Sat, Jun 13, 2015 at 09:57:05AM -0700, Joe Perches wrote: It seems ready to me. As far as I can tell, there's just a few niggles that could be done: Something like (too lazy to separate them into multiple patches) Thanks. I will break into patches. Call me lazy for not having it done

Re: doubt about sm7xxfb (was: Re: [PATCH v4 0/7] staging: fsl-mc: New functionality to the MC bus driver)

2015-06-13 Thread Joe Perches
On Sat, 2015-06-13 at 09:28 -0700, Greg KH wrote: On Sat, Jun 13, 2015 at 02:16:18PM +0530, Sudip Mukherjee wrote: [] Your reply above was for a different thread but my doubt started from this. I was working on adding the Dual-Head support to sm7xxfb. So that is also a new functionality

Re: doubt about sm7xxfb (was: Re: [PATCH v4 0/7] staging: fsl-mc: New functionality to the MC bus driver)

2015-06-13 Thread Greg KH
On Sat, Jun 13, 2015 at 02:16:18PM +0530, Sudip Mukherjee wrote: On Fri, Jun 12, 2015 at 05:18:49PM -0700, Greg KH wrote: On Tue, Jun 09, 2015 at 04:59:01PM -0500, J. German Rivera wrote: This patch series includes new functionality for the Freescale fsl-mc bus driver. Why are people

doubt about sm7xxfb (was: Re: [PATCH v4 0/7] staging: fsl-mc: New functionality to the MC bus driver)

2015-06-13 Thread Sudip Mukherjee
On Fri, Jun 12, 2015 at 05:18:49PM -0700, Greg KH wrote: On Tue, Jun 09, 2015 at 04:59:01PM -0500, J. German Rivera wrote: This patch series includes new functionality for the Freescale fsl-mc bus driver. Why are people working on new functionality instead of working on getting this out

Re: doubt about sm7xxfb

2015-02-25 Thread Sudip Mukherjee
On Wed, Feb 11, 2015 at 02:33:51PM +0800, Greg Kroah-Hartman wrote: On Wed, Feb 11, 2015 at 11:58:18AM +0530, Sudip Mukherjee wrote: Ok, that makes sense, I was thinking this was a new driver, instead of a vendor driver crud. Hi Greg, The SM750 driver is almost ready for staging, it now

Re: doubt about sm7xxfb

2015-02-25 Thread Greg Kroah-Hartman
On Wed, Feb 25, 2015 at 06:00:02PM +0530, Sudip Mukherjee wrote: On Wed, Feb 11, 2015 at 02:33:51PM +0800, Greg Kroah-Hartman wrote: On Wed, Feb 11, 2015 at 11:58:18AM +0530, Sudip Mukherjee wrote: Ok, that makes sense, I was thinking this was a new driver, instead of a vendor driver

Re: doubt about sm7xxfb

2015-02-10 Thread Greg Kroah-Hartman
On Tue, Feb 10, 2015 at 07:37:47PM +0530, Sudip Mukherjee wrote: Hi Greg, we have this sm7xxfb in drivers/staging now which is supporting SM710, SM712, SM721 and SM722. I am also working on another new hardware SM750, which will be ready for staging in next 1 -2 weeks. this SM750 is entirely

Re: doubt about sm7xxfb

2015-02-10 Thread Greg Kroah-Hartman
On Wed, Feb 11, 2015 at 11:58:18AM +0530, Sudip Mukherjee wrote: On Wed, Feb 11, 2015 at 12:36:36PM +0800, Greg Kroah-Hartman wrote: On Tue, Feb 10, 2015 at 07:37:47PM +0530, Sudip Mukherjee wrote: Hi Greg, we have this sm7xxfb in drivers/staging now which is supporting SM710, SM712,

doubt about sm7xxfb

2015-02-10 Thread Sudip Mukherjee
Hi Greg, we have this sm7xxfb in drivers/staging now which is supporting SM710, SM712, SM721 and SM722. I am also working on another new hardware SM750, which will be ready for staging in next 1 -2 weeks. this SM750 is entirely different hardware and these two drivers will have nothing in