Re: [PATCH] Adds Digi driver to staging.

2013-07-18 Thread Mark Hounschell
On 07/17/2013 05:49 PM, Greg KH wrote: On Wed, Jul 17, 2013 at 04:18:01PM -0400, Lidza Louina wrote: This patch adds the Digi driver to staging. Which digi driver? For what hardware? What type of driver is it? Please provide some more details here. From the readme: This Digi softwar

RE: [PATCH] staging: dwc2: add microframe scheduler from downstream Pi kernel

2013-07-18 Thread Paul Zimmerman
> From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Gordon Hollingworth > Sent: Wednesday, July 17, 2013 11:00 PM > > I'd suggest just adding a Raspberry Pi Foundation copyright. > > Is that OK or do you need names for SOB? Ah yes, thanks for remindin

Re: [PATCH] staging: dwc2: add microframe scheduler from downstream Pi kernel

2013-07-18 Thread Matthijs Kooijman
Hi Paul, > The transfer scheduler in the dwc2 driver is pretty basic, not to > mention buggy. It works fairly well with just a couple of devices > plugged in, but if you add, say, multiple devices with periodic > endpoints, the scheduler breaks down and can't even enumerate all > the devices. Thi

Re: [PATCH] staging: dwc2: add microframe scheduler from downstream Pi kernel

2013-07-18 Thread gre...@linuxfoundation.org
On Thu, Jul 18, 2013 at 04:45:55PM +, Paul Zimmerman wrote: > > From: linux-usb-ow...@vger.kernel.org > > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Gordon Hollingworth > > Sent: Wednesday, July 17, 2013 11:00 PM > > > > I'd suggest just adding a Raspberry Pi Foundation copyright.

Re: [PATCH] staging: dwc2: add microframe scheduler from downstream Pi kernel

2013-07-18 Thread Stephen Warren
On 07/18/2013 10:45 AM, Paul Zimmerman wrote: >> From: linux-usb-ow...@vger.kernel.org >> [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Gordon Hollingworth >> Sent: Wednesday, July 17, 2013 11:00 PM >> >> I'd suggest just adding a Raspberry Pi Foundation copyright. >> >> Is that OK or do y

Re: [PATCH] Adds Digi driver to staging.

2013-07-18 Thread Greg KH
On Thu, Jul 18, 2013 at 08:26:55AM -0400, Mark Hounschell wrote: > On 07/17/2013 05:49 PM, Greg KH wrote: > > On Wed, Jul 17, 2013 at 04:18:01PM -0400, Lidza Louina wrote: > >> This patch adds the Digi driver to staging. > > > > Which digi driver? For what hardware? What type of driver is it? > >

Re: [PATCH] staging: dwc2: add microframe scheduler from downstream Pi kernel

2013-07-18 Thread gre...@linuxfoundation.org
On Thu, Jul 18, 2013 at 11:34:47AM -0600, Stephen Warren wrote: > On 07/18/2013 10:45 AM, Paul Zimmerman wrote: > >> From: linux-usb-ow...@vger.kernel.org > >> [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Gordon Hollingworth > >> Sent: Wednesday, July 17, 2013 11:00 PM > >> > >> I'd sugge

Re: [PATCH] Adds Digi driver to staging.

2013-07-18 Thread Mark Hounschell
On 07/18/2013 01:40 PM, Greg KH wrote: On Thu, Jul 18, 2013 at 08:26:55AM -0400, Mark Hounschell wrote: On 07/17/2013 05:49 PM, Greg KH wrote: On Wed, Jul 17, 2013 at 04:18:01PM -0400, Lidza Louina wrote: This patch adds the Digi driver to staging. Which digi driver? For what hardware? Wha

Re: [PATCH] Adds Digi driver to staging.

2013-07-18 Thread Greg KH
On Thu, Jul 18, 2013 at 02:25:11PM -0400, Mark Hounschell wrote: > On 07/18/2013 01:40 PM, Greg KH wrote: > > On Thu, Jul 18, 2013 at 08:26:55AM -0400, Mark Hounschell wrote: > >> On 07/17/2013 05:49 PM, Greg KH wrote: > >>> On Wed, Jul 17, 2013 at 04:18:01PM -0400, Lidza Louina wrote: > This

Re: [PATCH] Adds Digi driver to staging.

2013-07-18 Thread Bill Pemberton
Greg KH writes: > > On Thu, Jul 18, 2013 at 02:25:11PM -0400, Mark Hounschell wrote: > > On 07/18/2013 01:40 PM, Greg KH wrote: > > > On Thu, Jul 18, 2013 at 08:26:55AM -0400, Mark Hounschell wrote: > > >> On 07/17/2013 05:49 PM, Greg KH wrote: > > >>> On Wed, Jul 17, 2013 at 04:18:01PM -0400, Lid

Re: [PATCH] Adds Digi driver to staging.

2013-07-18 Thread Lidza Louina
I've got all of your feedback. I'll send my patch up again with: * CVS directory removed * Makefile modified so it builds into the kernel * Better description of the driver * Attribute the original author * .h files in the main folder If there's anything else I need to add/modify, please let me kn

RE: [PATCH] staging: dwc2: add microframe scheduler from downstream Pi kernel

2013-07-18 Thread Paul Zimmerman
> From: Matthijs Kooijman [mailto:matth...@stdin.nl] > Sent: Thursday, July 18, 2013 10:19 AM > > This seems related to a patch I made last year for the dwc_otg driver. > On RT3052, we only have 4 host channels, so it was easy to run out of > them using a 3G stick and a hub. The 3G sticks hog up 2

Re: [PATCH] staging: dwc2: add driver parameter to set AHB config register value

2013-07-18 Thread Stephen Warren
On 07/16/2013 01:22 PM, Paul Zimmerman wrote: > The dwc2 driver sets the value of the DWC2 GAHBCFG register to 0x6, > which is GAHBCFG_HBSTLEN_INCR4. But different platforms may require > different values. In particular, the Broadcom 2835 SOC used in the > Raspberry Pi needs a value of 0x10, otherw

Re: [PATCH] staging: dwc2: add microframe scheduler from downstream Pi kernel

2013-07-18 Thread Stephen Warren
On 07/17/2013 01:35 PM, Paul Zimmerman wrote: > The transfer scheduler in the dwc2 driver is pretty basic, not to > mention buggy. It works fairly well with just a couple of devices > plugged in, but if you add, say, multiple devices with periodic > endpoints, the scheduler breaks down and can't ev