Re: [PATCH v2 2/4] staging: bcm: line over 80 characters in InterfaceIdleMode.c

2013-12-21 Thread Dan Carpenter
On Fri, Dec 20, 2013 at 08:54:30PM +0530, Gokulnath A wrote: > From: Gokulnath Avanashilingam No need. This should come from your email. > > Fixed all the line over 80 characters warning found by > checkpatch.pl script. > > Signed-off-by: Gokulnath Avanashilingam > This doesn't match the e

Re: [PATCH 2/3] staging: drm/imx: handle framebuffer offsets correctly

2013-12-21 Thread Dan Carpenter
On Fri, Dec 20, 2013 at 05:28:33PM +0100, Philipp Zabel wrote: > From: Lucas Stach > Sucky changelog. Doesn't say what the user visible effects are. > Signed-off-by: Lucas Stach > Signed-off-by: Philipp Zabel regards, dan carpenter ___ devel mail

Re: [PATCH 1/3] staging: dgnc: fix 80 characters per line limitation and code indent warnings.

2013-12-21 Thread Dan Carpenter
On Fri, Dec 20, 2013 at 10:03:25PM +0530, Stalin Srinivasan wrote: > From: stalinsrinivasan.s > We get your name from the email header. > This is a patch to the dgnc_cls.c file that > fixes up 80 characters per line and code indent > warnings found by the checkpatch.pl tool. And a bunch of ot

Re: [PATCH 2/3] staging: dgnc: fix checkpatch.pl usage of volatile.

2013-12-21 Thread Dan Carpenter
On Fri, Dec 20, 2013 at 10:03:26PM +0530, Stalin Srinivasan wrote: > From: stalinsrinivasan.s > > This is a patch to the dgnc_cls.c file that fixes up volatile usage > warning found by the checkpatch.pl tool > When you're writing a changelog please mention that you fixed the locking a little.

[PATCH] drivers: sbe-2t3e3: Mark functions as static in ctrl.c

2013-12-21 Thread Rashika Kheria
Mark functions t3e3_set_loopback(), t3e3_reg_read(), t3e3_reg_write(), t3e3_port_get(), t3e3_port_set(), t3e3_port_get_stats() and t3e3_port_del_stats() as static in ctrl.c because they are not used outside this file. This eliminates the following warnings in ctrl.c: drivers/staging/sbe-2t3e3/ctrl

[PATCH] drivers: sm7xxfb: Mark function as static in sm7xxfb.c

2013-12-21 Thread Rashika Kheria
Mark function smtcfb_setmode() as static in sm7xxfb.c because it is not used outside this file. This eliminates the following warning in sm7xxfb.c: drivers/staging/sm7xxfb/sm7xxfb.c:588:6: warning: no previous prototype for ‘smtcfb_setmode’ [-Wmissing-prototypes] Signed-off-by: Rashika Kheria -

Re: [PATCH v2 2/4] staging: bcm: line over 80 characters in InterfaceIdleMode.c

2013-12-21 Thread Gokulnath A
Hi Dan, On Sat, Dec 21, 2013 at 2:00 PM, Dan Carpenter wrote: > On Fri, Dec 20, 2013 at 08:54:30PM +0530, Gokulnath A wrote: >> From: Gokulnath Avanashilingam > > No need. This should come from your email. > >> >> Fixed all the line over 80 characters warning found by >> checkpatch.pl script. >

[PATCH] drivers: dwc2: Mark function as static in core.c

2013-12-21 Thread Rashika Kheria
Mark function dwc2_set_param_uframe_sched() as static in core.c because it is not used outside this file. This eliminates the following warning in core.c: drivers/staging/dwc2/core.c:2739:5: warning: no previous prototype for ‘dwc2_set_param_uframe_sched’ [-Wmissing-prototypes] Signed-off-by: Ra

[PATCH] drivers: dgnc: Include appropriate header file in dgnc_trace.c

2013-12-21 Thread Rashika Kheria
Include appropriate header file dgnc/dgnc_trace.h in dgnc_trace.c because function dgnc_tracer_free() has its prototype declaration in the header file. This eliminates the following warning in dgnc_trace.c: drivers/staging/dgnc/dgnc_trace.c:180:6: warning: no previous prototype for ‘dgnc_tracer_f

Re: [PATCH] drivers: sm7xxfb: Mark function as static in sm7xxfb.c

2013-12-21 Thread Josh Triplett
On Sat, Dec 21, 2013 at 03:44:13PM +0530, Rashika Kheria wrote: > Mark function smtcfb_setmode() as static in sm7xxfb.c because it is not > used outside this file. > > This eliminates the following warning in sm7xxfb.c: > drivers/staging/sm7xxfb/sm7xxfb.c:588:6: warning: no previous prototype for

[PATCH 1/2] drivers: dgap: Include appropriate header file in dgap_parse.c

2013-12-21 Thread Rashika Kheria
Include appropriate header file in dgap/dgap_parse.h in dgap_parse.c because functions dgap_parsefile(), dgap_config_get_useintr(), dgap_config_get_altpin(), dgap_find_config(), dgap_config_get_number_of_ports(), dgap_create_config_string() and dgap_get_config_letters() have their prototype declara

[PATCH 2/2] drivers: dgap: Include appropriate header file in dgap_trace.c

2013-12-21 Thread Rashika Kheria
Include appropriate header file dgap/dgap_trace.h in dgap_trace.c because function dgap_tracer_free() have its prototype declaration in the header file. This eliminates the following warning in dgap_trace.c: drivers/staging/dgap/dgap_trace.c:181:6: warning: no previous prototype for ‘dgap_tracer_

[PATCH 2/2] drivers: bcm: Remove unused function in nvm.c

2013-12-21 Thread Rashika Kheria
Remove unused function PropagateCalParamsFromEEPROMToMemory() in nvm.c. This eliminates the following warning in nvm.c: drivers/staging/bcm/nvm.c:1369:5: warning: no previous prototype for ‘PropagateCalParamsFromEEPROMToMemory’ [-Wmissing-prototypes] Signed-off-by: Rashika Kheria --- drivers/s

[PATCH 1/2] drivers: bcm: Mark functions as static in Qos.c

2013-12-21 Thread Rashika Kheria
Mark functions MatchSrcIpAddress(), MatchDestIpAddress() and MatchTos() as static in Qos.c because they are not used outside this file. This eliminates the following warnings in Qos.c: drivers/staging/bcm/Qos.c:27:6: warning: no previous prototype for ‘MatchSrcIpAddress’ [-Wmissing-prototypes] dr

Re: [PATCH] drivers: dwc2: Mark function as static in core.c

2013-12-21 Thread Josh Triplett
On Sat, Dec 21, 2013 at 03:50:29PM +0530, Rashika Kheria wrote: > Mark function dwc2_set_param_uframe_sched() as static in core.c because > it is not used outside this file. > > This eliminates the following warning in core.c: > drivers/staging/dwc2/core.c:2739:5: warning: no previous prototype fo

Re: [PATCH 1/2] drivers: dgap: Include appropriate header file in dgap_parse.c

2013-12-21 Thread Josh Triplett
On Sat, Dec 21, 2013 at 03:55:50PM +0530, Rashika Kheria wrote: > Include appropriate header file in dgap/dgap_parse.h in dgap_parse.c > because functions dgap_parsefile(), dgap_config_get_useintr(), > dgap_config_get_altpin(), dgap_find_config(), > dgap_config_get_number_of_ports(), dgap_create_co

Re: [PATCH] drivers: sbe-2t3e3: Mark functions as static in ctrl.c

2013-12-21 Thread Josh Triplett
On Sat, Dec 21, 2013 at 03:47:13PM +0530, Rashika Kheria wrote: > Mark functions t3e3_set_loopback(), t3e3_reg_read(), t3e3_reg_write(), > t3e3_port_get(), t3e3_port_set(), t3e3_port_get_stats() and > t3e3_port_del_stats() as static in ctrl.c because they are not used > outside this file. > > This

Re: [PATCH 2/2] drivers: dgap: Include appropriate header file in dgap_trace.c

2013-12-21 Thread Josh Triplett
On Sat, Dec 21, 2013 at 03:58:25PM +0530, Rashika Kheria wrote: > Include appropriate header file dgap/dgap_trace.h in dgap_trace.c > because function dgap_tracer_free() have its prototype declaration in > the header file. > > This eliminates the following warning in dgap_trace.c: > drivers/stagin

Re: [PATCH] drivers: dgnc: Include appropriate header file in dgnc_trace.c

2013-12-21 Thread Josh Triplett
On Sat, Dec 21, 2013 at 03:52:38PM +0530, Rashika Kheria wrote: > Include appropriate header file dgnc/dgnc_trace.h in dgnc_trace.c > because function dgnc_tracer_free() has its prototype declaration in the > header file. > > This eliminates the following warning in dgnc_trace.c: > drivers/staging

Re: [PATCH 2/2] drivers: bcm: Remove unused function in nvm.c

2013-12-21 Thread Josh Triplett
On Sat, Dec 21, 2013 at 04:03:22PM +0530, Rashika Kheria wrote: > Remove unused function PropagateCalParamsFromEEPROMToMemory() in nvm.c. > > This eliminates the following warning in nvm.c: > drivers/staging/bcm/nvm.c:1369:5: warning: no previous prototype for > ‘PropagateCalParamsFromEEPROMToMem

Re: [PATCH 1/2] drivers: bcm: Mark functions as static in Qos.c

2013-12-21 Thread Josh Triplett
On Sat, Dec 21, 2013 at 04:01:16PM +0530, Rashika Kheria wrote: > Mark functions MatchSrcIpAddress(), MatchDestIpAddress() and MatchTos() > as static in Qos.c because they are not used outside this file. > > This eliminates the following warnings in Qos.c: > drivers/staging/bcm/Qos.c:27:6: warning

Re: [PATCH] drivers: sm7xxfb: Mark function as static in sm7xxfb.c

2013-12-21 Thread Javier Muñoz
On 12/21/2013 11:14 AM, Rashika Kheria wrote: > Mark function smtcfb_setmode() as static in sm7xxfb.c because it is not > used outside this file. > > This eliminates the following warning in sm7xxfb.c: > drivers/staging/sm7xxfb/sm7xxfb.c:588:6: warning: no previous prototype for > ‘smtcfb_setmode

[PATCH] staging: lustre: Fix typo in lustre/ldlm

2013-12-21 Thread Masanari Iida
Correct spelling typo in lustre/ldlm Signed-off-by: Masanari Iida --- drivers/staging/lustre/lustre/ldlm/ldlm_lock.c | 8 drivers/staging/lustre/lustre/ldlm/ldlm_pool.c | 2 +- drivers/staging/lustre/lustre/ldlm/ldlm_request.c | 10 +- drivers/staging/lustre/lustre/ld

Re: [RFC PATCH 1/5] gpu: ipu-v3: Move i.MX IPUv3 core driver out of staging

2013-12-21 Thread Geert Uytterhoeven
On Fri, Dec 20, 2013 at 6:52 PM, Philipp Zabel wrote: > The i.MX Image Processing Unit (IPU) contains a number of image processing > blocks that sit right in the middle between DRM and V4L2. Some of the modules, > such as Display Controller, Processor, and Interface (DC, DP, DI) or CMOS > Sensor I

[RFC] staging: r8188eu: Fix sparse warnings in core/rtw_br_ext.c

2013-12-21 Thread Larry Finger
Please tell me if the following fixes are appropriate. In particular, I am uncertain of the __force attributes. Thanks, Larry Sparse lists the following: CHECK drivers/staging/rtl8188eu/core/rtw_br_ext.c drivers/staging/rtl8188eu/core/rtw_br_ext.c:1156:63: warning: restricted __sum16 deg

Re: [PATCH net] hyperv: Fix race between probe and open calls

2013-12-21 Thread David Miller
From: Haiyang Zhang Date: Fri, 20 Dec 2013 16:52:31 -0800 > Moving the register_netdev to the end of probe to prevent > possible open call happens before NetVSP is connected. > > Signed-off-by: Haiyang Zhang > Reviewed-by: K. Y. Srinivasan Applied, thanks.

[PATCH] staging: imx-drm: imx-tve: Fix a sparse warning

2013-12-21 Thread Liu Ying
This patch declares the function of_get_tve_mode as a static one to fix this sparse warning: drivers/staging/imx-drm/imx-tve.c:563:11: warning: \ symbol 'of_get_tve_mode' was not declared. \ Should it be static? Signed-off-by: Liu Ying --- drivers/staging/imx-drm/imx-tve.c |2 +- 1 file chan

Re: [RFC] staging: r8188eu: Fix sparse warnings in core/rtw_br_ext.c

2013-12-21 Thread Greg KH
On Sat, Dec 21, 2013 at 07:31:08PM -0600, Larry Finger wrote: > Please tell me if the following fixes are appropriate. In particular, I am > uncertain of > the __force attributes. > > Thanks, > > Larry > > > Sparse lists the following: > > CHECK drivers/staging/rtl8188eu/core/rtw_br_ext.c