Nice work.
This patch should move the binding from
Documentation/devicetree/bindings/staging/imx-drm/hdmi.txt
to the location instead of making a new file and leaving the old
one in place.
And use git format-patch -M to highlight any changes.
Regards
ZubairLK
On 08/11/14 05:32, Andy Yan wrote:
Hi Andy,
In 3.18 rc4, I cannot find checkpatch errors in imx-hdmi.c
Have these errors come during the previous 2 patches.
If yes, then these changes need to be squashed into the previous
patches. No patch should add a checkpatch error and then fix it in a later
patch.
Regards
ZubairLK
On 08/1
Hi ZubairLK:
On 2014年11月10日 17:22, Zubair Lutfullah Kakakhel wrote:
Hi Andy,
In 3.18 rc4, I cannot find checkpatch errors in imx-hdmi.c
Have these errors come during the previous 2 patches.
If yes, then these changes need to be squashed into the previous
patches. No patch should add a checkpat
Hi ZubairLK:
On 2014年11月10日 17:22, Zubair Lutfullah Kakakhel wrote:
Hi Andy,
In 3.18 rc4, I cannot find checkpatch errors in imx-hdmi.c
Have these errors come during the previous 2 patches.
If yes, then these changes need to be squashed into the previous
patches. No patch should add a checkpat
> -Original Message-
> From: Peter Zijlstra [mailto:pet...@infradead.org]
> Sent: Monday, November 10, 2014 1:44 AM
> To: Sitsofe Wheeler
> Cc: KY Srinivasan; Haiyang Zhang; de...@linuxdriverproject.org; Ingo Molnar;
> linux-ker...@vger.kernel.org
> Subject: Re: Inconsistent lock state wi
On 10/11/14 09:44, Andy Yan wrote:
> Hi ZubairLK
> On 2014年11月10日 17:17, Zubair Lutfullah Kakakhel wrote:
>> Nice work.
>>
>> This patch should move the binding from
>>
>> Documentation/devicetree/bindings/staging/imx-drm/hdmi.txt
>> to the location instead of making a new file and leaving the ol
On 2014年11月10日 17:53, Zubair Lutfullah Kakakhel wrote:
On 10/11/14 09:44, Andy Yan wrote:
Hi ZubairLK
On 2014年11月10日 17:17, Zubair Lutfullah Kakakhel wrote:
Nice work.
This patch should move the binding from
Documentation/devicetree/bindings/staging/imx-drm/hdmi.txt
to the location instead
Hi ZubairLK
On 2014年11月10日 17:17, Zubair Lutfullah Kakakhel wrote:
Nice work.
This patch should move the binding from
Documentation/devicetree/bindings/staging/imx-drm/hdmi.txt
to the location instead of making a new file and leaving the old
one in place.
And use git format-patch -M to highlig
On Sat, Nov 08, 2014 at 02:36:54PM +, Sitsofe Wheeler wrote:
> I've been trying to use the Hyper-V balloon driver to allow the host to
> reclaim unused memory but have been hitting issues. With a Hyper-V 2012
> R2 guest with 4GBytes of RAM, dynamic memory on, 1GByte minimum 10GByte
> maximum, 8
drm driver may probe before the i2c bus, so the driver should
defer probing until it is available
Signed-off-by: Andy Yan
---
Changes in v6: None
Changes in v5: None
Changes in v4:
- defer probe ddc i2c adapter
Changes in v3: None
Changes in v2: None
drivers/staging/imx-drm/imx-hdmi.c | 5 ++
imx6 and rockchip rk3288 and JZ4780 (Ingenic Xburst/MIPS)
use the interface compatible Designware HDMI IP, but they
also have some lightly difference, such as phy pll configuration,
register width, 4K support, clk useage, and the crtc mux configuration
is also platform specific.
To reuse the imx h
CHECK: Alignment should match open parenthesis
+ if ((hdmi->vic == 10) || (hdmi->vic == 11) ||
+ (hdmi->vic == 12) || (hdmi->vic == 13) ||
CHECK: braces {} should be used on all arms of this statement
+ if (hdmi->hdmi_data.video_mode.mdvi)
[...]
+ else {
[...]
Sign
We found freescale imx6 and rockchip rk3288 and Ingenic JZ4780 (Xburst/MIPS)
use the interface compatible Designware HDMI IP, but they also have some
lightly difference, such as phy pll configuration, register width(imx hdmi
register is one byte, but rk3288 is 4 bytes width and can only access by
the original imx hdmi driver is under staging/imx-drm,
which depends on imx-drm, so move the imx hdmi drvier out
to drm/bridge and rename imx-hdmi to dw-hdmi
Signed-off-by: Andy Yan
---
Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes in v3: None
Changes in v2:
- use git form
From: Yakir Yang
handle encoder in dw_hdmi-imx.c, keep the connector &
birdge in dw_hdmi.c
Signed-off-by: Andy Yan
Signed-off-by: Yakir Yang
---
Changes in v6:
- move some modification from patch#5
Changes in v5: None
Changes in v4: None
Changes in v3: None
Changes in v2: None
drivers/gpu
Hi Andy,
A few comments inline.
On 08/11/14 05:28, Andy Yan wrote:
> imx6 and rockchip rk3288 and JZ4780 (Ingenic Xburst/MIPS)
> use the interface compatible Designware HDMI IP, but they
> also have some lightly difference, such as phy pll configuration,
> register width, 4K support, clk useage,
On 11/08/2014 04:47 PM, Boris Brezillon wrote:
> Place v4l2_mbus_pixelcode in a #ifndef __KERNEL__ section so that kernel
> users don't have access to these definitions.
>
> We have to keep this definition for user-space users even though they're
> encouraged to move to the new media_bus_format en
Hi Zubair:
thanks very much for your comments.
On 2014年11月10日 18:51, Zubair Lutfullah Kakakhel wrote:
Hi Andy,
A few comments inline.
On 08/11/14 05:28, Andy Yan wrote:
imx6 and rockchip rk3288 and JZ4780 (Ingenic Xburst/MIPS)
use the interface compatible Designware HDMI IP, but they
also
Dexuan Cui writes:
>> -Original Message-
>> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
>> Sent: Saturday, November 8, 2014 1:09 AM
>> To: KY Srinivasan; Haiyang Zhang; Greg Kroah-Hartman
>> Cc: de...@linuxdriverproject.org; linux-ker...@vger.kernel.org; Dexuan Cui
>> Subject: [PA
Hi Maurice,
Would you be able to point to a complete piece of test code that exhibits this
failure?
Martyn Welch
Lead Software Engineer
GE Intelligent Platforms
Embedded Systems
T +44 (0) 1327 322748
F +44 (0) 1327 322817
E martyn.we...@ge.com
Tove Valley Business Park
Towcester, Northants, NN
This patch fixes the CamelCase checks for methods/variables in
virthba.c found with the checkpatch script.
Signed-off-by: Ken Depro
---
drivers/staging/unisys/virthba/virthba.c | 122 +++---
1 file changed, 61 insertions(+), 61 deletions(-)
diff --git a/drivers/staging/
Add a comment to the charqueue's spinlock to explain that it is a lock for the
structure. Now with spaces! :)
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorutil/charqueue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/visorutil/charqu
Delete the following unused types, and unused function prototypes:
VISORCHIPSET_SWITCH_INFO
VISORCHIPSET_EXTERNALPORT_INFO
VISORCHIPSET_INTERNALPORT_INFO
visorchipset_get_switch_info()
visorchipset_get_externalport_info()
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorchipset/vis
This patch series addresses the following issues:
- Verbosely report errors during freeze (mountpoint, exact error);
- Skip all readonly-mounted filesystems instead of skipping iso9660 only.
Changes since v1:
- Rebase on top of 'char-misc-next';
- "Tools: hv: vssdaemon: thaw everything in case of
Instead of making a list of exceptions for readonly filesystems
in addition to iso9660 we already have it is better to skip freeze
operation for all readonly-mounted filesystems.
Signed-off-by: Vitaly Kuznetsov
---
tools/hv/hv_vss_daemon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
d
When ioctl(fd, FIFREEZE, 0) results in an error we cannot report it
to syslog instantly since that can cause write to a frozen disk.
However, the name of the filesystem which caused the error and errno
are valuable and we would like to get a nice human-readable message
in the log. Save errno before
On Mon, 10 Nov 2014 12:09:19 +0100
Hans Verkuil wrote:
> On 11/08/2014 04:47 PM, Boris Brezillon wrote:
> > Place v4l2_mbus_pixelcode in a #ifndef __KERNEL__ section so that kernel
> > users don't have access to these definitions.
> >
> > We have to keep this definition for user-space users even
In order to have subsytem agnostic media bus format definitions we've
moved media bus definition to include/uapi/linux/media-bus-format.h and
prefixed enum values with MEDIA_BUS_FMT instead of V4L2_MBUS_FMT.
Reference new definitions in the ipu-v3 driver.
Signed-off-by: Boris Brezillon
Acked-by:
In order to have subsytem agnostic media bus format definitions we've
moved media bus definitions to include/uapi/linux/media-bus-format.h and
prefixed values with MEDIA_BUS_FMT instead of V4L2_MBUS_FMT.
Replace all references to the old definitions in i2c drivers.
Signed-off-by: Boris Brezillon
Place v4l2_mbus_pixelcode in a #ifndef __KERNEL__ section so that kernel
users don't have access to these definitions.
We have to keep this definition for user-space users even though they're
encouraged to move to the new media_bus_format enum.
Signed-off-by: Boris Brezillon
Acked-by: Sakari Ail
In order to have subsytem agnostic media bus format definitions we've
moved media bus definition to include/uapi/linux/media-bus-format.h and
prefixed values with MEDIA_BUS_FMT instead of V4L2_MBUS_FMT.
Replace all references to the old definitions in pci drivers.
Signed-off-by: Boris Brezillon
In order to have subsytem agnostic media bus format definitions we've
moved media bus definition to include/uapi/linux/media-bus-format.h and
prefixed them with MEDIA_BUS_FMT instead of V4L2_MBUS_FMT.
Update the v4l documentation accordingly.
Signed-off-by: Boris Brezillon
Acked-by: Hans Verkuil
In order to have subsytem agnostic media bus format definitions we've
moved media bus definition to include/uapi/linux/media-bus-format.h and
prefixed values with MEDIA_BUS_FMT instead of V4L2_MBUS_FMT.
Reference new definitions in all platform drivers.
Signed-off-by: Boris Brezillon
Acked-by: H
In order to have subsytem agnostic media bus format definitions we've
moved media bus definition to include/uapi/linux/media-bus-format.h and
prefixed values with MEDIA_BUS_FMT instead of V4L2_MBUS_FMT.
Reference new definitions in all media drivers residing in staging.
Signed-off-by: Boris Brezi
Hello,
This patch series prepares the use of media bus formats outside of
the V4L2 subsytem (my final goal is to use it in the Atmel HLCDC DRM
driver where I have to configure my DPI/RGB bus according to the
connected display).
The series first defines MEDIA_BUS_FMT_ macros, and then replace all
Define MEDIA_BUS_FMT macros (re-using the values defined in the
v4l2_mbus_pixelcode enum) into a separate header file so that they can be
used from the DRM/KMS subsystem without any reference to the V4L2
subsystem.
Then set V4L2_MBUS_FMT definitions to the MEDIA_BUS_FMT values using the
V4L2_MBUS_
Replace references to the v4l2_mbus_pixelcode enum with the new
media_bus_format enum in all common headers.
Signed-off-by: Boris Brezillon
Acked-by: Sakari Ailus
Acked-by: Hans Verkuil
---
include/media/v4l2-mediabus.h| 2 +-
include/media/v4l2-subdev.h | 2 +-
include/uapi/linux/v4l
In order to have subsytem agnostic media bus format definitions we've
moved media bus definition to include/uapi/linux/media-bus-format.h and
prefixed enum values with MEDIA_BUS_FMT instead of V4L2_MBUS_FMT.
Reference new definitions in all usb drivers.
Signed-off-by: Boris Brezillon
Acked-by: H
In order to have subsytem agnostic media bus format definitions we've
moved media bus definition to include/uapi/linux/media-bus-format.h and
prefixed enum values with MEDIA_BUS_FMT instead of V4L2_MBUS_FMT.
Reference new definitions in all usb drivers.
Signed-off-by: Boris Brezillon
Acked-by: H
Replace references to the v4l2_mbus_pixelcode enum with the new
media_bus_format enum in all common headers.
Signed-off-by: Boris Brezillon
Acked-by: Sakari Ailus
Acked-by: Hans Verkuil
---
include/media/v4l2-mediabus.h| 2 +-
include/media/v4l2-subdev.h | 2 +-
include/uapi/linux/v4l
On Mon, 10 Nov 2014 18:21:44 +0100
Boris Brezillon wrote:
> Hello,
>
> This patch series prepares the use of media bus formats outside of
> the V4L2 subsytem (my final goal is to use it in the Atmel HLCDC DRM
> driver where I have to configure my DPI/RGB bus according to the
> connected display)
Place v4l2_mbus_pixelcode in a #ifndef __KERNEL__ section so that kernel
users don't have access to these definitions.
We have to keep this definition for user-space users even though they're
encouraged to move to the new media_bus_format enum.
Signed-off-by: Boris Brezillon
Acked-by: Sakari Ail
In order to have subsytem agnostic media bus format definitions we've
moved media bus definition to include/uapi/linux/media-bus-format.h and
prefixed values with MEDIA_BUS_FMT instead of V4L2_MBUS_FMT.
Replace all references to the old definitions in pci drivers.
Signed-off-by: Boris Brezillon
In order to have subsytem agnostic media bus format definitions we've
moved media bus definition to include/uapi/linux/media-bus-format.h and
prefixed them with MEDIA_BUS_FMT instead of V4L2_MBUS_FMT.
Update the v4l documentation accordingly.
Signed-off-by: Boris Brezillon
Acked-by: Hans Verkuil
Hello,
This patch series prepares the use of media bus formats outside of
the V4L2 subsytem (my final goal is to use it in the Atmel HLCDC DRM
driver where I have to configure my DPI/RGB bus according to the
connected display).
The series first defines MEDIA_BUS_FMT_ macros, and then replace all
In order to have subsytem agnostic media bus format definitions we've
moved media bus definitions to include/uapi/linux/media-bus-format.h and
prefixed values with MEDIA_BUS_FMT instead of V4L2_MBUS_FMT.
Replace all references to the old definitions in i2c drivers.
Signed-off-by: Boris Brezillon
In order to have subsytem agnostic media bus format definitions we've
moved media bus definition to include/uapi/linux/media-bus-format.h and
prefixed enum values with MEDIA_BUS_FMT instead of V4L2_MBUS_FMT.
Reference new definitions in the ipu-v3 driver.
Signed-off-by: Boris Brezillon
Acked-by:
In order to have subsytem agnostic media bus format definitions we've
moved media bus definition to include/uapi/linux/media-bus-format.h and
prefixed values with MEDIA_BUS_FMT instead of V4L2_MBUS_FMT.
Reference new definitions in all platform drivers.
Signed-off-by: Boris Brezillon
Acked-by: H
In order to have subsytem agnostic media bus format definitions we've
moved media bus definition to include/uapi/linux/media-bus-format.h and
prefixed values with MEDIA_BUS_FMT instead of V4L2_MBUS_FMT.
Reference new definitions in all media drivers residing in staging.
Signed-off-by: Boris Brezi
Another set of checkpatch.pl fixups for visorchipset files.
Benjamin Romer (7):
staging: unisys: remove testing.h from visorchipset
staging: unisys: refactor visorchipset_file_init()
staging: unisys: fix CamelCase global variables in file.c
staging: unisys: get rid of HAVE_UNLOCKED_IOCTL c
Nothing in this file is used anymore, so remove it and the one last
reference to it from visorchipset_main.c.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorchipset/testing.h | 43 --
.../unisys/visorchipset/visorchipset_main.c| 1 -
2 files chang
Fix CamelCase name:
physAddr => physaddr
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorchipset/file.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/unisys/visorchipset/file.c
b/drivers/staging/unisys/visorchipset/file.c
index d43c40
This goto uses CamelCase and was completely unnecessary.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorchipset/file.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/unisys/visorchipset/file.c
b/drivers/staging/unisys/visorchipset/fil
Fix CamelCase names:
Cdev => file_cdev
PControlVm_channel => file_controlvm_channel
MajorDev => majordev
Registered => registered
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorchipset/file.c | 54 +++---
1 file changed, 27 insertions(+), 27 deletions(-)
Remove another completely unnecessary goto and just return the values
directly.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorchipset/file.c | 18 +-
1 file changed, 5 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/unisys/visorchipset/file.c
b/drive
Fix the declaration so it is a single line. Fix CamelCase parameter
names:
MajorDev => major_dev
pControlVm_channel => controlvm_channel
Remove the unnecessary gotos and just return directly in error cases.
Fix the last error condition so it returns the result of cdev_add()
instead of always zero
We definitely have it, so there's no point in keeping the older stuff
around. Get rid of the #ifdefs and old code.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorchipset/file.c | 18 +-
1 file changed, 1 insertion(+), 17 deletions(-)
diff --git a/drivers/staging/u
Define MEDIA_BUS_FMT macros (re-using the values defined in the
v4l2_mbus_pixelcode enum) into a separate header file so that they can be
used from the DRM/KMS subsystem without any reference to the V4L2
subsystem.
Then set V4L2_MBUS_FMT definitions to the MEDIA_BUS_FMT values using the
V4L2_MBUS_
From: Bryan Thompson
This series of patches addresses two CamelCase issues and a spinlock
commenting issue reported by checkpatch on the visorchannel tree.
Bryan Thompson (3):
staging: unisys: visorchannel: Rename CamelCase variable channelBytes
staging: unisys: visorchannel: Rename CamelCas
From: Bryan Thompson
Rename channelBytes to channel_bytes in the series of visorchannel_create
functions provided by visorchannel.
Signed-off-by: Bryan Thompson
---
drivers/staging/unisys/visorchannel/visorchannel.h | 10
.../unisys/visorchannel/visorchannel_funcs.c | 26 +++
From: Bryan Thompson
Add comments indicating the requirements and use of the insert_lock and
remove_lock in the VISORCHANNEL_Tag structure.
Signed-off-by: Bryan Thompson
---
.../unisys/visorchannel/visorchannel_funcs.c |7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff
From: Bryan Thompson
Rename the visorchannel_debug parameter nQueues to num_queues.
Signed-off-by: Bryan Thompson
---
drivers/staging/unisys/visorchannel/visorchannel.h |2 +-
.../unisys/visorchannel/visorchannel_funcs.c |4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
Rename the visorchannel_debug parameter nQueues to num_queues.
Signed-off-by: Bryan Thompson
---
drivers/staging/unisys/visorchannel/visorchannel.h |2 +-
.../unisys/visorchannel/visorchannel_funcs.c |4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/st
Add comments indicating the requirements and use of the insert_lock and
remove_lock in the VISORCHANNEL_Tag structure.
Signed-off-by: Bryan Thompson
---
.../unisys/visorchannel/visorchannel_funcs.c |7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/stagin
Resending due to return address error.
This series of patches addresses two CamelCase issues and a spinlock
commenting issue reported by checkpatch on the visorchannel tree.
Bryan Thompson (3):
staging: unisys: visorchannel: Rename CamelCase variable channelBytes
staging: unisys: visorchannel
Rename channelBytes to channel_bytes in the series of visorchannel_create
functions provided by visorchannel.
Signed-off-by: Bryan Thompson
---
drivers/staging/unisys/visorchannel/visorchannel.h | 10
.../unisys/visorchannel/visorchannel_funcs.c | 26 ++--
2 fi
Hi Martyn,
Thanks for your reply. I have pasted the code below. It is very much
similar to your test code from the forum.
Thanks!
#define _XOPEN_SOURCE 500
#define u32 unsigned int
#include
#include
#include
#include
#include
#include
#include
#include "vme_user.h"
int main(int argc, char
scripts/checkpatch.pl reports a coding style problem in xmit_linux.c
WARNING:BRACES: braces {} are not necessary for single statement blocks
#61852: FILE: rtl8188eu/os_dep/xmit_linux.c:70:
This patch removes unnecessary braces and simplifies the function to a
single return statement.
Signed-
Using a u16 pointer typecast for a result from htons() results in the following
warning from sparse:
drivers/staging/rtl8723au/core/rtw_xmit.c:1279:36: warning: incorrect type in
assignment (different base types)
drivers/staging/rtl8723au/core/rtw_xmit.c:1279:36:expected unsigned short
[uns
Chris Ruffin writes:
> Using a u16 pointer typecast for a result from htons() results in the
> following warning from sparse:
>
> drivers/staging/rtl8723au/core/rtw_xmit.c:1279:36: warning: incorrect type in
> assignment (different base types)
> drivers/staging/rtl8723au/core/rtw_xmit.c:1279:36:
Arend van Spriel writes:
> On 10-11-14 21:21, Jes Sorensen wrote:
>> Chris Ruffin writes:
>>> Using a u16 pointer typecast for a result from htons() results in
>>> the following warning from sparse:
>>>
>>> drivers/staging/rtl8723au/core/rtw_xmit.c:1279:36: warning:
>>> incorrect type in assignme
From: Jes Sorensen
Hi,
Here's a set of patches removing a pile of unused code from the
rtl8723au drivers. It also includes an alignment issue pointed out by
Arend van Spriel.
Note this set goes on top of Chris Ruffin's patch:
staging: rtl8723au: change typecast to match type returned by htons()
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 4
drivers/staging/rtl8723au/hal/usb_halinit.c | 4
drivers/staging/rtl8723au/include/rtl8723a_hal.h | 2 --
3 files changed, 10 deletions(-)
diff --git a/drivers/staging/rtl
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/core/rtw_xmit.c| 17 -
drivers/staging/rtl8723au/include/rtw_xmit.h | 2 --
2 files changed, 19 deletions(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_xmit.c
b/drivers/staging/rtl8723au/cor
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/core/rtw_recv.c | 40 ---
1 file changed, 4 insertions(+), 36 deletions(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_recv.c
b/drivers/staging/rtl8723au/core/rtw_recv.c
index de98da5.
From: Jes Sorensen
No point of masking out high bits since we never set the value to
anything exceeding bits 0-3.
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/core/rtw_xmit.c | 2 +-
drivers/staging/rtl8723au/hal/rtl8723au_xmit.c | 11 ++-
2 files changed, 7 insertio
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/core/rtw_xmit.c| 40 ++--
drivers/staging/rtl8723au/include/rtw_xmit.h | 1 -
2 files changed, 20 insertions(+), 21 deletions(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_xmit.c
b/d
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/rtl8723au_xmit.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8723au/hal/rtl8723au_xmit.c
b/drivers/staging/rtl8723au/hal/rtl8723au_xmit.c
index a67850f..cf31d29 1
From: Jes Sorensen
Reported-by: Arend van Spriel
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/core/rtw_xmit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_xmit.c
b/drivers/staging/rtl8723au/core/rtw_xmit.c
index 18a9f34..f
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/core/rtw_xmit.c | 26 +++---
1 file changed, 7 insertions(+), 19 deletions(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_xmit.c
b/drivers/staging/rtl8723au/core/rtw_xmit.c
index b9ee983..18a9
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 248 --
drivers/staging/rtl8723au/include/rtl8723a_xmit.h | 1 -
2 files changed, 249 deletions(-)
diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
b/driv
From: Jes Sorensen
The rtl8723au relies on hw led support, so no point carrying a large
unused sw led infrastructure around.
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/Makefile |2 -
drivers/staging/rtl8723au/core/rtw_cmd.c |6 -
drivers/staging/rtl
The Rev 1.0 APCI-1564 boards do not have counters.
Fix the code in the main driver source so that the I/O accesses to the
counters do not happen if the devpriv->counters member is not initialized.
This does not fix the code in hwdrv_apci1564.c. That code violates the
comedi API and is currently b
The timer subdevice is currently broken in this driver.
The Rev 1.0 and 2.x versions of the board both have a 12-bit timer. But only
the Rev 2.x boards have the 3 32-bit counters.
Split the current timer subdevice into two separate subdevices:
1) A single channel 12-bit timer subdevice
2) A t
The TCW (timer/counter/watchdog) devices in the various ADDI-DATA drivers
use a common register map definition. Provide a common generic define for
these registers so they don't have to be replicated in each driver.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
dri
According to ADDI-DATA, the PLD Revision 2.x versions of the APCI-1564 use
PCI BAR 0 for the main registers of the board.
Remove the 'amcc_iobase' member of the private data and use the dev->iobase
to store the base address of PCI BAR 1.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg
The APCI-1564 has different I/O mapping depending on if the PLD revision is
Rev 1.0 or Rev 2.x.
Fix the main register defines so they will work for all PLD revisions and
initialie the dev->iobase appropriately. Move the register defines to the
main driver source file.
Signed-off-by: H Hartley Swe
Use the generic TCW (timer/counter/watchdog) defines for the 8-bit watchdog.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi_watchdog.c | 30 --
1 file changed, 9 insertions(+), 21 deletions(-)
diff --git a
Use the generic TCW (timer/counter/watchdog) defines for the 12-bit timer.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../comedi/drivers/addi-data/hwdrv_apci1564.c | 24 +++---
drivers/staging/comedi/drivers/addi_apci_1564.c| 23
The APCI1564_DI_INT_STATUS_REG is located in the PCI BAR 0 I/O space. That
base address is stored in devpriv->amcc_iobase. Use that to correctly read
the register.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi_apci_1564.c | 4 ++-
The APCI-1564 has different I/O mapping depending on if the PLD revision
is Rev 1.0 or Rev 2.x.
Add a member, 'timer', to the private data for the base address of the
12-bit timer. Fix the register defines so they will work for all PLD
revisions and initialize the devpriv->timer appropriately.
Si
According to ADDI-DATA, the APCI-1564 board has a FPGA with a PCI core, it
does not use an AMCC PCI controller chip.
Remove the amcc_s5933.h include as well as the read of the AMCC_OP_REG_INTCSR
register. That offset would actually read APCI1564_WDOG_STATUS_REG register
in the FPGA which has nothi
The APCI-1564 has different I/O mapping depending on if the PLD revision is
Rev 1.0 or Rev 2.x. The revision can be determined by reading the EEPROM
register at offset 0x00 of PCI BAR 0 and checking the value of bits 7 to 4.
Add this check to apci1564_auto_attach(). Currently this driver is coded
The APCI-1564 boards do not actually have an AMCC PCI controller. According
to ADDI-DATA, the boards have always used an FPGA with a PCI core.
Unfortunately,
there are two major revisions of the FPGA and they use different I/O mappings.
Fix the driver so that both I/O map revisions work correctly
Remove the error return in the (*auto_attach) and allow the driver to
attach to APC-1564 boards that use the PLD Rev 1.0 I/O mapping.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi_apci_1564.c | 3 ---
1 file changed, 3 deletions(
Move the defines for the counter registers from the included source
file to the main driver source file.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c | 12
drivers/staging/comedi/drivers/addi_a
According to ADDI-DATA, only the PLD Revision 2.x versions of the APCI-1564
have the 3 counters. The base address for these counters is found in PCI BAR 1.
For aesthetics, save this base address in the private data. The dev->iobase
can then be used for the main registers of the board.
Signed-off-
Use the generic TCW (timer/counter/watchdog) defines for the 32-bit counters.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../comedi/drivers/addi-data/hwdrv_apci1564.c | 35 --
drivers/staging/comedi/drivers/addi_apci_1564.c| 35 +
The comedi core now counts the number of samples added to the async buffer and
detects the end-of-scan and increments the comedi_async 'scans_done' counter.
Remove the private data member 'stop_counter' and use the 'scans_done' member
to detect the end-of-acquisition.
This fixes a possible interg
Use the comedi_async 'scans_done' to detect the EOA and tidy up the DMA
code a bit.
H Hartley Sweeten (4):
staging: comedi: adl_pci9118: use comedi_async 'scans_done' to detect EOA
staging: comedi: adl_pci9118: absorb move_block_from_dma()
staging: comedi: adl_pci9118: use comedi_bytes_to_sa
1 - 100 of 129 matches
Mail list logo
