On Wednesday, July 20, 2016 7:25:19 AM CEST Jes Sorensen wrote:
> Arnd Bergmann writes:
> >> I'd like to get rid of all the drivers/staging/rtl* drivers eventually
> >
> > That would be great, yes.
> >
> > Can you clarify what the long-term plan is? I
g/rtl8192u/r8192U_dm.c:646:50: error: comparison is always false due to
limited range of data type [-Werror=type-limits]
This patch changes all uses of 'char' in this driver that refer to
8-bit integers to use 's8' instead, which is signed on all architectures.
Signed-off-by: Arnd Be
iver that refer to
8-bit integers to use 's8' instead, which is signed on all architectures.
Signed-off-by: Arnd Bergmann
Acked-by: Jes Sorensen
---
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 8
drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 2 +-
drivers/staging/rtl8
removing the warning.
Signed-off-by: Arnd Bergmann
---
drivers/staging/rtl8192e/rtl819x_Qos.h| 3 ---
drivers/staging/rtl8192e/rtl819x_TSProc.c | 5 +
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_Qos.h
b/drivers/staging/rtl8192e
On Wednesday, July 20, 2016 11:33:43 AM CEST Jes Sorensen wrote:
> Arnd Bergmann writes:
> > On Wednesday, July 20, 2016 7:25:19 AM CEST Jes Sorensen wrote:
> >> Arnd Bergmann writes:
> >> Well it really all depends on how much time I have and how much others
> >
On Friday, July 22, 2016 7:55:36 AM CEST Jes Sorensen wrote:
> Stefan Lippers-Hollmann writes:
> > Hi
> >
> > On 2016-07-20, Arnd Bergmann wrote:
> >> On Wednesday, July 20, 2016 11:33:43 AM CEST Jes Sorensen wrote:
> >> > Arnd Bergmann writes:
>
x27; [-Werror=unused-variable]
This puts the variable declaration into the same #ifdef.
Signed-off-by: Arnd Bergmann
Fixes: 1e1f9ff406fd ("staging: lustre: llite: break ll_getxattr_common into 2
functions")
---
drivers/staging/lustre/lustre/llite/xattr.c | 2 ++
1 file changed, 2 inser
to use the correct interface for accounting in the
"node" rather than the "zone".
Signed-off-by: Arnd Bergmann
Fixes: d806f30e639b ("staging: lustre: osc: revise unstable pages accounting")
Fixes: 11fb998986a7 ("mm: move most file-based accounting to the node&quo
On Thursday, September 1, 2016 3:40:43 PM CEST Laura Abbott wrote:
> --- a/drivers/staging/android/ion/ion-ioctl.c
> +++ b/drivers/staging/android/ion/ion-ioctl.c
> @@ -22,6 +22,29 @@
> #include "ion_priv.h"
> #include "compat_ion.h"
>
> +union ion_ioctl_arg {
> + struct ion_fd_data fd;
>
On Friday, September 2, 2016 1:33:44 PM CEST Laura Abbott wrote:
> On 09/02/2016 02:02 AM, Arnd Bergmann wrote:
> > On Thursday, September 1, 2016 3:40:43 PM CEST Laura Abbott wrote:
> >
> >> --- a/drivers/staging/android/ion/ion-ioctl.c
> >> +++ b/driver
On Friday, September 2, 2016 2:27:21 PM CEST Laura Abbott wrote:
> >
> > All warnings (new ones prefixed by >>):
> >
> >drivers/staging/android/ion/ion.c: In function 'ion_query_heaps':
> >>> drivers/staging/android/ion/ion.c:1181:3: warning: cast to pointer from
> >>> integer of different siz
ks these functions with 'static'.
>
> Signed-off-by: Baoyou Xie
>
Acked-by: Arnd Bergmann
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
used in the file in which it is
> declared and don't need a declaration, but can be made static.
> so this patch marks this function with 'static'.
>
> Signed-off-by: Baoyou Xie
>
Acked-by: Arnd Bergmann
_
/vme_fake.c: In function 'fake_slave_set':
drivers/vme/bridges/vme_fake.c:204:29: error: assignment makes pointer from
integer without a cast [-Werror=int-conversion]
To make this clearer while fixing the warning, I'm adding
a set of helper functions for the type conversion.
Sign
On Tuesday, September 6, 2016 10:39:25 PM CEST Dan Carpenter wrote:
> On Tue, Sep 06, 2016 at 02:59:41PM +0200, Arnd Bergmann wrote:
> > casting between dma_addr_t and a pointer is generally tricky,
> > as they might not be the same size and almost never point into
> > the sam
On Wednesday, September 7, 2016 11:49:59 AM CEST Laura Abbott wrote:
> - if (dir & _IOC_WRITE)
> - if (copy_from_user(&data, (void __user *)arg, _IOC_SIZE(cmd)))
> - return -EFAULT;
> + /*
> + * The copy_from_user is unconditional here for both read and
On Wednesday, September 7, 2016 11:49:58 AM CEST Laura Abbott wrote:
> The number of Ion ioctls may continue to grow along with necessary
> validation. Pull it out into a separate file for easier management
> and review.
>
> Signed-off-by: Laura Abbott
>
Acked
-cec.c:447:2: error: 'pa' may be used
uninitialized in this function [-Werror=maybe-uninitialized]
This sets the address to CEC_PHYS_ADDR_INVALID in this case, so we don't
try to write back the uninitialized data to the device.
Signed-off-by: Arnd Bergmann
Fixes: e28a6c8b3fcc (
On Tuesday, September 13, 2016 11:51:53 AM CEST Namrata A Shettar wrote:
> --- a/drivers/staging/comedi/comedi_pcmcia.c
> +++ b/drivers/staging/comedi/comedi_pcmcia.c
> @@ -18,7 +18,6 @@
>
> #include
> #include
> -
> #include "comedi_pcmcia.h"
>
> /**
>
I would argue that checkpatch is wr
ng/android/ion/hisilicon/hi6220_ion.o: In function
`hi6220_ion_probe':
hi6220_ion.c:(.text.hi6220_ion_probe+0x5c): undefined reference to
`ion_parse_dt'
hi6220_ion.c:(.text.hi6220_ion_probe+0xf8): undefined reference to
`ion_destroy_platform_data'
This selects the symbol when nee
On Sunday, September 18, 2016 8:43:18 PM CEST James Simmons wrote:
>
> Nak. I'm not seeing this error with W=1. Also if you look
> lmv_pack_md() is only used in lmv_obd.c and the function
> appears early in the file before it is used, so no prototype
> missing errors should happen.
So it should
sca3000_core: implemented
IIO_CHAN_INFO_SAMP_FREQ")
Signed-off-by: Arnd Bergmann
---
drivers/staging/iio/accel/sca3000_core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/iio/accel/sca3000_core.c
b/drivers/staging/iio/accel/sca3000_core.c
index d626125d7af9..564b36d4f648 10
On Saturday, September 24, 2016 9:34:41 AM CEST Baoyou Xie wrote:
> On 24 September 2016 at 01:10, Greg KH wrote:
>
> > On Fri, Sep 23, 2016 at 09:22:29PM +0800, Baoyou Xie wrote:
> > > We get 3 warnings when building kernel with W=1:
> > > drivers/staging/ks7010/ks7010_sdio.c:90:6: warning: no p
ut argument 9 has type 'size_t {aka const unsigned int}'
[-Werror=format=]
This adds it back.
Fixes: e10a431b3fd0 ("staging: lustre: lov: move LSM to LOV layer")
Cc: John L. Hammond
Cc: Jinshan Xiong
Cc: James Simmons
Signed-off-by: Arnd Bergmann
---
drivers/staging/lust
.
Fixes: 239fd5d41f9b ("staging: lustre: libcfs: shortcut to create CPT from NUMA
topology")
Cc: Liang Zhen
Cc: James Simmons
Signed-off-by: Arnd Bergmann
---
drivers/staging/lustre/lnet/libcfs/linux/linux-cpu.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/lustr
sca3000_core: implemented
IIO_CHAN_INFO_SAMP_FREQ")
Signed-off-by: Arnd Bergmann
Cc: Ico Doornekamp
Cc: Jonathan Cameron
---
I submitted this on Sept 22, and Jonathan said he applied it to his
'togreg' tree, but it hasn't appeared in linux-next yet, presumably
since this was not co
here, I don't expect this to result in additional runtime
checks.
Signed-off-by: Arnd Bergmann
---
drivers/net/hyperv/netvsc_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
index f0919bd..5d6e75a 1
On Monday, October 17, 2016 10:23:00 PM CEST Patrick Farrell wrote:
> Arnd,
>
>
> The description and the actual patch don't seem to match up. Am I missing
> something?
Sorry, I pasted the wrong error message when writing the changelog.
> From: lustre-devel on beh
zed in this function [-Werror=maybe-uninitialized]
drivers/staging/lustre/lustre/lov/lov_pack.c:313:6: note: 'rc' was declared here
This adds it back.
Fixes: e10a431b3fd0 ("staging: lustre: lov: move LSM to LOV layer")
Signed-off-by: Arnd Bergmann
---
v2: fix embarrassing i
On Monday, October 17, 2016 3:37:11 PM CEST Linus Torvalds wrote:
> On Mon, Oct 17, 2016 at 3:29 PM, Arnd Bergmann wrote:
> >
> > Sorry, I pasted the wrong error message when writing the changelog.
>
> Not just the warning, the summary above it talks about the wrong
&g
el.org/patch/8110281/
Signed-off-by: Arnd Bergmann
---
v2: handle failure for both affected reads instead of just the one
we get a warning for
v2: do not retry on failure to avoid looping in case of permanent
errors
---
drivers/staging/iio/impedance-analyzer/ad5933.c | 17 ++---
into
'default' makes it obvious to the compiler too, which avoids the
warning and probably leads to better object code too.
As the same warning appears in other files that have the exact
same code, I'm fixing it in both rtl8192e and rtl8192u, even
though I did not observe it for the
d
in this function [-Werror=maybe-uninitialized]
This sets it to IIO_VAL_INT, which I think is what we want here.
Fixes: 2296c0623eb7 ("staging: iio: cdc: ad7746: implement
IIO_CHAN_INFO_SAMP_FREQ")
Signed-off-by: Arnd Bergmann
---
drivers/staging/iio/cdc/ad7746.c | 1 +
1 file
ction [-Werror=maybe-uninitialized]
drivers/staging/lustre/lustre/lov/lov_pack.c:313:6: note: 'rc' was declared here
This adds it back.
Fixes: e10a431b3fd0 ("staging: lustre: lov: move LSM to LOV layer")
Signed-off-by: Arnd Bergmann
---
drivers/staging/lustre/lustre/lov/lov_pac
.
Fixes: 239fd5d41f9b ("staging: lustre: libcfs: shortcut to create CPT from NUMA
topology")
Signed-off-by: Arnd Bergmann
---
drivers/staging/lustre/lnet/libcfs/linux/linux-cpu.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/lustre/lnet/libcfs/linux/linux-cpu.c
On Thursday, October 27, 2016 3:12:42 PM CEST Greg Kroah-Hartman wrote:
> On Tue, Oct 25, 2016 at 11:22:30PM +0200, Arnd Bergmann wrote:
> > After a recent bugfix, we get a warning about the use of an uninitialized
> > variable:
> >
> > drivers/staging/lustre/lnet/l
On Monday, November 7, 2016 4:48:35 PM CET Michael Zoran wrote:
> .../vc04_services/interface/vchiq_arm/vchiq_arm.c | 269
> +
> .../vc04_services/interface/vchiq_arm/vchiq_if.h | 25 ++
> .../interface/vchiq_arm/vchiq_ioctl.h | 102
> 3 files changed
es the allocation of the 'st' structure before its first
use, as it should have been.
Fixes: 43a07e48af44 ("staging: iio: ad9832: clean-up regulator 'reg'")
Fixes: a98461d79ba5 ("staging: iio: ad9832: add DVDD regulator")
Signed-off-by: Arnd Bergmann
---
d
, which is more reliable and gives us better
compile time coverage.
Fixes: 0561155f6fc5 ("staging: iio: tsl2583: don't shutdown chip when updating
the lux table")
Signed-off-by: Arnd Bergmann
---
drivers/staging/iio/light/tsl2583.c | 15 +++
1 file changed, 3 insertions(+
sm750fb/*.[ch]
done
Fixes: 03140dabf584 ("staging: sm750fb: Replace functions CamelCase naming with
underscores.")
Signed-off-by: Arnd Bergmann
---
drivers/staging/sm750fb/ddk750_chip.c | 24
drivers/staging/sm750fb/ddk750_chip.h | 4 ++--
drivers/staging/sm750
On Wednesday, November 9, 2016 3:50:29 AM CET Dilger, Andreas wrote:
> On Nov 7, 2016, at 19:47, James Simmons wrote:
> >
> > The ldlm_pool field pl_recalc_time is set to the current
> > monotonic clock value but the interval period is calculated
> > with the wall clock. This means the interval p
On Wednesday, November 9, 2016 12:37:27 PM CET Michael Zoran wrote:
> static long
> -vchiq_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
> +vchiq_ioctl_shutdown(VCHIQ_INSTANCE_T instance,
> + unsigned int cmd,
> + unsigned long arg) {
This does n
On Thursday, November 10, 2016 1:21:08 PM CET Greg Kroah-Hartman wrote:
> >
> > the intention here is simply to have the console log keep the
> > same numbers as "date +%s" for absolute values. The patch that
> > James suggested converting everything to ktime_get_seconds()
> > would result in the
or pl_recalc")
Reported-by: James Simmons
Signed-off-by: Arnd Bergmann
---
v2: James' patch was similarly incomplete to mine, as it only
addressed some of the calls. With this new version, all ktime
accessors use the same time domain.
diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_poo
I found a few other places in the same file
that can be simplified. That code appears to be a relic from times
when the assumption above was not valid.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/linux_wlan.c | 34 +-
1 file changed, 9 insertions(+),
uld do the same for the down_interruptible_killable here, but
it's better to just remove the semaphores entirely from the driver,
which also takes care of that.
Signed-off-by: Arnd Bergmann
---
.../vc04_services/interface/vchiq_arm/vchiq_arm.c| 2 +-
.../interface/vchiq_arm/vc
mpletely disabled in case of compile-testing.
Signed-off-by: Arnd Bergmann
---
drivers/staging/vc04_services/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vc04_services/Kconfig
b/drivers/staging/vc04_services/Kconfig
index 660dcedc2820..061ffd261086
Removing the file causes a build failure:
make[5]: *** No rule to make target 'drivers/staging/fsl-mc/bus/dpmng.o',
needed by 'drivers/staging/fsl-mc/bus/mc-bus-driver.o'.
This adapts the Makefile as needed.
Fixes: b065307fe0ad ("staging: fsl-mc: remove dpmng API fi
On Tue, Jun 27, 2017 at 4:41 PM, wrote:
> From: Laurentiu Tudor
>
> This patch series contain mainly clean-ups of the mc-bus header files
> with the final goal of reorganizing them in just 2 files: a public
> and a private one, as per GregKH suggestion [1].
> Here's a summary of the header reorg
On Tue, Jun 27, 2017 at 6:00 PM, gregkh wrote:
> On Tue, Jun 27, 2017 at 05:33:21PM +0200, Arnd Bergmann wrote:
>> On Tue, Jun 27, 2017 at 4:41 PM, wrote:
>> > From: Laurentiu Tudor
>> >
>> > This patch series contain mainly clean-ups of the mc-bus head
either a NULL pointer or an error
code to consistently return error pointers when failing.
Fixes: e130291212df ("[media] media: Add i.MX media core driver")
Signed-off-by: Arnd Bergmann
---
I can't reproduce the original warning any more, but this
patch still makes sense by itsel
rx and tx now, returning
-EFAULT as expected.
Cc: sta...@vger.kernel.org
Signed-off-by: Arnd Bergmann
---
This warning now shows up in 'allmodconfig' builds, so it would be
good to get it fixed quickly for 4.13, but my patch should not go
in without careful review since I'm not familia
same as the others, replacing the
stack variable with a GFP_ATOMIC allocation.
Signed-off-by: Arnd Bergmann
---
This one is not important, as it only seems to show up in rare
configurations. I'd suggest adding it to staging-next for 4.14
after the merge window.
---
drivers/staging/rtl
On Mon, Jul 10, 2017 at 3:35 PM, Dan Carpenter wrote:
> You should add some kfree calls as well.
Oops, thanks for pointing out my mistake. I'll resend a fixed version.
Arnd
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.lin
same as the others, replacing the
stack variable with a GFP_ATOMIC allocation.
Signed-off-by: Arnd Bergmann
---
This one is not important, as it only seems to show up in rare
configurations. I'd suggest adding it to staging-next for 4.14
after the merge window.
v2: fix missing kfre
to '0' for success to keep the current behavior,
though returning an error would also make sense there.
Fixes: e130291212df ("[media] media: Add i.MX media core driver")
Signed-off-by: Arnd Bergmann
---
v2: fix type mismatch
v3: rework of_parse_subdev() as well.
---
drivers/stagi
On Thu, Jun 29, 2017 at 11:13 AM, Philipp Zabel wrote:
>> @@ -134,23 +134,26 @@ static void csi_idmac_put_ipu_resources(struct
>> csi_priv *priv)
>> static int csi_idmac_get_ipu_resources(struct csi_priv *priv)
>> {
>> int ch_num, ret;
>> + struct ipu_smfc *smfc, *idmac_ch;
>
> This
declared with attribute
>> warn_unused_result [-Werror=unused-result]
>>
>> In case we get short copies here, we may get incorrect behavior.
>> I've added failure handling for both rx and tx now, returning
>> -EFAULT as expected.
>>
>> Cc: sta...@vger.kern
nal code had 'unsigned short' here, but incorrectly got
converted to 'bool'. This reverts the regression and uses a normal
type instead.
Fixes: 29148543c521 ("staging:iio:resolver:ad2s1210 minimal chan spec
conversion.")
Cc: sta...@vger.kernel.org
Signed-off-by: Arnd
In case of simple 'if' checks, adding a temporary variable is
usually ok, and sometimes this can be used to propagate or
print an error code, so I do that.
For the 'while' loops, I ended up adding an otherwise useless
comparison with zero, which unfortunately makes the code
On Fri, Jul 14, 2017 at 2:05 PM, Dan Carpenter wrote:
> Changing:
>
> - if (!frob()) {
> + if (frob() == 0) {
>
> is a totally pointless change. They're both bad, because they're doing
> success testing instead of failure testing, but probably the second one
> is slightly worse.
>
> This warning
On Fri, Jul 14, 2017 at 3:09 PM, Dan Carpenter wrote:
> On Fri, Jul 14, 2017 at 03:55:26PM +0300, Dan Carpenter wrote:
>> I don't agree with it as a static analysis dev...
>
> What I mean is if it's a macro that returns -ENODEV or a function that
> returns -ENODEV, they should both be treated the
On Mon, Jul 17, 2017 at 3:26 PM, wrote:
> From: Laurentiu Tudor
>
> Split the 64-bit accesses in 32-bit accesses because there's no real
> constrain in MC to do only atomic 64-bit. There's only one place
> where ordering is important: when writing the MC command header the
> first 32-bit part of
On Mon, Jul 17, 2017 at 3:45 PM, Hans Verkuil wrote:
> On 14/07/17 11:36, Arnd Bergmann wrote:
>> @@ -201,8 +202,9 @@ static int cx18_g_fmt_sliced_vbi_cap(struct file *file,
>> void *fh,
>>* digitizer/slicer. Note, cx18_av_vbi() wipes the passed in
>>
On Mon, Jul 17, 2017 at 4:27 PM, Laurentiu Tudor
wrote:
> Hi Arnd,
>
> On 07/17/2017 04:45 PM, Arnd Bergmann wrote:
>> On Mon, Jul 17, 2017 at 3:26 PM, wrote:
>>> From: Laurentiu Tudor
>>>
>>> Split the 64-bit accesses in 32-bit accesses because ther
On Mon, Jul 17, 2017 at 4:35 PM, Hans Verkuil wrote:
> On 17/07/17 16:26, Arnd Bergmann wrote:
>> Let me try again without ccache for now and see what warnings remain.
>> We can find a solution for those first, and then decide how to deal with
>> ccache.
>
> Sounds goo
On Tue, Jul 18, 2017 at 1:08 PM, Laurentiu Tudor
wrote:
> On 07/17/2017 06:00 PM, Arnd Bergmann wrote:
>> Strictly speaking the __raw_writel() won't guarantee that the
>> data is written as a single word, the compiler might decide to
>> split it up into byte-sized
On Tue, Jul 18, 2017 at 3:37 PM, wrote:
> From: Laurentiu Tudor
>
> As raw device io functions are not portable and don't handle byte-order
> (triggering suspicion that endianness isn't handled well) switch to
> using the standard api.
> Since MC expects LE byte-order and the upper layers alread
On Tue, Jul 18, 2017 at 3:37 PM, wrote:
> --- a/drivers/staging/fsl-dpaa2/Kconfig
> +++ b/drivers/staging/fsl-dpaa2/Kconfig
> @@ -4,7 +4,7 @@
>
> config FSL_DPAA2
> bool "Freescale DPAA2 devices"
> - depends on FSL_MC_BUS
> + depends on FSL_MC_BUS && ARCH_LAYERSCAPE
>
th the two minor questions addressed
Acked-by: Arnd Bergmann
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Tue, Jul 18, 2017 at 4:26 PM, Laurentiu Tudor
wrote:
>
> Maybe i made an error in my previous emails, but the hi-lo variant is
> the correct one. The command execution is triggered when the _first_
> 32-bit half of the header (header&0x) is written, so that's why
> it must be written la
On Tue, Jul 18, 2017 at 4:36 PM, Laurentiu Tudor
wrote:
> Good point, I'll take care of it. But don't you mean COMPILE_TEST be
> added on the actual MC_BUS config, like so:
>
> config FSL_MC_BUS
> bool "QorIQ DPAA2 fsl-mc bus driver"
> - depends on OF && ARCH_LAYERSCAPE
> +
event'? [-Werror=implicit-function-declaration]
Fixes: e130291212df ("[media] media: Add i.MX media core driver")
Signed-off-by: Arnd Bergmann
---
drivers/staging/media/imx/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/media/imx/Kconfig
b/drivers/stag
e the redundant 'default n'.
Fixes: 874bcba65f9a ("staging: pi433: New driver")
Signed-off-by: Arnd Bergmann
---
drivers/staging/pi433/Kconfig | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/pi433/Kconfig b/drivers
at
contains the type.
Signed-off-by: Arnd Bergmann
---
drivers/staging/fsl-mc/include/dpaa2-io.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/fsl-mc/include/dpaa2-io.h
b/drivers/staging/fsl-mc/include/dpaa2-io.h
index 002829cecd75..c5646096c5d4 100644
--- a/drivers/st
eo driver that explicitly selects 'THERMAL'. Turning
this into a 'depends on' addresses the problem.
For completeness, I'm also removing the redundant 'select THERMAL'
from INTEL_MENLOW, so no other driver uses that statement.
Fixes: bcdfb5e56dc5 ("drm/etnaviv:
h 'depends on LCD_CLASS_DEVICE', that would clean
it up some more, but it is also a more invasive change that we
can do separately at some point.
Arnd
Arnd Bergmann (3):
backlight: always select BACKLIGHT_LCD_SUPPORT for
BACKLIGHT_CLASS_DEVICE
ACPI/DRM: rework ACPI_VIDEO
r dependency with X86_PLATFORM_DEVICES/NOUVEAU.
Signed-off-by: Arnd Bergmann
---
drivers/acpi/Kconfig| 5 -
drivers/gpu/drm/gma500/Kconfig | 6 +-
drivers/gpu/drm/i915/Kconfig| 7 +--
drivers/gpu/drm/nouveau/Kconfig | 10 ++
drivers/platform/x86/Kconfi
users of BACKLIGHT_CLASS_DEVICE also select
BACKLIGHT_LCD_SUPPORT, but not all of them do. This makes the remaining
ones behave like the others.
It would probably be best to rework the way those two options related
entirely, but for now this takes the simpler and safer approach to
fix the war
xf2): undefined reference to `gen_pool_free'
This adds a Kconfig select statement, mirroring what all the other
users have.
Fixes: dd55d44f4084 ("staging: vboxvideo: Add vboxvideo to drivers/staging")
Signed-off-by: Arnd Bergmann
---
drivers/staging/vboxvideo/Kconfig | 1 +
1 file
se div_u64()
to get the external division implementation.
Fixes: 874bcba65f9a ("staging: pi433: New driver")
Signed-off-by: Arnd Bergmann
---
drivers/staging/pi433/rf69.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/pi433/rf69.c b/drivers/s
On Fri, Jul 28, 2017 at 4:21 PM, Marcus Wolf
wrote:
> Hi Arnd,
>
> we already have a patch for this:
> [PATCH 1/1] staging: pi433: fix problem with division in rf69_set_deviation
> from 20.07.2017
>
> Maybe I did something wrong, but my first solution was exactly like your
> proposal. As far as I
rror=frame-larger-than=]
This moves the buffer into the dynamically allocated per-device
structure.
Signed-off-by: Arnd Bergmann
---
drivers/staging/pi433/pi433_if.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/
arily there with just the base driver enabled.
This moves the 'select' statement to the top-level option to make
sure it's always available.
Fixes: 64b5a49df486 ("[media] media: imx: Add Capture Device Interface")
Signed-off-by: Arnd Bergmann
---
drivers/staging/media/imx/Kco
Fixes: 9a5a6911aa3f ("staging: imx: fix non-static declarations")
Signed-off-by: Arnd Bergmann
---
drivers/staging/media/atomisp/i2c/imx/ad5816g.c | 11 +---
drivers/staging/media/atomisp/i2c/imx/drv201.c| 11 +---
drivers/staging/media/atomisp/i2c/imx/dw9714.c| 1
nd rtl_pci parts
for new driver")
Signed-off-by: Arnd Bergmann
---
drivers/staging/rtlwifi/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtlwifi/Kconfig b/drivers/staging/rtlwifi/Kconfig
index fc482b49f9aa..cb3a29ae764b 100644
--- a/drivers/sta
nd to make gcc happy.
Fixes: 56bde846304e ("staging: r8822be: Add existing rtlwifi and rtl_pci parts
for new driver")
Signed-off-by: Arnd Bergmann
---
drivers/staging/rtlwifi/btcoexist/halbtc8822b1ant.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/dri
t rid of the
warning.
Signed-off-by: Arnd Bergmann
---
drivers/staging/rts5208/sd.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/rts5208/sd.c b/drivers/staging/rts5208/sd.c
index 4033a2cf7ac9..d548bc695f9e 100644
--- a/drivers/staging/rts5208/sd.c
+++ b/drivers/
h ABI versions.
Fixes: e8d2ed7db7c3 ("Revert "staging: Fix build issues with new binder API"")
Signed-off-by: Arnd Bergmann
---
drivers/android/binder.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/android/binder.c b/drivers/android/binder
On Sunday 27 September 2015 23:57:30 Dilger, Andreas wrote:
> >diff --git a/drivers/staging/lustre/lustre/libcfs/debug.c
> >b/drivers/staging/lustre/lustre/libcfs/debug.c
> >index e93f556..ae325f7 100644
> >--- a/drivers/staging/lustre/lustre/libcfs/debug.c
> >+++ b/drivers/staging/lustre/lustre/li
On Monday 28 September 2015 00:38:37 Dilger, Andreas wrote:
> >Changing this would unfortunately change the format in an incompatible
> >way, breaking all existing user space tools that access the data.
>
> It seems that it would be possible to fix this declaration to be
> compatible with current
On Monday 28 September 2015 01:09:18 Dilger, Andreas wrote:
> On 2015/09/27, 10:45 PM, "gr...@linuxhacker.ru"
> wrote:
> >diff --git a/drivers/staging/lustre/lustre/ptlrpc/events.c
> >b/drivers/staging/lustre/lustre/ptlrpc/events.c
> >index 53f6b62..afd869b 100644
> >--- a/drivers/staging/lustre/l
; Signed-off-by: Arnd Bergmann
> Signed-off-by: Oleg Drokin
Thanks for all the work to split out the smaller patches from my
larger code removal!
There is one small point about the attribution though: your split
out patches now have 'From: Oleg Drokin ' along
wtih 'Signed-off-by:
On Friday 02 October 2015 23:54:26 Rocco Folino wrote:
> This patch fixes the warning generated by sparse: "symbol
> 'nrs_policy_get_info_locked' was not
> declared. Should it be static?" by declaring the function static.
>
> Signed-off-by: Rocco Folino
&g
On Saturday 03 October 2015 06:10:12 kbuild test robot wrote:
> >> drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c:456:13: error: static
> >> declaration of 'nrs_policy_get_info_locked' follows non-static declaration
> static void nrs_policy_get_info_locked(struct ptlrpc_nrs_policy *policy
On Wednesday 14 October 2015 08:47:44 David Daney wrote:
> On 10/14/2015 07:06 AM, Sakshi Bansal wrote:
> > Fixed allignment issues and line over 80 characters
>
> Use spell checking on 'allignment'
>
> But that is not the main problem with the patch...
>
>
> You are changing things other than
On Wednesday 14 October 2015 14:04:00 David Daney wrote:
> On 10/14/2015 01:58 PM, Arnd Bergmann wrote:
> > On Wednesday 14 October 2015 08:47:44 David Daney wrote:
> >> On 10/14/2015 07:06 AM, Sakshi Bansal wrote:
> >>> Fixed allignment issues and line over 80
A recent change to wilc1000 accidentally deleted an important
variable, so we now get a build error when the SPI mode is
selected:
ERROR: "wilc_spi_dev" [drivers/staging/wilc1000/wilc1000.ko] undefined!
This partially reverts the broken commit to put the variable back.
Signed-of
intermediate Kconfig
symbol "WILC1000_DRIVER" that controls visibility of the SDIO and
SPI sub-drivers, so we can control the dependencies better.
Signed-off-by: Arnd Bergmann
Fixes: 9535ebc5e9cc ("staging/wilc1000: fix Kconfig dependencies")
diff --git a/drivers/staging/wilc10
he Kconfig file to match what other drivers do.
Signed-off-by: Arnd Bergmann
Fixes: fd2bb310ca3d ("Staging: iio: Move evgen interrupt generation to
irq_work")
---
Found on ARM randconfig tests
diff --git a/drivers/staging/iio/Kconfig b/drivers/staging/iio/Kconfig
index 6d5b38d69578.
401 - 500 of 643 matches
Mail list logo
