[PATCH 13/28] staging: rtl8723au: Remove unused ODM ability flags

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/include/odm.h | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/staging/rtl8723au/include/odm.h b/drivers/staging/rtl8723au/include/odm.h index 7d505cf..78c17f3 100644 --- a/drivers/staging

[PATCH 24/28] staging: rtl8723au: Clean up odm_RSSIMonitorCheck()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 41 +++-- 1 file changed, 21 insertions(+), 20 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/odm.c b/drivers/staging/rtl8723au/hal/odm.c index b9f09d9..bfbb1a4

[PATCH 06/28] staging: rtl8723au: ODM_BB_DYNAMIC_TXPWR isn't used for anything

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_dm.c | 3 +-- drivers/staging/rtl8723au/include/odm.h | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_dm.c b/drivers/staging/rtl8723au/hal

[PATCH 23/28] staging: rtl8723au: ODM_TXPowerTrackingCheck23a(): Remove no-op function

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 20 1 file changed, 20 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/odm.c b/drivers/staging/rtl8723au/hal/odm.c index d3d4efc..b9f09d9 100644 --- a/drivers/staging

[PATCH 26/28] staging: rtl8723au: Clean up odm_RefreshRateAdaptiveMask()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 27 +++ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/odm.c b/drivers/staging/rtl8723au/hal/odm.c index 5269c39..e4500e9 100644

[PATCH 14/28] staging: rtl8723au: Make odm_PHY_SaveAFERegisters() readable

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/odm.c b/drivers/staging/rtl8723au/hal/odm.c index 3077735..c50b8a5 100644 --- a/drivers/staging

[PATCH 18/28] staging: rtl8723au: Remove write-only variable ControlChannel

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 9 - drivers/staging/rtl8723au/include/odm.h | 1 - 2 files changed, 10 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/odm.c b/drivers/staging/rtl8723au/hal/odm.c index 11c9a36

[PATCH 17/28] staging: rtl8723au: SupportInterface is always set to USB

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/HalHWImg8723A_BB.c | 9 ++ drivers/staging/rtl8723au/hal/HalHWImg8723A_MAC.c | 3 +- drivers/staging/rtl8723au/hal/HalHWImg8723A_RF.c | 3 +- drivers/staging/rtl8723au/hal/odm.c | 4

[PATCH 21/28] staging: rtl8723au: Remove unused struct pri_cca

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/include/odm.h | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/staging/rtl8723au/include/odm.h b/drivers/staging/rtl8723au/include/odm.h index 3f93b3d..3a68774 100644 --- a/drivers/staging

[PATCH 28/28] staging: rtl8723au: odm.c: Break some lines down to 80 characters

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 184 +++- 1 file changed, 117 insertions(+), 67 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/odm.c b/drivers/staging/rtl8723au/hal/odm.c index 69072c0..8d42661

[PATCH 27/28] staging: rtl8723au: ODM_Write_DIG23A(): Cosmetic cleanups

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/odm.c b/drivers/staging/rtl8723au/hal/odm.c index e4500e9..69072c0 100644 --- a/drivers

[PATCH 00/28] staging: rtl8723au: Another round of cleanups

From: Jes Sorensen Hi, Another round of cleanups getting rid of unnecessary cruft in the rtl8723au driver. Cheers, Jes Jes Sorensen (28): staging: rtl8723au: Variable bbtchange is always false staging: rtl8723au: Avoid zero initializing variables unnecessarily staging: rtl8723au

[PATCH 15/28] staging: rtl8723au: odm_dtc(): Remove no-op function

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 7 --- drivers/staging/rtl8723au/include/odm.h | 2 -- 2 files changed, 9 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/odm.c b/drivers/staging/rtl8723au/hal/odm.c index c50b8a5

[PATCH 03/28] staging: rtl8723au: ODM_MAC_EDCA_TURBO is always set

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 3 --- drivers/staging/rtl8723au/hal/rtl8723a_dm.c | 1 - drivers/staging/rtl8723au/include/odm.h | 1 - 3 files changed, 5 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/odm.c b

[PATCH 09/28] staging: rtl8723au: ODM_BB_CCK_PD is always set

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 3 --- drivers/staging/rtl8723au/hal/rtl8723a_dm.c | 3 +-- drivers/staging/rtl8723au/include/odm.h | 1 - 3 files changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/staging

[PATCH 19/28] staging: rtl8723au: Remove unused Funai TV hack

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 8 drivers/staging/rtl8723au/hal/rtl8723a_dm.c | 1 - drivers/staging/rtl8723au/include/odm.h | 2 -- 3 files changed, 11 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/odm.c

[PATCH 07/28] staging: rtl8723au: ODM_BB_FA_CNT is always set

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 11 +-- drivers/staging/rtl8723au/hal/rtl8723a_dm.c | 3 +-- drivers/staging/rtl8723au/include/odm.h | 1 - 3 files changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers

[PATCH 10/28] staging: rtl8723au: ODM_BB_PWR_SAVE is unused

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_dm.c | 3 +-- drivers/staging/rtl8723au/include/odm.h | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_dm.c b/drivers/staging/rtl8723au/hal

[PATCH 16/28] staging: rtl8723au: Remove no-op ODM_CMNINFO_PLATFORM

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 2 -- drivers/staging/rtl8723au/hal/rtl8723a_dm.c | 1 - drivers/staging/rtl8723au/include/odm.h | 15 +++ 3 files changed, 7 insertions(+), 11 deletions(-) diff --git a/drivers

[PATCH 05/28] staging: rtl8723au: ODM_BB_DIG is always set

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 5 ++--- drivers/staging/rtl8723au/hal/rtl8723a_dm.c | 3 +-- drivers/staging/rtl8723au/include/odm.h | 1 - 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging

[PATCH 08/28] staging: rtl8723au: ODM_BB_RSSI_MONITOR is always set

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 17 + drivers/staging/rtl8723au/hal/rtl8723a_dm.c | 3 +-- drivers/staging/rtl8723au/include/odm.h | 1 - 3 files changed, 2 insertions(+), 19 deletions(-) diff --git a

[PATCH 22/28] staging: rtl8723au: Remove write only bIsCurRDLState

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 1 - drivers/staging/rtl8723au/include/odm.h | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/odm.c b/drivers/staging/rtl8723au/hal/odm.c index d8f2095..d3d4efc

[PATCH 12/28] staging: rtl8723au: ODM_RF_CALIBRATION is never set

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_dm.c | 2 +- drivers/staging/rtl8723au/include/odm.h | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_dm.c b/drivers/staging/rtl8723au/hal

[PATCH 20/28] staging: rtl8723au: Remove unused struct odm_fat_t

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/include/odm.h | 28 1 file changed, 28 deletions(-) diff --git a/drivers/staging/rtl8723au/include/odm.h b/drivers/staging/rtl8723au/include/odm.h index 3a65195..3f93b3d 100644 --- a

[PATCH 25/28] staging: rtl8723au: Clean up FindMinimumRSSI()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/odm.c b/drivers/staging/rtl8723au/hal/odm.c index bfbb1a4..5269c39 100644 --- a/drivers/staging

[PATCH 01/28] staging: rtl8723au: Variable bbtchange is always false

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/odm.c b/drivers/staging/rtl8723au/hal/odm.c index 1b2baae..2c604da 100644 --- a/drivers/staging/rtl8723au

[PATCH 11/28] staging: rtl8723au: ODM_RF_TX_PWR_TRACK is always set

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/HalDMOutSrc8723A_CE.c | 11 +-- drivers/staging/rtl8723au/hal/rtl8723a_dm.c | 3 +-- drivers/staging/rtl8723au/include/odm.h | 1 - 3 files changed, 2 insertions(+), 13 deletions

[PATCH 16/17] staging: rtl8723au: odm.c: Further reduce the use of ODM_SetBBReg()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 168 +--- 1 file changed, 119 insertions(+), 49 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/odm.c b/drivers/staging/rtl8723au/hal/odm.c index 32d0732..6e34c71

[PATCH 00/17] staging: rtl8723au: Reduce number of register write APIs

From: Jes Sorensen Hi, Another set of changes for the rtl8723au driver. This primarily focuses on reducing the number of APIs to write to the same registers. Of course having just one API is no fun if you can have three or four :) Cheers, Jes Jes Sorensen (17): staging: rtl8723au: Remove

[PATCH 01/17] staging: rtl8723au: Remove unused struct rx_hp

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/include/odm.h | 14 -- 1 file changed, 14 deletions(-) diff --git a/drivers/staging/rtl8723au/include/odm.h b/drivers/staging/rtl8723au/include/odm.h index 0d1285c..d097465 100644 --- a/drivers/staging

[PATCH 14/17] staging: rtl8723au: Get rid of ODM_Read4Byte()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 9 - drivers/staging/rtl8723au/hal/odm_interface.c | 7 --- drivers/staging/rtl8723au/include/odm_interface.h | 2 -- 3 files changed, 4 insertions(+), 14 deletions(-) diff

[PATCH 15/17] staging: rtl8723au: Eliminate ODM_GetBBReg()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 28 ++- drivers/staging/rtl8723au/hal/odm_interface.c | 11 - drivers/staging/rtl8723au/include/odm_interface.h | 1 - 3 files changed, 17 insertions(+), 23

[PATCH 06/17] staging: rtl8723au: writeOFDMPowerReg() use rtl8723au_write32()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_rf6052.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_rf6052.c b/drivers/staging/rtl8723au/hal/rtl8723a_rf6052.c index 1aad438..32c58c6

[PATCH 09/17] staging: rtl8723au: odm.c: Use rtl8723au_{read, write}32() for 32 bit register access

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 35 --- 1 file changed, 16 insertions(+), 19 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/odm.c b/drivers/staging/rtl8723au/hal/odm.c index de0fe7a..fff1190

[PATCH 12/17] staging: rtl8723au: Eliminate ODM_Write1Byte()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c| 4 ++-- drivers/staging/rtl8723au/hal/odm_RegConfig8723A.c | 10 +++--- drivers/staging/rtl8723au/hal/odm_interface.c | 7 --- drivers/staging/rtl8723au/include

[PATCH 02/17] staging: rtl8723au: Remove a number of unused entries from struct dm_odm_t

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 9 - drivers/staging/rtl8723au/include/odm.h | 28 +--- 2 files changed, 1 insertion(+), 36 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/odm.c b/drivers

[PATCH 10/17] staging: rtl8723au: odm_ConfigBB_AGC_8723A() always does 32 bit writes

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/HalHWImg8723A_BB.c | 5 ++--- drivers/staging/rtl8723au/hal/odm_RegConfig8723A.c | 14 -- drivers/staging/rtl8723au/include/odm_RegConfig8723A.h | 3 +-- 3 files changed, 7 insertions

[PATCH 17/17] staging: rtl8723au: Eliminate ODM_SetBBReg()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 33 ++- drivers/staging/rtl8723au/hal/odm_interface.c | 12 - drivers/staging/rtl8723au/include/odm_interface.h | 1 - 3 files changed, 20 insertions(+), 26

[PATCH 04/17] staging: rtl8723au: Reduce the usage of ODM_[GS]et_BBReg()

From: Jes Sorensen The vendor code has at least three different APIs for accessing registers. One more ugly than the other. This is the start to move away from ODM_[GS]et_BBReg() Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 89 +++-- 1

[PATCH 11/17] staging: rtl8723au: odm_ConfigBB_PHY_8723A() always issues 32 bit writes

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/HalHWImg8723A_BB.c | 35 -- drivers/staging/rtl8723au/hal/odm_RegConfig8723A.c | 28 +++-- .../staging/rtl8723au/include/odm_RegConfig8723A.h | 2 +- 3 files changed, 31

[PATCH 03/17] staging: rtl8723au: Remove pointless wrappers around odm_TXPowerTrackingInit()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/odm.c b/drivers/staging/rtl8723au/hal/odm.c index 3c70ca3..2739240 100644 --- a/drivers

[PATCH 08/17] staging: rtl8723au: usb_halinit.c: Use rtl8723au_{read, write}32()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/usb_halinit.c | 43 ++--- 1 file changed, 21 insertions(+), 22 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/usb_halinit.c b/drivers/staging/rtl8723au/hal/usb_halinit.c index

[PATCH 07/17] staging: rtl8723au: rtl8723a_phycfg.c: Use proper register read/write functions

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c | 21 + 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c b/drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c index

[PATCH 05/17] staging: rtl8723au: Clean up PHY_{Query, Set}BBReg() 32 bit read/writes

From: Jes Sorensen This switches pure 32 bit read/writes to use the rtl8723au_{read,write}32() functions directly. Signed-off-by: Jes Sorensen --- .../staging/rtl8723au/hal/HalDMOutSrc8723A_CE.c| 209 - 1 file changed, 116 insertions(+), 93 deletions(-) diff --git a

[PATCH 13/17] staging: rtl8723au: Remove various ODM_* register access wrappers

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm_interface.c | 53 --- drivers/staging/rtl8723au/include/odm_interface.h | 6 --- 2 files changed, 59 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/odm_interface.c b/drivers

Re: [PATCH 1/1] staging: rtl8723au: Remove unnecessary OOM message

Quentin Lambert writes: > This patch reduces the kernel size by removing error messages that duplicate > the normal OOM message. > > A simplified version of the semantic patch that finds this problem is as > follows: (http://coccinelle.lip6.fr) This patch removes useful warnings about what alloca

Re: [PATCH 1/1] staging: rtl8723au: Remove unnecessary OOM message

Julia Lawall writes: > On Fri, 6 Mar 2015, Jes Sorensen wrote: > >> Quentin Lambert writes: >> > This patch reduces the kernel size by removing error messages that >> > duplicate >> > the normal OOM message. >> > >> > A simplified ve

Re: [PATCH 1/1] staging: rtl8723au: Remove unnecessary OOM message

Joe Perches writes: > On Fri, 2015-03-06 at 11:08 -0500, Jes Sorensen wrote: >> Julia Lawall writes: >> > On Fri, 6 Mar 2015, Jes Sorensen wrote: >> >> Quentin Lambert writes: >> >> > This patch reduces the kernel size by removing error messages

Re: [PATCH 17/17] staging: rtl8723au: Eliminate ODM_SetBBReg()

Greg KH writes: > On Thu, Mar 05, 2015 at 02:24:50PM -0500, jes.soren...@redhat.com wrote: >> From: Jes Sorensen >> >> Signed-off-by: Jes Sorensen >> --- >> drivers/staging/rtl8723au/hal/odm.c | 33 ++- >> drivers/staging

Re: [PATCH] staging: rtl8723au: Fix sparse warning cast to restricted __le16

Marcus Folkesson writes: > This patch fixes the following sparse warnings: > > CHECK drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c > drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:265:37: warning: > cast to restricted __le16 > drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:267:

[PATCH 1/3] staging: rtl8723au: Fix trailing whitespace

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723au/hal/odm.c b/drivers/staging/rtl8723au/hal/odm.c index 428b2b3..ec543cf 100644 --- a/drivers/staging/rtl8723au

[PATCH 2/3] staging: rtl8723au: update_txdesc(): bagg_pkt is always false

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723au_xmit.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723au_xmit.c b/drivers/staging/rtl8723au/hal/rtl8723au_xmit.c index 1759487..6bc1297

[PATCH 3/3] staging: rtl8723au: Do not byteswap timeout twice

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c index d01ca1d..c98920e

[PATCH 0/3] staging: rtl8723au: 3 fixes

From: Jes Sorensen Hi Greg, 3 fixes for the rtl8723au staging driver - one fixes a whitespace mess I created. One is an old one I forgot to post a while ago, and the least one fixes an issue where a timeout value would get byteswapped twice which is somewhat serious. Cheers, Jes Jes Sorensen

[PATCH 0/3] staging: rtl8723au: 3 fixes

From: Jes Sorensen Hi Greg, 3 fixes for the rtl8723au staging driver - one fixes a whitespace mess I created. One is an old one I forgot to post a while ago, and the least one fixes an issue where a timeout value would get byteswapped twice which is somewhat serious. Cheers, Jes Jes Sorensen

[PATCH 1/3] staging: rtl8723au: Fix trailing whitespace

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723au/hal/odm.c b/drivers/staging/rtl8723au/hal/odm.c index 428b2b3..ec543cf 100644 --- a/drivers/staging/rtl8723au

[PATCH 3/3] staging: rtl8723au: Do not byteswap timeout twice

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c index d01ca1d..c98920e

[PATCH 2/3] staging: rtl8723au: update_txdesc(): bagg_pkt is always false

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723au_xmit.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723au_xmit.c b/drivers/staging/rtl8723au/hal/rtl8723au_xmit.c index 1759487..6bc1297

[PATCH 1/1] staging: rtl8723au: Fix mis-placed break

From: Jes Sorensen In 7c3a8f2a5ec95e2b13704562f36321e20ddfc190 I made a mistake and moved a break below a bracket, causing a situation where the for loop would always exit when it shouldn't. This patch corrects that mistake. Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au

Re: [PATCH] staging: rtl8723au: Remove uses of MAC_FMT and MAC_ARG

8 +++--- > drivers/staging/rtl8723au/os_dep/os_intfs.c | 7 +-- > 9 files changed, 101 insertions(+), 122 deletions(-) Looks good to me Acked-by: Jes Sorensen ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: rtl8723au: Update RT_TRACE macro and uses

Joe Perches writes: > Create an rt_trace function using %pV to reduce overall code size. > Update the macro uses to remove unnecessary and now harmful parentheses. > > Miscellanea around these changes: > > o Coalesce formats > o Realign arguments > o Remove commented-out RT_TRACE uses > o Spelling

Re: [PATCH] drivers: staging: rtl8723au: fix "warning: cast to restricted __le16"

Dan Carpenter writes: > This doesn't look right and it doesn't have a changelog explainly the > weirdness. > ... and the fix is as ugly as it gets! If something like this is needed, creating a __le16 *ptr at the beginnging of the function would be a lot better. Jes _

Re: [PATCH 0/2] *** r8723au: Replace semaphore lock with mutex ***

Binoy Jayan writes: > Hi, > > These are a set of patches which removes semaphores from: > > drivers/staging/rtl8723au > > These are part of a bigger effort to eliminate all semaphores > from the linux kernel. > > They build correctly (individually and as a whole). > NB: I have not tested this as

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

Arnd Bergmann writes: > Compiling the rtlwifi drivers for ARM with gcc -Wextra warns about lots of > incorrect code that results from 'char' being unsigned here, e.g. > > staging/rtl8192e/rtl8192e/r8192E_phy.c:1072:36: error: comparison is always > false due to limited range of data type [-Werror

Re: [PATCH 3/3] staging/rtl8192u: use s8 instead of char

; 3 files changed, 11 insertions(+), 11 deletions(-) Looks good to me Acked-by: Jes Sorensen ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

Arnd Bergmann writes: > On Tuesday, July 19, 2016 11:46:04 AM CEST Jes Sorensen wrote: >> > diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c >> > b/drivers/staging/rtl8192e/rtl819x_TSProc.c >> > index 2c8a526773ed..e0a2fe5e6148 100644 >> > --- a/dr

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

Arnd Bergmann writes: > On Tuesday, July 19, 2016 12:05:00 PM CEST Jes Sorensen wrote: >> Arnd Bergmann writes: >> I think that would be better, albeit not a big issue. > > Ok, and since Kalle applied the first patch to his tree, I'm now sending > a series of three

Re: [PATCH] staging: rtl8723au: hal: check BT_Active and BT_State with correct bit pattern

Colin King writes: > From: Colin Ian King > > BT_Active and BT_State are being masked with 0x00ff so it the subsequent > comparisons with 0x are therefore a buggy check. Instead, check them > against 0x00ff. > > Unfortunately I couldn't find a datasheet or hardware to see if 0xff

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

Arnd Bergmann writes: > On Wednesday, July 20, 2016 7:25:19 AM CEST Jes Sorensen wrote: >> Arnd Bergmann writes: >> Well it really all depends on how much time I have and how much others >> step up and help contribute to the code. For rtl8xxxu my plans are as >> f

Re: [PATCH 3/3] staging/rtl8192e: avoid comparing unsigned type >= 0

ion to clarify the types and simplify > the check while removing the warning. > > Signed-off-by: Arnd Bergmann > --- > drivers/staging/rtl8192e/rtl819x_Qos.h| 3 --- > drivers/staging/rtl8192e/rtl819x_TSProc.c | 5 + > 2 files changed, 5 insertions(+), 3 deletions(-) Lo

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

Stefan Lippers-Hollmann writes: > Hi > > On 2016-07-20, Arnd Bergmann wrote: >> On Wednesday, July 20, 2016 11:33:43 AM CEST Jes Sorensen wrote: >> > Arnd Bergmann writes: >> > > On Wednesday, July 20, 2016 7:25:19 AM CEST Jes Sorensen wrote: >> >

Re: [PATCH 0955/1285] Replace numeric parameter like 0444 with macro

Baole Ni writes: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the > corresponding macro, > and that using macro can improve the ro

Re: [PATCH] Staging: rtl8723au: rtw_xmit: fixed coding style issues

Shiva Kerdel writes: > Fixed some coding style issues that were detected as errors. > > Signed-off-by: Shiva Kerdel You have already been told this once by Greg. Describe what you are fixing in the commit message, and don't fix more than one type of bug per commit. Jes > --- > drivers/staging

Re: [PATCH] Staging: rtl8723au: os_intfs: fixed case statement is variable issue

Bing Sun writes: > Fixed sparse parse error: > Expected constant expression in case statement. > > Signed-off-by: Bing Sun > --- > drivers/staging/rtl8723au/os_dep/os_intfs.c | 11 +-- > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/rtl8723au/os_dep/os_

Re: [PATCH] Staging: rtl8723au: os_intfs: fixed case statement is variable issue

sunbing writes: > On Aug 11, 2016, at 23:25, Jes Sorensen wrote: > >> Bing Sun writes: >>> Fixed sparse parse error: >>> Expected constant expression in case statement. >>> >>> Signed-off-by: Bing Sun >>> --- >>> drivers/stagi

Re: [PATCH 0/5] Some cleanup patches for drivers/staging/rtl8723au/core/rtw_mlme.c

Matthias Beyer writes: > This patchset fixes some errors and warnings reported by checkpatch.pl. > > Matthias Beyer (5): > drivers: staging: rtl8723au: core: Fix checkpatch.pl errors > drivers: staging: rtl8723au: core: simplify if-break-else > drivers: staging: rtl8723au: core: Refactor poi

Re: [PATCH 0/5] Some cleanup patches for drivers/staging/rtl8723au/core/rtw_mlme.c

Joe Perches writes: > On Tue, 2016-09-06 at 12:00 -0400, Jes Sorensen wrote: > >> Nothing wrong with these patches, however I intend to post a patch to >> remove this driver soon, so it's kind of a waste of your time to spend >> too many cycles on it. > > It

[PATCH - FYI - do not apply] staging: Remove rtl8723au driver

From: Jes Sorensen Hi, I sent Greg the full version of this patch, removing the old rtl8723au driver. I didn't want to spam the list with a 2M+ patch so this is the summary version. Cheers, Jes This driver is superseded by rtl8xxxu and has been marked as scheduled for deletion sinc

Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: Remove ternary operator

On 09/12/16 09:58, Bhumika Goyal wrote: > Relational and logical operators evaluate to either true or false. > Explicit conversion is not needed so remove the ternary operator. > Done using coccinelle: > > @r@ > expression A,B; > symbol true,false; > binary operator b = {==,!=,&&,||,>=,<=,>,<}; >

Re: [PATCH] staging: squash lines for simple wrapper functions

Masahiro Yamada writes: > Remove unneeded variables and assignments. > > While we are here, clean up the following as well: > - refactor rtl8723a_get_bcn_valid() a bit > - remove unneeded casts in sii164Get{Vendor,Device}ID() > > Signed-off-by: Masahiro Yamada > --- > > drivers/staging/andro

Re: [PATCH] rtl8xxxu: Stop log spam from each successful interrupt

Joe Perches writes: > On Sat, 2016-09-17 at 12:09 -0500, Larry Finger wrote: >> As soon as debugging is turned on, the logs are filled with messages >> reporting the interrupt status. As this quantity is usually zero, this >> output is not needed. In fact, there will be a report if the status is >

Re: [PATCH] rtl8xxxu: Stop log spam from each successful interrupt

Larry Finger writes: > As soon as debugging is turned on, the logs are filled with messages > reporting the interrupt status. As this quantity is usually zero, this > output is not needed. In fact, there will be a report if the status is > not zero, thus the debug line in question could probably b

Re: [PATCH] rtl8xxxu: Stop log spam from each successful interrupt

Larry Finger writes: > On 09/17/2016 03:59 PM, Jes Sorensen wrote: >> Larry Finger writes: >>> As soon as debugging is turned on, the logs are filled with messages >>> reporting the interrupt status. As this quantity is usually zero, this >>> output is not nee

Re: [PATCH] rtl8xxxu: Stop log spam from each successful interrupt

Kalle Valo writes: > Jes Sorensen writes: > >> Joe Perches writes: >>> I think it'd be nicer to use dev_dbg for all these cases >>> and as well use some new macro that includes the test >>> >>> Something like: >>> >>&g

Re: [PATCH v2] staging: rtl8723au: Fix resource leak

Mateusz Kulikowski writes: > Firmware was not released properly if kmemdup fails. > > Addresses-Coverity-Id: 1269118 > Signed-off-by: Mateusz Kulikowski > --- > drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) A

Re: [PATCH 1/2 v3] drivers: staging: rtl8723au: Changed rssi_cmd to little-endian param

Jacob Kiefer writes: > From: Jacob Kiefer > > Changed rssi_cmd interface to accept le32 param instead of > unnecessary u8 * conversion. Updated existing calls to rssi_cmd. > This patch pushes responsibility to caller to convert to > le32. This cleans up the code quite a bit. > Also removed magic

Re: staging/rtl8723au should be removed

Larry Finger writes: > On 10/23/2015 05:44 AM, Xose Vazquez Perez wrote: >> Hi, >> >> Support for RTL8723AU devices was added to >> wireless-drivers-next.git recently: >> https://marc.info/?l=linux-wireless&m=144541406318463 >> commit: >> https://git.kernel.org/cgit/linux/kernel/git/kvalo/wireless

Re: [PATCH] staging: rtl8723au: core: rtw_wlan_util: fix misleading indentation

; Signed-off-by: Luis de Bethencourt > --- > drivers/staging/rtl8723au/core/rtw_wlan_util.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Jes Sorensen > > diff --git a/drivers/staging/rtl8723au/core/rtw_wlan_util.c > b/drivers/staging/rtl8723au/core/rtw_w

Re: [PATCH] staging: rtl8723au: fix potential leak in update_bcn_wps_ie()

Christian Engelmayer writes: > On Thu, 1 May 2014 14:22:17 +0200, Mateusz Guzik wrote: >> On Thu, May 01, 2014 at 01:57:27PM +0200, Christian Engelmayer wrote: >> > Fix a potential leak in the error path of function update_bcn_wps_ie(). >> > Make sure that allocated memory for 'pbackup_remainder_

Re: [PATCH v2] staging: rtl8723au: fix potential leak in update_bcn_wps_ie()

Christian Engelmayer writes: > Fix a potential leak in the error path of function update_bcn_wps_ie(). > Move the affected input verification to the beginning of the function so > that it may return directly without leaking already allocated memory. > Detected by Coverity - CID 1077718. > > Signed

Re: [patch] staging: rtl8723au: fix some confusing indenting

Dan Carpenter writes: > The break and the "unknown++" are at the same indent level so my static > checker complains. The if statement should be indented more. > > Signed-off-by: Dan Carpenter Urgh yes, that should be cleaned up! Acked-by: Jes Sorensen > >

Re: [PATCH v3] staging: rtl8188eu: fix potential leak in update_bcn_wps_ie()

ernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > --- > drivers/staging/rtl8188eu/core/rtw_ap.c | 8 ---- > 1 file changed, 4 insertions(+), 4 deletions(-) Acked-by: Jes Sorensen ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: randconfig build error with next-20140516, in drivers/staging/rtl8723au/core/rtw_cmd.c

Jim Davis writes: > Building with the attached random configuration file, > > drivers/staging/rtl8723au/core/rtw_cmd.c: In function ‘c2h_evt_hdl’: > drivers/staging/rtl8723au/core/rtw_cmd.c:1315:4: error: implicit declaration > of > function ‘c2h_handler_8723a’ [-Werror=implicit-function-declarat

Re: [PATCH 0/2] staging: rtl8188eu: fix Coverity defects in rtw_drv_init()

gt; > drivers/staging/rtl8188eu/os_dep/usb_intf.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Acked-by: Jes Sorensen ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: rtl8723au: rtw_sta_mgt: change rtw_alloc_stainfo23a to use gfp_t instead if int

Dan Carpenter writes: > On Sun, May 18, 2014 at 07:39:23AM +0100, Karim Raslan wrote: >> This should fix a few sparse warnings like the following: >> >> CHECK drivers/staging/rtl8723au/core/rtw_ap.c >> drivers/staging/rtl8723au/core/rtw_ap.c:1054:45: warning: incorrect >> type in argument 3 (

Re: [PATCH] staging: rtl8723au: rtw_sta_mgt: change rtw_alloc_stainfo23a to use gfp_t instead if int

Dan Carpenter writes: > On Mon, May 19, 2014 at 12:25:13PM +0200, Jes Sorensen wrote: >> Dan, >> >> Calm down, I haven't been bombarding the list, due to the sheer volume >> of commits. If you want me to spam the list, tell me where and I'll add >> th

Re: [PATCH] staging: rtl8723au: rtw_sta_mgt: change rtw_alloc_stainfo23a to use gfp_t instead if int

Dan Carpenter writes: > On Mon, May 19, 2014 at 12:49:03PM +0200, Jes Sorensen wrote: >> You should be running your tools against the staging tree automatically, >> that way you catch it before it hits the mainline tree. >> >> Just flooding mailing lists for the sake o

Re: randconfig build error with next-20140520, in drivers/staging/rtl8723au/core/rtw_cmd.c

Jim Davis writes: > Building with the attached random configuration file, > > drivers/staging/rtl8723au/core/rtw_cmd.c: In function ‘dynamic_chk_wk_hdl’: > drivers/staging/rtl8723au/core/rtw_cmd.c:1036:2: error: implicit declaration > of > function ‘rtl8723a_sreset_xmit_status_check’ > [-Werror=

[PATCH 09/74] staging: rtl8723au: Remove unused enum odm_security

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/include/odm.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/staging/rtl8723au/include/odm.h b/drivers/staging/rtl8723au/include/odm.h index 5ad0a14..183d8ff 100644 --- a/drivers/staging

[PATCH 03/74] staging: rtl8723au: Get rid of write only NetworkTypeInUse and matching enum

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_ap.c | 18 - drivers/staging/rtl8723au/core/rtw_mlme.c | 27 - drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 2 -- drivers/staging/rtl8723au/include

<    1   2   3   4   5   6   7   8   >