On Wed, Sep 02, 2020 at 06:16:27PM +0200, Antoni Przybylik wrote:
> Changed return type to bool and removed inline specifier. Also added
> static specifier.
>
> Signed-off-by: Antoni Przybylik
> ---
> drivers/staging/gdm724x/gdm_tty.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
You
On Mon, Sep 07, 2020 at 12:27:45PM +0530, Naveen Panwar wrote:
> Fixed checkpatch warnings two warnings still exits about DT
> compatible strings appers undocumented. Fixed the other codestyle
> errors, and some warnings about use of volatile and un-necessary
> out of memory errors.
>
> Signed-off
On Mon, Sep 07, 2020 at 03:05:03PM +0530, Naveen Panwar wrote:
> Fixing the codestyle related changes in the ralink-gdma driver
>
> Signed-off-by: Naveen Panwar
> ---
> drivers/staging/ralink-gdma/ralink-gdma.c | 23 ---
> 1 file changed, 12 insertions(+), 11 deletions(-)
>
On Mon, Sep 07, 2020 at 04:07:03PM +0530, Naveen Panwar wrote:
> Adding a blank line after variable declarations
Why?
>
> Signed-off-by: Naveen Panwar
> ---
> drivers/staging/ralink-gdma/ralink-gdma.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/ralink-gdma/ralink-
The following changes since commit 9123e3a74ec7b934a4a099e98af6a61c2f80bbf5:
Linux 5.9-rc1 (2020-08-16 13:04:57 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
tags/staging-5.9-rc5
for you to fetch changes up to a139ffa40f0c24
On Sat, Sep 12, 2020 at 07:47:19AM -0700, t...@redhat.com wrote:
> From: Tom Rix
>
> Reviewing sram_write_dma_safe(), there are two
> identical calls to virt_addr_valid(). The second
> call can be simplified by a comparison of variables
> set from the first call.
>
> Signed-off-by: Tom Rix
> -
On Wed, Sep 16, 2020 at 10:36:18PM +0100, Daniel Scally wrote:
> MAINTAINERS | 6 +
> drivers/media/pci/intel/ipu3/ipu3-cio2.c | 67 +++-
staging drivers should be self-contained, and not modify stuff outside
of drivers/staging/
> drivers/staging/media/ipu3/Kconfi
On Tue, Sep 22, 2020 at 07:43:36PM -0600, Shuah Khan wrote:
> counter_atomic is introduced to be used when a variable is used as
> a simple counter and doesn't guard object lifetimes. This clearly
> differentiates atomic_t usages that guard object lifetimes.
>
> counter_atomic variables will wrap
On Wed, Sep 23, 2020 at 12:04:58PM -0700, Kees Cook wrote:
> On Wed, Sep 23, 2020 at 07:10:27AM +0200, Greg KH wrote:
> > On Tue, Sep 22, 2020 at 07:43:36PM -0600, Shuah Khan wrote:
> > > counter_atomic is introduced to be used when a variable is used as
> > > a simpl
On Sat, Sep 26, 2020 at 11:39:37PM -0700, Ryan Kosta wrote:
> Signed-off-by: Ryan Kosta
> ---
> drivers/staging/nvec/nvec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
> index 360ec040774..a80996b2f5c 100644
>
On Tue, Sep 29, 2020 at 11:39:53PM -0400, Matthew Hanzelik wrote:
> Remove a duplicate word in a comment within nvec.c.
>
> Signed-off-by: Matthew Hanzelik
> ---
> Changes in v2:
> - Fix spelling mistake in commit.
> ---
> drivers/staging/nvec/nvec.c | 2 +-
> 1 file changed, 1 insertion(+), 1
The following changes since commit 856deb866d16e29bd65952e0289066f6078af773:
Linux 5.9-rc5 (2020-09-13 16:06:00 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
tags/staging-5.9-rc8
for you to fetch changes up to 52a035235ed5a1
On Sat, Oct 10, 2020 at 01:32:00AM +0100, Tabot Kevin wrote:
> This patch fixes the following:
> - Made sure alignment matched open parenthesis.
>
> Signed-off-by: Tabot Kevin
> ---
> drivers/staging/greybus/audio_module.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff
The following changes since commit 549738f15da0e5a00275977623be199fbbf7df50:
Linux 5.9-rc8 (2020-10-04 16:04:34 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
tags/staging-5.10-rc1
for you to fetch changes up to e1f13c879a7c2
On Thu, Oct 15, 2020 at 09:49:56AM -0700, Linus Torvalds wrote:
> On Thu, Oct 15, 2020 at 5:26 AM Greg KH wrote:
> >
> > Included in here are:
> > - new IIO drivers
> [...]
> > - no new drivers added or removed
>
> So which one is it?
>
&g
On Fri, Oct 16, 2020 at 01:11:11AM -0400, kiransu...@osuosl.org wrote:
> From: kiransuren
This does not match your signed-off-by line :(
>
> Fixed a coding style issue.
What issue? Always be specific.
>
> Signed-off-by: Kiran Surendran
> ---
> drivers/staging/android/ashmem.c | 2 +-
> 1
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Fri, Oct 16, 2020 at 01:38
On Tue, Oct 13, 2020 at 09:27:18PM +, Giovanni Bertao wrote:
> Remove repeated word on comment.
>
> Signed-off-by: Giovanni Bertao
> ---
> drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/drivers/staging/comedi/drivers/q
On Sat, Oct 17, 2020 at 09:09:28AM -0700, t...@redhat.com wrote:
> From: Tom Rix
>
> This is a upcoming change to clean up a new warning treewide.
> I am wondering if the change could be one mega patch (see below) or
> normal patch per file about 100 patches or somewhere half way by collecting
>
On Tue, Oct 20, 2020 at 08:08:23AM -0700, Elena Afanasova wrote:
> Replace function names with __func__ macro.
> Remove unnecessary characters in error messages.
> Reported by checkpatch.pl.
>
> Signed-off-by: Elena Afanasova
> ---
> drivers/staging/rtl8192u/ieee80211/dot11d.c | 12 ++--
On Thu, Oct 22, 2020 at 09:07:01AM +0530, Deepak R Varma wrote:
> Hello,
> I am reviewing the file: drivers/staging/greybus/audio_manager_module.c
> and have found that there are several gb_audio_module_*_show functions
> that accept "struct gb_audio_manager_module_attribute * " as a function
> par
On Fri, Oct 23, 2020 at 11:47:05AM -0700, Elena Afanasova wrote:
> Replace kmalloc + memset 0 by a call to kzalloc which zeroes memory too.
> Found with Coccinelle.
>
> Signed-off-by: Elena Afanasova
> ---
> Changes in v2:
> - correct the subject line
> - correct the commit message
>
On Fri, Oct 23, 2020 at 12:01:47PM -0700, Elena Afanasova wrote:
> Replace kmalloc + memset 0 by a call to kzalloc which zeroes memory too.
> Found with Coccinelle.
>
> Signed-off-by: Elena Afanasova
> ---
> Changes in v2:
> - correct the subject line
> - correct the commit message
>
On Mon, Oct 26, 2020 at 05:14:35PM +0500, Muhammad Usama Anjum wrote:
> Use pointer notation instead of using array notation as info_element is
> a pointer not array.
>
> Warnings from sparse:
> drivers/staging/rtl8192u/ieee80211/ieee80211.h:1013:51: warning: array of
> flexible structures
> driv
On Wed, Oct 28, 2020 at 09:28:37PM +, Manuel Palenzuela wrote:
> Fixed two cases where the if-statement coding style wasn't following the
> guidelines. (rtw_cmd.c)
>
Please properly wrap your changelog comments at 72 columns like your
editor asked you to :)
And what is with the file name in
On Thu, Oct 29, 2020 at 03:37:59PM +0530, Bhaskar Chowdhury wrote:
> Fixed two spelling in two different comments.
>
> s/defalut/default/p
>
> This is in linux-next.
No need for this line, it doesn't make any sense here, right?
___
devel mailing list
On Thu, Oct 29, 2020 at 03:37:59PM +0530, Bhaskar Chowdhury wrote:
> Fixed two spelling in two different comments.
>
> s/defalut/default/p
>
> This is in linux-next.
>
> Signed-off-by: Bhaskar Chowdhury
> ---
> drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 4 ++--
> 1 file changed, 2 insertion
On Thu, Oct 29, 2020 at 04:36:00PM +0530, Bhaskar Chowdhury wrote:
> Fixed two spelling in two different comments.
>
> s/defalut/default/p
>
> Signed-off-by: Bhaskar Chowdhury
> ---
> Greg, I have included the driver name as you suggested.
Suggested when, is this a v2 patch?
Remember, kernel
On Thu, Oct 29, 2020 at 05:37:25PM +0530, Bhaskar Chowdhury wrote:
> Fixed two spelling in two different comments.
>
> s/defalut/default/p
>
> Signed-off-by: Bhaskar Chowdhury
> ---
> drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
What c
On Sun, Nov 01, 2020 at 02:20:10AM +0200, Hassan Shahbazi wrote:
> Fix the checkpath.pl issue on fb_watterott.c. write_vmem and
> write_vmem_8bit functions are within non-atomic context and can
> safely use usleep_range.
> see Documentation/timers/timers-howto.txt
>
> Signed-off-by: Hassan Shahbaz
The following changes since commit 3650b228f83adda7e5ee532e2b90429c03f7b9ec:
Linux 5.10-rc1 (2020-10-25 15:14:11 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
tags/staging-5.10-rc2
for you to fetch changes up to 7e97e4cbf300
On Mon, Nov 02, 2020 at 04:14:03PM +0100, Christian Gromm wrote:
> This patch moves the ALSA sound driver out of the staging area and adds it
> to the stable part of the MOST driver. Modifications to the Makefiles and
> Kconfigs are done accordingly to not break the build.
>
> Signed-off-by: Chris
On Tue, Nov 03, 2020 at 01:04:02AM +0530, siddhant gupta(siddhant1223) wrote:
>
> Replace left shifting on 1 by a BIT macro to fix checkpatch warning.
>
> Signed-off-by: Siddhant Gupta
>
> ---
> drivers/staging/mt7621-dma/mtk-hsdma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
On Mon, Nov 02, 2020 at 11:17:40PM +, christian.gr...@microchip.com wrote:
> On Mon, 2020-11-02 at 16:31 +0100, Greg KH wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you
> > know the content is safe
> >
> > On Mon, Nov 02, 2020 at 04:14:
On Sat, Oct 31, 2020 at 01:22:46PM +0100, Sergio Paracuellos wrote:
> Remove this driver from staging because it has been moved
> into its properly place in the kernel.
>
> Signed-off-by: Sergio Paracuellos
> ---
> drivers/staging/Kconfig | 2 -
> drivers/staging/Makefile
On Sun, Nov 01, 2020 at 12:32:44PM +0200, Hassan Shahbazi wrote:
> On Sun, Nov 01, 2020 at 07:39:48AM +0100, Greg KH wrote:
> > On Sun, Nov 01, 2020 at 02:20:10AM +0200, Hassan Shahbazi wrote:
> > > Fix the checkpath.pl issue on fb_watterott.c. write_vmem and
> > > wr
On Mon, Oct 12, 2020 at 02:08:38AM +0100, Tabot Kevin wrote:
> This patch fixes the following:
> - Made sure alignment matched open parenthesis.
>
> Signed-off-by: Tabot Kevin
> ---
> drivers/staging/greybus/audio_module.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff
On Tue, Nov 10, 2020 at 12:53:38PM -0700, Shuah Khan wrote:
> seqnum_ops api is introduced to be used when a variable is used as
> a sequence/stat counter and doesn't guard object lifetimes. This
> clearly differentiates atomic_t usages that guard object lifetimes.
>
> seqnum32 variables wrap arou
On Fri, Nov 13, 2020 at 04:26:08PM +0100, Sergio Paracuellos wrote:
> Hi Greg,
>
> On Mon, Nov 2, 2020 at 9:25 PM Sergio Paracuellos
> wrote:
> >
> > After upgrading kernel to version 5.9.x the driver was not
> > working anymore showing the following kernel trace:
> >
> > ...
> > mt7621-pci 1e140
On Mon, Nov 09, 2020 at 09:13:47PM +0800, Zhang Qilong wrote:
> When gb_audio_apbridgea_register_cport failed, maybe:
>
> 1) gb_pm_runtime_get_sync failed, usage counter remained unchanged;
>
> 2) gb_hd_output failed, usage counter remained increased;
>
> In error state, there are two differ
On Mon, Nov 16, 2020 at 09:43:23PM +0100, Emmanouil Perselis wrote:
> On 11/15/20 9:17 AM, Greg Kroah-Hartman wrote:
> > On Sun, Nov 15, 2020 at 03:53:16PM +0100, Emmanouil Perselis wrote:
> >> This patch fixes the warning "static const char * array should
> >> probably be static const char * const
On Fri, Nov 20, 2020 at 03:37:43PM -0800, Todd Kjos wrote:
> Add a per-transaction flag to indicate that the buffer
> must be cleared when the transaction is complete to
> prevent copies of sensitive data from being preserved
> in memory.
>
> Signed-off-by: Todd Kjos
> ---
DOes this need to be b
The following changes since commit 3cea11cd5e3b00d91caf0b4730194039b45c5891:
Linux 5.10-rc2 (2020-11-01 14:43:51 -0800)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
tags/staging-5.10-rc5
for you to fetch changes up to 2dde2821b57f
On Thu, Dec 03, 2020 at 01:47:53PM +0100, Enrico Weigelt, metux IT consult
wrote:
> Remove MODULE_VERSION(), as it doesn't seem to serve any practical
> purpose. For in-tree drivers, the kernel version matters.
>
> The drivers have received lots of changes, without the module version
> (or the un
On Thu, Dec 03, 2020 at 01:47:56PM +0100, Enrico Weigelt, metux IT consult
wrote:
> Remove MODULE_VERSION(), as it doesn't seem to have much practical purpose.
> For in-kernel drivers, the kernel version matters. The driver received lots
> of changes, but version number has remained the same since
On Fri, Dec 04, 2020 at 04:00:43PM -0600, Brother Matthew De Angelis wrote:
> Fix all the brace code style warnings found by checkpatch.pl at the
> following lines:
> 748, 940, 1039, 1602, 1922, 1939.
> At line 940 add a semi-colon to specify a line that does not execute
> anything, as in Kernighan
On Sat, Dec 05, 2020 at 08:28:10AM -0600, YOUR NAME wrote:
> On Sat, Dec 05, 2020 at 09:41:16AM +0100, Greg KH wrote:
> > On Fri, Dec 04, 2020 at 04:00:43PM -0600, Brother Matthew De Angelis wrote:
> > > Fix all the brace code style warnings found by checkpatch.pl at the
>
On Sun, Dec 06, 2020 at 11:59:07PM +0800, shaojie.d...@isrc.iscas.ac.cn wrote:
> From: "shaojie.dong"
>
> Function register_netdev() can fail, so we should check it's return value
You just check it, you are not doing anything with it, which is just the
same as not checking this.
Please fix this
On Sat, Dec 05, 2020 at 09:45:17PM -0600, Ross Schmidt wrote:
> Replace unique macros and ELEMENT_ID with kernel provided ieee80211_eid
> enum.
>
> In a several cases multiple macros or constants are replaced by one
> constant.
>
> WLAN_EID_HT_CAP, _HT_CAPABILITY_IE_, and EID_HTCapability are rep
On Mon, Dec 07, 2020 at 04:40:06PM +0100, Linus Walleij wrote:
> On Mon, Dec 7, 2020 at 2:57 PM Sergio Paracuellos
> wrote:
> > On Mon, Dec 7, 2020 at 2:05 PM Linus Walleij
> > wrote:
>
> > > After this I think the driver looks good and can graduate from staging.
> > > Can you send a patch to m
On Mon, Dec 07, 2020 at 05:56:46PM +0100, Ferdinand Schober wrote:
> Enclose macros in parentheses to ensure correct casting behaviour as
> suggested by checkpatch.
checkpatch is wrong here :)
always use your brain when making changes like this, checkpatch is just
a perl script, and while it is q
On Tue, Dec 08, 2020 at 09:21:31AM +0100, Linus Walleij wrote:
> On Tue, Dec 8, 2020 at 8:55 AM Sergio Paracuellos
> wrote:
>
> > These Socs have 1-3 banks of 8-32 gpios. Rather then setting the muxing of
> > each
> > pin individually, these socs have mux groups that when set will effect 1-N
>
On Wed, Dec 09, 2020 at 11:01:24PM +0800, shaojie.d...@isrc.iscas.ac.cn wrote:
> From: "shaojie.dong"
>
> Function register_netdev() can fail, so we should check it's return value
>
> Signed-off-by: shaojie.dong
I doubt you sign your name with a '.' in it, right?
Please resend with the correc
On Thu, Dec 10, 2020 at 01:32:28AM +, Triplehx3 wrote:
> Fix a coding style issue as identified by checkpatch.pl
>
> Signed-off-by: Triplehx3
> ---
> drivers/staging/ralink-gdma/ralink-gdma.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c
On Thu, Dec 10, 2020 at 10:06:57AM +, Chris Bloomfield wrote:
> Fix a coding style issue as identified by checkpatch.pl
>
> Signed-off-by: Chris Bloomfield
> ---
> drivers/staging/ralink-gdma/ralink-gdma.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/ralink-gdma/
On Sun, Dec 13, 2020 at 01:59:33PM +0200, eli.billa...@gmail.com wrote:
> From: Eli Billauer
>
> Xillybus is a means for exchanging data between an FPGA and a Linux
> host, which helps making the task easier on both sides. The already
> existing driver resides in drivers/char/xillybus/ and it sup
On Sun, Dec 13, 2020 at 06:26:22PM +0200, Eli Billauer wrote:
> Hello Greg,
>
> There's no TODO file because it would have been empty: There is nothing to
> do, as far as I know.
>
> I submitted this to staging because I failed to push the Xillybus driver to
> non-staging back in 2013. In the end
The following changes since commit 418baf2c28f3473039f2f7377760bd8f6897ae18:
Linux 5.10-rc5 (2020-11-22 15:36:08 -0800)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
tags/staging-5.11-rc1
for you to fetch changes up to 4996b4610767
On Tue, Dec 15, 2020 at 10:37:52PM +1100, Stephen Rothwell wrote:
> Hi Greg,
>
> On Tue, 15 Dec 2020 11:17:49 +0100 Greg KH wrote:
> >
> > All have been in linux-next for a while with no reported issues.
>
> There is, however, a semantic conflict with a commit t
On Mon, Dec 21, 2020 at 09:15:57AM +, Anjandev Momi wrote:
> Fixed coding style issues
>
> Signed-off-by: Anjandev Momi
> ---
> drivers/staging/octeon-usb/octeon-hcd.c | 96 -
> 1 file changed, 46 insertions(+), 50 deletions(-)
>
Hi,
This is the friendly patch-bot
On Wed, Dec 23, 2020 at 10:11:29PM +0800, Zheng Yongjun wrote:
> Signed-off-by: Zheng Yongjun
> ---
> .../vc04_services/interface/vchiq_arm/vchiq_connected.c| 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
I can not take patches without any changelog text :(
On Wed, Dec 23, 2020 at 10:11:38PM +0800, Zheng Yongjun wrote:
> Signed-off-by: Zheng Yongjun
> ---
> drivers/staging/most/net/net.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Again, no changelog text?
And why are you not cc:ing the developers and maintainers of the code
you are
On Wed, Dec 23, 2020 at 09:22:30PM +0100, Ayoub Soussi wrote:
> Fixed coding style issue.
>
> Signed-off-by: Ayoub Soussi
> ---
> drivers/staging/ralink-gdma/ralink-gdma.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c
> b/drivers/staging/ral
On Fri, Dec 18, 2020 at 05:48:29PM -0800, Daniel West wrote:
> This patch fixes the checkpatch warning:
>
> WARNING: Possible repeated word: 'and'
>
> Signed-off-by: Daniel West
signed-off-by does not match From: line, so I can't take this :(
Please fix up and resend.
thanks,
greg k-h
__
On Sat, Dec 19, 2020 at 02:43:12PM -0800, Daniel West wrote:
> Fixed a checkpatch warning:
>
> WARNING: Block comments use * on subsequent lines
> #4595: FILE: drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:4595:
> +/
> +
On Mon, Jan 04, 2021 at 03:45:36PM +0100, Sergio Paracuellos wrote:
> Hi,
>
> On Mon, Jan 4, 2021 at 3:39 PM Linus Walleij wrote:
> >
> > On Sun, Dec 13, 2020 at 5:17 PM Sergio Paracuellos
> > wrote:
> >
> > > After this driver was moved from staging into pinctrl subsytems
> > > some reviews for
On Tue, Jan 05, 2021 at 10:05:47AM +0800, Zheng Yongjun wrote:
> mutex lock can be initialized automatically with DEFINE_MUTEX()
> rather than explicitly calling mutex_init().
>
> Signed-off-by: Zheng Yongjun
> ---
> .../vc04_services/interface/vchiq_arm/vchiq_connected.c | 6 ++
> 1 fil
On Wed, Jan 06, 2021 at 09:18:20PM +0800, Zheng Yongjun wrote:
> Use resource_size rather than a verbose computation on
> the end and start fields.
>
> Signed-off-by: Zheng Yongjun
> ---
> drivers/staging/media/rkvdec/rkvdec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --g
On Wed, Jan 06, 2021 at 09:17:37PM +0800, Zheng Yongjun wrote:
> Use resource_size rather than a verbose computation on
> the end and start fields.
>
> Signed-off-by: Zheng Yongjun
> ---
> drivers/staging/media/atomisp/pci/sh_css_params.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(
The following changes since commit 5c8fe583cce542aa0b84adc939ce85293de36e5e:
Linux 5.11-rc1 (2020-12-27 15:30:22 -0800)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
tags/staging-5.11-rc3
for you to fetch changes up to 00b8c557d096
On Fri, Jan 22, 2021 at 05:23:44PM +0800, Yang Li wrote:
> Fix below warnings reported by coccicheck:
> ./drivers/scsi/megaraid/megaraid_sas_fusion.c:3924:3-8: WARNING: NULL
> check before some freeing functions is not needed.
>
> Reported-by: Abaci Robot
> Signed-off-by: Yang Li
> ---
> driver
The following changes since commit 7c53f6b671f4aba70ff15e1b05148b10d58c2837:
Linux 5.11-rc3 (2021-01-10 14:34:50 -0800)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
tags/staging-5.11-rc5
for you to fetch changes up to a1bfb0ccf94d
On Mon, Jan 25, 2021 at 04:44:12PM +0800, Carlis wrote:
> From: "carlis.zhang_cp"
I need a "real" name here, and in the signed-off-by: area as I do not
think you sign documents with a "." and "_", right?
thanks,
greg k-h
___
devel mailing list
de...@l
On Sun, Jan 24, 2021 at 11:31:59AM -0800, Linus Torvalds wrote:
> On Sun, Jan 24, 2021 at 4:58 AM Greg KH wrote:
> >
> > David Lechner (1):
> > counter:ti-eqep: remove floor
>
> I'm not sure why that ti-eqep counter driver seems to be in your
> "
On Mon, Jan 18, 2021 at 01:32:40PM +0100, Nicolas Saenz Julienne wrote:
> Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware
> interface when unbinding the device.
>
> Signed-off-by: Nicolas Saenz Julienne
> Reviewed-by: Florian Fainelli
> ---
> drivers/staging/vc04_servic
On Wed, Jan 27, 2021 at 06:26:46PM +0800, Carlis wrote:
> From: zhangxuezhi
>
> For st7789v ic,add tearing signal detect to avoid screen tearing
>
> Signed-off-by: zhangxuezhi
> ---
> v8: delete a log line
> ---
> drivers/staging/fbtft/fb_st7789v.c | 132
>
On Wed, Jan 27, 2021 at 08:57:37PM +0800, Carlis wrote:
> From: zhangxuezhi
>
> For st7789v ic,add tearing signal detect to avoid screen tearing
I need a much better changelog description here please.
>
> Signed-off-by: zhangxuezhi
> ---
> v9: change pr_* to dev_*
> ---
What changed in all o
On Wed, Jan 27, 2021 at 09:42:52PM +0800, Carlis wrote:
> From: zhangxuezhi
>
> For st7789v ic,when we need continuous full screen refresh, it is best to
> wait for the TE signal arrive to avoid screen tearing
>
> Signed-off-by: zhangxuezhi
Please slow down and wait at least a day between patc
On Mon, Jan 18, 2021 at 02:09:51AM +0100, Johannes Czekay wrote:
> This patch cleans up all the "Lines should not end with a '('" warnings.
>
> Signed-off-by: Johannes Czekay
> Co-developed-by: Nicolai Fischer
> Signed-off-by: Nicolai Fischer
> ---
> drivers/staging/wlan-ng/cfg80211.c | 6 ++--
On Wed, Jan 27, 2021 at 10:02:29PM +0800, Carlis wrote:
> From: zhangxuezhi
>
> For st7789v ic,when we need continuous full screen refresh, it is best to
> wait for the TE signal arrive to avoid screen tearing
>
> Signed-off-by: zhangxuezhi
Again, slow down, and wait for comments before respon
On Wed, Jan 27, 2021 at 10:08:09PM +0800, carlis wrote:
> On Wed, 27 Jan 2021 14:51:55 +0100
> Greg KH wrote:
>
> > On Wed, Jan 27, 2021 at 09:42:52PM +0800, Carlis wrote:
> > > From: zhangxuezhi
> > >
> > > For st7789v ic,when we need continuous ful
On Wed, Jan 27, 2021 at 10:17:08PM +0800, carlis wrote:
> On Wed, 27 Jan 2021 15:13:05 +0100
> Greg KH wrote:
>
> > On Wed, Jan 27, 2021 at 10:08:09PM +0800, carlis wrote:
> > > On Wed, 27 Jan 2021 14:51:55 +0100
> > > Greg KH wrote:
> > >
> &
On Wed, Jan 27, 2021 at 05:49:46PM +0300, Dan Carpenter wrote:
> On Wed, Jan 27, 2021 at 03:25:20PM +0100, Greg KH wrote:
> > On Wed, Jan 27, 2021 at 10:17:08PM +0800, carlis wrote:
> > > On Wed, 27 Jan 2021 15:13:05 +0100
> > > Greg KH wrote:
> > >
> &
On Thu, Jan 28, 2021 at 08:53:55PM +0800, Carlis wrote:
> From: zhangxuezhi
>
> For st7789v ic,when we need continuous full screen refresh, it is best to
> wait for the TE signal arrive to avoid screen tearing
>
> Signed-off-by: zhangxuezhi
> ---
> v12: change dev_err to dev_err_probe and add s
On Thu, Jan 28, 2021 at 07:45:51PM +, Jonathan Cameron wrote:
> On Mon, 25 Jan 2021 15:08:17 +0100
> Greg KH wrote:
>
> > On Sun, Jan 24, 2021 at 11:31:59AM -0800, Linus Torvalds wrote:
> > > On Sun, Jan 24, 2021 at 4:58 AM Greg KH
> > > wrote:
On Fri, Jan 29, 2021 at 05:01:54PM -0300, Emmanuel Arias wrote:
> Fix coding style using __packed sentece instead of
Spelling check please?
And _why_ are you making this change, what does this do "better" than
the original?
thanks,
greg k-h
___
devel
On Sat, Jan 30, 2021 at 04:36:30PM +0530, Ahana Datta wrote:
> Fixed warning "struct file_operations should normally be const"
>
> Signed-off-by: Ahana Datta
> ---
> drivers/staging/android/ashmem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android
On Sat, Jan 30, 2021 at 06:04:18PM +0530, Ahana Datta wrote:
> Hi,
> I am sorry this was my first time. I followed instructions given here :
> https://www.youtube.com/watch?v=LLBrBBImJt4
Note, that is a 10 year old talk :)
> and recompiled the driver that I had changed.
Are you sure?
Touch the
On Wed, Feb 03, 2021 at 05:17:20PM +0530, Ayush wrote:
> - fix "multiple blank lines" issues.
> - fix a couple of parenthesis alignment issues.
> - fix no space before parenthesis issue.
> - fix no blank line after declaration.
>
> compile tested only (on next-20210202).
>
> Signed-off-by: Ayush
On Wed, Feb 03, 2021 at 03:40:06PM +, Ayush wrote:
> >
> > - Your patch did many different things all at once, making it difficult
> > to review. All Linux kernel patches need to only do one thing at a
> > time. If you need to do multiple things (such as clean up all coding
> > style issues in
On Mon, Dec 10, 2018 at 03:23:06PM +0800, yuhui zhang wrote:
> This patch fixes the following checkpatch.pl errors in the
> drivers/staging/mt7621-pci:
> ERROR: space required after that ')'.
> ERROR: space required after that '='.
>
> Signed-off-by: zhangyuhui
> ---
> drivers/staging/mt7621-pci
On Sun, Dec 09, 2018 at 11:27:42AM -0500, Yangtao Li wrote:
> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
>
> Signed-off-by: Yangtao Li
> ---
> drivers/staging/fwserial/fwserial.c | 32 +++
> drivers/staging/greybus/loopback.c| 16 ++
> dri
On Thu, Dec 13, 2018 at 02:58:00PM +0300, Dan Carpenter wrote:
> On Wed, Dec 12, 2018 at 01:15:31PM +0100, Christian Gromm wrote:
> > This patch updates driver_usage.txt file to reflect the latest changes
> > that this patch set introduces.
> >
> > Signed-off-by: Christian Gromm
> > ---
> > driv
On Thu, Dec 13, 2018 at 04:32:25PM +, christian.gr...@microchip.com wrote:
> On Do, 2018-12-13 at 13:32 +0100, Greg KH wrote:
> > On Thu, Dec 13, 2018 at 02:58:00PM +0300, Dan Carpenter wrote:
> > >
> > > On Wed, Dec 12, 2018 at 01:15:31PM +0100, Christian Gromm w
On Fri, Dec 14, 2018 at 09:33:50AM +, christian.gr...@microchip.com wrote:
> On Fr, 2018-12-14 at 12:10 +0300, Dan Carpenter wrote:
> > On Fri, Dec 14, 2018 at 09:06:01AM +, Christian.Gromm@microchip.c
> > om wrote:
> > >
> > > Message received. Anyway, I would like to resent the current
>
On Sun, Dec 16, 2018 at 08:57:43AM -0800, Amir Mahdi Ghorbanian wrote:
> @@ -626,7 +628,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
> break;
> case 2: /* first byte after command */
> if (status == (I2C_SL_IRQ | RNW | RCVD)) {
> -
On Sun, Dec 16, 2018 at 08:57:25AM -0800, Amir Mahdi Ghorbanian wrote:
> Fixed a coding style issue.
>
> Signed-off-by: Amir Mahdi Ghorbanian
> ---
> drivers/staging/comedi/drivers/cb_pcidas.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
You already sent this patch, right?
What chan
On Thu, Dec 13, 2018 at 08:53:17AM -0800, Amir Mahdi Ghorbanian wrote:
> From: Amir Mahdi Ghorbanian
>
> Fixed a coding style issue.
>
> Signed-off-by: Amir Mahdi Ghorbanian
> ---
> drivers/staging/comedi/drivers/8255.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/
On Sat, Dec 15, 2018 at 05:46:08PM +0100, Michael Straube wrote:
> Replace tabs with spaces and/or remove spaces in declarations.
> Remove unused/commented declarations, remove unnecessary comment,
> remove blank lines between declarations and add missing lines after
> declarations. Also clears som
On Sat, Dec 15, 2018 at 05:46:11PM +0100, Michael Straube wrote:
> Covert unsigned char arrays to u8 and make them static and/or const
> where possible.
You are also moving things around here from different .h files in
different places. Always say exactly what you are doing.
And this too needs t
301 - 400 of 4990 matches
Mail list logo
