On Sun, Oct 06, 2019 at 05:34:20PM -0300, Gabriela Bittencourt wrote:
> Cleans up warnings of "Block comments should align the * on each line"
>
> Signed-off-by: Gabriela Bittencourt
> ---
> drivers/staging/rtl8712/recv_linux.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> dif
On Sun, Oct 06, 2019 at 04:10:20PM -0300, Gabriela Bittencourt wrote:
> Cleans up CHECKs of "Alignment should match open parenthesis"
>
> Signed-off-by: Gabriela Bittencourt
> ---
> drivers/staging/vt6656/rxtx.c | 63 +++
> 1 file changed, 41 insertions(+), 22 del
On Sun, Oct 06, 2019 at 07:20:15PM -0300, Gabriela Bittencourt wrote:
> Cleans up checks of: "Alignment should match open parenthesis"
>
> Signed-off-by: Gabriela Bittencourt
> ---
> drivers/staging/rtl8712/osdep_service.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
You sent 2 diffe
On Sun, Oct 06, 2019 at 05:09:55PM +0800, zhengbin wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/staging/rtl8723bs/core/rtw_xmit.c: In function update_attrib:
> drivers/staging/rtl8723bs/core/rtw_xmit.c:680:7: warning: variable i set but
> not used [-Wunused-but-set-variable
On Tue, Oct 08, 2019 at 09:25:03AM +0800, zhengbin wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/staging/rtl8723bs/core/rtw_xmit.c: In function update_attrib:
> drivers/staging/rtl8723bs/core/rtw_xmit.c:680:7: warning: variable i set but
> not used [-Wunused-but-set-variable
On Tue, Oct 08, 2019 at 01:55:01PM +0100, Ian Abbott wrote:
> On 08/10/2019 08:41, zhengbin wrote:
> > Fixes gcc '-Wunused-but-set-variable' warning:
> >
> > drivers/staging/comedi/drivers/dt2814.c: In function dt2814_interrupt:
> > drivers/staging/comedi/drivers/dt2814.c:193:6: warning: variable
On Tue, Oct 08, 2019 at 01:56:49PM +0100, Ian Abbott wrote:
> On 08/10/2019 08:41, zhengbin wrote:
> > Fixes gcc '-Wunused-but-set-variable' warning:
> >
> > drivers/staging/comedi/drivers/dt2815.c: In function dt2815_ao_insn:
> > drivers/staging/comedi/drivers/dt2815.c:91:19: warning: variable hi
On Tue, Oct 08, 2019 at 08:50:39PM -0700, Chandra Annamaneni wrote:
> Fixed alignment and style issues raised by checkpatch.pl
Why is this padded?
Also, you need to break this up into "one logical change per patch",
you can't "fix all style issues" at once, sorry.
Please fix this up and se
On Wed, Oct 09, 2019 at 12:12:30PM +0200, Alexander Gordeev wrote:
> +static int setup_dma_descs(struct dma_desc *dma_descs,
> +struct avalon_dma_desc *desc)
> +{
> + struct scatterlist *sg_stop;
> + unsigned int sg_set;
> + int ret;
> +
> + ret = setup_descs
On Wed, Oct 09, 2019 at 12:12:31PM +0200, Alexander Gordeev wrote:
> +config AVALON_TEST_TARGET_BASE
> + hex "Target device base address"
> + default "0x7000"
> +
> +config AVALON_TEST_TARGET_SIZE
> + hex "Target device memory size"
> + default "0x1000"
Don't put stuff like
On Wed, Oct 09, 2019 at 08:08:57PM -0700, Chandra Annamaneni wrote:
> Resoved: "WARNING: line over 80 characters" from checkpatch.pl
>
> Signed-off-by: Chandra Annamaneni
> ---
> drivers/staging/kpc2000/kpc2000_spi.c | 20 ++--
> 1 file changed, 10 insertions(+), 10 deletions(-)
On Thu, Oct 10, 2019 at 07:49:05AM +0300, Wambui Karuga wrote:
> Remove most comparisons to NULL in conditionals in
> drivers/staging/rtl8723bs/core/rtw_mlme.c
> Issues reported by checkpatch.pl as:
> CHECK: Comparison to NULL could be written
>
> Signed-off-by: Wambui Karuga
> ---
> drivers/sta
On Thu, Oct 10, 2019 at 10:51:51PM -0700, Chandra Annamaneni wrote:
> Resoved: "WARNING: line over 80 characters" from checkpatch.pl
Please put "staging:" in your subject line, makes it easier to sort and
handle. It should look something like:
staging: kpc2000_spi: fix line length issues
On Thu, Oct 10, 2019 at 10:51:52PM -0700, Chandra Annamaneni wrote:
> Resolved: "CHECK: Please use a blank line after.." from checkpatch.pl
>
> Signed-off-by: Chandra Annamaneni
Please fix the subject lines for all of these patches and resend.
Also, this is a second set of patches, right? What
On Fri, Oct 11, 2019 at 09:02:37AM +0300, Wambui Karuga wrote:
> This patchset removes various typedef declarations of new data types
> in drivers/staging/octeon/octeon-stubs.h.
> The series also changes their old uses with the new declaration
> format.
The subject line of this email seems to be l
On Fri, Oct 11, 2019 at 09:02:39AM +0300, Wambui Karuga wrote:
> -typedef union {
> +union cvmx_helper_link_info_t {
I agree with Julia, all of the "_t" needs to be dropped as that is
pointless. It's a holdover from the original name where "_t" was trying
to say that this is a typedef. Gotta lov
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Fri, Oct 11, 2019 at 02:
On Fri, Oct 11, 2019 at 01:54:04PM +0300, Dan Carpenter wrote:
> On Thu, Oct 10, 2019 at 04:15:29PM +0300, Wambui Karuga wrote:
> > psetauthparm = rtw_zmalloc(sizeof(struct setauth_parm));
> > - if (psetauthparm == NULL) {
> > - kfree(pcmd);
> > + if (!psetauthparm) {
> > +
On Fri, Oct 11, 2019 at 02:07:17PM +0200, Greg KH wrote:
> On Fri, Oct 11, 2019 at 01:54:04PM +0300, Dan Carpenter wrote:
> > On Thu, Oct 10, 2019 at 04:15:29PM +0300, Wambui Karuga wrote:
> > > psetauthparm = rtw_zmalloc(sizeof(struct setauth_parm));
> > >
The following changes since commit 54ecb8f7028c5eb3d740bb82b0f1d90f2df63c5c:
Linux 5.4-rc1 (2019-09-30 10:35:40 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
tags/staging-5.4-rc3
for you to fetch changes up to 3f3d31622a2c18
On Fri, Oct 18, 2019 at 12:09:48AM -0700, Chandra Annamaneni wrote:
> Resolved: ERROR: else should follow close brace '}'
>
> Signed-off-by: Chandra Annamaneni
> ---
> Previous versions of these patches were not split into different
> patches, did not have different patch numbers and did not hav
On Wed, Oct 16, 2019 at 12:09:22AM +0100, Jules Irenge wrote:
> Add space betwen operator to fix check warning.
> Issue detected by checkpatch tool.
>
> Signed-off-by: Jules Irenge
> ---
> drivers/staging/vc04_services/interface/vchi/vchi_cfg.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 dele
On Fri, Oct 25, 2019 at 12:29:38AM +0300, Samuil Ivanov wrote:
> In terms of namespace, the driver uses either qlge_, ql_ (used by
> other qlogic drivers, with clashes, ex: ql_sem_spinlock) or nothing (with
> clashes, ex: struct ob_mac_iocb_req). Rename everything to use the "qlge_"
> prefix.
>
>
The following changes since commit 4f5cafb5cb8471e54afdc9054d973535614f7675:
Linux 5.4-rc3 (2019-10-13 16:37:36 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
tags/staging-5.4-rc5
for you to fetch changes up to 153c5d8191c261
On Mon, Oct 28, 2019 at 08:21:08AM -0700, Davidlohr Bueso wrote:
> On Mon, 28 Oct 2019, Stefan Wahren wrote:
>
> > Hi Davidlohr,
> >
> > Am 27.10.19 um 23:15 schrieb Davidlohr Bueso:
> > > There seems no need to be using a semaphore, or a sleeping lock
> > > in the first place: critical region is
On Mon, Oct 28, 2019 at 08:53:54AM -0700, Davidlohr Bueso wrote:
> Cc de...@driverdev.osuosl.org
>
> On Sun, 27 Oct 2019, Bueso wrote:
>
> > There seems no need to be using a semaphore, or a sleeping lock
> > in the first place: critical region is extremely short, does not
> > call into any block
On Mon, Oct 28, 2019 at 09:35:37AM -0700, Davidlohr Bueso wrote:
> On Mon, 28 Oct 2019, Greg KH wrote:
> > This is obviously not in a format I can apply it in :(
>
> What are you talking about? I sent you the original patch,
> then Cc'ed the drivers mailing list. So you s
On Tue, Oct 29, 2019 at 12:59:25AM +0200, Samuil Ivanov wrote:
> >From the TODO:
> - apex_get_status() should actually check status
>
> The function now checkes the status of the driver
>
> Signed-off-by: Samuil Ivanov
> ---
> drivers/staging/gasket/apex_driver.c | 3 +++
> 1 file changed, 3 in
On Tue, Oct 29, 2019 at 11:55:15AM -0300, Gabriela Bittencourt wrote:
> Cleans up checks of "Avoid CamelCase" in file ms.h and ms.c
>
> Signed-off-by: Gabriela Bittencourt
The subject line seems odd, what does "in files ms" mean?
Same for other patches in this series, please clean that up to ma
On Wed, Oct 30, 2019 at 02:03:28AM +0100, Roi Martin wrote:
> Replace expressions of the form:
> kmalloc(count * size, GFP_KERNEL);
> With:
> kmalloc_array(count, size, GFP_KERNEL);
>
> Signed-off-by: Roi Martin
> ---
> drivers/staging/exfat/exfat_core.c | 8
> 1 file change
On Fri, Nov 01, 2019 at 06:21:51PM +0100, Christophe JAILLET wrote:
> The current code is a no-op, because all it can do is 'dev_kfree_skb(NULL)'
> Revert the test to free skb, if not NULL.
>
> Signed-off-by: Christophe JAILLET
> ---
> This patch is purely speculative.
>
> The 'if (...)' could
On Fri, Nov 01, 2019 at 11:29:49AM -0700, Davidlohr Bueso wrote:
> There is no need to be using a semaphore, or a sleeping lock
> in the first place: critical region is extremely short, does not
> call into any blocking calls and furthermore lock and unlocking
> operations occur in the same context
On Sat, Nov 02, 2019 at 07:59:06PM -0500, rama wrote:
> ---
> drivers/staging/fbtft/fb_agm1264k-fl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually
On Sun, Nov 03, 2019 at 09:40:03AM -0600, Rama Kumar wrote:
>
> Hi,
>
> Changed udelay() to usleep_range() based on the document in the path,
> "Documentation/timers/timers-howto.rst". It was suggested to use
> usleep_range() function for sleeping duration between 10us - 20 ms. original
> code
On Mon, Nov 04, 2019 at 07:22:20PM +0800, Jack Ping CHNG wrote:
> This driver enables the Intel's LGM SoC GSWIP block.
> GSWIP is a core module tailored for L2/L3/L4+ data plane and QoS functions.
> It allows CPUs and other accelerators connected to the SoC datapath
> to enqueue and dequeue packets
On Mon, Nov 04, 2019 at 04:33:31PM +, Jules Irenge wrote:
> Rewrite macro function with the GNU extension typeof
> to remove a possible side-effects of MACRO argument reuse "x".
> - Problem could rise if arguments have different types
> and different use though.
You can not just get away with
On Mon, Nov 04, 2019 at 04:44:00PM +, Jules Irenge wrote:
> Rewrite macro function with GNU extension __auto_type
> to remove issue detected by checkpatch tool.
> CHECK: MACRO argument reuse - possible side-effects?
>
> Signed-off-by: Jules Irenge
> ---
> drivers/staging/rts5208/rtsx_chip.h
On Mon, Nov 04, 2019 at 05:03:04PM +, Ian Abbott wrote:
> On 04/11/2019 16:33, Jules Irenge wrote:
> > Rewrite macro function with the GNU extension typeof
> > to remove a possible side-effects of MACRO argument reuse "x".
> > - Problem could rise if arguments have different types
> > and dif
On Tue, Nov 05, 2019 at 10:36:59PM +0800, Chen Wandun wrote:
> From: Chenwandun
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/staging/hp/hp100.c: In function hp100_start_xmit:
> drivers/staging/hp/hp100.c:1629:10: warning: variable val set but not used
> [-Wunused-but-set-varia
On Thu, Nov 07, 2019 at 05:35:21PM +1000, g...@kernel.org wrote:
> From: Greg Ungerer
>
> Add a driver to support the NAND flash controller of the MediaTek MT7621
> System-on-Chip device. (This one is the MIPS based parts from Mediatek).
>
> This code is a re-working of the earlier patches for t
On Wed, Nov 06, 2019 at 06:08:21PM +, Valery Ivanov wrote:
> This patch fix the function signature for
> trace_gasket_ioctl_page_table_data
> to avoid the checkpatch.pl warning:
>
> CHECK: Lines should not end with a '('
Why the huge indentation?
THat's not ok, ple
On Wed, Nov 06, 2019 at 11:12:09AM -0800, Joe Perches wrote:
> On Wed, 2019-11-06 at 18:08 +, Valery Ivanov wrote:
> > This patch fix the function signature for
> > trace_gasket_ioctl_page_table_data
> > to avoid the checkpatch.pl warning:
> >
> > CHECK: Lines should not e
On Fri, Nov 08, 2019 at 11:38:37PM +, Jules Irenge wrote:
> Add gcc extension __force and __le32 cast to fix warning issued by Sparse
> tool."warning: cast to restricted __le32"
Can you wrap your lines properly please?
>
> Signed-off-by: Jules Irenge
> ---
> drivers/staging/wfx/debug.c |
The following changes since commit d6d5df1db6e9d7f8f76d2911707f7d5877251b02:
Linux 5.4-rc5 (2019-10-27 13:19:19 -0400)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
tags/staging-5.4-rc7
for you to fetch changes up to e39fcaef7ed993
On Mon, Nov 11, 2019 at 01:30:55PM +, Jules Irenge wrote:
> Replace u32 by __le32 to fix warning of cast from restricted __le32.
> Issue detected by sparse tool.
>
> Signed-off-by: Jules Irenge
> ---
> v1 uses casting to fix the warnings
> v2 replace the declaration type of the variables
>
>
On Mon, Nov 11, 2019 at 01:30:54PM +, Jules Irenge wrote:
> Wrap characters to fix line of over 80 characters.
> Issue detected by Checkpatch tool
You did other things in here as well:
> {
> - struct ieee80211_hdr *frame = (struct ieee80211_hdr *) skb->data;
> + struct ieee80211_hdr
On Mon, Nov 11, 2019 at 10:34:40PM -0800, Christoph Hellwig wrote:
> On Sun, Nov 10, 2019 at 04:43:03PM +0100, Greg KH wrote:
> > The staging driver addition is the vboxsf filesystem, which is the
> > VirtualBox guest shared folder code. Hans has been trying to get
> > fi
On Mon, Nov 11, 2019 at 12:14:23PM -0500, Marcelo Diop-Gonzalez wrote:
> This allows the removal of the struct rpi_firmware* member
> from struct vchiq_drvdata.
>
> Signed-off-by: Marcelo Diop-Gonzalez
> ---
> .../interface/vchiq_arm/vchiq_2835_arm.c | 14 +-
> .../vc04_ser
On Tue, Nov 12, 2019 at 06:29:55PM -0500, Marcelo Diop-Gonzalez wrote:
> On Tue, Nov 12, 2019 at 6:09 PM Greg KH wrote:
> >
> > On Mon, Nov 11, 2019 at 12:14:23PM -0500, Marcelo Diop-Gonzalez wrote:
> > > This allows the removal of the struct rpi_firmware* member
> &g
On Mon, Nov 18, 2019 at 11:35:25AM +0100, Daniel Vetter wrote:
> There's no callers in-tree anymore.
>
> For merging probably best to stuff this into drm-misc, since that's
> where the dma-buf heaps will land too. And the resulting conflict
> hopefully ensures that dma-buf heaps wont have a new ->
On Tue, Nov 04, 2014 at 09:48:33AM +0100, Tobias Klauser wrote:
> On 2014-11-03 at 21:42:52 +0100, Stephanie Wallick
> wrote:
> > This is where we handle media specific packets and transport. The MS driver
> > interfaces with a media agnostic (MA) driver via a series of transfer pairs.
> > Transf
On Tue, Nov 04, 2014 at 09:55:19AM -0800, sostalle wrote:
> >On Mon, Nov 03, 2014 at 01:24:04PM -0800, Greg KH wrote:
> >>On Mon, Nov 03, 2014 at 12:42:57PM -0800, Stephanie Wallick wrote:
> >> --- /dev/null
> >> +++ b/drivers/staging/mausb/TODO
On Wed, Nov 05, 2014 at 05:05:03PM +0530, Sanjeev Sharma wrote:
> This is a patch to the rtw_cmd.c file that fixes
> Error reported by checkpatch.
What error are you "fixing"? Please be specific.
thanks,
greg k-h
___
devel mailing list
de...@linuxdriv
On Tue, Nov 04, 2014 at 11:25:14AM -0500, Benjamin Romer wrote:
> Add a comment to the charqueue's spinlock to explain that it is a lock for the
> structure.
>
> Signed-off-by: Benjamin Romer
> ---
> drivers/staging/unisys/visorutil/charqueue.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletio
On Wed, Nov 05, 2014 at 12:47:49PM -0500, Benjamin Romer wrote:
> Delete the following unused types, and unused function prototypes:
>
> VISORCHIPSET_SWITCH_INFO
> VISORCHIPSET_EXTERNALPORT_INFO
> VISORCHIPSET_INTERNALPORT_INFO
> visorchipset_get_switch_info()
> visorchipset_get_externalport_info(
On Wed, Nov 05, 2014 at 12:14:33PM -0800, sostalle wrote:
> On Mon, Nov 03, 2014 at 04:13:55PM -0800, Greg KH wrote:
> > On Mon, Nov 03, 2014 at 04:04:42PM -0800, steph wrote:
> > > On Mon, Nov 03, 2014 at 01:21:39PM -0800, Greg KH wrote:
> > > > On Mon, Nov 03, 2014
On Wed, Nov 05, 2014 at 04:04:32PM -0500, Ken Depro wrote:
> From: Ken Depro
>
> This patch removes unneeded spaces after casts within the virthba.c
> file. The checkpatch script was run after these changes, and no
> "remove spaces after casts" checks were generated.
>
> Later patches will fix
Please specify the "error" in the subject in some way.
On Thu, Nov 06, 2014 at 11:46:13AM +0530, Sanjeev Sharma wrote:
> This is a patch to the rtw_cmd.c file that fixes following
> error.
>
> ERROR: spaces required around that '>' (ctx:WxV)
> ERROR: that open brace { should be on the previous li
On Thu, Nov 06, 2014 at 12:06:36PM +0530, Sanjeev Sharma wrote:
> This is a patch to the rtw_cmd.c file that fixes following
> Warning by introducing temporary structure.
>
> WARNING: line over 80 characters
>
> Signed-off-by: Sanjeev Sharma
> ---
> drivers/staging/rtl8723au/core/rtw_cmd.c | 12
On Thu, Nov 06, 2014 at 10:33:28AM -0500, Ken Depro wrote:
> From: Ken Depro
>
> This patch removes unneeded spaces after casts within the virthba.c
> file. The checkpatch script was run after these changes, and no
> "remove spaces after casts" checks were generated.
>
> Later patches will fix
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Thu, Nov 06, 2014 at 10:22:30AM -0600, Depro, Kenneth J wrote:
> Greg,
>
> When I executed the format-patch command, it added the conflict lines below.
> There was indeed a conflict in this file
On Thu, Nov 06, 2014 at 12:53:32PM -0600, Ken Cox wrote:
> From: Benjamin Romer
>
> This patch adds the visorclientbus driver to the Unisys s-Par driver set. This
> driver is responsible for helping manage virtual devices like keyboards, mice,
> serial ports, displays, and any customized drivers
On Mon, Nov 03, 2014 at 07:52:38PM +0100, Konrad Zapalowicz wrote:
> This commit adds the Digi Classic board implementation to the
> staging/jsm driver.
>
> The code here is taken from the staging/dgnc driver and modified to
> match the serial/jsm state. This work is mostly based on the changes
>
On Thu, Nov 06, 2014 at 01:17:56PM -0600, Ken Cox wrote:
> >There are also other checkpatch errors in this patch, which makes me not
> >want to take it at all, as you would now just be required to send more
> >fixes for the file. So why not fix things up right the first time?
> The only checkpatch
On Fri, Nov 07, 2014 at 12:05:34AM +0100, Konrad Zapalowicz wrote:
> This commit removes the staging/dgnc driver in favor of the serial/jsm
> driver.
>
> This is because the serial/jsm driver now supports all of the hardware
> that has been supported by the staging/dgnc plus it offers better
> ove
On Fri, Nov 07, 2014 at 12:36:23AM +0100, Konrad Zapalowicz wrote:
> On 11/06, Greg KH wrote:
> > On Fri, Nov 07, 2014 at 12:05:34AM +0100, Konrad Zapalowicz wrote:
> > > This commit removes the staging/dgnc driver in favor of the serial/jsm
> > > driver.
> > &g
On Fri, Nov 07, 2014 at 12:51:34PM -0500, Ken Depro wrote:
>
> Signed-off-by: Ken Depro
Your Subject: is a bit long...
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Fri, Nov 07, 2014 at 12:58:24PM -0500, Ken Depro wrote:
> While fixing the CamelCase checks for the functions in the chanstub
> source and header files, I discovered they are no longer being used.
> This patch removes the two chanstub files, and deletes the #include
> of these files from uis
On Tue, Oct 21, 2014 at 04:46:58PM +0200, Matej Mužila wrote:
> From: Matej Mužila
>
> Check if cpmsg->size is in limits of DATA_FRAGMENT
>
> Signed-off-by: Matej Mužila
> ---
>
> If corrupted data are read from /dev/vmbus/hv_fcopy, pwrite can
> read from memory outside of the buffer (defined
On Sat, Nov 08, 2014 at 06:39:06PM +0200, sharon wrote:
> Fix coding style warning.
What coding style warning? Be specific please.
And your subject:, you aren't saying where in the kernel you are fixing
anything, look at other patches for this file in git, what did the
subject look like for them
The following changes since commit 0df1f2487d2f0d04703f142813d53615d62a1da4:
Linux 3.18-rc3 (2014-11-02 15:01:51 -0800)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/
tags/staging-3.18-rc4
for you to fetch changes up to bce20b23966
On Mon, Nov 10, 2014 at 06:09:32PM -0800, Stephanie Wallick wrote:
> +static int mausb_bus_probe(struct device *dev)
> +{
> + return mausb_probe(dev);
> +}
> +
> +static int mausb_bus_remove(struct device *dev)
> +{
> + return mausb_remove(dev);
> +}
Wrapper functions that just call anothe
On Mon, Nov 10, 2014 at 06:09:36PM -0800, Stephanie Wallick wrote:
> +static int ma_open;
Why do you need this variable?
> +/**
> + * This function is used to open the device file in order to read/write
> + * from/to it.
> + *
> + * @inode: Struct with various information that is passed in when
On Mon, Nov 10, 2014 at 06:09:41PM -0800, Stephanie Wallick wrote:
> Signed-off-by: Sean O. Stalley
> Signed-off-by: Stephanie Wallick
No changelog entry?
> ---
> MAINTAINERS| 7 +++
> drivers/staging/Kconfig| 2 ++
> drivers/staging/Makefile
On Mon, Nov 10, 2014 at 06:09:34PM -0800, Stephanie Wallick wrote:
> +/**
> + * Returns the number of urbs currently in the MA USB HCD. Will return 0 if
> the
> + * MA USB HCD is empty or a negative errno if an error occurs.
How can this function return a negative number? I don't see that
codepa
On Tue, Nov 11, 2014 at 02:42:22PM -0800, Sean O. Stalley wrote:
> On Tue, Nov 11, 2014 at 01:38:21PM +0900, Greg KH wrote:
> > On Mon, Nov 10, 2014 at 06:09:34PM -0800, Stephanie Wallick wrote:
> > Intel has a whole group of very experienced Linux kernel developers who
> > wi
On Sat, Nov 15, 2014 at 09:59:34PM +0100, Pavel Machek wrote:
> On Sat 2014-11-15 21:12:18, Konrad Zapalowicz wrote:
> > On 11/15, Christian Resell wrote:
> > > Simple style fix (checkpatch.pl: "space prohibited before that ','").
> > > For the eudyptula challenge (http://eudyptula-challenge.org/).
On Mon, Nov 17, 2014 at 11:11:36AM -0800, Thomas Wood wrote:
> Fixed Subject line containing the entire patch description.
> >88<
Ick, what is that here? Please put that below the --- line, otherwise I
have to hand-edit t
On Mon, Nov 17, 2014 at 02:46:35PM -0500, Jeffrey Brown wrote:
> From: Jeff
This doesn't match your signed-off-by: line, nor your From: line of your
email above. Why even have this line when it isn't needed, and wrong?
greg k-h
___
devel mailing list
On Tue, Nov 18, 2014 at 01:45:41AM +, Tobenna P. Igwe wrote:
> This patch fixes the following sparse warning:
>
> drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c:343:36: warning:
> cast to restricted __le16
>
> by using the le16_to_cpus function.
>
> Signed-off-by: Tobenna P. Igwe
> ---
On Tue, Nov 18, 2014 at 02:51:45AM +, Tobenna Peter, Igwe wrote:
> On Mon, Nov 17, 2014 at 05:59:47PM -0800, Greg KH wrote:
> > On Tue, Nov 18, 2014 at 01:45:41AM +, Tobenna P. Igwe wrote:
> > > This patch fixes the following sparse warning:
> > >
> >
On Mon, Nov 17, 2014 at 04:23:08PM -0800, Juston wrote:
> On Tue, 2014-11-18 at 01:46 +0300, Dan Carpenter wrote:
> > On Mon, Nov 17, 2014 at 02:23:48PM -0800, Juston Li wrote:
> > > FMODE_EXEC is type fmode_t but is used in operations
> > > with integers which leads to sparse warnings:
> > > drive
On Fri, Nov 21, 2014 at 05:11:27AM +0530, Anjana Sasindran wrote:
> This patch fixes the checkpatch.pl error:
>
> ERROR: trailing whitespace
>
> Signed-off-by: Anjana Sasindran
> ---
> arch/arm/boot/dts/include/dt-bindings | 1 -
> arch/metag/boot/dts/include/dt-bindings | 1 -
> arch/mips/bo
On Fri, Nov 21, 2014 at 10:31:57AM +0100, Abel Moyo wrote:
> Replaced printk with pr_debug in dprintk
>
> Signed-off-by: Abel Moyo
> ---
> drivers/staging/media/lirc/lirc_serial.c | 2 +-
Please use scripts/get_maintainer.pl to determine the correct person to
send this patch to, it's not me, sor
On Fri, Nov 21, 2014 at 05:37:04AM +0530, Anjana Sasindran wrote:
> This patch fixes the checkpatch.pl error:
>
> ERROR: trailing whitespace
>
> Signed-off-by: Anjana Sasindran
> ---
> drivers/staging/skein/skein_generic.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/st
On Sat, Nov 22, 2014 at 11:34:29AM +0530, Anjana Sasindran wrote:
> This patch fixes the checkpatch.pl error:
>
> ERROR: trailing whitespace
>
> Signed-off-by: Anjana Sasindran
> ---
> drivers/staging/skein/skein_generic.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/st
On Sat, Nov 22, 2014 at 01:11:59PM +0530, Anjana Sasindran wrote:
> This patch fixes the checkpatch.pl error:
>
> ERROR: trailing whitespace
>
> Signed-off-by: Anjana Sasindran
> ---
> drivers/staging/skein/skein_generic.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drive
On Tue, Nov 11, 2014 at 12:15:28AM -0500, Adrian Nicoara wrote:
> All the changes are against variables/functions that are only accessed from
> within the same file. If the scope needs to change later on, the static
> keyword
> can be removed.
>
> Build tested.
>
> Signed-off-by: Adrian Nicoara
On Sun, Nov 23, 2014 at 03:26:54PM +0530, Lekshmi wrote:
> The following chaeckpatch warning was fixed:
> WARNING: line over 80 characters
>
> Signed-off-by: Lekshmi
I need a "full and real" name here in order to be able to accept any
patch.
___
devel
On Tue, Nov 25, 2014 at 11:00:35PM +0530, icyflame wrote:
> Changing the following:
>
> Adapater -> Adapter
> STATUS_SUCESS -> STATUS_SUCCESS
>
> Signed-off by: Siddharth Kannan
> ---
> drivers/staging/bcm/nvm.c | 26 +-
> 1 file changed, 13 insertions(+), 13 deletions
On Tue, Nov 11, 2014 at 03:28:57PM +0530, Sanjeev Sharma wrote:
> This is a patch to the rtw_cmd.c file that fixes following
> Error.
>
> ERROR: that open brace { should be on the previous line
This patch does much more than that :(
___
devel mailing li
On Mon, Nov 24, 2014 at 07:55:40PM +0100, Zahari Doychev wrote:
> The two patches fix several sparse warning in the lustre module.
>
> Zahari Doychev (2):
> [drivers] staging/lustre: fix sparse warnings
> [drivers] staging/lustre: fix sparse warnings
>
> drivers/staging/lustre/include/linux/
On Wed, Nov 26, 2014 at 05:15:48PM +0100, Loic Pefferkorn wrote:
> Add __acquires() and __releases() function annotations, to fix sparse
> warnings related to lock context imbalance.
>
> This fixes the following warnings:
>
> drivers/staging/lustre/lustre/libcfs/linux/linux-tracefile.c:153:5: wa
On Fri, Nov 07, 2014 at 10:17:40AM -0800, Greg KH wrote:
> On Fri, Nov 07, 2014 at 12:58:24PM -0500, Ken Depro wrote:
> > While fixing the CamelCase checks for the functions in the chanstub
> > source and header files, I discovered they are no longer being used.
> > This
On Wed, Nov 12, 2014 at 11:28:15AM -0500, Jeffrey Brown wrote:
> Sorry for all of the messy patches from before but here
> are the improved patches for parser.h and parser.c.
> The camel cases are grouped on functions and structs
> that occurs in both files.
You have to do a 'vN' where 'N' is a nu
On Thu, Nov 13, 2014 at 09:56:39AM -0500, Jeffrey Brown wrote:
> Fixed small bug in parser.c by removing "cleanups:" in parser_init
> _guts struct. Replaced it with proper error handling code
> and removed the instances of rc = NULL in the code. rc = NULL is
> redudant
>
> Signed-off-by: Jeffrey
I _strongly_ suggest unisys get their act together here. The number of
patches that were sent recently that make no sense at all is horrid.
I've now purged all of them from my to-apply queue, please resend
_everything_ that you have, in the correct order, _AFTER_ you all review
them among yoursel
On Thu, Nov 20, 2014 at 11:31:14PM +0530, Lekshmi wrote:
> The following checkpatch warning was fixed:
> WARNING: Missing a blank line after declarations
>
> Signed-off-by: Lekshmi
I need a "full name" here, sorry.
Please fix and resend.
greg k-h
___
On Wed, Nov 26, 2014 at 05:58:37PM +0530, Athira Lekshmi C V wrote:
> Fixed the checkpatch warning:
> WARNING: Missing a blank line after declarations
>
> Signed-off-by: Athira Lekshmi C V
What is the "C V" at the end of the name here? Is that your "full
name"? I need a real name, not initials
On Tue, Nov 25, 2014 at 01:26:14PM +, Luis de Bethencourt wrote:
> This patch fixes the checkpatch.pl warnings:
>
> WARNING: line over 80 characters
> + int cores_in_use = core_state.baseline_cores -
> atomic_read(&core_state.available_cores);
>
> WARNING: line over 80
601 - 700 of 4990 matches
Mail list logo
