On Thu, May 30, 2019 at 10:57:09PM +, Matt Sickler wrote:
> >From: devel On Behalf Of
> >Greg KH
> >On Fri, May 24, 2019 at 01:07:59PM +0200, Simon Sandström wrote:
> >> --- a/drivers/staging/kpc2000/kpc2000/core.c
> >> +++ b/drivers/staging/kpc2000/kp
The following changes since commit a188339ca5a396acc588e5851ed7e19f66b0ebd9:
Linux 5.2-rc1 (2019-05-19 15:47:09 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
tags/staging-5.2-rc3
for you to fetch changes up to e61ff0fba72d98
On Mon, Jun 03, 2019 at 01:43:50PM +0200, Tobias Nießen wrote:
> These changes to sd.c and xd.c slightly improve the code style and
> reduce the overall line length.
>
> Signed-off-by: Tobias Nießen
> Signed-off-by: Sabrina Gaube
> ---
> drivers/staging/rts5208/sd.c | 23 +++
On Fri, May 31, 2019 at 11:52:30AM +0100, Jeremy Sowden wrote:
> Added more read-only device attributes in order to expose all the
> information about the hardware which is available by calling read() or
> ioct() on the misc device associated with it.
>
> Signed-off-by: Jeremy Sowden
> ---
> dri
On Mon, Jun 03, 2019 at 02:08:56PM +0200, Greg KH wrote:
> On Fri, May 31, 2019 at 11:52:30AM +0100, Jeremy Sowden wrote:
> > Added more read-only device attributes in order to expose all the
> > information about the hardware which is available by calling read() or
> > ioct
On Fri, May 31, 2019 at 02:27:55AM +0530, Nishka Dasgupta wrote:
> Remove function r8712_free_network_queue as it does nothing except call
> _free_network_queue.
> Rename _free_network_queue to r8712_free_network_queue (and change its
> type to static) for continued use of the original functionalit
On Fri, May 31, 2019 at 02:31:41AM +0530, Nishka Dasgupta wrote:
> Remove function alloc_network as it does nothing except call
> _r8712_alloc_network. Further, to maintain consistency with
> the names of other functions, rename _r8712_alloc_network as
> r8712_alloc_network.
> Also change the corre
On Fri, May 31, 2019 at 02:36:38AM +0530, Nishka Dasgupta wrote:
> Change return values _SUCCESS and _FAIL to 0 and -ENOMEM respectively,
> to match the convention in the drivers (and also because the return
> value of this changed function is never checked anyway).
> Change return type of the func
On Mon, Jun 03, 2019 at 02:21:02PM +0200, Christian Müller wrote:
> From: Felix Trommer
>
> Replace C99-Style comments with C89-Style comments.
What does that mean?
> if (MaxChnlNum >= pTriple->first_channel) {
> - /* It is not in a monotonically increasing ord
On Mon, Jun 03, 2019 at 02:21:04PM +0200, Christian Müller wrote:
> Fix issues that lead to multiple checkpatch warnings and errors, most of
> them regarding formatting of code and comments.
> Comments that contain only commented out code are removed as well.
>
> Signed-off-by: Felix Trommer
> Si
On Mon, Jun 03, 2019 at 02:21:03PM +0200, Christian Müller wrote:
> From: Felix Trommer
>
> Remove the majority of all commented-out code. Commented out code, that
> was adressed by a comment itself is not removed. The code that we left
> in as comments was mostly due to the "pseudo-code"-like na
On Wed, Jun 05, 2019 at 03:53:49PM +0200, Valerio Genovese wrote:
> This was reported by sparse:
> drivers/staging/isdn/hysdn/hysdn_procconf.c:352:23: warning: symbol
> 'hysdn_proc_entry' was not declared. Should it be static?
>
> Signed-off-by: Valerio Genovese
> ---
> drivers/staging/isdn/hys
On Wed, Jun 05, 2019 at 05:57:11PM +0200, Valerio Genovese wrote:
> This was reported by sparse:
> drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c:39:7: warning: symbol
> 'kpc_dma_add_device
> ' was not declared. Should it be static?
>
> Signed-off-by: Valerio Genovese
> ---
> drivers/staging/
On Tue, Jun 04, 2019 at 12:29:13AM +0200, Simon Sandström wrote:
> Fixes checkpatch.pl warning "Prefer using '"%s...", __func__' to using
> '', this function's name, in a string".
>
> Signed-off-by: Simon Sandström
> ---
> drivers/staging/kpc2000/kpc2000/core.c | 10 +-
> 1 file changed,
On Tue, Jun 04, 2019 at 01:42:22PM +0530, Nishka Dasgupta wrote:
> Remove function rtw_free_network_nolock, as all it does is call
> _rtw_free_network_nolock, and rename _rtw_free_network_nolock to
> rtw_free_network_nolock.
>
> Signed-off-by: Nishka Dasgupta
> ---
> drivers/staging/rtl8188eu/co
On Sat, Jun 08, 2019 at 03:53:35PM +0200, xabi1...@gmail.com wrote:
> From: Xabier Etxezarreta
>
> Fixed a coding style issue checked with checkpatch.pl
>
> Signed-off-by: Xabier Etxezarreta
> ---
> drivers/staging/rts5208/rtsx.c | 5 +
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
>
On Wed, Jun 05, 2019 at 03:53:49PM +0200, Valerio Genovese wrote:
> This was reported by sparse:
> drivers/staging/isdn/hysdn/hysdn_procconf.c:352:23: warning: symbol
> 'hysdn_proc_entry' was not declared. Should it be static?
>
> Signed-off-by: Valerio Genovese
> ---
> drivers/staging/isdn/hys
On Fri, Jun 07, 2019 at 12:41:23PM +0530, Nishka Dasgupta wrote:
> Remove variables that are declared and assigned values but not otherwise
> used.
> Issue found with Coccinelle.
>
> Signed-off-by: Nishka Dasgupta
> ---
> drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 9 -
> 1 file chan
On Sat, Jun 08, 2019 at 01:45:05PM +, Geordan Neukum wrote:
> On Sat, Jun 08, 2019 at 03:27:46PM +0800, Hao Xu wrote:
> > modify void* to void * for #define inb_p(a) readq((void*)a)
> > and #define outb_p(d,a) writeq(d,(void*)a)
> >
> > Signed-off-by: Hao Xu
> > ---
> > drivers/staging/kpc20
On Mon, Jun 10, 2019 at 10:08:21AM +0530, Nishka Dasgupta wrote:
> On 09/06/19 4:32 PM, Greg KH wrote:
> > On Fri, Jun 07, 2019 at 12:41:23PM +0530, Nishka Dasgupta wrote:
> > > Remove variables that are declared and assigned values but not otherwise
> > > used.
> &
On Mon, Jun 10, 2019 at 12:44:05PM +0530, Nishka Dasgupta wrote:
> On 10/06/19 11:19 AM, Greg KH wrote:
> > On Mon, Jun 10, 2019 at 10:08:21AM +0530, Nishka Dasgupta wrote:
> > > On 09/06/19 4:32 PM, Greg KH wrote:
> > > > On Fri, Jun 07, 2019 at 12:41:23P
On Mon, Jun 10, 2019 at 09:20:09AM +0200, Simon Sandström wrote:
> On 06/06, Greg KH wrote:
> > On Tue, Jun 04, 2019 at 12:29:13AM +0200, Simon Sandström wrote:
> > >
> > > - dev_dbg(&pdev->dev, "kp2000_pcie_probe(pdev = [%p], id = [%p])\n",
> >
On Mon, Jun 10, 2019 at 08:51:10AM -0400, Sven Van Asbroeck wrote:
> Hello Greg, just a friendly ping regarding this patch. It got my Reviewed-by
> tag
> two weeks ago, no further feedback from anyone. Is there anything you would
> like us to do before queuing this?
>
> Link to v2 that got the Re
On Mon, Jun 10, 2019 at 04:08:25PM +0530, Merwin Trever Ferrao wrote:
> From: Merwin Trever Ferrao
>
> Fixed a coding style issue.
>
> Signed-off-by: Merwin Trever Ferrao
> ---
> drivers/staging/wlan-ng/cfg80211.c | 32 ++
> 1 file changed, 15 insertions(+), 17 dele
On Mon, Jun 10, 2019 at 03:48:24PM +0800, Hao Xu wrote:
> remove inb_p and outb_p to call readq/writeq directly.
>
> Signed-off-by: Hao Xu
> ---
> Changes in v2:
> - remove the macros inb_p/outb_p and use readq/writeq directly, per
> https://lkml.kernel.org/lkml/20190608134505.ga...@arch-01.home
On Wed, Jun 12, 2019 at 10:39:36AM +0300, Dan Carpenter wrote:
> On Mon, Jun 10, 2019 at 10:05:35PM +0200, Simon Sandström wrote:
> > @@ -349,9 +340,7 @@ static int kp2000_pcie_probe(struct pci_dev *pdev,
> > goto err_remove_ida;
> > }
> >
> > - /*
> > -* Step 4: Setup the R
On Wed, Jun 12, 2019 at 01:29:27PM -0700, Todd Kjos wrote:
> There is a race between the binder driver cleaning
> up a completed transaction via binder_free_transaction()
> and a user calling binder_ioctl(BC_FREE_BUFFER) to
> release a buffer. It doesn't matter which is first but
> they need to be
On Tue, Jun 11, 2019 at 08:50:59PM +0100, Jeremy Sowden wrote:
> The DMA driver has call-backs for doing asynchronous I/O which are
> protected by a CONFIG_ macro which is not defined. Added a Kconfig
> stanza to define it.
>
> Cc: Matt Sickler
> Signed-off-by: Jeremy Sowden
> ---
> drivers/st
On Thu, Jun 13, 2019 at 10:13:06AM +0100, Jeremy Sowden wrote:
> On 2019-06-13, at 10:45:31 +0200, Greg KH wrote:
> > On Tue, Jun 11, 2019 at 08:50:59PM +0100, Jeremy Sowden wrote:
> > > The DMA driver has call-backs for doing asynchronous I/O which are
> > > protected
On Fri, Jun 14, 2019 at 03:47:22PM +0200, Christoph Hellwig wrote:
> comedi_buf.c abuse the DMA API in gravely broken ways, as it assumes it
> can call virt_to_page on the result, and the just remap it as uncached
> using vmap. Disable the driver until this API abuse has been fixed.
>
> Signed-of
On Fri, Jun 14, 2019 at 04:48:57PM +0200, Christoph Hellwig wrote:
> On Fri, Jun 14, 2019 at 04:02:39PM +0200, Greg KH wrote:
> > Perhaps a hint as to how we can fix this up? This is the first time
> > I've heard of the comedi code not handling dma properly.
>
> I
On Thu, Jun 20, 2019 at 11:45:34AM +0200, Christian Müller wrote:
> As stated in coding-styles.rst multiline comments should be structured in a
> way,
> that the actual comment starts on the second line of the commented portion.
> E.g:
>
> /*
> * Multiline comments
> * should look like
> * th
On Thu, Jun 20, 2019 at 07:20:52AM +0200, Sergio Paracuellos wrote:
> Hi Greg,
>
> On Thu, Jun 20, 2019 at 2:40 AM Greg Ungerer wrote:
> >
> > Hi Sergio,
> >
> > On 19/6/19 5:44 pm, Sergio Paracuellos wrote:
> > > Some boards seems to ignore builtin perst configuration and use gpio
> > > instead.
On Fri, Jun 21, 2019 at 11:42:21AM +0800, YueHaibing wrote:
> when CRYPTO is m and KS7010 is y, building fails:
>
> drivers/staging/ks7010/ks_hostif.o: In function `michael_mic.constprop.13':
> ks_hostif.c:(.text+0x560): undefined reference to `crypto_alloc_shash'
> ks_hostif.c:(.text+0x580): unde
The following changes since commit f2c7c76c5d0a443053e94adb9f0918fa2fb85c3a:
Linux 5.2-rc3 (2019-06-02 13:55:33 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
tags/staging-5.2-rc6
for you to fetch changes up to 9b9410766f5422
On Mon, Jun 24, 2019 at 11:46:39AM +0200, Christian Müller wrote:
> As stated in coding-styles.rst multiline comments should be structured in a
> way,
> that the actual comment starts on the second line of the commented portion.
> E.g:
You sent 2 patches that did different things, yet have the
On Tue, Jun 25, 2019 at 10:41:29AM +0200, Simon Sandström wrote:
> Fixes checkpatch "CHECK: Unnecessary parentheses around '...'".
>
> Signed-off-by: Simon Sandström
> ---
> drivers/staging/kpc2000/kpc2000_spi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/st
On Thu, Jun 27, 2019 at 10:33:35AM +0200, Christian Müller wrote:
> As stated in coding-styles.rst multiline comments should be structured in a
> way,
> that the actual comment starts on the second line of the commented portion.
> E.g:
>
> /*
> * Multiline comments
> * should look like
> * th
On Thu, Jun 27, 2019 at 02:12:40PM +0200, Lukas Schneider wrote:
> Cleanup the line over 80 character warnings, reported by checkpatch
>
> Signed-off-by: Lukas Schneider
> Signed-off-by: Jannik Moritz
> Cc:
> ---
> drivers/staging/fbtft/fbtft-sysfs.c | 3 ++-
> drivers/staging/fbtft/fbtft.h
On Fri, Jun 28, 2019 at 12:21:38AM +0530, Harsh Jain wrote:
> From: root
Interesting user name :)
> Fix following sparse warning
> symbol was not declared. Should it be static?
> Using plain integer as NULL pointer
Don't do multiple things in the same patch. Please break thsi up into
two diffe
On Sun, Jun 30, 2019 at 08:27:26AM -0700, Gabriel Beauchamp wrote:
> This is a patch for the core.[ch] files that fixes up warnings
> found with the checkpatch.pl tool.
>
> Signed-off-by: Gabriel Beauchamp
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that
On Wed, Jun 26, 2019 at 12:24:02PM +0530, Nishka Dasgupta wrote:
> Remove function clk_sce as all it does is call clk_gat_sce.
> Modify call site of clk_sce to call clk_gat_sce instead.
> Issue found with Coccinelle.
>
> Signed-off-by: Nishka Dasgupta
> ---
> drivers/staging/comedi/drivers/amplc
On Thu, Jun 27, 2019 at 09:53:23PM +0200, Simon Sandström wrote:
> Fixes issues found by checkpatch:
>
> - "WARNING: braces {} are not necessary for single statement blocks"
> - "WARNING: braces {} are not necessary for any arm of this statement"
>
> Signed-off-by: Simon Sandström
> ---
> drive
On Fri, Jun 28, 2019 at 10:57:23PM +0530, Harsh Jain wrote:
> It fixes "symbol was not declared. Should it be static?"
> sparse warning.
>
> Signed-off-by: Harsh Jain
> ---
> drivers/staging/kpc2000/kpc_i2c/i2c_driver.c | 4 ++--
This file isn't even in the linux-next tree at all, it has moved w
On Mon, Jul 01, 2019 at 11:49:02AM +0530, Nishka Dasgupta wrote:
> Remove function rtl8192_rx_enable as all it does is call
> rtl8192_rx_initiate.
> Rename rtl8192_rx_initiate to rtl8192_rx_enable and change its type from
> static to non-static to maintain compatibility with call sites of
> rtl8192
On Tue, Jul 02, 2019 at 08:44:14AM +, Turritopsis Dohrnii Teo En Ming wrote:
> Good afternoon from Singapore,
>
> What device drivers for Linux does this project develop?
All taht is needed. What type of device do you have that Linux
currently does not support?
greg k-h
On Tue, Jul 02, 2019 at 09:29:47AM +, Turritopsis Dohrnii Teo En Ming wrote:
> My Hauppauge WinTV-HVR-935 HD Tri-Mode TV Stick DVB-T2 TV Tuner in
> Singapore is currently not supported by Linux.
Have you tried contacting the linux-me...@vger.kernel.org mailing list
first? The developers for t
On Tue, Jul 02, 2019 at 05:24:03AM -0700, Gabriel Beauchamp wrote:
> This is a patch for the core.[ch] files that fixes up warnings
> found with the checkpatch.pl tool.
>
> Signed-off-by: Gabriel Beauchamp
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that
On Wed, Jul 03, 2019 at 01:48:41PM +0530, Nishka Dasgupta wrote:
> Remove file ion_carveout_heap.c as its functions and definitions are not
> used anywhere.
> Issue found with Coccinelle.
>
> Signed-off-by: Nishka Dasgupta
> ---
> drivers/staging/android/ion/Kconfig | 9 --
> drivers
On Wed, Jul 03, 2019 at 02:14:21PM +0530, Nishka Dasgupta wrote:
> On 03/07/19 2:07 PM, Greg KH wrote:
> > On Wed, Jul 03, 2019 at 01:48:41PM +0530, Nishka Dasgupta wrote:
> > > Remove file ion_carveout_heap.c as its functions and definitions are not
> > > used anywh
On Tue, Jul 02, 2019 at 10:56:01AM +0800, Yue Hu wrote:
> From: Yue Hu
>
> Already check if ->datamode is supported in read_inode(), no need to check
> again in the next fill_inline_data() only called by fill_inode().
>
> Signed-off-by: Yue Hu
> Reviewed-by: Gao Xiang
> Reviewed-by: Chao Yu
>
On Wed, Jul 03, 2019 at 07:32:27AM -0400, Laura Abbott wrote:
> On 7/3/19 5:50 AM, Daniel Vetter wrote:
> > On Wed, Jul 3, 2019 at 10:37 AM Greg KH wrote:
> > >
> > > On Wed, Jul 03, 2019 at 01:48:41PM +0530, Nishka Dasgupta wrote:
> > > > Remove file i
On Tue, Jul 02, 2019 at 11:06:32AM +0300, fatihaltinpi...@gmail.com wrote:
> From: Fatih ALTINPINAR
>
> Fixed a coding style issue. Removed curly brackets of an one
> line if statement.
>
> Signed-off-by: Fatih ALTINPINAR
> ---
> drivers/staging/mt7621-dma/mtk-hsdma.c | 3 +--
> 1 file changed
On Thu, Jul 04, 2019 at 09:59:03AM +0800, Yue Hu wrote:
> On Wed, 3 Jul 2019 18:20:38 +0200
> Greg KH wrote:
>
> > On Tue, Jul 02, 2019 at 10:56:01AM +0800, Yue Hu wrote:
> > > From: Yue Hu
> > >
> > > Already check if ->datamode is supported in
The following changes since commit 4b972a01a7da614b4796475f933094751a295a2f:
Linux 5.2-rc6 (2019-06-22 16:01:36 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
tags/staging-5.3-rc1
for you to fetch changes up to 5d153248294340
On Sat, Jul 13, 2019 at 06:26:52PM -0300, christianlucian...@gmail.com wrote:
> From: Christian Luciano Moreno
>
> Add parenthesis to Macro argument to avoid precedence issues.
>
> Signed-off-by: Christian Luciano Moreno
> ---
> drivers/staging/rtl8712/basic_types.h | 2 +-
> 1 file changed, 1
On Sat, Jul 13, 2019 at 06:47:20PM -0300, christianlucian...@gmail.com wrote:
> From: Christian Luciano Moreno
>
> Fix alignment check reported by checkpatch.
>
> Signed-off-by: Christian Luciano Moreno
> ---
> drivers/staging/rtl8712/recv_linux.c | 2 +-
> 1 file changed, 1 insertion(+), 1 de
On Sat, Jul 13, 2019 at 09:20:05PM -0300, christianlucian...@gmail.com wrote:
> From: Christian Luciano Moreno
>
> Change local variable name to avoid CamelCase.
> Align code to the open parenthesis to fix alignment issues.
That is two different things, right?
So it should be 2 patches.
thanks
On Sat, Jul 13, 2019 at 06:47:20PM -0300, christianlucian...@gmail.com wrote:
> From: Christian Luciano Moreno
>
> Fix alignment check reported by checkpatch.
>
> Signed-off-by: Christian Luciano Moreno
> ---
> drivers/staging/rtl8712/recv_linux.c | 2 +-
> 1 file changed, 1 insertion(+), 1 de
On Mon, Jul 15, 2019 at 02:17:04PM -0300, christianlucian...@gmail.com wrote:
> From: Christian Luciano Moreno
>
> Fix: line over 80 characters
> space unnecesary after cast
> alignment match open parenthesis
> comparison to NULL
> Those warnings and check were reported by checkpat
On Sat, Jul 13, 2019 at 06:57:43PM -0300, christianlucian...@gmail.com wrote:
> From: Christian Luciano Moreno
>
> Signed-off-by: Christian Luciano Moreno
> ---
> drivers/staging/rtl8712/rtl8712_cmdctrl_bitdef.h | 1 -
> 1 file changed, 1 deletion(-)
I can't take patches without any changelog
On Tue, Jul 16, 2019 at 01:47:43PM -0300, Karen Palacio wrote:
> Signed-off-by: Karen Palacio
> ---
> drivers/staging/erofs/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I can not take patches without any changelog text, sorry.
___
de
On Tue, Jul 16, 2019 at 06:16:23PM -0300, Karen Palacio wrote:
> Fix typo in Kconfig
> Signed-off-by: Karen Palacio
I need a blank line before the signed-off-by line :(
3rd try?
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linux
On Wed, Jul 17, 2019 at 11:41:37PM +0900, Jan Sebastian Götte wrote:
> Commit c440eee1a7a1 ("Staging: fbtft: Switch to the gpio descriptor
> interface") breaks GPIO handling. In several places, checks to only set
> a GPIO if it was configured ended up backwards.
> I have tested this fix. The fixed
On Wed, Jul 17, 2019 at 05:11:19PM -0300, Karen Palacio wrote:
> Fix typo in Kconfig
>
> Signed-off-by: Karen Palacio
> Reviewed-by: Gao Xiang
> Reviewed-by: Chao Yu
>
> diff --git a/drivers/staging/erofs/Kconfig b/drivers/staging/erofs/Kconfig
> index d04b798..0dcefac 100644
> --- a/drivers/s
On Sat, Jul 20, 2019 at 11:02:14PM +0530, Bharath Vedartham wrote:
> For pages that were retained via get_user_pages*(), release those pages
> via the new put_user_page*() routines, instead of via put_page().
>
> This is part a tree-wide conversion, as described in commit fc1d8e7cca2d
> ("mm: int
On Thu, Jul 18, 2019 at 05:25:22PM +0800, Kai-Heng Feng wrote:
> The procfs provides many useful information for debugging, but it may be
> too much for normal usage, routines like proc_get_sec_info() reports
> various security related information.
>
> So disable it by defaultl.
>
> Signed-off-by
On Wed, Jul 24, 2019 at 02:12:28PM -0700, David Miller wrote:
> From: David Miller
> Date: Wed, 24 Jul 2019 14:12:02 -0700 (PDT)
>
> > From: YueHaibing
> > Date: Wed, 24 Jul 2019 21:01:26 +0800
> >
> >> Now if CONFIG_ETHERNET is not set, QLGE driver
> >> building fails:
> >>
> >> drivers/stagi
On Thu, Jul 25, 2019 at 10:27:16PM +0800, YueHaibing wrote:
> use variables 'local_entity_uc' and 'local_uc',
> mute gcc used-but-set-variable warning:
>
> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c: In function
> vchiq_release_internal:
> drivers/staging/vc04_services/interfac
On Thu, Jul 25, 2019 at 10:48:42PM +0800, Kai-Heng Feng wrote:
> at 15:55, Greg KH wrote:
>
> > On Thu, Jul 18, 2019 at 05:25:22PM +0800, Kai-Heng Feng wrote:
> > > The procfs provides many useful information for debugging, but it may be
> > > too much f
On Sun, Jul 28, 2019 at 05:51:57PM +0530, Saurav-Girepunje wrote:
> RTWAP:Fixed Coding function and style issues
> Removed Unnecessary parentheses
What is "RRWAP:"? Please look at other commits for this driver and copy
how they structure the subject and changelog information and then
resend
On Tue, Jul 30, 2019 at 02:58:44PM +0530, Bharath Vedartham wrote:
> put_page() to put_user_page*()
What does this mean?
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Tue, Jul 30, 2019 at 09:30:58AM -0500, Navid Emamdoost wrote:
> Allocation for priv->pFirmware may fail, so a null check is necessary.
> priv->pFirmware is accessed later in rtl8192_adapter_start. I added the
> check and made appropriate changes to propagate the errno to the caller.
>
> Update
On Tue, Jul 30, 2019 at 05:01:39PM -0500, Navid Emamdoost wrote:
> In rtl8192_init_priv_variable allocation for priv->pFirmware may fail,
> so a null check is necessary.priv->pFirmware is accessed later in
> rtl8192_adapter_start. I added the check and made appropriate changes
> to propagate the er
On Fri, Sep 08, 2017 at 11:18:08PM +0530, Harsha Sharma wrote:
> Hello,
> I have tried to follow above given instructions but please correct me if I am
> wrong somewhere.
What "above given instructions"?
And please fix your email client to not send html email, it is getting
rejected by the mailin
On Mon, Sep 11, 2017 at 11:55:22AM +, Laurentiu Tudor wrote:
> Hi,
>
> > -Original Message-
> > From: Greg KH [mailto:gre...@linuxfoundation.org]
> > Sent: Thursday, August 31, 2017 7:05 PM
> >
> > On Mon, Aug 28, 2017 at 01:54:05PM +0300, laure
On Mon, Sep 11, 2017 at 09:29:31PM +0530, Srishti Sharma wrote:
> The use of volatile for the variable monitor_lock is unnecessary.
>
> Signed-off-by: Srishti Sharma
> ---
> drivers/staging/ccree/ssi_request_mgr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/
On Thu, Sep 07, 2017 at 07:44:52PM +0530, Srishti Sharma wrote:
> Use BIT(x) instead of using (1<
> Signed-off-by: Srishti Sharma
> ---
> Changes in v2:
> - Add tab spaces before BIT macro.
>
> drivers/staging/ccree/ssi_cipher.h | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-
On Sat, Sep 09, 2017 at 10:43:36PM +0530, Harsha Sharma wrote:
> This coding style (foo *bar) is more common for the kernel code.
> Change foo* bar to foo *bar.
> Change foo * bar to foo *bar.
> Change (foo*) to (foo *).
>
> Signed-off-by: Harsha Sharma
> ---
> Change in v2:
> -Updated log messa
On Sun, Sep 10, 2017 at 11:02:02PM +0530, Harsha Sharma wrote:
> Space required after ','
>
> Signed-off-by: Harsha Sharma
> Acked-by: Julia Lawall
This patch does not apply, can you rebase and resend?
thanks,
greg k-h
___
devel mailing list
de...@l
On Sun, Sep 10, 2017 at 11:04:34PM +0530, Harsha Sharma wrote:
> Remove space between function name and open parenthesis '('
>
> Signed-off-by: Harsha Sharma
> ---
> drivers/staging/rtl8723bs/os_dep/os_intfs.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
This and patch 8/10, ha
On Mon, Sep 11, 2017 at 10:37:05PM +0200, ArminSchoenlieb wrote:
> From: Armin Schoenlieb
>
> This is a patch to the irqueue.h file that fixes up pointer style errors and
> trailing whitespace errors, found by the checkpatch.pl tool
>
> Signed-off-by: Armin Schoenlieb
> ---
> drivers/staging/i
On Tue, Sep 12, 2017 at 07:05:23PM +0530, Harsha Sharma wrote:
> Space required after ','
>
> Signed-off-by: Harsha Sharma
> ---
> Changes in v2:
> -Rebase against staging-testing and solve merge conflicts
>
> drivers/staging/rtl8723bs/os_dep/os_intfs.c | 12 ++--
> 1 file changed, 6 i
On Fri, Sep 08, 2017 at 11:21:25PM +0530, Harsha Sharma wrote:
> Make code more concise and readable
>
> Signed-off-by: Harsha Sharma
> ---
> Change in v3:
> -Change in subject and log message
> Change in v2:
> -Change in subject
> -Change in log message
> drivers/staging/typec/tcpm.c | 2 +
On Tue, Sep 12, 2017 at 01:40:15AM +0100, Liam Ryan wrote:
> Fix checkpath-reported unbalanced braces in the following areas
>
> 221: FILE: drivers/staging/rtl8712/hal_init.c:221:
> 392: FILE: drivers/staging/rtl8712/os_intfs.c:392:
> 363: FILE: drivers/staging/rtl8712/rtl8712_cmd.c:363:
> 889: FI
On Wed, Sep 13, 2017 at 06:03:10PM +0100, Jonathan Cameron wrote:
> On Wed, 13 Sep 2017 14:14:07 +0530
> Himanshi Jain wrote:
>
> > Add __ATTR_NAMED macro similar to __ATTR but taking name as a
> > string instead of implicit conversion of argument to string using
> > the macro _stringify(_name).
On Wed, Sep 13, 2017 at 09:23:31PM +0200, Lars-Peter Clausen wrote:
> On 09/13/2017 08:58 PM, Greg KH wrote:
> > On Wed, Sep 13, 2017 at 06:03:10PM +0100, Jonathan Cameron wrote:
> >> On Wed, 13 Sep 2017 14:14:07 +0530
> >> Himanshi Jain wrote:
> >>
> >&
On Thu, Sep 14, 2017 at 10:21:29PM +0530, Harsha Sharma wrote:
> Hi,
> Yes, you are right but the function returns 0 in the end and the changes
> compiles well .
Then the function is incorrect, it should be reporting back that error.
thanks,
greg k-h
_
On Sun, Sep 17, 2017 at 08:54:16PM -0700, k...@exchange.microsoft.com wrote:
> From: Dexuan Cui
>
> Due to commit 54a66265d675 ("Drivers: hv: vmbus: Fix rescind handling"),
> we need this patch to resolve the below deadlock:
So does this patch need a "Fixes:" tag, and a "stable@" tag as well, so
On Sun, Sep 17, 2017 at 08:54:17PM -0700, k...@exchange.microsoft.com wrote:
> From: Olaf Hering
>
> Till recently the expected length of bytes read by the
> daemon did depend on the context. It was either hv_start_fcopy or
> hv_do_fcopy. The daemon had a buffer size of two pages, which was much
On Sun, Sep 17, 2017 at 08:54:19PM -0700, k...@exchange.microsoft.com wrote:
> From: Stephen Hemminger
>
> When investigating performance, it is useful to be able to look at
> the number of host and guest events per-channel. This is equivalent
> to per-device interrupt statistics.
>
> Signed-off
On Sun, Sep 17, 2017 at 08:54:18PM -0700, k...@exchange.microsoft.com wrote:
> From: Stephen Hemminger
>
> This extends existing vmbus related sysfs structure to provide per-channel
> state information. This is useful when diagnosing issues with multiple
> queues in networking and storage.
>
> T
On Sun, Sep 17, 2017 at 08:54:16PM -0700, k...@exchange.microsoft.com wrote:
> From: Dexuan Cui
>
> Due to commit 54a66265d675 ("Drivers: hv: vmbus: Fix rescind handling"),
> we need this patch to resolve the below deadlock:
>
> after we get the mutex in vmbus_hvsock_device_unregister() and call
On Mon, Sep 04, 2017 at 01:17:40PM +0800, Jisheng Zhang wrote:
> The binder driver now could cause warnings as below on 32bit platforms
> if ANDROID_BINDER_IPC_32BIT is unselected:
>
> drivers/android/binder.c:1550:15: warning: cast to pointer from integer
> of different size [-Wint-to-pointer-cas
On Tue, Sep 19, 2017 at 12:25:38PM +0200, Benjamin Gaignard wrote:
> Instead a getting one common device "/dev/ion" for
> all the heaps this patch allow to create one device
> entry ("/dev/ionX") per heap.
> Getting an entry per heap could allow to set security rules
> per heap and global ones for
On Tue, Sep 19, 2017 at 01:55:36PM +0200, Benjamin Gaignard wrote:
> >> +
> >> spin_lock_init(&heap->free_lock);
> >> heap->free_list_size = 0;
> >>
> >> @@ -595,13 +610,9 @@ static int ion_device_create(void)
> >> if (!idev)
> >> return -ENOMEM;
> >>
> >> - idev
On Thu, Sep 21, 2017 at 12:07:04PM +0530, Janani Sankara Babu wrote:
> This patch solves the following error shown by checkpatch script
> ERROR: do not use assignment in if condition
>
> Signed-off-by: Janani Sankara Babu
> ---
> drivers/staging/ccree/ssi_hash.c | 8
> 1 file changed, 4
On Fri, Sep 22, 2017 at 02:15:34PM +0530, kart...@techveda.org wrote:
> From: Karthik Tummala
>
> Fixed following checkpatch warnings & checks:
> CHECK: Unnecessary parentheses
> WARNING: suspect code indent for conditional statements
> WARNING: Missing a blank line after declarations
Hi,
This
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Fri, Sep 22, 2017 at 03:
On Mon, Sep 25, 2017 at 12:21:47PM +0530, Arvind Yadav wrote:
> Signed-off-by: Arvind Yadav
> ---
I can't take patches without any changelog text, sorry.
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.o
901 - 1000 of 4990 matches
Mail list logo
