d *)(p+2), cur->Ssid.Ssid, cur->Ssid.SsidLength))
ACKed-by: Larry Finger
Thanks,
Larry
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
cReqFail;
} else {
/* check if ssid match */
if (memcmp((void *)(p+2), cur->Ssid.Ssid, cur->Ssid.SsidLength))
ACKed-by: Larry Finger
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdri
ecvframe_attrib().")
Cc: Stable
Cc: youling257
Cc: u.srikant.patn...@gmail.com
Reported-and-tested-by: youling257
Signed-off-by: Larry Finger
---
drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal
NetworkManager, but it
does no harm in that case.
Reported-and-Tested-by: youling257
Cc: linux-wirel...@vger.kernel.org
Cc: youling257
Signed-off-by: Larry Finger
---
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/s
*/
{} /* Terminating entry */
};
Acked-by: Larry Finger
Larry
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On 12/30/18 12:39 PM, Michael Straube wrote:
Commit 6bd082af7e36 ("staging:r8188eu: use lib80211 CCMP decrypt")
is causing hardfreeze whenever the driver tries to connect to my wifi
network. That makes the driver unusable on my system. Reverting the
commit fixes the issue and the driver works pro
On 1/1/19 3:02 AM, Ivan Safonov wrote:
I suggested a patch for loading modules from interruptible mode, but this patch
remained unclaimed (
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-August/124851.html
).
For some reason I thought that this patch had been removed a
On 1/1/19 1:31 PM, Michael Straube wrote:
I've tested your patch and it solved the issue. No freezes and dmesg looks good.
I noticed that try_then_request_module() is also used in rtw_wep_encrypt() and
rtw_wep_decrypt(). I guess that also could cause problems?
Yes, I believe it would if anyon
This entry was missed when the driver was added.
Signed-off-by: Larry Finger
---
Greg,
Because this driver is in staging, I am sending it to you. I hope that is OK.
Larry
---
MAINTAINERS | 5 +
1 file changed, 5 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index f4855974f325
ll be more intrusive. My original attempt failed, thus I am
delaying that fix.
Cc: Michael Straube
Cc: Ivan Safonov
Signed-off-by: Larry Finger
---
Larry Finger (2):
staging: rtl8188eu: Fix module loading from tasklet for CCMP
encryption
staging: rtl8188eu: Fix module loading from taskl
el Straube
Cc: Ivan Safonov
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_security.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_security.c
b/drivers/staging/rtl8188eu/core/rtw_security.c
index 052656a22821..bab96
el Straube
Cc: Ivan Safonov
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_security.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_security.c
b/drivers/staging/rtl8188eu/core/rtw_security.c
index f7407632e80b..05265
On 1/5/19 3:10 AM, Július Milan wrote:
Fixes the following sparse warnings:
drivers/staging/wilc1000/host_interface.c:2360:30: warning:
incorrect type in assignment (different base types)
expected restricted __le32 [addressable] [assigned] [usertype] frame_type
got restricted __le16
On 1/7/19 11:28 AM, Michael Straube wrote:
This device was added to the stand-alone driver on github.
Add it to the staging driver as well.
Link: https://github.com/lwfinger/rtl8188eu/commit/a0619a07cd1e
Signed-off-by: Michael Straube
Acked-by: Larry Finger
Thanks,
Larry
rried over between
calls to this routine. Your fix is correct.
Acked-by: Larry Finger
Thanks,
Larry
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
files changed, 78 insertions(+), 110 deletions(-)
Tested-by: Larry Finger
This change for the RTL8192E works. I do not have the hardware for testing the
equivalent change for r8192u, but as the changes look the same, that one is
likely OK as well.
Thanks for the change,
Larry
7eb5 rtl8188eu/core/rtw_ieee80211.o
After:
text data bss dec hex filename
26612 5776 0 323887e84 rtl8188eu/core/rtw_ieee80211.o
(gcc version 9.2.1, amd64)
Signed-off-by: Colin Ian King
---
Acked-by: Larry Finger
Thanks,
On 9/23/19 2:48 PM, Connor Kuehl wrote:
The local variable 'bcmd_down' is always set to true almost immediately
before the do-while's condition is checked. As a result, !bcmd_down
evaluates to false which short circuits the logical AND operator meaning
that the second operand is never reached and
On 9/25/19 4:32 PM, Connor Kuehl wrote:
Inside a nested 'else' block at the beginning of this function is a
call that assigns 'psta' to the return value of 'rtw_get_stainfo()'.
If 'rtw_get_stainfo()' returns NULL and the flow of control reaches
the 'else if' where 'psta' is dereferenced, then we
r->addr3, get_bssid(pmlmepriv), ETH_ALEN);
- if (psta->qos_option)
+ if (psta && psta->qos_option)
qos_option = true;
} else {
RT_TRACE(_module_rt
d be
with 0x03 according to the max_rate_idx in ODM_RAInfo_Init().
Cc: Larry Finger
Cc: Greg Kroah-Hartman
Cc: Michael Straube
Cc: sta...@vger.kernel.org
Signed-off-by: Denis Efremov
---
drivers/staging/rtl8188eu/hal/hal8188e_rate_adaptive.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --
< RTL88E_MESSAGE_BOX_SIZE; cmd_idx++)
+ usb_write8(adapt, msgbox_addr + cmd_idx, *((u8 *)(&h2c_cmd) +
cmd_idx));
- } while ((!bcmd_down) && (retry_cnts--));
+ adapt->HalData->LastHMEBoxNum =
+ (h2c_box_num + 1) %
rtw_ps_cmd(), report_survey_event(), report_join_res(), survey_timer_hdl(),
and rtw_check_bcn_info().
Signed-off-by: Larry Finger
Cc: navin patidar
---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 22 +++---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 12 ++--
drive
On 11/15/2014 08:25 AM, Christian Resell wrote:
Simple style fix ("else is not generally useful after a break or return").
For the eudyptula challenge (http://eudyptula-challenge.org/).
Signed-off-by: Christian F. Resell
---
This patch leads to the following build warnings:
CC [M] drivers
The DLink GO-USB-N150 with revision B1 uses this driver.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
index 65a257f
On 11/27/2014 10:28 AM, Greg KH wrote:
On Thu, Nov 27, 2014 at 10:10:21AM -0600, Larry Finger wrote:
The DLink GO-USB-N150 with revision B1 uses this driver.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a
On 12/01/2014 09:53 AM, Anjana Sasindran wrote:
This patch fix the checkpatch.pl warning:
WARNING: please, no spaces at the start of a line
Signed-off-by: Anjana Sasindran
---
drivers/staging/rtl8723au/hal/odm_RegConfig8723A.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
dif
| 33 +
1 file changed, 15 insertions(+), 18 deletions(-)
Acked-by: Larry Finger
Thanks for porting your changes found in one of the Realtek drivers.
Larry
diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
On 12/11/2014 04:23 PM, Krzysztof Konopko wrote:
Some struct fields in wifi.h are meant to be __le16 bu were declared as
unsigned short. This was reported by sparse:
rtw_wlan_util.c:538:24: warning: cast to restricted __le16
rtw_wlan_util.c:1544:29: warning: cast to restricted __le16
r
On 12/12/2014 06:52 AM, Dan Carpenter wrote:
On Thu, Dec 11, 2014 at 05:53:30PM -0600, Larry Finger wrote:
On 12/11/2014 04:23 PM, Krzysztof Konopko wrote:
Some struct fields in wifi.h are meant to be __le16 bu were declared as
unsigned short. This was reported by sparse:
rtw_wlan_util.c
On 12/12/2014 05:35 AM, Krzysztof Konopko wrote:
On 12/12/14 00:53, Larry Finger wrote:
This fix may make the sparse warnings go away, but I think it introduces
new bugs.
Right, I see. Nice try though, isn't it? ;)
In particular, did you test on big-endian hardware after you
made
On 12/12/2014 04:50 PM, Krzysztof Konopko wrote:
On 12/12/14 18:35, Larry Finger wrote:
On 12/12/2014 05:35 AM, Krzysztof Konopko wrote:
On 12/12/14 00:53, Larry Finger wrote:
In particular, did you test on big-endian hardware after you
made this change?
Nope. I don't have any big-e
On 12/15/2014 05:01 PM, Rickard Strandqvist wrote:
Hi
No the rtw_hw_resume23a() is not used anywhere.
I also do a check of all functions that are not used, but not in the
drivers/staging, I suspected that these might be under development and
used in the future.
What do you want to do, who decid
On 12/28/2014 11:47 PM, Serguey Parkhomovsky wrote:
Fixes the following sparse warning for rtw_mlme.c:
drivers/staging/rtl8188eu/core/rtw_mlme.c:810:9: warning: context imbalance in
'rtw_free_assoc_resources' - different lock contexts for basic block
Signed-off-by: Serguey Parkhomovsky
---
The driver allocates memory to store the firmware image; however, that
memory is never released. The kmemleak facility was used to find this
error.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/fw.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8188eu
On 01/02/2015 12:17 PM, Larry Finger wrote:
The driver allocates memory to store the firmware image; however, that
memory is never released. The kmemleak facility was used to find this
error.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/fw.c | 1 +
1 file changed, 1
your Kconfig may be newer than mine. In any
case, the changes are harmless.
Acked-by: Larry Finger
---
drivers/staging/rtl8188eu/Kconfig | 4 ++--
drivers/staging/rtl8192e/Kconfig | 8
drivers/staging/rtl8712/Kconfig | 4 ++--
drivers/staging/rtl8723bs/Kconfig | 2 +-
4 fil
On 5/15/19 8:06 AM, Kai-Heng Feng wrote:
at 20:33, Greg KH wrote:
On Wed, May 15, 2019 at 07:54:58PM +0800, Kai-Heng Feng wrote:
at 19:40, Greg KH wrote:
On Wed, May 15, 2019 at 07:24:01PM +0800, Kai-Heng Feng wrote:
The rtl8821ce can be found on many HP and Lenovo laptops.
Users have bee
ons(+), 38 deletions(-)
If they apply, all six of these are OK.
Acked-by: Larry Finger
Larry
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
lue[max_level]);
This condition is caused when a loop falls through. The fix is to pin
max_level to be >= 0.
Signed-off-by: Larry Finger
c: kbuild test robot
Fixes: 9ce99b04b5b82fdf11e4c76b60a5f82c1e541297 staging: r8822be: Add phydm
mini driver
---
drivers/staging/rtlwifi/phydm/phydm_dig.
On 09/29/2017 02:51 AM, Dan Carpenter wrote:
I'm not totally certain that it's necessary to put an upper limit here.
I think it happens at lower levels. But if we are going to do that then
we should have a lower bound as well.
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/rtlwifi/
On 10/11/2017 08:13 AM, Greg Kroah-Hartman wrote:
On Wed, Oct 11, 2017 at 12:06:00PM +0300, Kalle Valo wrote:
(Sorry for taking so long with the reply, I wanted first to check what
the rtlwifi in staging contains.)
Larry Finger writes:
On 08/24/2017 07:14 AM, Kalle Valo wrote:
Dan
The kbuild test robot reports two conditions with no effect (if == else).
These are the result of copy and paste typographical errors.
Signed-off-by: Larry Finger
Cc: Ping-Ke Shih
Cc: Yan-Hsuan Chuang
Cc: Birming Chiu
Cc: Shaofu
Cc: Steven Ting
Cc: kbuild-...@01.org
Cc: Julia Lawall
]
Signed-off-by: Stanislaw Gruszka
Acked-by: Larry Finger
Thanks Stanislaw. It is amazing how long I can stare at a piece of code without
seeing the problem.
Larry
---
drivers/staging/rtlwifi/rtl8822be/fw.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers
On 10/24/2017 08:24 AM, txt.file wrote:
Hey Linux wireless list,
A while ago I bought an ALFA Network AWUS036AC[0] which does not yet
seem to be supported in Linux mainline. I would like to get it supported.
The problem is that I have not that much experience doing software
development.
kind r
On 11/17/2017 08:50 AM, Colin King wrote:
From: Colin Ian King
dev_alloc_skb can potentially return NULL, so add a null check to
avoid a null pointer dereference on skb
Acked-by: Larry Finger
Larry
Detected by CoverityScan, CID#1454558 ("Dereference on null return")
Fixes: 7e
not a wireless interface
and therefore it fails to work correctly with it thereafter.
This problem was reported and tested at
https://github.com/lwfinger/rtl8188eu/issues/234.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 14 --
1 file changed, 4
not a wireless interface
and therefore it fails to work correctly with it thereafter.
This problem was reported and tested at
https://github.com/lwfinger/rtl8188eu/issues/234.
Signed-off-by: Larry Finger
---
v2 - completed missing subject
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 14
On 12/09/2017 05:11 AM, Neil Singh wrote:
Cleanup below checkpatch issue:
WARNING:LONG_LINE: line over 80 characters
1000: FILE: rtl871x_security.c:1000:
+static void construct_ctr_preload(u8 *ctr_preload, sint a4_exists, sint
qc_exists,
Signed-off-by: Neil Singh
---
drivers/staging/rtl8712
On 07/04/2018 03:03 AM, Jian-Hong Pan wrote:
Hi,
We have an ASUS X530UN (Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz)
laptop equipped with Realtek rtl8822be wireless which cannot find any
access point after WiFi is launched.
Realtek rtl8822be wireless' information:
dev@endless:~/linux-eos$ sudo ls
On 07/04/2018 09:09 AM, Dan Carpenter wrote:
On Wed, Jul 04, 2018 at 08:55:00AM -0500, Larry Finger wrote:
I do not think this is a bug.
It's obviously a bug. The driver should just work by default.
As a last resort, we would do something like add quirk or something. I
haven't
On 07/05/2018 02:36 AM, Pkshih wrote:
On Wed, 2018-07-04 at 10:33 -0500, Daniel Drake wrote:
On Wed, Jul 4, 2018 at 10:13 AM, Larry Finger wrote:
We will have to agree to disagree.
I have no idea what the vendors are doing that cause some motherboards to
need a different aspm value. What I
On 08/05/2018 02:35 PM, Umang Parmar wrote:
Remove unnecessary conditions where if and else block had same code.
Signed-off-by: Umang Parmar
The subject should be "staging: rtlwifi: ...". If someone wants to search for
fixes to the modules in drivers/staging/rtlwifi/, your subject would not b
On 08/05/2018 02:35 PM, Umang Parmar wrote:
Directly return value and remove unneeded variables.
Signed-off-by: Umang Parmar
This patch also has the same problem with the subject. Otherwise it is OK.
Larry
___
devel mailing list
de...@linuxdriverpro
On 08/08/2018 04:22 AM, Greg KH wrote:
On Sun, Aug 05, 2018 at 09:41:06PM +0200, Frank Werner-Krippendorf wrote:
Removed 5 inline comments "/*volatile*/" rtl87x_event.h, to fix
a coding style issue "Statements should start on a tabstop"
detected by checkpatch.pl script.
Signed-off-by: Frank Wer
When the size argument in a call to strncpy() is the size of the
destimation, gcc8 issues a warning. These patches fix the potential
problem by replacing the strncpy() with strlcpy().
Signed-off-by: Larry Finger
Larry Finger (2):
staging: rtl8192e: Fix compiler warning about strncpy
When strncpy() is called with source and destination strings the same
length, gcc 8 warns that there may be an unterminated string. Using
strlcpy() rather than strncpy() forces a null at the end and quiets the
warning.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8712
When strncpy() is called with source and destination strings the same
length, gcc 8 warns that there may be an unterminated string. Using
strlcpy() rather than strncpy() forces a null at the end and quiets the
warning.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8192e/rtllib_softmac.c
When strncpy() is called with source and destination strings the same
length, gcc 8 warns that there may be an unterminated string. This section
is completely reworked to use the known lengths of the strings.
Signed-off-by: Larry Finger
---
v2 - David Laight's comments are implem
When the size argument in a call to strncpy() is the size of the
destimation, gcc8 issues a warning. These patches fix the potential
problem.
Signed-off-by: Larry Finger
v2 - The code is changed to implement the comments of David Laight.
Larry Finger (2):
staging: rtl8192e: Fix compiler
When strncpy() is called with source and destination strings the same
length, gcc 8 warns that there may be an unterminated string. Using
strlcpy() rather than strncpy() forces a null at the end and quiets the
warning.
Signed-off-by: Larry Finger
---
v2 - No changes.
---
drivers/staging/rtl8712
On 08/29/2018 04:14 PM, Joe Perches wrote:
On Wed, 2018-08-29 at 21:35 +0100, John Whitmore wrote:
Rename the bit field element AdvCoding, as it causes a checkpatch issue
with CamelCase naming. As the element is not actually used in code it
has been renamed to 'not_used_adv_coding'.
The single
On 02/13/2017 05:27 AM, David Laight wrote:
From: Larry Finger
Sent: 11 February 2017 03:30
Sparse reports the following:
CHECK drivers/staging/rtl8712/rtl871x_ioctl_linux.c
drivers/staging/rtl8712/rtl871x_ioctl_linux.c:1422:46: warning: restricted
__le16 degrades to integer
drivers
, there is a patch
commit 07222e535831b916221dd2a48a3047ec7e45dc72
Author: Larry Finger
Date: Fri Feb 10 21:30:27 2017 -0600
staging: r8712u: Fix Sparse warning in rtl871x_xmit.c
that already makes that fix. In fact, all the endian issues in that driver are
resolved. When the compilers were
On 04/22/2015 02:48 AM, Dan Carpenter wrote:
That's Larry Finger's driver and it might be different from the
kernel.org driver. I've added him to the CC list. If you look in
/var/log/messages there may be some useful warning messages from when
the driver loaded to when it crashed?
Actually, t
On 04/22/2015 11:45 AM, dborlau...@gmail.com wrote:
Dear Mr. Carpenter,
Thank you kindly for your help and these nice suggestions. Thank you
for CCing Mr. Finger. Actually, I stumbled across his name in my online
searches as on of the developers of this driver, and that's why I tried
to seek h
On 04/23/2015 10:00 AM, DHANAPAL, GNANACHANDRAN (G.) wrote:
This patch removes unused return variable in this file.
You should hold off with V2 to give others a chance to comment.
Your commit message does not exactly describe what is happening. The return
variable is not unused. More accurate
patch has been submitted by
Larry Finger earlier to silence the same spatch warning in another
file.
What's the git hash and title for Larry's patch?
The logic is the negative number to an unsigned quantity is
fixed by adding 256 to -98 to get the equivalent negative number as
per La
On 04/30/2015 12:50 PM, Gujulan Elango, Hari Prasath (H.) wrote:
From: Larry Finger on behalf of Larry Finger
Sent: Thursday, April 30, 2015 11:03 PM
To: Gujulan Elango, Hari Prasath (H.); Dan Carpenter
Cc: de...@driverdev.osuosl.org; julia.law...@lip6.fr;
gre...@linuxfoundation.org; wlan
On 05/04/2015 02:21 AM, Gujulan Elango, Hari Prasath (H.) wrote:
On Thu, Apr 30, 2015 at 02:09:13PM -0500, Larry Finger wrote:
Please fix your mailer. The most recent material to which you were
replying was not indented any levels, but the "new" material was 3
levels deep. It is
On 05/13/2015 05:08 PM, Luca Ceresoli wrote:
Fixes checkpatch warnings:
WARNING: Missing a blank line after declarations
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Larry Finger
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 3 +++
1 file changed, 3 insertions(+)
diff
otherwise. This has the advantage that the return value also
describes the kind of error that happened, while a boolean squashes all errors
down a unique value.
Change rtw_start_drv_threads() to return a proper 0-or-error value.
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Larry Finger
On 05/14/2015 02:35 PM, Johannes Berg wrote:
On Wed, 2015-05-13 at 22:04 -0300, Gaston Gonzalez wrote:
.../rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 53
++
include/net/mac80211.h | 3 ++
net/mac80211/tkip.c
: Greg Kroah-Hartman
Cc: Larry Finger
Cc: Florian Schilhabel
---
Can you assure us that you have carefully checked the the source address of
addr->sa_data and padapter->eeprompriv.mac_addr are suitably aligned? At a
minimum, have you tested this change on real hardware?
Larry
d
eg Kroah-Hartman
Cc: Larry Finger
Cc: Florian Schilhabel
---
Changes for v3:
- Removed unaligned conversions
Changes for v2:
- Describe a changelog, to prove address are aligned
drivers/staging/rtl8712/os_intfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
On 05/20/2015 02:46 PM, Jagan Teki wrote:
On 21 May 2015 at 01:10, Larry Finger wrote:
On 05/20/2015 01:41 PM, Jagan Teki wrote:
On 18 May 2015 at 22:02, Jagan Teki wrote:
Fixes Warning encounter this by applying checkpatch.pl against this file:
Prefer ether_addr_copy() over memcpy() if
The driver is reporting a warning at kernel/time/timer.c:1096 due to calling
del_timer_sync() while in interrupt mode. Such warnings are fixed by calling
del_timer() instead.
Signed-off-by: Larry Finger
Cc: Stable
Cc: Haggi Eran
---
drivers/staging/rtl8712/rtl8712_led.c | 2 +-
drivers
On 05/24/2015 02:03 PM, Haggai Eran wrote:
On 24 May 2015 at 00:16, Larry Finger wrote:
The driver is reporting a warning at kernel/time/timer.c:1096 due to calling
del_timer_sync() while in interrupt mode. Such warnings are fixed by calling
del_timer() instead.
Signed-off-by: Larry Finger
On 05/25/2015 04:37 AM, Vaishali Thakkar wrote:
On 25 May 2015 14:49, "Dan Carpenter" mailto:dan.carpen...@oracle.com>> wrote:
>
> On Sun, May 24, 2015 at 07:11:40PM -0500, Larry Finger wrote:
> > On 05/24/2015 02:03 PM, Haggai Eran wrote:
> > >
On 05/24/2015 11:42 PM, Sudip Mukherjee wrote:
I haven't been using kernel v4.1 so I haven't seen this warning, but looking
at the code it seems to originate from the two recent patches to remove
_cancel_timer and _cancel_timer_ex. I see that there's another patch in lkml [1]
that changes del_tim
On 05/23/2015 04:16 PM, Larry Finger wrote:
The driver is reporting a warning at kernel/time/timer.c:1096 due to calling
del_timer_sync() while in interrupt mode. Such warnings are fixed by calling
del_timer() instead.
Signed-off-by: Larry Finger
Cc: Stable
Cc: Haggi Eran
---
Greg,
Please
On 05/26/2015 12:30 AM, Sudip Mukherjee wrote:
On Mon, May 25, 2015 at 10:07:59PM -0700, Joe Perches wrote:
On Tue, 2015-05-26 at 10:32 +0530, Sudip Mukherjee wrote:
On Mon, May 25, 2015 at 09:55:08PM -0700, Joe Perches wrote:
On Tue, 2015-05-26 at 10:16 +0530, Sudip Mukherjee wrote:
On Mon,
On 05/26/2015 10:48 AM, Dan Carpenter wrote:
On Tue, May 26, 2015 at 07:14:01AM -0700, Greg KH wrote:
I take the blame for any problems with Outreachy patches. Given the
huge volume of them, one bug out of 900 isn't that bad of a percentage.
We don't get many bugs through outreachy, but this
| 2 --
drivers/staging/rtl8188eu/include/rtw_ioctl.h | 2 --
drivers/staging/rtl8188eu/os_dep/mlme_linux.c | 2 --
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 12
5 files changed, 19 deletions(-)
This patch looks good to me.
ACKed-by: Larry Finger
diff --git
On 06/03/2015 08:28 AM, Mutharaju, Prasanna (P.) wrote:
On Wed, Jun 03, 2015 at 02:35:35PM +0530, Sudip Mukherjee wrote:
On Wed, Jun 03, 2015 at 08:23:54AM +, Mutharaju, Prasanna (P.) wrote:
From: Prasanna Karthik
Fix reported by coccinelle compressing last two lines with single return
ca
---
---
drivers/staging/rtl8712/rtl871x_sta_mgt.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
Much better.
Acked-by: Larry Finger
diff --git a/drivers/staging/rtl8712/rtl871x_sta_mgt.c
b/drivers/staging/rtl8712/rtl871x_sta_mgt.c
index a9b93d0..6ae8cdc 100644
--- a/drivers/staging
On 11/23/19 9:16 AM, Michael Straube wrote:
Remove unnecessary parentheses reported by checkpatch.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
Acked-by: Larry Finger
Thanks,
Larry
On 11/23/19 9:16 AM, Michael Straube wrote:
Replace tabs with spaces in declarations to cleanup whitespace.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
Acked-by: Larry Finger
/core/rtw_pwrctrl.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
Acked-by: Larry Finger
Thanks,
Larry
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
It was recently reported that staging drivers rtl8188eu and rtl8723bs
contained a security flaw because a parameter had not been checked.
The following patches fix that flaw and cleans up the routines.
Signed-off-by: Larry Finger
Larry Finger (6):
staging: rtl8188eu: Fix potential security
eliminate the got target.
Signed-off-by: Larry Finger
Cc: Pietro Oliva
---
.../staging/rtl8723bs/os_dep/ioctl_linux.c| 47 +--
1 file changed, 12 insertions(+), 35 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
b/drivers/staging/rtl8723bs/os_dep
f216 ("0taging: Add rtl8723bs sdio wifi driver").
Signed-off-by: Larry Finger
---
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
b/drivers/staging/rtl8723bs/os_dep/ioc
eliminate the got target.
Signed-off-by: Larry Finger
Cc: Pietro Oliva
---
.../staging/rtl8188eu/os_dep/ioctl_linux.c| 40 ++-
1 file changed, 12 insertions(+), 28 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
b/drivers/staging/rtl8188eu/os_dep
commit 554c0a3abf216 ("staging: Add rtl8723bs sdio wifi driver").
Reported by: Pietro Oliva
Cc: Pietro Oliva
Cc: Stable
Fixes: 554c0a3abf216 ("staging: Add rtl8723bs sdio wifi driver").
Signed-off-by: Larry Finger
-# Please enter the commit message for your changes. Lines starting
---
commit a2c60d42d97c ("Add files for new driver - part 16").
Reported by: Pietro Oliva
Cc: Pietro Oliva
Cc: Stable
Fixes commit a2c60d42d97c ("Add files for new driver - part 16").
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 2 +-
1 file changed,
("Add files for new driver - part 16").
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
b/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
ind
The ASUS USB-N10 Nano B1 has been reported as a new RTL8188EU device.
Add it to the device tables.
Signed-off-by: Larry Finger
Reported-by: kovi
Cc: Stable
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8188eu/os_dep
t digit of the address and the NUL terminator so it was already a bit
broken.
Signed-off-by: Dan Carpenter
Nothing seems to be broken.
Acked-by: Larry Finger
Larry
diff --git a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
b/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
index de
This routine is a wrapper for _rtw_memcmp(), which is a wrapper for memcmp.
In a later change, _rtw_memcmp will be removed.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c| 4 ++--
drivers/staging/rtl8188eu/hal/odm_interface.c | 5 -
drivers/staging
This routine is never used.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/odm_interface.c | 6 --
drivers/staging/rtl8188eu/include/odm_interface.h | 2 --
2 files changed, 8 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/odm_interface.c
b/drivers/staging
1 - 100 of 621 matches
Mail list logo
