Re: [E1000-devel] [PATCH net-next] i40e: i40evf: fix error checking path

2014-03-24 Thread Jeff Kirsher
On Sun, 2014-03-23 at 14:26 -0600, Jean Sacren wrote: > The commit 6494294f277fd ("i40e/i40evf: Use > dma_set_mask_and_coherent") uses dma_set_mask_and_coherent() to > replace dma_set_coherent_mask() for the benefit of return error. > The conversion brings some confusion in error checking as whethe

Re: [E1000-devel] [PATCH net-next] intel: Remove addressof casts to same type

2014-03-24 Thread Jeff Kirsher
On Mon, 2014-03-24 at 10:45 -0700, Joe Perches wrote: > Using addressof then casting to the original type is pointless, > so remove these unnecessary casts. > > Done via coccinelle script: > > $ cat typecast.cocci > @@ > type T; > T foo; > @@ > > - (T *)&foo > + &foo > > Signed-off

Re: [E1000-devel] [PATCH net-next 3/7] intel: Remove casts of pointer to same type

2014-03-24 Thread Jeff Kirsher
On Mon, 2014-03-24 at 13:15 -0700, Joe Perches wrote: > Casting a pointer to a pointer of the same type is pointless, > so remove these unnecessary casts. > > Done via coccinelle script: > > $ cat typecast_2.cocci > @@ > type T; > T *foo; > @@ > > - (T *)foo > + foo > > Signed-off-b

[E1000-devel] [PATCH net-next 0/7] drivers/net: Remove pointer casts to same type

2014-03-24 Thread Joe Perches
All of these are pointless... Joe Perches (7): altera: Remove casts of pointer to same type alx: Remove casts of pointer to same type intel: Remove casts of pointer to same type qlcnic: Remove casts of pointer to same type carl9170: Remove casts of pointer to same type mwifiex: Remove

[E1000-devel] [PATCH net-next 3/7] intel: Remove casts of pointer to same type

2014-03-24 Thread Joe Perches
Casting a pointer to a pointer of the same type is pointless, so remove these unnecessary casts. Done via coccinelle script: $ cat typecast_2.cocci @@ type T; T *foo; @@ - (T *)foo + foo Signed-off-by: Joe Perches --- drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 4 ++-- 1 file

[E1000-devel] [PATCH net-next] intel: Remove addressof casts to same type

2014-03-24 Thread Joe Perches
Using addressof then casting to the original type is pointless, so remove these unnecessary casts. Done via coccinelle script: $ cat typecast.cocci @@ type T; T foo; @@ - (T *)&foo + &foo Signed-off-by: Joe Perches --- drivers/net/ethernet/intel/i40e/i40e_common.c | 4 ++-- dri