Re: [edk2] [RFC PATCH 0/8] small C model and LLVM/clang support for AARCH64

Ard: I review your changes in GenSec, GenFfs and GenFv tool. This change assumes there is only one section in FFS with the specific alignment. If there are more than one sections have the different alignments in single FFS, this patch may not work. For example, the first section aligns at 16 b

[edk2] [PATCH 0/2] Correct address pointers from AuthVariableLib

Star Zeng (2): MdeModulePkg VariableDxe: Correct address pointers from AuthVariableLib SecurityPkg AuthVariableLib: Correct address pointers data MdeModulePkg/Include/Library/AuthVariableLib.h| 2 +- .../Universal/Variable/RuntimeDxe/VariableDxe.c | 2 +- SecurityPkg/Libra

[edk2] [PATCH 1/2] MdeModulePkg VariableDxe: Correct address pointers from AuthVariableLib

Originally, the double pointer (VOID **) is not correct for convert address pointers from AuthVariableLib. Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng --- MdeModulePkg/Include/Library/AuthVariableLib.h | 2 +- MdeModulePkg/Universal/

[edk2] [PATCH 2/2] SecurityPkg AuthVariableLib: Correct address pointers data

Originally, the double pointer (VOID **) is not correct for convert address pointers, and also some address pointers were missing. Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng --- SecurityPkg/Library/AuthVariableLib/AuthVariableLib.c | 19 +

Re: [edk2] [PATCH 2/6] OvmfPkg: SmbiosPlatformDxe: restrict current Xen code to IA32/X64

On 07/21/15 05:55, Jordan Justen wrote: > On 2015-07-17 03:42:21, Ard Biesheuvel wrote: >> On 17 July 2015 at 12:10, Laszlo Ersek wrote: >>> On 07/17/15 08:45, Ard Biesheuvel wrote: >> [...] There is a distinction, though. The reason we could not rely on the HOB for the XenHypercall

Re: [edk2] [PATCH 2/6] OvmfPkg: SmbiosPlatformDxe: restrict current Xen code to IA32/X64

On 07/21/15 06:18, Jordan Justen wrote: > On 2015-07-17 04:11:46, Laszlo Ersek wrote: >> On 07/17/15 12:42, Ard Biesheuvel wrote: >>> On 17 July 2015 at 12:10, Laszlo Ersek wrote: On 07/17/15 08:45, Ard Biesheuvel wrote: >>> [...] > > There is a distinction, though. The reason we coul

[edk2] [PATCH v2 1/6] OvmfPkg: SmbiosPlatformDxe: move IsEntryPointStructureValid() to Xen.c

This function is only called from Xen.c, so it should be defined in Xen.c and have internal linkage (ie. STATIC). Cc: Jordan Justen Cc: Wei Liu Cc: Gabriel Somlo Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek Reviewed-by: Wei Liu Acked-by: Gabriel Somlo -

[edk2] [PATCH v2 2/6] OvmfPkg: SmbiosPlatformDxe: restrict current Xen code to IA32/X64

The Xen code in SmbiosPlatformDxe is centered on the informational HOB with GUID gEfiXenInfoGuid, and the address constants XEN_SMBIOS_PHYSICAL_ADDRESS=0x000EB000, XEN_SMBIOS_PHYSICAL_END=0x000F. This Xen hand-off mechanism is specific to the IA32 and X64 architectures, and it is very unlikely

[edk2] [PATCH v2 5/6] ArmVirtPkg: QemuFwCfgToPcdDxe: set SMBIOS entry point version dynamically

(This patch parallels OvmfPkg commit 37baf06b (SVN r17676).) PcdSmbiosVersion controls the version number of the SMBIOS entry point table (and other, related things) that the universal "MdeModulePkg/Universal/SmbiosDxe" driver, providing EFI_SMBIOS_PROTOCOL, installs. The "virt" machine type of Q

[edk2] [PATCH v2 6/6] ArmVirtPkg/ArmVirtQemu: support SMBIOS

The "MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf" driver is generic, it provides EFI_SMBIOS_PROTOCOL. The "OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.inf" driver downloads the SMBIOS payload from QEMU via fw_cfg. Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement 1.0 Sign

[edk2] [PATCH v2 3/6] MdeModulePkg: SmbiosDxe: ARM and AARCH64 are VALID_ARCHITECTURES

This driver is soon going to be built by ArmVirtPkg/ArmVirtQemu.dsc (without any changes). Although VALID_ARCHITECTURES is not used by the build system (it is just a comment), it is best kept up-to-date for human readers' sake. Cc: Feng Tian Cc: Elvin Li Cc: Star Zeng Contributed-under: TianoCo

[edk2] [PATCH v2 0/6] ArmVirtPkg/ArmVirtQemu: support SMBIOS

Version 2 of . Only patch #2 has been changed, implementing Jordan's suggestions. Public branch: . Cc: Ard Biesheuvel Cc: Wei Huang Cc: Jordan Justen Cc: Wei Liu C

[edk2] [PATCH v2 4/6] ArmVirtPkg: add QemuFwCfgToPcdDxe

Many universal DXE drivers in edk2 can be controlled by setting dynamic PCDs. Such a PCD must be set before the consumer DXE driver is dispatched. (In general we assume that the DXE driver will consume the PCD in its entry point, or in the constructor of a library instance it links against. In spe

Re: [edk2] [PATCH 2/2] SecurityPkg AuthVariableLib: Correct address pointers data

Indeed, this bug breaks the installation of Windows 8.1 guests on top of OVMF. (The installer crashes while copying files.) Alex (Cc'd) reported this to me in private. I bisected the issue to the variable driver unification patches, and then found this new series on the list. One comment below:

[edk2] [PATCH 0/7] Add missing PCD usage information in UNI and DEC files.

When PCD defined in DEC file, PCD Help/Prompt information must be provided. PCD Help and Prompt string is required in Package DEC and Package UNI file. PCD Valid Range is optional. If specified, its format should be valid. Qiu Shumin (7): MdePkg: Add missing PCD usage information in UNI files.

[edk2] [PATCH 1/7] MdePkg: Add missing PCD usage information in UNI files.

Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin --- MdePkg/MdePkg.uni | Bin 66564 -> 69572 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/MdePkg/MdePkg.uni b/MdePkg/MdePkg.uni index 893e62c2663a6385e62920d51f24aa11b1758a8e.

[edk2] [PATCH 2/7] MdeModulePkg: Add missing PCD usage information in UNI and DEC files.

Cc: Feng Tian Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin --- MdeModulePkg/MdeModulePkg.dec | 3 +++ MdeModulePkg/MdeModulePkg.uni | Bin 166792 -> 178978 bytes 2 files changed, 3 insertions(+) diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/Md

[edk2] [PATCH 4/7] NetworkPkg: Add missing PCD usage information in UNI and DEC files.

Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin Signed-off-by: Zhang Lubo --- NetworkPkg/NetworkPkg.dec | 1 + NetworkPkg/NetworkPkg.uni | Bin 6182 -> 7948 bytes 2 files changed, 1 insertion(+) diff --git a/NetworkPkg/NetworkPkg.

[edk2] [PATCH 3/7] IntelFrameworkModulePkg: Add missing PCD usage information in UNI and DEC files.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin Signed-off-by: Jeff Fan --- IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec | 4 IntelFrameworkModulePkg/IntelFrameworkModulePkg.uni | Bin 33748 -> 37454 bytes 2 files changed, 4 insertions(+) diff --g

[edk2] [PATCH 5/7] SecurityPkg: Add missing PCD usage information in UNI files.

Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin --- SecurityPkg/SecurityPkg.uni | Bin 35774 -> 37742 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/SecurityPkg/SecurityPkg.uni b/SecurityPkg/SecurityPkg.uni index 0a13827c8d7e

Re: [edk2] [RFC PATCH 0/8] small C model and LLVM/clang support for AARCH64

On 21 July 2015 at 10:39, Gao, Liming wrote: > Ard: > I review your changes in GenSec, GenFfs and GenFv tool. This change assumes > there is only one section in FFS with the specific alignment. If there are > more than one sections have the different alignments in single FFS, this > patch may

[edk2] [PATCH 7/7] SourceLevelDebugPkg: Add missing PCD usage information in UNI files.

Cc Jeff Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin --- SourceLevelDebugPkg/SourceLevelDebugPkg.uni | Bin 12228 -> 17346 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/SourceLevelDebugPkg/SourceLevelDebugPkg.uni b/SourceLevelDebugP

[edk2] [PATCH 6/7] UefiCpuPkg: Add missing PCD usage information in UNI files.

Cc Jeff Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin --- UefiCpuPkg/UefiCpuPkg.uni | Bin 3320 -> 6586 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/UefiCpuPkg/UefiCpuPkg.uni b/UefiCpuPkg/UefiCpuPkg.uni index db624f3bc545ec7daf9fae1

Re: [edk2] [PATCH 2/2] SecurityPkg AuthVariableLib: Correct address pointers data

Good comments and sure to add (VOID **) cast. Thanks for your Tested-by. Thanks, Star -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, July 21, 2015 8:39 PM To: Zeng, Star; edk2-de...@ml01.01.org Cc: Yao, Jiewen; Alex Williamson Subject: Re: [edk2] [PATCH 2/

Re: [edk2] [PATCH v2 3/6] MdeModulePkg: SmbiosDxe: ARM and AARCH64 are VALID_ARCHITECTURES

Reviewed-by: Feng Tian -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Tuesday, July 21, 2015 7:10 PM To: edk2-de...@ml01.01.org Cc: Tian, Feng; Elvin Li; Zeng, Star Subject: [edk2] [PATCH v2 3/6] MdeModulePkg: SmbiosDxe: ARM a

Re: [edk2] [PATCH v2 1/6] OvmfPkg: SmbiosPlatformDxe: move IsEntryPointStructureValid() to Xen.c

1-3 Reviewed-by: Jordan Justen On 2015-07-21 04:10:10, Laszlo Ersek wrote: > This function is only called from Xen.c, so it should be defined in Xen.c > and have internal linkage (ie. STATIC). > > Cc: Jordan Justen > Cc: Wei Liu > Cc: Gabriel Somlo > Contributed-under: TianoCore Contribution

Re: [edk2] [PATCH 2/6] OvmfPkg: SmbiosPlatformDxe: restrict current Xen code to IA32/X64

On 2015-07-21 02:40:33, Laszlo Ersek wrote: > On 07/21/15 06:18, Jordan Justen wrote: > > On 2015-07-17 04:11:46, Laszlo Ersek wrote: > >> Guys, let's wrap this up. Just tell me what you want to see. I don't > >> care any longer about the specifics. It's incredible that I can't submit > >> a trivia

[edk2] question about filter driver for BlockIo protocol

Hi, I just implemented an UEFI filter driver for the BlockIO protocol. The intention of this driver is to provide an encryption/decryption driver for a block device (disk partition). I followed the hints as given in this thread: http://comments.gmane.org/gmane.comp.bios.tianocore.devel/2003 Unfort

[edk2] Simple text protocol- Help

Hi, I am facing an issue while installing the Simple text protocol (or) Simple text ex protocol outside the "DriverBindingStart" routine? The API "InstallMultipleProtocolInterfaces" succeeds but there is no call to the "WaitForKey" Event routine. Any idea what could be the cause? (Or) it is ma

Re: [edk2] Simple text protocol- Help

> On Jul 21, 2015, at 5:28 PM, Saiprasad Chavali wrote: > > Hi, > > I am facing an issue while installing the Simple text protocol (or) Simple > text ex protocol outside the "DriverBindingStart" routine? The API > "InstallMultipleProtocolInterfaces" succeeds but there is no call to the > "Wa

Re: [edk2] [PATCH 2/2] SecurityPkg AuthVariableLib: Correct address pointers data

Reviewed by: Yao, Jiewen -Original Message- From: Zeng, Star Sent: Tuesday, July 21, 2015 5:02 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen Subject: [PATCH 2/2] SecurityPkg AuthVariableLib: Correct address pointers data Originally, the double pointer (VOID **) is not correct for conve

Re: [edk2] Simple text protocol- Help

Hi Andrew, I do install the device path protocol. What I am trying is, to install the Text Protocol Interface at later stage rather during Start routine. The Question I have is "WaitForKey" is triggered when I call during start routine, not at a later stage. So wondering all has to be initializ

Re: [edk2] Simple text protocol- Help

In case you are using events for registering your callback. make sure your TPL levels are at correct levels. pBS->CreateEvent( EVT_NOTIFY_WAIT, TPL_NOTIFY, YOUR_FUNCTION Context, &WaitForKey); VOID YOUR_FUNCTION( EFI_EVENT Event, VOID*Con

Re: [edk2] Simple text protocol- Help

> On Jul 21, 2015, at 5:52 PM, Saiprasad Chavali wrote: > > Hi Andrew, > > I do install the device path protocol. What I am trying is, to install the > Text Protocol Interface at later stage rather during Start routine. > That does not make any sense. The Start() routine is called vary late

Re: [edk2] Simple text protocol- Help

> On Jul 21, 2015, at 6:06 PM, Neeraj Ladkani wrote: > > In case you are using events for registering your callback. make sure your > TPL levels are at correct levels. > > pBS->CreateEvent( > EVT_NOTIFY_WAIT, > TPL_NOTIFY, > YOUR_FUNCTION > Context, > &

Re: [edk2] [PATCH 1/7] MdePkg: Add missing PCD usage information in UNI files.

Reviewed-by: Liming Gao -Original Message- From: Qiu, Shumin Sent: Tuesday, July 21, 2015 8:50 PM To: edk2-devel@lists.01.org Cc: Qiu, Shumin; Gao, Liming Subject: [PATCH 1/7] MdePkg: Add missing PCD usage information in UNI files. Cc: Liming Gao Contributed-under: TianoCore Contributi

Re: [edk2] Simple text protocol- Help

Thanks Andrew, sorry to say this I am not confused, as well understood the role of events. (OR) I am not properly communicating,. 1) Installing the driver as a standalone, not attached to any device. 2) Installed the app protocol interface for an app to call the custom routines defin

Re: [edk2] Simple text protocol- Help

Hi Neeraj, Thanks for the response, sure I have covered all the cases. As mentioned in my previous mail, the code works fine if I call from Driver start routine. And fails if I call it from a custom routine, so understanding the behavior, if at all any difference in the execution path. Sai --

Re: [edk2] Simple text protocol- Help

> On Jul 21, 2015, at 6:29 PM, Saiprasad Chavali wrote: > > Thanks Andrew, sorry to say this I am not confused, as well understood the > role of events. > (OR) I am not properly communicating,. > > 1) Installing the driver as a standalone, not attached to any device. What is the diffe

Re: [edk2] Simple text protocol- Help

Comments Inline >>> From: Andrew Fish [mailto:af...@apple.com] Sent: Tuesday, July 21, 2015 6:49 PM To: Saiprasad Chavali Cc: edk2-de...@ml01.01.org Subject: Re: [edk2] Simple text protocol- Help On Jul 21, 2015, at 6:29 PM, Saiprasad Chavali mailto:s...@marvell.com>> wrote: Thanks Andrew, sor

Re: [edk2] Simple text protocol- Help

I forgot to add, I have this USB device added to the “BdsLibUpdateConsoleVariable” of PlatformBdsInit() function, which I believe is what you have mentioned, to bind the device by the splitter driver. Thanks Sai From: Andrew Fish [mailto:af...@apple.com] Sent: Tuesday, July 21, 2015 6:49 PM To:

Re: [edk2] Simple text protocol- Help

> On Jul 21, 2015, at 6:59 PM, Saiprasad Chavali wrote: > > Comments Inline >>> > > From: Andrew Fish [mailto:af...@apple.com ] > Sent: Tuesday, July 21, 2015 6:49 PM > To: Saiprasad Chavali > Cc: edk2-de...@ml01.01.org > Subject: Re: [e

Re: [edk2] [Patch v3] NetworkPkg: Add old IPv4_DEVICE_PATH and IPv6_DEVICE_PATH support

Reviewed-by: Ye Ting -Original Message- From: Wang, Fan Sent: Wednesday, July 22, 2015 8:57 AM To: Ye, Ting; Fu, Siyuan; Wu, Jiaxin; edk2-de...@lists.sourceforge.net; edk2-devel@lists.01.org Cc: Tian, Hot; Ni, Ruiyu Subject: [Patch v3] NetworkPkg: Add old IPv4_DEVICE_PATH and IPv6_DEVI

Re: [edk2] [Patch v3] MdeModulePkg: Add old IPv4_DEVICE_PATH support for new IScsiDxe

Reviewed-by: Ye Ting -Original Message- From: Wang, Fan Sent: Wednesday, July 22, 2015 8:58 AM To: Ye, Ting; Fu, Siyuan; Wu, Jiaxin; edk2-de...@lists.sourceforge.net; edk2-devel@lists.01.org Cc: Tian, Hot; Ni, Ruiyu Subject: [Patch v3] MdeModulePkg: Add old IPv4_DEVICE_PATH support for

Re: [edk2] Simple text protocol- Help

Hi Andrew, Looks like you haven’t understood what I am trying here? Questions: 1) Can I install my own custom protocol on to the Dxe driver handle under test ? Yes or No 2) If Yes, to point 1) Can the custom protocol define routines? Yes or No. 3) If yes to both (1 & 2) , can I

[edk2] [PATCH] Make AutoGen.h array declaration match AutoGen.c definition

When a quoted string is used as initialization data in a DEC file PCD entry, the PCD data type in that entry must be VOID*. The created AutoGen.c defines the PCD data as UINT8[] or UINT16[], depending on the string type. The created AutoGen.h, however, declares the PCD data as VOID*. For a standard

Re: [edk2] [PATCH] Make AutoGen.h array declaration match AutoGen.c definition

Reviewed-by: Yingke Liu Dennis -Original Message- From: Scott Duplichan [mailto:sc...@notabs.org] Sent: Wednesday, July 22, 2015 11:05 To: edk2-devel@lists.01.org Cc: Liu, Yingke D; Gao, Liming; 'Laszlo Ersek' Subject: [PATCH] Make AutoGen.h array declaration match AutoGen.c definition

Re: [edk2] Simple text protocol- Help

> On Jul 21, 2015, at 7:28 PM, Saiprasad Chavali wrote: > > Hi Andrew, > > Looks like you haven’t understood what I am trying here? > Sorry you are not using all the terminology correctly so it is hard to answer the questions. > Questions: > 1) Can I install my own custom protocol o