[edk2] [patch] MdeModulePkg/Xhci: make all timeout values be consistent with comments.

2015-08-16 Thread Tian Feng
In the original code, there exists some mismatches between the real waiting time and the corresponding timeout comments. For example, the XHC_GENERIC_TIMEOUT comment says it's 10ms timeout value, but the real code in fact waits 10s. So the code is refined and XHC_POLL_DELAY macro also be removed t

[edk2] PCI driver issue

2015-08-16 Thread Leekha Shaveta
Hi, I was trying to run network using PCI. Have written PCI hostBridge driver for my controller, using PCI bus driver from MdeModulePkg(as it is). PCI NIC card I am using is from Intel, and I have picked its driver from Intel's source. But after integrating it in UEFI, I am facing issues.

Re: [edk2] Help debugging PEIM on Minnowboard Max

2015-08-16 Thread Tian, Feng
Do you look into the UsbController.h in MdeModulePkg/Include/Ppi directory? typedef EFI_STATUS (EFIAPI *PEI_GET_USB_CONTROLLER)( IN EFI_PEI_SERVICES**PeiServices, IN PEI_USB_CONTROLLER_PPI *This, IN UINT8 UsbControllerId, OUT UINTN *Controlle

Re: [edk2] [patch] Add context check and init in BaseCrypto2Hash().

2015-08-16 Thread Zhang, Chao B
It is good to me. Reviewed-by: Chao Zhang Thanks & Best regards Chao Zhang -Original Message- From: Yao, Jiewen Sent: Monday, August 17, 2015 11:44 AM To: edk2-devel@lists.01.org Cc: Yao, Jiewen; Zhang, Chao B Subject: [patch] Add context check and init in BaseCrypto2Hash(). Follo

Re: [edk2] [PATCH v2] MdeModulePkg: IP4 should re-initiate a DHCP while network reconnection

2015-08-16 Thread Zhang, Lubo
The patch looks good. Reviewed-by: Lubo Zhang < lubo.zh...@intel.com > -Original Message- From: Wu, Jiaxin Sent: Monday, August 17, 2015 11:25 AM To: edk2-devel@lists.01.org Cc: Ye, Ting; Zhang, Lubo Subject: [PATCH v2] MdeModulePkg: IP4 should re-initiate a DHCP while network reconnecti

Re: [edk2] Help debugging PEIM on Minnowboard Max

2015-08-16 Thread Eric Wittmayer
Hi Feng, I see now that XhciPei needs gPeiUsbControllerPpiGuid and creates gPeiUsbHostControllerPpiGuid which UsbBusPei needs. I can't seem to figure out what creates gPeiUsbControllerPpiGuid? I see it listed in the .dec file I'm using but that apparently isn't enough to install the Ppi. Wh

[edk2] [patch] Add context check and init in BaseCrypto2Hash().

2015-08-16 Thread jiewen yao
Follow UEFI specification to add context check and init in BaseCrypto2Hash(), so that other function can get proper status on hash operation. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: "Yao, Jiewen" Cc: "Zhang, Chao B" --- SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c

[edk2] [PATCH v2] MdeModulePkg: IP4 should re-initiate a DHCP while network reconnection

2015-08-16 Thread Jiaxin Wu
v2: * Update the MediaPresent detect declaring. IP4 driver should re-initiate a DHCP if it detects that there is a network reconnection. To fix this issue, we can implement the DHCP re-initiate policy while the media change detected. The Ip4 driver should set a timer to signal the Ip4 to run the

Re: [edk2] [patch] SecurityPkg: Fixed build error due to FixedAtBuild PcdTcg2HashAlgorithmBitmap

2015-08-16 Thread Yao, Jiewen
HI Samer Yes, I can, if you can attach you patch. I think it is good idea, but I have not seen your patch yet. Thank you Yao Jiewen From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hp.com] Sent: Saturday, August 15, 2015 7:45 PM To: edk2-devel@lists.01.org; Yao, Jiewen Cc: Zhang, Chao B;

Re: [edk2] [PATCH] SecurityPkg: Update SignatureSize to comply UEFI spec

2015-08-16 Thread Long, Qin
Looks good. Reviewed-by: Qin Long < qin.l...@intel.com> Best Regards & Thanks, LONG, Qin > -Original Message- > From: Zhang, Chao B > Sent: Monday, August 17, 2015 10:01 AM > To: edk2-devel@lists.01.org > Cc: Long, Qin; Zhang, Chao B > Subject: [PATCH] SecurityPkg: Update SignatureSize

Re: [edk2] [PATCH 1/2] NetworkPkg: Remove the hostname for the http request url

2015-08-16 Thread Ye, Ting
I checked RFC7230 and agreed we need use the origin-form of URI instead of using absolute-form. Thanks for fixing this. Reviewed-by: Ye Ting -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Gary Ching-Pang Lin Sent: Friday, August 14, 2015 5:04

Re: [edk2] [PATCH 0/2] Add HttpBoot support to OvmfPkg

2015-08-16 Thread Gary Ching-Pang Lin
On Fri, Aug 14, 2015 at 07:58:31AM -0700, Blibbet wrote: > > On 08/14/2015 02:03 AM, Gary Ching-Pang Lin wrote: > > Although the current HttpBoot implementation is incomplete, it would be > > easier to develop and test the software stack with a virtual machine. > > THANKS for adding to OVMF! > >

[edk2] [PATCH] SecurityPkg: Update SignatureSize to comply UEFI spec

2015-08-16 Thread Zhang, Chao B
Update SignatureSize to include SignatureOwner GUID. This behavior is defined by UEFI spec Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Chao Zhang --- SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificationLib.c | 2 +- 1 file changed, 1 insertion(+), 1 deleti

Re: [edk2] Help debugging PEIM on Minnowboard Max

2015-08-16 Thread Tian, Feng
Eric, I must agree the naming of these usb pei related ppi guids are not good, which misleads you. There is no the chicken and egg problem. gPeiUsbHostControllerPpiGuid and gPeiUsbControllerPpiGuid are two different ppis. The former is consumed by UsbPei and the latter is consumed by XhciPei.

Re: [edk2] [patch] Fix typo in BaseCrypto2HashInit() which causes sanity check incorrect.

2015-08-16 Thread Zhang, Chao B
The patch is good to me Reviewed-by: Chao Zhang Thanks & Best regards Chao Zhang -Original Message- From: Yao, Jiewen Sent: Saturday, August 15, 2015 6:59 AM To: edk2-devel@lists.01.org Cc: Yao, Jiewen; Zhang, Chao B Subject: [patch] Fix typo in BaseCrypto2HashInit() which causes sa

Re: [edk2] [PATCH 00/15] unify GCC command line options

2015-08-16 Thread Scott Duplichan
]Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] wrote: . . . ]> Thanks for this much needed tool chain definition consolidation. I ran ]> a build test with and without the patch. The build test uses GCC44-49 ]> and Microsoft tool chains. Log files are here: http://notabs.org/uefi/tmp/. ] ]Tha

Re: [edk2] [PATCH 00/15] unify GCC command line options

2015-08-16 Thread Ard Biesheuvel
On 15 August 2015 at 22:43, Scott Duplichan wrote: > Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] wrote: > > ]Sent: Friday, August 14, 2015 02:15 PM > ]To: edk2-de...@ml01.01.org; yingke.d@intel.com > ]Cc: wp...@windriver.com; sc...@notabs.org; Ard Biesheuvel > ; jordan.l.jus...@intel.co

Re: [edk2] DXE loading order

2015-08-16 Thread Michael Zimmermann
nvm. I had some problems with the TerminalDxe configuration. On Sun, Aug 16, 2015 at 8:34 AM, Michael Zimmermann < sigmaepsilo...@gmail.com> wrote: > I've enabled both SimpleTextInOutSerial and ConPlatformDxe on my device > but it seems like ConPlatformDxe doesn't get notified about the binding o