Re: [edk2] [PATCH] MdeModulePkg: Make the BmFindLoadOption function public

2015-10-12 Thread Wang, Sunny (HPS SW)
Hi Ruiyu, Thanks for the quick response. It is because of that we need to do same thing as what BmFindLoadOption function did in our PlatformBootManagerLib to check/find specific boot option from the boot options array which is got from EfiBootManagerGetLoadOptions function. I also think

Re: [edk2] Cross compiling EDK2 for Aarch64

2015-10-12 Thread Ard Biesheuvel
On 11 October 2015 at 09:34, Yehuda Yitschak wrote: > Hi Laszlo > >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Thursday, October 08, 2015 22:21 >> To: Yehuda Yitschak >> Cc: edk2-devel@lists.01.org; leif.lindh...@linaro.org >>

Re: [edk2] [PATCH] MdeModulePkg: Make the BmFindLoadOption function public

2015-10-12 Thread Ni, Ruiyu
Sunny, Why do you want to expose this function? Bm* needs to change to EfiBootManager* if it's public. Thanks, Ray -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Sunny Wang Sent: Monday, October 12, 2015 3:15 PM To: edk2-devel@lists.01.org

Re: [edk2] Cross compiling EDK2 for Aarch64

2015-10-12 Thread Leif Lindholm
On Mon, Oct 12, 2015 at 08:50:53AM +, Yehuda Yitschak wrote: > Thanks. It worked fine. > I assumed the linaro-edk2 GIT should be more up to date with ARM > fixes but I think this is not the case here. No, that will never be the case - we work upstream, so fixes only go into linaro-edk2 after

Re: [edk2] [PATCH 6/7] UefiCpiPkg: Add PiSmmCpuDxeSmm module

2015-10-12 Thread Paolo Bonzini
On 05/10/2015 01:57, Michael Kinney wrote: > Add module that initializes a CPU for the SMM envirnment and > installs the first level SMI handler. This module along with the > SMM IPL and SMM Core provide the services required for > DXE_SMM_DRIVERS to register hardware and software SMI handlers.

Re: [edk2] [PATCH] BaseTools/Scripts: Add PatchCheck.py script

2015-10-12 Thread Bjorge, Erik C
I think it may have been outlook messing with me when applying the patch. The whitespace notice was about some of the copyright lines. I will pull from your public repo/branch and see if I have the same issue. Thanks, -Erik -Original Message- From: Justen, Jordan L Sent: Friday,

Re: [edk2] [PATCH] MdeModulePkg: Make the BmFindLoadOption function public

2015-10-12 Thread El-Haj-Mahmoud, Samer
Reviewed-by: Samer El-Haj-Mahmoud -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Wang, Sunny (HPS SW) Sent: Monday, October 12, 2015 2:15 AM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH] MdeModulePkg: Make the

Re: [edk2] [Patch] BaseTools: Fixed an error reported during generating report

2015-10-12 Thread Laszlo Ersek
On 10/12/15 04:39, Gao, Liming wrote: > Reviewed-by: Liming Gao Let's hope my comment arrives before this gets committed -- Yonghong, can you please state specific details in the subject and/or the body of the commit message? What is the error? What circumstances trigger

Re: [edk2] [PATCH] MdeModulePkg: Make the BmFindLoadOption function public

2015-10-12 Thread Laszlo Ersek
On 10/12/15 09:45, Wang, Sunny (HPS SW) wrote: > Hi Ruiyu, > > Thanks for the quick response. > It is because of that we need to do same thing as what > BmFindLoadOption function did in our PlatformBootManagerLib to > check/find specific boot option from the boot options array which is >

Re: [edk2] [PATCH] MdeModulePkg: Make the BmFindLoadOption function public

2015-10-12 Thread Ni, Ruiyu
Sunny, Your bitmask idea works. But I think it might introduce unnecessary complexity. Keeping current implementation is good enough I think. Thanks, Ray -Original Message- From: Wang, Sunny (HPS SW) [mailto:sunnyw...@hpe.com] Sent: Tuesday, October 13, 2015 12:15 PM To: Ni, Ruiyu