[edk2] [PATCH] MdeModulePkg: Add NULL pointer check for RegularExpressionDxe.

2015-12-13 Thread Qiu Shumin
Refine code by adding NULL pointer check to avoid potential NULL pointer dereferenced. Cc: Eric Dong Cc: Feng Tian Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin --- .../RegularExpressionDxe/Oniguruma/enc/unicode.c | 2 +- .../Universal/RegularExpr

Re: [edk2] [PATCH] MdeModulePkg: Add NULL pointer check for RegularExpressionDxe.

2015-12-13 Thread El-Haj-Mahmoud, Samer
Reviewed-by: Samer El-Haj-Mahmoud -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Qiu Shumin Sent: Sunday, December 13, 2015 7:46 AM To: edk2-devel@lists.01.org Cc: Feng Tian ; Qiu Shumin ; Eric Dong Subject: [edk2] [PATCH] MdeModulePkg: Add N

Re: [edk2] [PATCH] Add QuarkSocPkg and QuarkPlatformPkg packages

2015-12-13 Thread Kinney, Michael D
Jordan, I have updated to Quark_V3 that uses this concept along with a proposed edk2-non-osi repository with a new QuarkSocBinPkg. It uses PACKAGES_PATH to support the multiple repositories to do a build. The content is posted for review on GitHub. The QuarkSocPkg and QuarkPlatformPkg are i

Re: [edk2] [Patch] NetworkPkg: Enlarge the TCP send/receive buffer in HTTP driver.

2015-12-13 Thread Wu, Jiaxin
Looks good. Reviewed-by: Jiaxin Wu -Original Message- From: Fu, Siyuan Sent: Friday, December 11, 2015 10:41 AM To: edk2-de...@ml01.01.org Cc: Zhang, Lubo; Wu, Jiaxin Subject: [Patch] NetworkPkg: Enlarge the TCP send/receive buffer in HTTP driver. This patch enlarges the TCP send/rece

Re: [edk2] [patch] MdeModulePkg: add clarification for PcdAcpiDefault value PCD.

2015-12-13 Thread Zeng, Star
On 2015/12/11 9:41, jiewen yao wrote: Add clarification for PcdAcpiDefaultOemTableId, PcdAcpiDefaultOemRevision, PcdAcpiDefaultCreatorId, PcdAcpiDefaultCreatorRevision. According to ACPI spec, they are used as special meaning for SSDT, so we ignore them in updating generic SSDT provided by EDKII.

Re: [edk2] [Patch] NetworkPkg: Remove a CopyMem to speed up the HTTP boot download.

2015-12-13 Thread Wu, Jiaxin
Looks good. Reviewed-by: Jiaxin Wu -Original Message- From: Fu, Siyuan Sent: Friday, December 11, 2015 10:17 AM To: edk2-de...@ml01.01.org Cc: Zhang, Lubo; Wu, Jiaxin Subject: [Patch] NetworkPkg: Remove a CopyMem to speed up the HTTP boot download. This patch updates the HTTP boot dr

Re: [edk2] [patch] MdeModulePkg: add clarification for PcdAcpiDefault value PCD.

2015-12-13 Thread Zeng, Star
On 2015/12/14 8:59, Zeng, Star wrote: On 2015/12/11 9:41, jiewen yao wrote: Add clarification for PcdAcpiDefaultOemTableId, PcdAcpiDefaultOemRevision, PcdAcpiDefaultCreatorId, PcdAcpiDefaultCreatorRevision. According to ACPI spec, they are used as special meaning for SSDT, so we ignore them in u

Re: [edk2] [BaseTool][UPT][ECC]Fix a bug to ignore the lib ins defined in [components] section but also listed in SkipDir

2015-12-13 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Chen, Hesheng Sent: Tuesday, December 08, 2015 10:34 AM To: Zhu, Yonghong; edk2-devel@lists.01.org Subject: [BaseTool][UPT][ECC]Fix a bug to ignore the lib ins defined in [components] section but also listed

[edk2] [PATCH] MdeModulePkg UfsPassThru: ASSERT if params are NULL in SignalCallerEvent

2015-12-13 Thread Hao Wu
In function SignalCallerEvent(), 'Private' and 'TransReq' are dereferenced before NULL checking. Since the function assumes that both 'Private' and 'TransReq' passed in are not NULL pointer, this commit will add an ASSERT to make sure the above assumption is satisfied. Contributed-under: TianoCor

Re: [edk2] [patch] MdeModulePkg: add clarification for PcdAcpiDefault value PCD.

2015-12-13 Thread Yao, Jiewen
Yes. Thanks for the reminder. -Original Message- From: Zeng, Star Sent: Monday, December 14, 2015 9:38 AM To: Yao, Jiewen; edk2-devel@lists.01.org Subject: Re: [edk2] [patch] MdeModulePkg: add clarification for PcdAcpiDefault value PCD. On 2015/12/14 8:59, Zeng, Star wrote: > On 2015/12

Re: [edk2] [Patch] MdePkg/BaseIoLibIntrinsic: Add EBC support

2015-12-13 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Kinney, Michael D Sent: Sunday, December 13, 2015 5:37 AM To: edk2-devel@lists.01.org Cc: Gao, Liming; Ni, Ruiyu Subject: [Patch] MdePkg/BaseIoLibIntrinsic: Add EBC support The EBC instruction set supports memory and MMIO access, but not

[edk2] [Patch 3/6] UefiCpuPkg/CpuMpPei: Prepare for monitor buffer

2015-12-13 Thread Jeff Fan
Get AP loop mode to prepare for the monitor buffer required for ApInMwaitLoop and ApInRunLoop. Contributed-under: TianoCore Contribution Agreement 1.0 Cc: Feng Tian Cc: Michael Kinney Cc: Jordan Justen Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan --- UefiCpu

[edk2] [Patch 0/6] Support the different AP loop mode

2015-12-13 Thread Jeff Fan
Support 3 AP loop modes: A: Place AP in the Hlt-Loop state. B: Place AP in the Mwait-Loop state. C: Place AP in the Run-Loop state. Jeff Fan (6): UefiCpuPkg: Add PCD PcdCpuApLoopMode UefiCpuPkg/CpuMpPei: Add GetApLoopMode() to get AP loop mode UefiCpuPkg/CpuMpPei: Prepare for monitor buffer

[edk2] [Patch 2/6] UefiCpuPkg/CpuMpPei: Add GetApLoopMode() to get AP loop mode

2015-12-13 Thread Jeff Fan
Add GetApLoopMode() that will get PCD PcdCpuApLoopMode firstly. If it is ApInMwaitLoop, we will check if MONITOR/MWAIT feature supported by CPUID. If MONITOR/MWAIT feature is not supported, force AP loop mode to ApInHltLoop. GetApLoopMode() also return the maximum C-state supported by processor an

[edk2] [Patch 1/6] UefiCpuPkg: Add PCD PcdCpuApLoopMode

2015-12-13 Thread Jeff Fan
This new PCD is used to specify the AP loop mode during POST phase. The value 1 means we will place AP in the Hlt-Loop state by HLT instruction. BSP need to send INIT-SIPI-SIPI to wake up APs. The value 2 means we will place AP in the deepest C-state by MWAIT instruction. BSP need to modify the m

[edk2] [Patch 5/6] UefiCpuPkg/CpuMpPei: Wake up APs by proper method

2015-12-13 Thread Jeff Fan
If ApLoopMode is ApInHltLoop, BSP will send INIT-SIPI-SIPI to wake up APs. If ApLoopMode is ApInMwaitLoop or ApInRunLoop, BSP will write one semaphore to wake up APs. Contributed-under: TianoCore Contribution Agreement 1.0 Cc: Feng Tian Cc: Michael Kinney Cc: Jordan Justen Contributed-under: Ti

[edk2] [Patch 6/6] UefiCpuPkg/CpuMpPei: Remove un-used AsmCliHltLoop()

2015-12-13 Thread Jeff Fan
Contributed-under: TianoCore Contribution Agreement 1.0 Cc: Feng Tian Cc: Michael Kinney Cc: Jordan Justen Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan --- UefiCpuPkg/CpuMpPei/CpuMpPei.h| 10 -- UefiCpuPkg/CpuMpPei/Ia32/MpFuncs.asm | 6 -

[edk2] [Patch 4/6] UefiCpuPkg/CpuMpPei: Place APs in proper loop mode after AP execution

2015-12-13 Thread Jeff Fan
After AP function is executed, we will place AP in proper loop mode. Because AP maybe waken up by SMI or other reasons. We need to read signature in monitor buffer to check if APs is waken up by BSP. If it is not waken up by BSP, we will continue to place them into proper loop mode. Contributed-un

Re: [edk2] [PATCH v2 16/20] SecurityPkg: Convert all .uni files to utf-8

2015-12-13 Thread Jordan Justen
Mike Kinney gave a Review-by for this series. Are you okay if I commit this patch to SecurityPkg with his Reviewed-by? Thanks, -Jordan On 2015-12-04 12:13:37, Jordan Justen wrote: > To convert these files I ran: > > $ python3 BaseTools/Scripts/ConvertUni.py SecurityPkg > > Cc: Chao Zhang > Co

Re: [edk2] [PATCH v2 16/20] SecurityPkg: Convert all .uni files to utf-8

2015-12-13 Thread Zhang, Chao B
Jordan: The patch is good to me. Reviewed-by: Chao Zhang Thanks & Best regards Chao Zhang -Original Message- From: Justen, Jordan L Sent: Monday, December 14, 2015 10:31 AM To: edk2-devel@lists.01.org Cc: Zhang, Chao B Subject: Re: [PATCH v2 16/20] SecurityPkg: Convert all .uni f

Re: [edk2] [PATCH v2 13/20] Nt32Pkg: Convert all .uni files to utf-8

2015-12-13 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni -Original Message- From: Justen, Jordan L Sent: Saturday, December 5, 2015 4:14 AM To: edk2-devel@lists.01.org Cc: Justen, Jordan L ; Ni, Ruiyu Subject: [PATCH v2 13/20] Nt32Pkg: Convert all .uni files to utf-8 To convert these files I ran: $ python3 BaseTools/S

Re: [edk2] [PATCH v2 08/20] IntelFrameworkModulePkg: Convert all .uni files to utf-8

2015-12-13 Thread Fan, Jeff
Reviewed-by: Jeff Fan -Original Message- From: Justen, Jordan L Sent: Saturday, December 05, 2015 4:13 AM To: edk2-devel@lists.01.org Cc: Justen, Jordan L; Fan, Jeff Subject: [PATCH v2 08/20] IntelFrameworkModulePkg: Convert all .uni files to utf-8 To convert these files I ran: $ pyth

Re: [edk2] [PATCH v2 18/20] SourceLevelDebugPkg: Convert all .uni files to utf-8

2015-12-13 Thread Fan, Jeff
Reviewed-by: Jeff Fan -Original Message- From: Justen, Jordan L Sent: Saturday, December 05, 2015 4:14 AM To: edk2-devel@lists.01.org Cc: Justen, Jordan L; Fan, Jeff Subject: [PATCH v2 18/20] SourceLevelDebugPkg: Convert all .uni files to utf-8 To convert these files I ran: $ python3 B

Re: [edk2] [PATCH v2 19/20] UefiCpuPkg: Convert all .uni files to utf-8

2015-12-13 Thread Fan, Jeff
Reviewed-by: Jeff Fan -Original Message- From: Justen, Jordan L Sent: Saturday, December 05, 2015 4:14 AM To: edk2-devel@lists.01.org Cc: Justen, Jordan L; Fan, Jeff Subject: [PATCH v2 19/20] UefiCpuPkg: Convert all .uni files to utf-8 To convert these files I ran: $ python3 BaseTools/

Re: [edk2] [PATCH v2 09/20] IntelFrameworkPkg: Convert all .uni files to utf-8

2015-12-13 Thread Fan, Jeff
Reviewed-by: Jeff Fan -Original Message- From: Justen, Jordan L Sent: Saturday, December 05, 2015 4:13 AM To: edk2-devel@lists.01.org Cc: Justen, Jordan L; Kinney, Michael D; Fan, Jeff Subject: [PATCH v2 09/20] IntelFrameworkPkg: Convert all .uni files to utf-8 To convert these files I

Re: [edk2] [Patch] MdeModulePkg/PciSioSerialDxe: Fix compiler warnings

2015-12-13 Thread Tian, Feng
On behalf of Ray, Reviewed-by: Feng Tian I will help commit it. Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Michael Kinney Sent: Sunday, December 13, 2015 04:33 To: edk2-devel@lists.01.org Cc: Ni, Ruiyu Subject: [edk2] [Patch] M

Re: [edk2] [Patch] ShellPkg/Mm: Fix build warnings

2015-12-13 Thread Tian, Feng
On behalf of Ray. Reviewed-by: Feng Tian Same again, I will help commit it. -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Michael Kinney Sent: Sunday, December 13, 2015 05:50 To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Carsey, Jaben Subject: [e

Re: [edk2] [Patch] MdePkg: backout Ipmi2.0 definitions header file.

2015-12-13 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Bu, Daocheng Sent: Friday, December 11, 2015 4:57 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [Patch] MdePkg: backout Ipmi2.0 definitions header file. The file name is too long and with "Definitions" word that is duplicated me

[edk2] [Patch] MdePkg: Add Ipmi2.0 definitions head file.

2015-12-13 Thread Daocheng Bu
Re-add Ipmi2.0 definitions header files based on Ipmi category: App, Storage and etc. In V3, the file name has been changed for short. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daocheng Bu CC: Liming Gao --- MdePkg/Include/IndustryStandard/Ipmi.h | 29 +

[edk2] [PATCH] MdeModulePkg: Improved SetupBrowser handling to failed GOTO callback.

2015-12-13 Thread Cecil Sheng
On a failed REF_OP callback, all changed fields in the Selection should be restored. Signed-off-by: Cecil Sheng --- MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Presentati

Re: [edk2] [Patch] MdePkg: Add Ipmi2.0 definitions head file.

2015-12-13 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Bu, Daocheng Sent: Monday, December 14, 2015 11:59 AM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [Patch] MdePkg: Add Ipmi2.0 definitions head file. Re-add Ipmi2.0 definitions header files based on Ipmi category: App, Storage and

Re: [edk2] GenFW Error 3000 Invalid WriteRelocations64() errors

2015-12-13 Thread Ard Biesheuvel
On 9 December 2015 at 12:24, M.V.R. Ravikanth wrote: > Hi,When I am trying to run GenFw on my module to create an image(.efi),I am > receiving below errors. > <>GenFw: ERROR 3000: Invalid WriteRelocations64(): > c:\udk14_arm\myworkspace\Build\MdeModule\RELEASE_ARMGCC\AARCH64\MdeModulePkg\Applic