Re: [edk2] PL180MciDxe problem with TC2

2016-02-29 Thread Ryan Harkin
Thanks for jumping in! On 29 February 2016 at 20:59, Ard Biesheuvel wrote: > On 29 February 2016 at 21:05, Laszlo Ersek wrote: >> On 02/29/16 20:39, Ryan Harkin wrote: >>> Hi Ard/Leif/anyone who cares, >>> >>> So I was trying to work out who broke MMC support in TC2 in the >>> upstream EDK2 tree

Re: [edk2] [Patch 3/4] NetworkPkg: Revert git 'eb213f2f' fix

2016-02-29 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan > -Original Message- > From: Wu, Jiaxin > Sent: Thursday, February 25, 2016 12:22 PM > To: edk2-devel@lists.01.org > Cc: Subramanian Sriram ; El-Haj-Mahmoud Samer > ; Ye, Ting ; Fu, > Siyuan > Subject: [Patch 3/4] NetworkPkg: Revert git 'eb213f2f' fix > > 'eb21

Re: [edk2] [Patch 4/4] ShellPkg: Revert git 'd6cf1af9' fix

2016-02-29 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Jiaxin Wu > Sent: Thursday, February 25, 2016 12:22 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Fu, Siyuan > Subject: [edk2] [Patch 4/4] ShellPkg: Revert git 'd6

[edk2] [patch v2 2/2] MdeModulePkg/UfsPassThru: Fix uninitialized field in QueryReqest UPIU

2016-02-29 Thread Feng Tian
The DataSegmentLength field of Query Request UPIU doesn't set correctly, which causes a 0 value rather than right data length is set to this field Cc: Hao Wu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Feng Tian --- MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThruHci.

[edk2] [patch v2 0/2] Fix uninitialized field in QueryRequest UPIU in EDKII UFS stack

2016-02-29 Thread Feng Tian
Changes made compared with v1 of the patch: 1. Fix the same bug in UfsBlockIoPei Feng Tian (2): MdeModulePkg/UfsBlockIoPei: Fix uninitialized field in QueryRequest UPIU MdeModulePkg/UfsPassThru: Fix uninitialized field in QueryReqest UPIU MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHci.c

[edk2] [patch v2 1/2] MdeModulePkg/UfsBlockIoPei: Fix uninitialized field in QueryRequest UPIU

2016-02-29 Thread Feng Tian
The DataSegmentLength field of Query Request UPIU doesn't set correctly, which causes a 0 value rather than right data length is set to this field Cc: Hao Wu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Feng Tian --- MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHci.c | 9 +++

Re: [edk2] [PATCH 07/17] OvmfPkg: PciHostBridgeLib: convert main loop from PciHostBridgeDxe

2016-02-29 Thread Jordan Justen
On 2016-02-26 16:23:26, Laszlo Ersek wrote: > In this patch we import the scan for extra root buses from the > InitializePciHostBridge() function, in file > "OvmfPkg/PciHostBridgeDxe/PciHostBridge.c". > > For the time being, the InitRootBridge() and UninitRootBridge() functions > are just placehol

Re: [edk2] [PATCH 05/17] OvmfPkg: factor the MMIO aperture shared by all PCI root bridges into PCDs

2016-02-29 Thread Jordan Justen
On 2016-02-26 16:23:24, Laszlo Ersek wrote: > Going forward, two modules will need to know about the aperture: > PlatformPei (as before), and OVMF's upcoming PciHostBridgeLib instance > (because the core PciHostBridgeDxe driver requires the library to state > the exact apertures for all root bridge

[edk2] [patch] MdeModulePkg: FileExplorerLib: Modify the EFI_FILE_EXPLORE_FORMSET_GUID

2016-02-29 Thread Dandan Bi
Currently the EFI_FILE_EXPLORE_FORMSET_GUID value in BdsDxe in IntelFrameworkModulePkg is same with the GUID VALUE in FileExplorerLib. This patch is to modify the EFI_FILE_EXPLORE_FORMSET_GUID in FileExplorerLib to avoid potential issue. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore

Re: [edk2] UnicodeError: UTF-16 stream does not start with BOM error when update from UDK2015 to latest Github trunk

2016-02-29 Thread Gao, Liming
Do you get the latest BaseTools binary win32? > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > wang xiaofeng > Sent: Tuesday, March 01, 2016 2:04 PM > To: edk2-devel@lists.01.org > Subject: [edk2] UnicodeError: UTF-16 stream does not start wit

[edk2] UnicodeError: UTF-16 stream does not start with BOM error when update from UDK2015 to latest Github trunk

2016-02-29 Thread wang xiaofeng
Hi All Edk2 developer, I meet a build error when update code from UDK2015 to latest Github trunk. Do anyone meet similar issue before? I sync NetworkPkg seperately to latest code but find the following error: build... : error C0DE: Unknown fatal error when processing [e:\code\cl174\Netwo

[edk2] [PATCH] MdeModulePkg: Fixed incorrect Regular expression protocol MatchString return value.

2016-02-29 Thread Cecil Sheng
According to UEFI2.6, CapturePtr in the Captures array returned by MatchString() should be separatedly allocated so that they can be freed by the caller. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Cecil Sheng Reviewed-by: Samer El-Haj-Mahmoud --- .../RegularExpress

[edk2] [PATCH v3 6/6] Nt32Pkg: Enable Nt32Pkg platform HTTPS boot feature.

2016-02-29 Thread Jiaxin Wu
v3: *Update to introduce HTTPS_BOOT_ENABLE flag for TlsDxe. This path is used to enable HTTPS boot feature. Cc: Ye Ting Cc: Fu Siyuan Cc: Long Qin Cc: Ruiyu Ni Cc: El-Haj-Mahmoud Samer Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiaxin Wu --- Nt32Pkg/Nt32Pkg.dsc

[edk2] [patch] MdeModulePkg: Add ASSERT to make sure pointers are not NULL

2016-02-29 Thread Dandan Bi
Cc: Qiu Shumin Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Library/FileExplorerLib/FileExplorer.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MdeModulePkg/Library/FileExplorerLib/FileExplorer.c b/MdeModulePkg/Library

Re: [edk2] [Patch] MdeModulePkg: Add new API HttpUrlGetPath() to HttpLib.h

2016-02-29 Thread Wu, Jiaxin
Reviewed-by: Jiaxin Wu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu > Siyuan > Sent: Monday, February 29, 2016 1:52 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Wu, Jiaxin > Subject: [edk2] [Patch] MdeModulePkg: Add new API HttpUr

Re: [edk2] [PATCH v2] MdeModulePkg: PciHostBridgeDxe: don't assume extended config space

2016-02-29 Thread Ni, Ruiyu
Copying Mike who might have other comments. Regards, Ray From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ni, Ruiyu Sent: Tuesday, March 1, 2016 10:12 AM To: mar...@redhat.com; Laszlo Ersek ; edk2-de...@ml01.01.org Cc: Justen, Jordan L Subject: Re: [edk2] [PATCH v2] MdeModu

[edk2] [patch] MdeModulePkg: FileExplorerLib: Add check when to call FreePool function

2016-02-29 Thread Dandan Bi
when free up resource allocated for a MenuEntry, there exists the case that the DevicePath and DisplayString are NULL, so before calling FreePool function, need to check. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModu

Re: [edk2] [PATCH v2] MdeModulePkg: PciHostBridgeDxe: don't assume extended config space

2016-02-29 Thread Ni, Ruiyu
Laszlo, How about using a flag NoExtendedConfigSpace? Since for most cases the PCI CFG space limit is 0xFFF, so I think it's better to choose a flag whose default value meets most of the cases. For a Boolean flag inside a structure when the structure is allocated using AllocateZeroPool, the flag

Re: [edk2] [PATCH] MdePkg: fix comment typo in DebugLib.h

2016-02-29 Thread Gao, Liming
Ersek: Do you create another patch for the typo SNI driver? Or, you expect to include the fix in this patch. Thanks Liming > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, March 01, 2016 4:14 AM > To: Leif Lindholm; edk2-de...@ml01.01.org > Cc: Ki

Re: [edk2] [PATCH] MdeModulePkg: DxeCore: fully initialize image context before passing it on

2016-02-29 Thread Zeng, Star
On 2016/3/1 0:16, Ard Biesheuvel wrote: When the DXE core is loaded, it invokes the PeCoffExtraActionLib library function 'PeCoffLoaderRelocateImageExtraAction' explicitly, which may be in addition to the same function having been called by the DxeIpl PE/COFF loader instance. The ImageContext th

Re: [edk2] [Patch] MdeModulePkg: Add new API HttpUrlGetPath() to HttpLib.h

2016-02-29 Thread Ye, Ting
Reviewed-by: Ye Ting -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu Siyuan Sent: Monday, February 29, 2016 1:52 PM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Wu, Jiaxin Subject: [edk2] [Patch] MdeModulePkg: Add new API HttpUrlGetPath() to H

[edk2] [PATCH] MdeModulePkg/Ufs: Fix uninitialized field of QueryRequest UPIU

2016-02-29 Thread Feng Tian
The DataSegmentLength field of Query Request UPIU doesn't set correctly, which causes a 0 value rather than right data length is set to this field Cc: Hao Wu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Feng Tian --- MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThruHci.c

Re: [edk2] [Patch] BaseTools: fix LzmaCompress VS2013 make failure

2016-02-29 Thread Zhu, Yonghong
Hi Jordan, Sorry. I did missed. I will fix it in a new patch. Best Regards, Zhu Yonghong -Original Message- From: Justen, Jordan L Sent: Tuesday, March 01, 2016 4:45 AM To: Zhu, Yonghong ; edk2-devel@lists.01.org Subject: Re: [edk2] [Patch] BaseTools: fix LzmaCompress VS2013 make fail

Re: [edk2] [PATCH v2 6/6] Nt32Pkg: Enable Nt32Pkg platform HTTPS boot feature.

2016-02-29 Thread Wu, Jiaxin
Thanks Laszlo, below patch did miss that point to avoid the build performance impact. I will update it to introduce HTTPS_BOOT_ENABLE flag for TlsDxe. Thanks. Jiaxin > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Monday, February 29, 2016 11:26 PM > To: Wu

Re: [edk2] [Patch] BaseTools: update the mail address for stack trace info

2016-02-29 Thread Andrew Fish
> On Feb 28, 2016, at 7:51 PM, Gao, Liming wrote: > > Reviewed-by: Liming Gao > Reviewed-by: Andrew Fish Thanks, Andrew Fish >> -Original Message- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >> Yonghong Zhu >> Sent: Monday, February 29, 2016 11:24 AM

Re: [edk2] [PATCH] MdePkg: fix comment typo in DebugLib.h

2016-02-29 Thread Kinney, Michael D
Reviewed-by: Michael Kinney Mike > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Monday, February 29, 2016 11:43 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Gao, Liming > > Subject: [PATCH] MdePkg: fix comment typo in DebugLib.h > >

Re: [edk2] PL180MciDxe problem with TC2

2016-02-29 Thread Ard Biesheuvel
On 29 February 2016 at 21:05, Laszlo Ersek wrote: > On 02/29/16 20:39, Ryan Harkin wrote: >> Hi Ard/Leif/anyone who cares, >> >> So I was trying to work out who broke MMC support in TC2 in the >> upstream EDK2 tree. It was difficult because the tree is borked on >> TC2 in so many interesting ways

Re: [edk2] [Patch] BaseTools: fix LzmaCompress VS2013 make failure

2016-02-29 Thread Jordan Justen
On 2016-02-28 23:16:20, Jordan Justen wrote: > On 2016-02-28 19:23:35, Yonghong Zhu wrote: > > when make BaseTools by VS2013, LzmaEnc.c report warning C4127: > > conditional expression is constant, so this patch fix this issue. > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Si

Re: [edk2] [PATCH] Platforms/ARM: ArmVexpress.dsc.inc - update debug levels

2016-02-29 Thread Laszlo Ersek
On 02/29/16 20:34, Leif Lindholm wrote: > The comments on PcdDebugPrintErrorLevel are clearly based on a version > of MdePkg/Include/Library/DebugLib.h predating SVN r12933. > Bring up to date to reduce confusion (and fix a couple of mistakes). > > Contributed-under: TianoCore Contribution Agreeme

Re: [edk2] [PATCH] MdePkg: fix comment typo in DebugLib.h

2016-02-29 Thread Laszlo Ersek
On 02/29/16 20:42, Leif Lindholm wrote: > The definition of DEBUG_LOADFILE was incorrectly described as "UNDI > Driver". Correct this to align with MdePkg.dec. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Leif Lindholm > --- > MdePkg/Include/Library/DebugLib.h | 2

Re: [edk2] PL180MciDxe problem with TC2

2016-02-29 Thread Laszlo Ersek
On 02/29/16 20:39, Ryan Harkin wrote: > Hi Ard/Leif/anyone who cares, > > So I was trying to work out who broke MMC support in TC2 in the > upstream EDK2 tree. It was difficult because the tree is borked on > TC2 in so many interesting ways throughout history, but I eventually > bisected down to

Re: [edk2] [PATCH] Platforms/ARM: ArmVexpress.dsc.inc - update debug levels

2016-02-29 Thread Laszlo Ersek
On 02/29/16 20:34, Leif Lindholm wrote: > The comments on PcdDebugPrintErrorLevel are clearly based on a version > of MdePkg/Include/Library/DebugLib.h predating SVN r12933. > Bring up to date to reduce confusion (and fix a couple of mistakes). > > Contributed-under: TianoCore Contribution Agreeme

[edk2] [PATCH] MdePkg: fix comment typo in DebugLib.h

2016-02-29 Thread Leif Lindholm
The definition of DEBUG_LOADFILE was incorrectly described as "UNDI Driver". Correct this to align with MdePkg.dec. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Leif Lindholm --- MdePkg/Include/Library/DebugLib.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[edk2] PL180MciDxe problem with TC2

2016-02-29 Thread Ryan Harkin
Hi Ard/Leif/anyone who cares, So I was trying to work out who broke MMC support in TC2 in the upstream EDK2 tree. It was difficult because the tree is borked on TC2 in so many interesting ways throughout history, but I eventually bisected down to this patch: 300fc77 2015-08-25 ArmPlatformPkg/P

[edk2] [PATCH] Platforms/ARM: ArmVexpress.dsc.inc - update debug levels

2016-02-29 Thread Leif Lindholm
The comments on PcdDebugPrintErrorLevel are clearly based on a version of MdePkg/Include/Library/DebugLib.h predating SVN r12933. Bring up to date to reduce confusion (and fix a couple of mistakes). Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Leif Lindholm --- Platform

Re: [edk2] [PATCH v2] MdeModulePkg: PciHostBridgeDxe: don't assume extended config space

2016-02-29 Thread Marcel Apfelbaum
On 02/29/2016 03:15 PM, Laszlo Ersek wrote: The "pc" ("pc-i440fx-*") machine types of QEMU don't support extended config space. Accordingly, OVMF will use the following library instances in connection with the core PciHostBridgeDxe driver: BasePciSegmentLibPci [class: PciSegmentLib] Base

Re: [edk2] [PATCH] BaseTools: Update ARM/AArch64 GenFv vector processing for encapsulated FVs

2016-02-29 Thread Ard Biesheuvel
On 17 February 2016 at 14:39, Cohen, Eugene wrote: > Instead of only handling SEC Core or PEI Core instances in the outer FV, > the GenFv tool will now recurse into FV image FFS files to look for instances > in encapsulated FVs so the vector area can be updated appropriately. > > Tested on ARM and

Re: [edk2] [PATCH v2] MdeModulePkg: PciHostBridgeDxe: don't assume extended config space

2016-02-29 Thread Laszlo Ersek
On 02/29/16 14:15, Laszlo Ersek wrote: > The "pc" ("pc-i440fx-*") machine types of QEMU don't support extended > config space. Accordingly, OVMF will use the following library instances > in connection with the core PciHostBridgeDxe driver: > > BasePciSegmentLibPci [class: PciSegmentLib] > B

Re: [edk2] [PATCH] ShellPkg: Add FileSize member to shell memory file structure.

2016-02-29 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel-boun...@lists.01.org [mailto:edk2-devel- > boun...@lists.01.org] On Behalf Of jim_dai...@dell.com > Sent: Thursday, February 18, 2016 6:41 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Qiu, Shumin > > Subject: [ed

Re: [edk2] RESEND: [PATCH] ShellPkg: Do not write the UNICODE BOM on ConOut

2016-02-29 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel-boun...@lists.01.org [mailto:edk2-devel- > boun...@lists.01.org] On Behalf Of jim_dai...@dell.com > Sent: Thursday, February 18, 2016 6:47 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Qiu, Shumin > > Subject: [ed

Re: [edk2] [PATCH] ShellPkg: Increase reallocation size for temp memory files

2016-02-29 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel-boun...@lists.01.org [mailto:edk2-devel- > boun...@lists.01.org] On Behalf Of jim_dai...@dell.com > Sent: Thursday, February 18, 2016 7:52 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Qiu, Shumin > > Subject: [ed

[edk2] [PATCH] MdeModulePkg: DxeCore: fully initialize image context before passing it on

2016-02-29 Thread Ard Biesheuvel
When the DXE core is loaded, it invokes the PeCoffExtraActionLib library function 'PeCoffLoaderRelocateImageExtraAction' explicitly, which may be in addition to the same function having been called by the DxeIpl PE/COFF loader instance. The ImageContext that DXE core presents to this function is o

Re: [edk2] [PATCH] SecurityPkg: Change TPM MMIO range attribute

2016-02-29 Thread Laszlo Ersek
Hello Anbazhagan, (apologies if Anbazhagan is not your given name -- I tried to google both "Anbazhagan" and "Baraneedharan", and it seems like "Baraneedharan" is your given name,) On 02/29/16 01:09, Anbazhagan, Baraneedharan wrote: > Could you please help to merge these changes? Thanks. The pat

Re: [edk2] [PATCH 0/9] enhance mmc

2016-02-29 Thread Leif Lindholm
On Mon, Feb 29, 2016 at 01:46:42PM +, Ryan Harkin wrote: > >> This is a substantial contribution, and on inspection it looks fine. > >> However, it does change bits of MmcDxe substantially - so I would > >> really like to see some Tested-by:s for existing platforms. > >> > >> Ryan? > > I'd lov

Re: [edk2] [PATCH v2 1/1] EmbeddedPkg/AndroidFastboot: fix size with 64bit

2016-02-29 Thread Leif Lindholm
On 29 February 2016 at 14:51, Haojian Zhuang wrote: > Since there's percentage calcution, multiply on 32bit variable > will cause overflow. So fix the variables as 64bit. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Zhangfei Gao > Signed-off-by: Haojian Zhuang Re

Re: [edk2] [PATCH v2 6/6] Nt32Pkg: Enable Nt32Pkg platform HTTPS boot feature.

2016-02-29 Thread Laszlo Ersek
On 02/29/16 02:37, Jiaxin Wu wrote: > v2: > *Update to remove 'SECURE_BOOT_ENABLE' flag for all library defined > in CryptoPkg. > > This path is used to enable HTTPS boot feature. > > Cc: Ye Ting > Cc: Fu Siyuan > Cc: Long Qin > Cc: Ruiyu Ni > Cc: El-Haj-Mahmoud Samer > Contributed-under: Ti

Re: [edk2] [PATCH 00/17] Port OvmfPkg to MdeModulePkg/Bus/Pci/PciHostBridgeDxe

2016-02-29 Thread Laszlo Ersek
On 02/29/16 15:01, Gerd Hoffmann wrote: > Hi, > >> Okay, OVMF does not conform to this at the moment. It fetches the amount >> of RAM above the 4GB mark from the CMOS, and makes it all available to >> the DXE and later phases (and the OS as well). >> >> Assuming the "etc/reserved-memory-end" fw_

[edk2] [PATCH v2 1/1] EmbeddedPkg/AndroidFastboot: fix size with 64bit

2016-02-29 Thread Haojian Zhuang
Since there's percentage calcution, multiply on 32bit variable will cause overflow. So fix the variables as 64bit. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhangfei Gao Signed-off-by: Haojian Zhuang --- EmbeddedPkg/Application/AndroidFastboot/AndroidFastbootApp.c |

[edk2] [PATCH v2 0/1] fix data size in AndroidFastboot

2016-02-29 Thread Haojian Zhuang
Changelog: v2: * Avoid to use UINTN. Since UINTN means UINT32 on aarch32. Haojian Zhuang (1): EmbeddedPkg/AndroidFastboot: fix size with 64bit EmbeddedPkg/Application/AndroidFastboot/AndroidFastbootApp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 1.9.1 __

Re: [edk2] [PATCH 00/17] Port OvmfPkg to MdeModulePkg/Bus/Pci/PciHostBridgeDxe

2016-02-29 Thread Gerd Hoffmann
Hi, > Okay, OVMF does not conform to this at the moment. It fetches the amount > of RAM above the 4GB mark from the CMOS, and makes it all available to > the DXE and later phases (and the OS as well). > > Assuming the "etc/reserved-memory-end" fw_cfg file is found, how does > that affect the CM

Re: [edk2] [PATCH 0/9] enhance mmc

2016-02-29 Thread Ryan Harkin
On 27 February 2016 at 08:48, Haojian Zhuang wrote: > On 2016/2/27 4:38, Leif Lindholm wrote: >> >> Hi Haojian, >> >> On Fri, Feb 26, 2016 at 05:27:47PM +0800, Haojian Zhuang wrote: >>> >>> * Wait OCR busy bit free according to eMMC spec. >>> * Define ECSD structure. >>> * Add interface to set IO

Re: [edk2] [PATCH 00/17] Port OvmfPkg to MdeModulePkg/Bus/Pci/PciHostBridgeDxe

2016-02-29 Thread Laszlo Ersek
On 02/29/16 14:19, Gerd Hoffmann wrote: > Hi, > >> I didn't mean "fw_cfg-based configuration" as another, "new" config >> knob. I just recall some discussions that "etc/reserved-memory-end" is >> related to the 64-bit MMIO aperture, somehow. (I don't yet know how >> exactly -- I intended to ask

Re: [edk2] [PATCH] MdeModulePkg/HiiDatabaseDxe: Fix a variable is uninitialized.

2016-02-29 Thread Laszlo Ersek
On 02/29/16 11:49, Shia, Cinnamon wrote: > Hi Feng and Star, > > Can you help to check in this patch? Committed & pushed as f5e6aa8e176c. Thanks Laszlo > > Thanks, > Cinnamon Shia > > -Original Message- > From: Dong, Eric [mailto:eric.d...@intel.com] > Sent: Tuesday, February 23, 201

Re: [edk2] [PATCH 00/17] Port OvmfPkg to MdeModulePkg/Bus/Pci/PciHostBridgeDxe

2016-02-29 Thread Gerd Hoffmann
Hi, > I didn't mean "fw_cfg-based configuration" as another, "new" config > knob. I just recall some discussions that "etc/reserved-memory-end" is > related to the 64-bit MMIO aperture, somehow. (I don't yet know how > exactly -- I intended to ask about it anyway, later). Ah, that one you mean.

[edk2] [PATCH v2] MdeModulePkg: PciHostBridgeDxe: don't assume extended config space

2016-02-29 Thread Laszlo Ersek
The "pc" ("pc-i440fx-*") machine types of QEMU don't support extended config space. Accordingly, OVMF will use the following library instances in connection with the core PciHostBridgeDxe driver: BasePciSegmentLibPci [class: PciSegmentLib] BasePciLibCf8 [class: PciLib] BasePciCf8L

Re: [edk2] [PATCH] EmbeddedPkg/AndroidFastboot: fix size with 64bit

2016-02-29 Thread Haojian Zhuang
On 29 February 2016 at 17:53, Leif Lindholm wrote: > On Mon, Feb 29, 2016 at 04:36:00PM +0800, Haojian Zhuang wrote: >> 在 02/27/2016 04:42 AM, Leif Lindholm 写道: >> >On Fri, Feb 26, 2016 at 05:34:50PM +0800, Haojian Zhuang wrote: >> >>Since there's percentage calcution, multiply on 32bit variable >

Re: [edk2] [PATCH] EmbeddedPkg/AndroidFastboot: fix size with 64bit

2016-02-29 Thread Leif Lindholm
On Mon, Feb 29, 2016 at 04:36:00PM +0800, Haojian Zhuang wrote: > 在 02/27/2016 04:42 AM, Leif Lindholm 写道: > >On Fri, Feb 26, 2016 at 05:34:50PM +0800, Haojian Zhuang wrote: > >>Since there's percentage calcution, multiply on 32bit variable > >>will cause overflow. So fix the variables as 64bit. >

Re: [edk2] [PATCH] MdeModulePkg/HiiDatabaseDxe: Fix a variable is uninitialized.

2016-02-29 Thread Shia, Cinnamon
Hi Feng and Star, Can you help to check in this patch? Thanks, Cinnamon Shia -Original Message- From: Dong, Eric [mailto:eric.d...@intel.com] Sent: Tuesday, February 23, 2016 2:02 PM To: Shia, Cinnamon; edk2-devel@lists.01.org Cc: Tian, Feng; Zeng, Star Subject: FW: [edk2] [PATCH] MdeMo

Re: [edk2] [PATCH 02/17] MdeModulePkg: PciHostBridgeLibNull: rewrap source to 79 characters

2016-02-29 Thread Laszlo Ersek
On 02/27/16 03:13, Ni, Ruiyu wrote: > > > Reviewed-by: Ruiyu Ni I committed & pushed this patch in separation: commit 9b6b938538076116768ee9b8e4d52d0cb51dcc8c. Thanks! Laszlo > >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Saturday, February 27, 2016

Re: [edk2] [PATCH 00/17] Port OvmfPkg to MdeModulePkg/Bus/Pci/PciHostBridgeDxe

2016-02-29 Thread Laszlo Ersek
On 02/29/16 08:30, Gerd Hoffmann wrote: > Hi, > >> Once this is in, the next plan is to enable 64-bit MMIO -- first for >> emulated devices, then maybe for assigned devices. See >> . With the core driver, >> 64-bit MMIO should "only" take some fw_cfg-

Re: [edk2] [PATCH 01/17] MdeModulePkg: PciHostBridgeDxe: don't assume extended config space

2016-02-29 Thread Laszlo Ersek
On 02/28/16 08:16, Ni, Ruiyu wrote: >>> 在 2016年2月27日,下午6:17,Laszlo Ersek 写道: >> Thus, this argument comprises two parts: >> >> 1. PciHostBridgeDxe needs to use a platform dependent config space >> limit: 0xFF, 0xFFF, or something else that matches the platform's >> PciSegmentLib instance. Co

Re: [edk2] [PATCH] EmbeddedPkg/AndroidFastboot: fix size with 64bit

2016-02-29 Thread Haojian Zhuang
在 02/27/2016 04:42 AM, Leif Lindholm 写道: On Fri, Feb 26, 2016 at 05:34:50PM +0800, Haojian Zhuang wrote: Since there's percentage calcution, multiply on 32bit variable will cause overflow. So fix the variables as 64bit. So, this is not technically what it does - it changes the variables to b

Re: [edk2] [Patch] NetworkPkg: Add URI configuration form to HTTP boot driver.

2016-02-29 Thread Fu, Siyuan
You are right, I will update it. From: Wu, Jiaxin Sent: Monday, February 29, 2016 3:40 PM To: Fu, Siyuan ; edk2-devel@lists.01.org Cc: Ye, Ting Subject: RE: [Patch] NetworkPkg: Add URI configuration form to HTTP boot driver. Siyuan, Seems unreasonable to only accept http and https URI. If the u