Re: [edk2] [PATCH] PcAtChipsetPkg/PciHostBridgeDxe: Remove it since MdeModulePkg contains a new one.

2016-03-15 Thread wang xiaofeng
HI Ruiyu, Thanks for your detailed information. We can try to move to MdeModulePkg/PciHostBridgeDxe later. At 2016-03-16 10:41:38, "Ni, Ruiyu" wrote: MdeModulePkg/PciHostBridgeDxe is a superset of PcAtChipsetPkg/PciHostBridgeDxe. It requires a platform/silicon library instance PciHos

Re: [edk2] [PATCH] Nt32Pkg: Switch the DebugLibReportStatusCode to MdeModulePkg

2016-03-15 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Cinnamon Shia [mailto:cinnamon.s...@hpe.com] > Sent: Wednesday, March 16, 2016 10:45 AM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu; Gao, Liming; el...@hpe.com; Cinnamon Shia > Subject: [PATCH] Nt32Pkg: Switch the DebugLibReportStatus

[edk2] [Patch] BaseTools: Fix nmake failure due to command-line length limitation

2016-03-15 Thread Yonghong Zhu
NMAKE is limited to command-line length of 4096 characters. Due to the large number of /I directives specified on command line (one per include directory), the path length of WORKSPACE is multiplied by the number of /I directives and can exceed the limit. This patch: 1. Add new build option -l, --c

[edk2] [PATCH] Nt32Pkg: Switch the DebugLibReportStatusCode to MdeModulePkg

2016-03-15 Thread Cinnamon Shia
Switch the DebugLibReportStatusCode from IntelFrameworkPkg to MdeModulePkg. The functionality and the code between them are almost the same. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Cinnamon Shia --- Nt32Pkg/Nt32Pkg.dsc | 2 +- 1 file changed, 1 insertion(+), 1 dele

Re: [edk2] [PATCH] PcAtChipsetPkg/PciHostBridgeDxe: Remove it since MdeModulePkg contains a new one.

2016-03-15 Thread Ni, Ruiyu
MdeModulePkg/PciHostBridgeDxe is a superset of PcAtChipsetPkg/PciHostBridgeDxe. It requires a platform/silicon library instance PciHostBridgeLib which provides the information related to the how many root bridges the platform contains, and which range of MMIO/IO resources for each root bridge. It

Re: [edk2] [patch] MdeModulePkg/DriverSampleDxe: Uninstall the ConfigAccess protocol

2016-03-15 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Bi, Dandan > Sent: Tuesday, March 15, 2016 10:19 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming; Dong, Eric > Subject: [patch] MdeModulePkg/DriverSampleDxe: Uninstall the ConfigAccess > protocol > > In DriverSampleInit, has install

Re: [edk2] [Patch] NetworkPkg: Fix the driver model issue in HTTP Boot driver.

2016-03-15 Thread Zhang, Lubo
Reviewed-by: Zhang, Lubo -Original Message- From: Fu, Siyuan Sent: Tuesday, March 15, 2016 9:41 AM To: edk2-devel@lists.01.org Cc: Gary Lin ; Laszlo Ersek ; Wu, Jiaxin ; Zhang, Lubo Subject: [Patch] NetworkPkg: Fix the driver model issue in HTTP Boot driver. The HTTP Boot driver have

Re: [edk2] [PATCH] PcAtChipsetPkg/PciHostBridgeDxe: Remove it since MdeModulePkg contains a new one.

2016-03-15 Thread wang xiaofeng
Hi Ruiyu, What's the diffience between PcAtChipsetPkg/PciHostBridgeDxe and MdeModulePkg/PciHostBridgeDxe ? We are now using PcAtChipsetPkg/PciHostBridgeDxe . We can move to MdeModulePkg/PciHostBridgeDxe if the new driver also works. It will be helpful we can know more detail informati

Re: [edk2] [MdeModulePkg] Do we support redefinition of typedefs?

2016-03-15 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Andrew > Fish > Sent: Wednesday, March 16, 2016 2:06 AM > To: edk2-devel > Subject: [edk2] [MdeModulePkg] Do we support redefinition of typedefs? > > Xcode clang seems un

Re: [edk2] [Patch V3] OvmfPkg/LegacyRegion: Support legacy region manipulation of Q35

2016-03-15 Thread Jordan Justen
Regarding the subject, how about "PATCH v3" rather than "Patch V3"? Reviewed-by: Jordan Justen Pushed as db27e9f3d8f007bf26bcb8907ecab5b5f1fb8f24. On 2016-03-15 01:10:40, Ruiyu Ni wrote: > Current implementation only supports legacy region of 440 chip. > When QEMU is launched in Q35 mode using

Re: [edk2] [PATCH] ShellPkg:

2016-03-15 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: jim_dai...@dell.com [mailto:jim_dai...@dell.com] > Sent: Tuesday, March 15, 2016 2:09 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Qiu, Shumin > > Subject: [PATCH] ShellPkg: > Importance: High > > ShellPkg: Launch shell wh

[edk2] [PATCH] ShellPkg:

2016-03-15 Thread Jim_Dailey
ShellPkg: Launch shell when startup.nsh is in the same directory If there is a startup.nsh file in the same directory as the shell that is being launched, the shell will abort. This change fixes that issue. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jim Dailey --- Sh

Re: [edk2] [MdeModulePkg] Do we support redefinition of typedefs?

2016-03-15 Thread Andrew Fish
> On Mar 15, 2016, at 11:26 AM, Alcantara, Paulo > wrote: > > EDK II C Coding Standards spec seems to not recommend redefinition of > typedefs. Since it's not supported by C89 and C99, I'd rather avoid it. > Paulo, I agree with you. I just wanted to double check as it seems most compilers a

Re: [edk2] [MdeModulePkg] Do we support redefinition of typedefs?

2016-03-15 Thread Alcantara, Paulo
EDK II C Coding Standards spec seems to not recommend redefinition of typedefs. Since it's not supported by C89 and C99, I'd rather avoid it. Paulo -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Andrew Fish Sent: terça-feira, 15 de março de 201

[edk2] [MdeModulePkg] char sign miss match

2016-03-15 Thread Andrew Fish
The regular expression driver is mixing types it defines with edk2 types. The regular expression types are less portable in regards to assumptions about the sign of char. Matching the types removes a compiler warning on Xcode clang. /Users/andrewfish/work/src/edk2/MdeModulePkg/Universal/Regular

[edk2] [MdeModulePkg] Do we support redefinition of typedefs?

2016-03-15 Thread Andrew Fish
Xcode clang seems unhappy with both FileExplorerLib.h and Protocol/FileExplorer.h both defining CHOOSE_HANDLER /Users/andrewfish/work/src/edk2/MdeModulePkg/Include/Library/FileExplorerLib.h:30:10: error: redefinition of typedef 'CHOOSE_HANDLER' is a C11 feature [-Werror,-Wtypedef-redefinition]

Re: [edk2] EDK2 Staging Repository 2nd Draft

2016-03-15 Thread Kinney, Michael D
David, Thanks for the suggestion. Today the git dev process requires a rebase. Given that this operation is transferring content from one community maintained feature branch in edk2-staging into edk2/master, I agree the option to use 'git pull' should be available. Not sure it should be requir

Re: [edk2] Software SMI STS bit is not set when writing port B2 in QEMU Q35

2016-03-15 Thread Paolo Bonzini
On 15/03/2016 16:48, Ni, Ruiyu wrote: > I don't think CSM matters and the bin I am using cannot be > distributed. Does the qemu build steps matters? I ran configure > --target-list=x86_64-softmmu. I traced the code and found the code > hung when SMM is relocating. The code was waiting for mRebase

Re: [edk2] Software SMI STS bit is not set when writing port B2 in QEMU Q35

2016-03-15 Thread Ni, Ruiyu
I don't think CSM matters and the bin I am using cannot be distributed. Does the qemu build steps matters? I ran configure --target-list=x86_64-softmmu. I traced the code and found the code hung when SMM is relocating. The code was waiting for mRebased flag be set. Thanks, Ray > 在 2016年3月15日,下午

Re: [edk2] Software SMI STS bit is not set when writing port B2 in QEMU Q35

2016-03-15 Thread Paolo Bonzini
On 15/03/2016 12:59, Ni, Ruiyu wrote: >> > I'm not sure. The above command line works for me after building OVMF >> > like this: >> > >> >build -p OvmfPkg/OvmfPkgIa32X64.dsc -a IA32 -a X64 -b DEBUG -t GCC49 -n >> > 4 >> > >> > I'm using commit 89a8115 ("BaseTools: Support recent versions

Re: [edk2] Problem with Author, Sign Off, and IP concerns

2016-03-15 Thread Leif Lindholm
Hi Evan, Thanks - I really appreciate you taking the time to summarise the situation. On Tue, Mar 15, 2016 at 01:14:39PM +, Evan Lloyd wrote: > I recently submitted some patches with fixes and improvements > derived from our work on the Juno platform. > Laszlo very politely queried my "sign o

[edk2] [PATCH v2] ShellPkg: Per UEFI Shell 2.2 SPEC to make Shell supports 'NoNesting'.

2016-03-15 Thread Qiu Shumin
This patch makes Shell support -nonesting invocation option. This option specifies that EFI_SHELL_PROTOCOL.Execute API nesting of a new Shell instance is optional and dependent on the 'nonesting' Shell environment variable. Difference with previous patch: Do not use "negative" functions names. Co

[edk2] Problem with Author, Sign Off, and IP concerns

2016-03-15 Thread Evan Lloyd
I recently submitted some patches with fixes and improvements derived from our work on the Juno platform. Laszlo very politely queried my "sign off" of the patches which bore Sami's name as author and gracefully suggested the proper "S-o-b" style. Others have since queried my consequent strategy

Re: [edk2] Software SMI STS bit is not set when writing port B2 in QEMU Q35

2016-03-15 Thread Ni, Ruiyu
Thanks, Ray > 在 2016年3月15日,下午5:33,Paolo Bonzini 写道: > > > >> On 15/03/2016 10:10, Ni, Ruiyu wrote: >> Paolo, Laszlo, >> As I mentioned in previous mail, the EAX I got from CpuSaveState >> is different from what I set before entering SMM. >> Because the failure was seen in a QEMU launched in

Re: [edk2] EDK2 Staging Repository 2nd Draft

2016-03-15 Thread David Woodhouse
On Tue, 2016-03-15 at 00:16 +, Kinney, Michael D wrote: > > > Can you provide some revised text you would like to see in step 6. > > I agree that we need to use the tools in ways that help make this easy, > prevent > errors, and preserve history.  Given that step 6 describes promoting a >

Re: [edk2] [PATCH] MdeModulePkg: Fixed incorrect Regular expression protocol MatchString return value.

2016-03-15 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Sheng, > Cecil (HPS SW) > Sent: Tuesday, March 15, 2016 10:39 AM > To: edk2-devel@lists.01.org > Cc: Tian, Feng; Zeng, Star > Subject: Re: [edk2] [PATCH] MdeModulePkg: Fi

Re: [edk2] Software SMI STS bit is not set when writing port B2 in QEMU Q35

2016-03-15 Thread Paolo Bonzini
On 15/03/2016 10:10, Ni, Ruiyu wrote: > Paolo, Laszlo, > As I mentioned in previous mail, the EAX I got from CpuSaveState > is different from what I set before entering SMM. > Because the failure was seen in a QEMU launched in Windows > using the following command: > qemu-system-x86_64.exe \ >

Re: [edk2] Software SMI STS bit is not set when writing port B2 in QEMU Q35

2016-03-15 Thread Ni, Ruiyu
Paolo, Laszlo, As I mentioned in previous mail, the EAX I got from CpuSaveState is different from what I set before entering SMM. Because the failure was seen in a QEMU launched in Windows using the following command: qemu-system-x86_64.exe \ -machine q35,smm=on,accel=tcg \ -smp 1 \ -drive if

Re: [edk2] [Patch V3] OvmfPkg/LegacyRegion: Support legacy region manipulation of Q35

2016-03-15 Thread Ni, Ruiyu
Forgot to mention the diff between v3 and v2. v3 uses PcdOvmfHostBridgePciDevId as Jordan suggested. v2 just updates the comments. Regards, Ray >-Original Message- >From: Ni, Ruiyu >Sent: Tuesday, March 15, 2016 4:11 PM >To: edk2-devel@lists.01.org >Cc: Ni, Ruiyu ; Justen, Jordan L >;

[edk2] [Patch V3] OvmfPkg/LegacyRegion: Support legacy region manipulation of Q35

2016-03-15 Thread Ruiyu Ni
Current implementation only supports legacy region of 440 chip. When QEMU is launched in Q35 mode using CSM enabled OVMF image, LegacyBios driver fails to start due to the legacy region [0xC, 0xF] cannot be written. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Rui

[edk2] [PATCH] PcAtChipsetPkg/PciHostBridgeDxe: Remove it since MdeModulePkg contains a new one.

2016-03-15 Thread Ni, Ruiyu
All, I am going to remove the PciHostBridgeDxe driver from PcAtChipsetPkg. This driver is not used by any platform as far as I know. Any concerns? Regards, Ray ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk