Sorry for late to reply you. (Both Monday and Tuesday are public holidays in my
location)
Yeah, you concern is more effective than preventing potential issue. Thanks
for the clarifying this.
Reviewed-by: Sunny Wang
-Original Message-
From: Ni, Ruiyu [mailto:ruiyu...@intel.com]
Tested it in my side as well. Looks good! Thanks for the quick fix.
Reviewed-by: Sunny Wang
-Original Message-
From: Ruiyu Ni [mailto:ruiyu...@intel.com]
Sent: Wednesday, April 06, 2016 2:37 PM
To: edk2-devel@lists.01.org
Cc: Ruiyu Ni ; Wang, Sunny (HPS SW)
Subject: [Patch] MdeModulePk
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni
Cc: Sunny Wang
---
MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
b/MdeModulePkg/Library/Ue
v2:
*refine some codes
Add 2 macros in NetLib.h
#define IP4_MASK_MAX 32
#define IP6_PREFIX_MAX128
we will use these two macros to check the max mask/prefix length,
instead of
#define IP4_MASK_NUM 33
#define IP6_PREFIX_NUM129
which means a valid number
This wil
Hi Sriram
I will send a new patch v2 later for your comment and this may be more
clear. Thanks
Best regards
Lubo
-Original Message-
From: Subramanian, Sriram (EG Servers Platform SW) [mailto:srira...@hpe.com]
Sent: Wednesday, April 06, 2016 1:51 PM
To: Zhang, Lubo ; edk2-devel@
Lubo,
Will you be sending out a patch for this, or will you update them at commit
time?
I'm fine with either. In case you plan to address this at commit time, I can
add my Rb for this with the two changes suggested below.
Reviewed-by: Sriram Subramanian
Thanks,
Sriram.
-Original Messag
On 2016-03-14 05:53:17, Laszlo Ersek wrote:
> This series enables OvmfPkg and ArmVirtPkg to work with non-transitional
> VirtIo 1.0 PCI devices. The first 12 patches rework our edk2-only,
> private VIRTIO_DEVICE_PROTOCOL (and its two existent implementations),
> and adapt the four device drivers we
I have given comments on 3rd patch in the series. Others look good to me
Reviewed-by: Feng Tian
Thanks
Feng
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Eric Dong
Sent: Friday, April 1, 2016 1:38 PM
To: edk2-devel@lists.01.org
Subject: [edk2
It's better to split it to two patches. One is for removing unnecessary build
option in INF. Another is for pointer check.
And the title is better to be updated to reflect the action you take in code.
Others look good to me
Reviewed-by: Feng Tian
Thanks
Feng
-Original Message-
From:
> From: Wu, Jiaxin [mailto:jiaxin...@intel.com]
> Sent: Wednesday, April 06, 2016 8:41 AM
>
> More Info:
> '-s SourceIp' operation is not defined in shell Spec 2.1 or any old
> version, but for ping usage convenience(like Bhupesh's case), the code
> implementation added the additional option '-_
On 03/22/2016 08:48 PM, Haojian Zhuang wrote:
According to eMMC spec, OCR.PowerUp bit is also busy bit. If the busy
bit is '0', CMD1 should be sent and OCR should be fetched again. And add
a timeout counter on the repeated steps.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-o
Ok, I will modify that when to check in.
Best regards
Lubo
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
Subramanian, Sriram (EG Servers Platform SW)
Sent: Wednesday, April 06, 2016 11:01 AM
To: Zhang, Lubo ; edk2-devel@lists.01.org
Cc: Ye, Ti
More Info:
'-s SourceIp' operation is not defined in shell Spec 2.1 or any old version,
but for ping usage convenience(like Bhupesh's case), the code implementation
added the additional option '-_s'. That is a non-standard option in shell Spec
2.1 but it's allowed by the Shell Spec. Because the
Thanks Lubo. Please address this if you agree.
Reviewed-by: Sriram Subramanian
Thanks,
Sriram.
-Original Message-
From: Zhang, Lubo [mailto:lubo.zh...@intel.com]
Sent: Wednesday, April 6, 2016 7:37 AM
To: Subramanian, Sriram (EG Servers Platform SW) ;
edk2-devel@lists.01.org
Cc: Ye, T
Ok - I agree. Thanks Siyuan.
From: Fu, Siyuan [mailto:siyuan...@intel.com]
Sent: Wednesday, April 6, 2016 8:07 AM
To: Palmer, Thomas ; Subramanian, Sriram (EG Servers
Platform SW) ; Zhang, Lubo ;
edk2-devel@lists.01.org
Cc: Ye, Ting ; Wu, Jiaxin
Subject: RE: [patch 1/2] NetworkPkg: Add new macr
Hi, Sriram
There is no error return path in Ip6GetPrefix() function. On any output, the
Prefix will be updated with the useless bit clear. So below code in
Ip6GetPrefix() doesn't mean it reject the prefix length 128, instead, it's a
success return because the output value of Prefix will be iden
Hi, Sriram
There is no error return path in Ip6GetPrefix() function. On any output, the
Prefix will be updated with the useless bit clear. So below code in
Ip6GetPrefix() doesn't mean it reject the prefix length 128, instead, it's a
success return because the output value of Prefix will be iden
I think the code seems same, may be "if (Length > IP6_PREFIX_MAX)" more
readable.
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
Subramanian, Sriram (EG Servers Platform SW)
Sent: Tuesday, April 05, 2016 10:21 PM
To: Zhang, Lubo ; edk2-devel@lis
On 04/05/16 20:20, Jordan Justen wrote:
> On 2016-04-05 11:06:39, Laszlo Ersek wrote:
>> On 04/05/16 19:26, Jordan Justen wrote:
>>> On 2016-04-05 09:46:33, Laszlo Ersek wrote:
(I've snipped liberally below, but I've been careful to follow up on all
of your comments.)
On 04/05/1
On 2016-04-05 11:06:39, Laszlo Ersek wrote:
> On 04/05/16 19:26, Jordan Justen wrote:
> > On 2016-04-05 09:46:33, Laszlo Ersek wrote:
> >> (I've snipped liberally below, but I've been careful to follow up on all
> >> of your comments.)
> >>
> >> On 04/05/16 18:08, Jordan Justen wrote:
> >>> On 2016
On 04/05/16 19:46, Andrew Fish wrote:
>
>> On Apr 5, 2016, at 10:26 AM, Jordan Justen wrote:
>>
>> I don't think it conflicts either.
>>
>> I wonder if Mike or Andrew have any thoughts about why the ACPI
>> includes (and arguably EDK II) go out of their way to define flattened
>> (duplicated) str
On 2016-04-05 10:46:15, Andrew Fish wrote:
>
> > On Apr 5, 2016, at 10:26 AM, Jordan Justen
> > wrote:
> >
> > I don't think it conflicts either.
> >
> > I wonder if Mike or Andrew have any thoughts about why the ACPI
> > includes (and arguably EDK II) go out of their way to define flattened
>
On 04/05/16 19:26, Jordan Justen wrote:
> On 2016-04-05 09:46:33, Laszlo Ersek wrote:
>> (I've snipped liberally below, but I've been careful to follow up on all
>> of your comments.)
>>
>> On 04/05/16 18:08, Jordan Justen wrote:
>>> On 2016-04-05 01:31:27, Laszlo Ersek wrote:
On 04/05/16 09:0
> On Apr 5, 2016, at 10:26 AM, Jordan Justen wrote:
>
> I don't think it conflicts either.
>
> I wonder if Mike or Andrew have any thoughts about why the ACPI
> includes (and arguably EDK II) go out of their way to define flattened
> (duplicated) structures for different spec versions.
>
> Onc
Series reviewed-by: Samer El-Haj-Mahmoud
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni
Sent: Tuesday, April 5, 2016 2:54 AM
To: edk2-devel@lists.01.org
Cc: Ruiyu Ni
Subject: [edk2] [Patch v4 0/3] HTTP Boot to RAM Disk
The existing co
On 04/04/2016 10:30 PM, Andrew Fish wrote:
On Apr 4, 2016, at 9:17 PM, Bhupesh Sharma wrote:
-Original Message-
From: Carsey, Jaben [mailto:jaben.car...@intel.com]
Sent: Monday, April 04, 2016 11:28 PM
To: Laszlo Ersek; Bhupesh Sharma
Cc: edk2-devel@lists.01.org; David Van Arnem; C
On 2016-04-05 09:46:33, Laszlo Ersek wrote:
> (I've snipped liberally below, but I've been careful to follow up on all
> of your comments.)
>
> On 04/05/16 18:08, Jordan Justen wrote:
> > On 2016-04-05 01:31:27, Laszlo Ersek wrote:
> >> On 04/05/16 09:03, Jordan Justen wrote:
> >>> On 2016-03-14 0
(I've snipped liberally below, but I've been careful to follow up on all
of your comments.)
On 04/05/16 18:08, Jordan Justen wrote:
> On 2016-04-05 01:31:27, Laszlo Ersek wrote:
>> On 04/05/16 09:03, Jordan Justen wrote:
>>> On 2016-03-14 05:53:23, Laszlo Ersek wrote:
These header files are i
On 5 April 2016 at 18:08, Jordan Justen wrote:
> On 2016-04-05 01:31:27, Laszlo Ersek wrote:
>> On 04/05/16 09:03, Jordan Justen wrote:
>> > On 2016-03-14 05:53:23, Laszlo Ersek wrote:
>> >> These header files are intentionally minimal, and intentionally kept apart
>> >> from the VirtIo 0.9.5 head
On 2016-04-05 01:31:27, Laszlo Ersek wrote:
> On 04/05/16 09:03, Jordan Justen wrote:
> > On 2016-03-14 05:53:23, Laszlo Ersek wrote:
> >> These header files are intentionally minimal, and intentionally kept apart
> >> from the VirtIo 0.9.5 headers.
> >>
> >> Cc: Ard Biesheuvel
> >> Cc: Jordan Jus
On 5 April 2016 at 11:18, Haojian Zhuang wrote:
> On 5 April 2016 at 17:49, Ryan Harkin wrote:
>> On 5 April 2016 at 09:37, Ryan Harkin wrote:
>>> On 5 April 2016 at 03:57, Haojian Zhuang wrote:
On 5 April 2016 at 01:17, Ryan Harkin wrote:
> Hi Haojian,
>
> I've had time to in
Sriram,
If PrefixLength is allowed to be 128 in Ip6GetPrefix, then the Addr
array is overrun on line 489:
Value = Prefix->Addr[Byte];
Where Byte = PrefixLength / 8.
If 128 should be allowed, then the function should have a separate
condition for that (like wh
> @@ -3113,11 +3113,11 @@ NetLibStrToIp6andPrefix (
> Status = EFI_INVALID_PARAMETER;
> Length = 0;
> while (*PrefixStr != '\0') {
>if (NET_IS_DIGIT (*PrefixStr)) {
> Length = (UINT8) (Length * 10 + (*PrefixStr - '0'));
> -if (Length >= IP6_PREFIX_NUM) {
> +
> diff --git a/NetworkPkg/Ip6Dxe/Ip6Common.c b/NetworkPkg/Ip6Dxe/Ip6Common.c
> index 4f71d05..9e6d368 100644
> --- a/NetworkPkg/Ip6Dxe/Ip6Common.c
> +++ b/NetworkPkg/Ip6Dxe/Ip6Common.c
> @@ -426,11 +426,11 @@ Ip6RemoveAddr (
>LIST_ENTRY *Entry;
>LIST_ENTRY *Next;
>IP
On 5 April 2016 at 17:49, Ryan Harkin wrote:
> On 5 April 2016 at 09:37, Ryan Harkin wrote:
>> On 5 April 2016 at 03:57, Haojian Zhuang wrote:
>>> On 5 April 2016 at 01:17, Ryan Harkin wrote:
Hi Haojian,
I've had time to investigate where TC2 is hanging with your patches
app
On 5 April 2016 at 09:37, Ryan Harkin wrote:
> On 5 April 2016 at 03:57, Haojian Zhuang wrote:
>> On 5 April 2016 at 01:17, Ryan Harkin wrote:
>>> Hi Haojian,
>>>
>>> I've had time to investigate where TC2 is hanging with your patches
>>> applied and narrowed it down to the single line of code m
Sunny,
I reposted the patch serials to follow your suggestions.
Regards,
Ray
>-Original Message-
>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Wang,
>Sunny (HPS SW)
>Sent: Friday, April 1, 2016 7:42 PM
>To: Ni, Ruiyu
>Cc: Fu, Siyuan ; edk2-devel@lists.01.org;
Zhang Lubo (2):
NetworkPkg: Add new macros and refine codes
MdeModulePkg: Add new macros and refine codes
MdeModulePkg/Include/Library/NetLib.h | 5 -
MdeModulePkg/Library/DxeNetLib/DxeNetLib.c | 6 +++---
MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Config2Impl.c
Add 2 macros inNetLib.h
#define IP4_MASK_MAX 32
#define IP6_PREFIX_MAX128
we will use these two macros to check the max mask/prefix length,
instead of
#define IP4_MASK_NUM 33
#define IP6_PREFIX_NUM129
which means a valid number.
This will make the code readabil
Add 2 macros in NetLib.h
#define IP4_MASK_MAX 32
#define IP6_PREFIX_MAX128
we will use these two macros to check the max mask/prefix length,
instead of
#define IP4_MASK_NUM 33
#define IP6_PREFIX_NUM129
which means a valid number
This will make the code readabil
On 5 April 2016 at 03:57, Haojian Zhuang wrote:
> On 5 April 2016 at 01:17, Ryan Harkin wrote:
>> Hi Haojian,
>>
>> I've had time to investigate where TC2 is hanging with your patches
>> applied and narrowed it down to the single line of code marked below.
>>
>> I'm going to read the code now and
On 04/05/16 09:03, Jordan Justen wrote:
> On 2016-03-14 05:53:23, Laszlo Ersek wrote:
>> These header files are intentionally minimal, and intentionally kept apart
>> from the VirtIo 0.9.5 headers.
>>
>> Cc: Ard Biesheuvel
>> Cc: Jordan Justen
>> Contributed-under: TianoCore Contribution Agreemen
Reviewed-by: Ruiyu Ni
>
>-Original Message-
>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jeff Fan
>Sent: Friday, April 01, 2016 12:57 PM
>To: edk2-devel@lists.01.org
>Cc: Ni, Ruiyu; Wu, Hao A
>Subject: [edk2] [Patch] SourceLevelDebugPkg/SmmDebugAgent: mMailbo
From: "Ni, Ruiyu"
The resource free includes to un-register the ram disk device and
free the memory occupied by the ram disk.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni
Reviewed-by: Siyuan Fu
---
MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 155 +++
From: "Ni, Ruiyu"
MemoryTypeInformation don't count the reserved memory used by RAM Disk,
but it still check all types of memory and do reset when any type
of memory size changes.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni
Reviewed-by: Siyuan Fu
---
MdeMod
From: "Ni, Ruiyu"
Use reserved memory to hold the buffer for the RAM disk to
follow the ACPI spec requirement.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni
Reviewed-by: Siyuan Fu
---
MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 149 +++---
The existing code already supports HTTP boot to RAM Disk.
The patch 1/3 is to follow the ACPI spec to use reserved memory instead
of BS memory.
Patch 2/3 is to fix the memory leak issue when Http Boot finishes or fails.
Patch 3/3 is to update memory type information check algorithm to support
Ram D
On 04/05/16 06:43, Jordan Justen wrote:
> ===
>
> web: https://github.com/jljusten/edk2/tree/fatpkg-open-source-v2
>
> git: https://github.com/jljusten/edk2.git fatpkg-open-source-v2
>
> In this commit 4cefb4cd738fc2bba95ae2e6382f4617bd86aff4.
>
> If no one has any concerns, then I'll push this
Reviewed-off-by: Jeff Fan
-Original Message-
From: Wu, Hao A
Sent: Tuesday, April 05, 2016 2:55 PM
To: edk2-devel@lists.01.org; Fan, Jeff; Gao, Liming; Kinney, Michael D
Cc: Wu, Hao A
Subject: [PATCH V2] MdePkg Cper.h: Add missing structure for 'Processor Error
Record'
Contributed-unde
Add alignment (4K) check on each processor's SMM Base address, it could help to
detect SMRR programming issue early in DEBUG image.
Cc: Michael Kinney
Cc: Jiewen Yao
Cc: Feng Tian
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jeff Fan
---
UefiCpuPkg/PiSmmCpuDxeSmm/PiS
BTS used DS save area by IA32_DS_AREA MSR to get invoker IP instead of the
Last Branch Record Stack. So, removed the unnecessary BTS MSRs.
Cc: Michael Kinney
Cc: Jiewen Yao
Cc: Feng Tian
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jeff Fan
---
UefiCpuPkg/PiSmmCpuDxe
SmmProfile feature depends on BTS feature to get the invoker IP (in SMM) from
last branch record. If this feature is not supported, SmmProfile cannot get the
invoker IP (in SMM). Per IA-32 Architectures Software Developer's Manual, BTS
feature is detected by IA32_MISC_ENABLE. If BIT11 of IA32_MISC_
On 2016-03-14 05:53:23, Laszlo Ersek wrote:
> These header files are intentionally minimal, and intentionally kept apart
> from the VirtIo 0.9.5 headers.
>
> Cc: Ard Biesheuvel
> Cc: Jordan Justen
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Laszlo Ersek
> ---
> O
This feature is enhance build tool to incorporate execution of prebuild
and postbuild.
1.Prebuild script
a.DEFINE PREBUILD in DSC [Defines] section
b.Build command -D PREBUILD to override the one in DSC [Defines] section
1)If PREBUILD is a file, then this file will be used as prebuild script.
2)If
54 matches
Mail list logo
