Re: [edk2] [PATCH] NetworkPkg: Don't need to update device path in home environment

2016-04-24 Thread Li, Gary (HPS SW)
Hi Siyuan, Let's discuss the "corporate boot option" off-line. Regards, Gary Li Platform SW Engineering Servers Office: +886 (2) 8722 9977 From: Fu, Siyuan [mailto:siyuan...@intel.com] Sent: Monday, April 25, 2016 12:59 PM To: Li, Gary (HPS SW) ; El-Haj-Mahmoud, Samer ; edk2-devel@lists.01.org

[edk2] [PATCH] ShellPkg: Fix Shell treats every .EFI file as an executable application.

2016-04-24 Thread Qiu Shumin
UEFI Shell 2.x cannot recognize whether a .EFI file is an application or a driver. This means when we typed in a driver image in Shell command line, Shell will load the driver image and try to run the entry point function of the driver. This patch check the ImageCodeType to fix the issue. Cc: Jabe

Re: [edk2] [PATCH 06/12] MdeModulePkg-FPDT(1): Add SMM_FPDT_FUNCTION_GET_BOOT_RECORD_DATA_BY_OFFSET definition.

2016-04-24 Thread Gao, Liming
Reviewed-by: Liming Gao for Patch 6~8. > -Original Message- > From: Yao, Jiewen > Sent: Friday, April 22, 2016 4:04 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming; Tian, Feng; Laszlo Ersek > Subject: [PATCH 06/12] MdeModulePkg-FPDT(1): Add > SMM_FPDT_FUNCTION_GET_BOOT_RECORD_DATA_BY_O

Re: [edk2] [PATCH] NetworkPkg: Don't need to update device path in home environment

2016-04-24 Thread Fu, Siyuan
Gary, Because both of the 2 boot options are corresponding to a same NIC handle in the system. And again, it's not a "corporate boot option", it's just a BDS created boot option, which will always reflect the real device path of that handle. You could create a real "corporate boot option", by

Re: [edk2] [PATCH] NetworkPkg: Don't need to update device path in home environment

2016-04-24 Thread Li, Gary (HPS SW)
Siyuan, The URI setting of a corporate boot option should be from DHCP server, right? If so, why is it updated by home boot option? Regards, Gary Li Platform SW Engineering Servers Office: +886 (2) 8722 9977 From: Fu, Siyuan [mailto:siyuan...@intel.com] Sent: Monday, April 25, 2016 11:47 AM To:

Re: [edk2] [PATCH] NetworkPkg: Don't need to update device path in home environment

2016-04-24 Thread Fu, Siyuan
Gary, No, anyway the device path must be updated to reflect the correct IP and URI setting for the current HTTP boot. I only explained why the corporation boot option is also updated, because it's just an auto enumerated boot option by BDS. Best Regards Siyuan From: Li, Gary (HPS SW) [mailto:g

Re: [edk2] [PATCH] NetworkPkg: Don't need to update device path in home environment

2016-04-24 Thread Li, Gary (HPS SW)
Hi Siyuan, So, this change is OK to commit, right? Regards, Gary Li Platform SW Engineering Servers Office: +886 (2) 8722 9977 -Original Message- From: Fu, Siyuan [mailto:siyuan...@intel.com] Sent: Monday, April 25, 2016 8:48 AM To: El-Haj-Mahmoud, Samer ; Li, Gary (HPS SW) ; edk2-dev

Re: [edk2] [PATCH v2 0/2] Report ACPI NFIT for reserved memory RAM disks

2016-04-24 Thread Wu, Hao A
Hi Samer, For the new RamDiskAcpiDxe driver, do you mean the driver will report all the registered reserved memory type RAM disks to NFIT at a point (like ExitBootServices)? If so, there are some concerns for at which point should those RAM disks be reported to NFIT. If the point is 'ExitBootSe

[edk2] [Patch] MdeModulePkg: Add description to MdeModulePkg AcpiTable driver.

2016-04-24 Thread Liming Gao
Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf | 3 +++ MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.uni | 8 +++- 2 files changed, 6 insertions(+), 5 deletions(-) diff --

Re: [edk2] [Patch] MdeModulePkg/DxeCore: Avoid assertion in CoreLocateProtocol

2016-04-24 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Ni, Ruiyu > Sent: Friday, April 22, 2016 5:09 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu; Gao, Liming > Subject: [Patch] MdeModulePkg/DxeCore: Avoid assertion in > CoreLocateProtocol > > The patch uses CoreAcquireLockOrFail() ins

Re: [edk2] [PATCH] NetworkPkg: Don't need to update device path in home environment

2016-04-24 Thread Fu, Siyuan
Already replied, see attached mail. > -Original Message- > From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hpe.com] > Sent: Friday, April 22, 2016 11:07 PM > To: Li, Gary (HPS SW) ; edk2-devel@lists.01.org > Cc: Ye, Ting ; Fu, Siyuan ; Wu, > Jiaxin ; El-Haj-Mahmoud, Samer mahm...

Re: [edk2] [PATCH 12/12] Vlv2TbltDevicePkg: Convert to build FatPkg from source

2016-04-24 Thread Wei, David
Looks good. Reviewed-by: zwei4 Thanks, David Intel SSG BIOS -Original Message- From: Justen, Jordan L Sent: Thursday, April 21, 2016 1:14 AM To: edk2-devel@lists.01.org; Wei, David ; He, Tim Subject: Re: [PATCH 12/12] Vlv2TbltDevicePkg: Convert to build FatPkg from source David