On Wed, Apr 27, 2016 at 05:39:40AM +, Ni, Ruiyu wrote:
>
>
> Regards,
> Ray
>
> >-Original Message-
> >From: Gary Lin [mailto:g...@suse.com]
> >Sent: Wednesday, April 27, 2016 12:29 PM
> >To: Ni, Ruiyu
> >Cc: edk2-devel@lists.01.org; Xen Devel
> >Subject: Re: [edk2] OVMF broken und
Use 128 bytes as the start size region to be same to previous one.
64 bytes is small as the first range. On X64 arch, POOL_OVERHEAD
takes 40 bytes, the pool data less than 24 bytes can be fit into
it. But, the real allocation is few that can't reduce its free pool
link list. And, the second range
Reviewed-by: David Wei
Thanks,
David
Intel SSG BIOS
-Original Message-
From: Guo, Mang
Sent: Wednesday, April 27, 2016 10:38 AM
To: edk2-devel@lists.01.org
Cc: Wei, David
Subject: [PATCH] Vlv2TbltDevicePkg: Modify DSC file to ensure
PlatformPkgIA32.dsc is sync with PlatformPkgX64.
Regards,
Ray
>-Original Message-
>From: Gary Lin [mailto:g...@suse.com]
>Sent: Wednesday, April 27, 2016 12:29 PM
>To: Ni, Ruiyu
>Cc: edk2-devel@lists.01.org; Xen Devel
>Subject: Re: [edk2] OVMF broken under Xen (in PCI initialisation)
>
>On Tue, Apr 26, 2016 at 09:40:42AM +, Ni, R
Samer,
I have merged the pull request, but seems it's not a clean way to contribution
the patch (with another merge operation). I would like to commit the patch
manually next time.
Thanks.
Jiaxin
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behal
On Tue, Apr 26, 2016 at 09:40:42AM +, Ni, Ruiyu wrote:
> Gary,
> I can reproduce the issue and have debugged to get the reason.
> In MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c:
> PciEnumeratorLight() calls PciRootBridgeIo->Configuration()
> while the Configuration returns EFI_UNSUPPO
David,
I think your original understanding should be correct. (I am not 100% sure.
Still need to double-confirm.)
For one OSAP session,
sharedSecret = HMAC(key.usageAuth, nonceEvenOSAP, nonceOddOSAP)
The shared secret will be calculated by HMACing the TPM OSAP nonce (nonceEven)
and the
Please see my comments below in [Chao]
The If{} else{} logic for debug log makes ImageVerificationLib logic more
complex and less readable.
My suggestion is to direct report image signature against DBX/DBT, image
signature against DB/DBT, image hash against DB/DBX result in debug log.
User can g
Reviewed-by: Samer El-Haj-Mahmoud
> -Original Message-
> From: Bi, Dandan
> Sent: Tuesday, April 26, 2016 11:03 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming; Dong, Eric
> Subject: [PATCH v2] MdeModulePkg: Export ConfigResp only for form
> Package after ReadyToBoot
>
> The Hii run
Already committed 2c1c50fc61132517e352862b6748c57c5d443837
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hegde,
Nagaraj P
Sent: Wednesday, April 27, 2016 11:08 AM
To: Wu, Jiaxin ; edk2-devel@lists.01.org
Cc: Ye, Ting ; Fu, Siyuan
Subject: Re: [edk2] [PATCH v1] MdePkg:Htt
I see Siyuan has already commit it:).
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Hegde, Nagaraj P
> Sent: Wednesday, April 27, 2016 11:08 AM
> To: Wu, Jiaxin ; edk2-devel@lists.01.org
> Cc: Ye, Ting ; Fu, Siyuan
> Subject: Re: [edk2] [P
Hi Jiaxin, Siyuan,
Can you please help me with the commit of this patch?
Regards,
Nagaraj.
-Original Message-
From: Wu, Jiaxin [mailto:jiaxin...@intel.com]
Sent: Wednesday, April 27, 2016 6:48 AM
To: Hegde, Nagaraj P ; edk2-devel@lists.01.org
Cc: Fu, Siyuan ; Ye, Ting ;
El-Haj-Mahmoud,
Reviewed-by: Hegde Nagaraj P
-Original Message-
From: Jiaxin Wu [mailto:jiaxin...@intel.com]
Sent: Tuesday, April 26, 2016 4:09 PM
To: edk2-devel@lists.01.org
Cc: Hegde, Nagaraj P ; El-Haj-Mahmoud, Samer
; Ye Ting ; Fu Siyuan
; Zhang Lubo
Subject: [Patch] NetworkPkg: Avoid the indefin
Reviewed-by: Liming Gao
> -Original Message-
> From: Bi, Dandan
> Sent: Tuesday, April 26, 2016 11:03 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming; Dong, Eric
> Subject: [PATCH v2] MdeModulePkg: Export ConfigResp only for form
> Package after ReadyToBoot
>
> The Hii runtime support
Hi, Nagaraj
I suggest to add more API descriptions to the modified interface, will add
below words when commit the patch. Other parts are good to me.
Reviewed-by: Fu Siyuan
/**
Generate HTTP request message.
This function will allocate memory for the whole HTTP message and generate a
we
Reviewed-by: Fu Siyuan
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Nagaraj Hegde
> Sent: Monday, April 4, 2016 6:09 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH v1 2/2] NetworkPkg:HttpDxe:Consume DxeHttpLib API
> changes
>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Mang Guo
Reviewed-by: David Wei
---
Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 11 ++-
Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 5 +++--
2 files changed, 13 insertions(+), 3 deletions(-)
diff --git a/Vlv2TbltDevicePkg/P
> On Apr 26, 2016, at 8:58 AM, Laszlo Ersek wrote:
>
> On 04/26/16 17:38, Michael Zimmermann wrote:
>> is Intel's bds deprecated now
>
> Yes, it is. I seem to remember that Ray said he wouldn't implement new
> UEFI spec features for the BDS driver in IntelFrameworkModulePkg, only
> the new one
In current code will always call submit callback function,
but we should call submit callback function when has no failure
in the submit action. This patch to fix this issues.
Cc: Liming Gao
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi
Reviewed-
When RouteConfig function fail in SubmitForForm or SubmitForFormSet
function, we should restore the question value base on the failure
information, should not restore all the question.
This patch to fix this issue.
Cc: Liming Gao
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement
Patch 1 is to restore the question value base on the
submit fail info when submit action failed.
Patch 2 is to call submit callback function only
when there are no failure in submit action.
Cc: Liming Gao
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dand
Jaben and Bhupesh,
Any comments for this patch?
Thanks.
Jiaxin
> -Original Message-
> From: Wu, Jiaxin
> Sent: Friday, April 22, 2016 11:01 AM
> To: Bhupesh Sharma ; Wu, Jiaxin
> ; edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Ye, Ting ;
> Fu, Siyuan
> Subject: RE: [edk2] [Patch] ShellP
Reviewed-by: Jiaxin Wu
> -Original Message-
> From: Nagaraj Hegde [mailto:nagaraj-p.he...@hpe.com]
> Sent: Tuesday, April 26, 2016 11:47 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Jiaxin ; Fu, Siyuan ; Ye,
> Ting ; samer.el-haj-mahm...@hpe.com
> Subject: [PATCH v1] MdePkg:Http11.h: Add d
Thanks your report. This is a bug.
We will send the patch to fix it soon. Moreover, PEBS feature is not required
for SmmProfile and only BTS feature support is enough.
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
Shifflett, Joseph
Sent: Wedne
Hi. I am attempting to rebuild my system with a host EFI bootloader,
namely GRUB.
I did a fresh install of F23(i've found that way easier than figuring
out how to migrate to EFI), turned off my CSM in host UEFI setup, got
my windows exVM booting in pure EFI, got my fedora booting in pure
EFI.
So,
Hi all,
I don't know if this is the correct place for this question, but I'm
hoping someone can provide insight.
I'm trying to calculate authorization HMACs for authenticated commands
with a TPM 1.2 from an EFI application, but I have not been able to get
the correct values the TPM expects. The
Hi,
I have referred the SATA Dxe code that in Ovmf commit:
commit b82802b83f069c7322337b802a744491010cbfb1
Author: Reza Jelveh mailto:reza.jel...@tuhh.de>>
Date: Tue Sep 22 11:18:45 2015 +
OvmfPkg: enable SATA controller
I have few queries in same context.
The SATA driver I am writing
On 04/26/16 19:47, El-Haj-Mahmoud, Samer wrote:
> Reviewed-by: Samer El-Haj-Mahmoud
>
> Chao or Laszlo, will one of you commit this please?
The only SecurityPkg maintainer is Chao (according to Maintainers.txt);
I can't commit the patch without his review.
Thanks
Laszlo
> -Original Message
Reviewed-by: Samer El-Haj-Mahmoud
Chao or Laszlo, will one of you commit this please?
Thanks,
--Samer
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Tuesday, April 26, 2016 12:17 PM
To: Shia, Cinnamon ; edk2-de...@ml01.01.org
Cc: El-Haj-Mahmoud, Samer ; chao.b.z
On 04/26/16 18:51, Cinnamon Shia wrote:
> Add DEBUG messages in DxeImageerificationLib to help debug Secure Boot image
> verification failures
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Cinnamon Shia
> Reviewed-by: Samer EL-Haj-Mahmoud
> ---
> .../DxeImageVeri
Mike, Laszlo,
Thanks for the answers.
--Samer
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Tuesday, April 26, 2016 12:13 PM
To: Kinney, Michael D ; El-Haj-Mahmoud, Samer
; edk2-devel@lists.01.org
; Mangefeste, Tony ; Andrew
Fish
Subject: Re: Questions on wr
On 04/26/16 19:04, Kinney, Michael D wrote:
> Samer,
>
> Access to edk2-staging should be identical to edk2.
>
> Every feature branch on edk2-staging requires one or more maintainer(s)
> with write access to support updates to a feature branch in edk2-staging.
>
> If a developer does not have
Samer,
Access to edk2-staging should be identical to edk2.
Every feature branch on edk2-staging requires one or more maintainer(s)
with write access to support updates to a feature branch in edk2-staging.
If a developer does not have write access to edk2-staging, then they
need to share chan
I have a question about the logic of this code here:
https://svn.code.sf.net/p/edk2/code/trunk/edk2/UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c
>From Line 958:
if (mBtsSupported) {
AsmCpuid (CPUID_VERSION_INFO, NULL, NULL, NULL, &RegEdx);
if ((RegEdx & CPUID1_EDX_BTS_AVAILABLE) != 0) {
Add DEBUG messages in DxeImageerificationLib to help debug Secure Boot image
verification failures
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Cinnamon Shia
Reviewed-by: Samer EL-Haj-Mahmoud
---
.../DxeImageVerificationLib.c | 49
Reviewed-by: Samer El-Haj-Mahmoud
-Original Message-
From: Hegde, Nagaraj P
Sent: Monday, April 25, 2016 10:47 PM
To: edk2-devel@lists.01.org
Cc: jiaxin...@intel.com; siyuan...@intel.com; ting...@intel.com;
El-Haj-Mahmoud, Samer
Subject: [PATCH v1] MdePkg:Http11.h: Add defines for "Ex
Reviewed-by: Samer El-Haj-Mahmoud
-Original Message-
From: Fu, Siyuan
Sent: Tuesday, April 26, 2016 11:47 AM
To: edk2-devel@lists.01.org
Cc: Li Gary ; Ye, Ting ; Wu, Jiaxin
Subject: [PATCH v2] NetworkPkg: Allow user to create a HTTP corporate boot
option in setup page.
This patch up
Agreed. Will fixed it in the v3 patch.
Thanks,
Cinnamon Shia
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Tuesday, April 26, 2016 11:54 PM
To: Shia, Cinnamon ; edk2-de...@ml01.01.org
Cc: El-Haj-Mahmoud, Samer ; chao.b.zh...@intel.com
Subject: Re: [PATCH v2] Secu
Does not look like I have write permission to edk2-staging... I sent a separate
email with question on the write access permissions for edk2-staging
I also created a pull request against the edk2-staging/https-tls branch:
https://github.com/tianocore/edk2-staging/pull/1
-Original Message-
What is the process of requesting write access to edk2-staging?
*Should only module and tree maintainers have write access (similar to
edk2)?
*Should developers working on contributing to the feature branches have
write access?
Also related:
*Should developers use pu
Heyi,
I agree the source code required to detect the current tick rate using only
UEFI services
is more complex.
However, a UEFI driver (especially ones on an add-in devices such as a PCI
adapter) should not
use a PCD for the system tick rate because the add-in card can be used in
systems with
Thanks Laszlo. I tried this and it worked...
git format-patch --subject-prefix="staging/HTTPS-TLS][PATCH"
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Tuesday, April 26, 2016 6:16 AM
To: Wu, Jiaxin ; Carsey, Jaben ;
El-Haj-Mahmoud, Samer
Cc: edk2-devel@list
Removed unnecessary error condition in TLS Lib that that would report an
error if a certificate is being added to the X509_STORE more than once.
This causes HTTPS to fail on second attempt with the same certificate.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Samer El-Ha
New change looks good to me.
Thanks,
Simon
-Original Message-
From: Wu, Hao A [mailto:hao.a...@intel.com]
Sent: Tuesday, April 26, 2016 12:05 AM
To: Tian, Feng; edk2-devel@lists.01.org
Cc: Simon (Xiang) Lian-SSI
Subject: RE: [patch] MdeModulePkg/NvmExpressDxe: comments update to meet
impl
On 04/21/16 08:57, Ruiyu Ni wrote:
> It will be changed to build with MdeModulePkg/BDS.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ruiyu Ni
> Cc: Jordan Justen
> Cc: Laszlo Ersek
> ---
> .../Library/PlatformBootManagerLib/BdsPlatform.c | 1575
>
On 04/26/16 17:13, Jordan Justen wrote:
> Series Reviewed-by: Jordan Justen
Thank you, commit range dea0d6bf2f19..0b448dd8b27c.
Laszlo
> On 2016-04-26 05:42:10, Laszlo Ersek wrote:
>> Brown paper bag for Laszlo.
>>
>> Fix tested with repeated connects / disconnects on Q35's PCI dev/fun at
>> 00
On 04/26/16 17:38, Michael Zimmermann wrote:
> is Intel's bds deprecated now
Yes, it is. I seem to remember that Ray said he wouldn't implement new
UEFI spec features for the BDS driver in IntelFrameworkModulePkg, only
the new one in MdeModulePkg.
IIRC the main reason for the new BDS driver (in M
On 04/26/16 17:22, Cinnamon Shia wrote:
> Add DEBUG messages in DxeImageerificationLib to help debug Secure Boot image
> verification failures
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Cinnamon Shia
> Reviewed-by: Samer EL-Haj-Mahmoud
> ---
> .../DxeImageVeri
is Intel's bds deprecated now or what is this switch about?
Michael
On Thu, Apr 21, 2016 at 9:03 AM, Ni, Ruiyu wrote:
> The changes set can be found in below GIT repos:
> https://github.com/niruiyu/edk2/tree/Ovmf_Bds2
>
>
> Regards,
> Ray
>
> >-Original Message-
> >From: Ni, Ruiyu
> >Se
Add DEBUG messages in DxeImageerificationLib to help debug Secure Boot image
verification failures
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Cinnamon Shia
Reviewed-by: Samer EL-Haj-Mahmoud
---
.../DxeImageVerificationLib.c | 37
On 04/21/16 08:57, Ruiyu Ni wrote:
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ruiyu Ni
> Cc: Jordan Justen
> Cc: Laszlo Ersek
> ---
> .../PlatformBootManagerLib/PlatformBdsLib.inf | 73
> --
> .../PlatformBootManagerLib.inf
Hi Michael,
It seems we are making the implementation more and more complicated. How
about just creating a PCD for polling rate which can be set freely by
platforms?
Regards.
Heyi
On 04/24/2016 12:11 AM, Kinney, Michael D wrote:
Heyi Guo,
The TerminalDxe driver is intended to be a UEFI Dr
Series Reviewed-by: Jordan Justen
On 2016-04-26 05:42:10, Laszlo Ersek wrote:
> Brown paper bag for Laszlo.
>
> Fix tested with repeated connects / disconnects on Q35's PCI dev/fun at
> 00:1f.2 (onboard SATA controller) in the UEFI shell.
>
> Patches formatted with --function-context for better
This patch looks very good, I have a few minor comments.
(Sorry that I'm taking so long to review individual patches -- reviewing this
one, and writing up my comments for it, took me two hours, for example. I'm
trying to be thorough.)
On 04/21/16 08:57, Ruiyu Ni wrote:
> NOTE: SetBootOrderFromQ
Make sense to me. Will fix it in the patch v2.
Thanks,
Cinnamon Shia
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Tuesday, April 26, 2016 9:27 PM
To: Shia, Cinnamon ; edk2-de...@ml01.01.org
Cc: El-Haj-Mahmoud, Samer ; chao.b.zh...@intel.com
Subject: Re: [edk2] [
On 04/26/16 15:10, Shia, Cinnamon wrote:
> Hi Lazlo,
>
> Thanks for your feedbacks.
>
> How VerifyStatus being used in ImageVerificationInAuditMode() is from
> DxeImageVerificationHandler(). Not 100% the same, but similar.
Yes, that's why I got confused initially about it; I recalled the name.
Hi Lazlo,
Thanks for your feedbacks.
How VerifyStatus being used in ImageVerificationInAuditMode() is from
DxeImageVerificationHandler(). Not 100% the same, but similar.
Changing its type to BOOLEAN sounds good to me, do we need to change its name
from VerifyStatus to SigFoundInDb to match its
On 04/21/16 08:57, Ruiyu Ni wrote:
> QemuNewBootOrderLib will be changed to work with MdeModulePkg/BDS.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ruiyu Ni
> Cc: Jordan Justen
> Cc: Laszlo Ersek
> ---
> .../Library/QemuNewBootOrderLib/ExtraRootBusMap.c | 313
It would be possible to remove the UAF without local variables, by calling
SataPrivateData->PciIo->Attributes() before releasing SataPrivateData.
However, by keeping the location of the call (for which temporary
variables are necessary), we continue to match the error path logic in
SataControllerS
Brown paper bag for Laszlo.
Fix tested with repeated connects / disconnects on Q35's PCI dev/fun at
00:1f.2 (onboard SATA controller) in the UEFI shell.
Patches formatted with --function-context for better readability.
Cc: wang xiaofeng
Cc: Jordan Justen
Cc: Ruiyu Ni
Laszlo Ersek (2):
Ovmf
"ASSERT (SataPrivateData != NULL)" is just a few lines higher up.
Cc: Jordan Justen
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
OvmfPkg/SataControllerDxe/SataController.c | 20 +---
1 file changed, 9 insertions(+), 11 deletions(-)
dif
On 04/26/16 03:50, Yao, Jiewen wrote:
> Comments below:
>
>> -Original Message-
>> From: Laszlo Ersek [mailto:ler...@redhat.com]
>> Sent: Tuesday, April 26, 2016 12:32 AM
>> To: Yao, Jiewen
>> Cc: edk2-de...@ml01.01.org; Gao, Liming ; Tian,
>> Feng ; Zeng, Star ; Dong, Eric
>> ; Justen, J
On 04/26/16 02:43, Wu, Jiaxin wrote:
> Hi Samer,
>
> I think the prefix with " staging/branch][PATCH " should be good to the
> staging patch subject.
>
> For example:
> *git format-patch --subject-prefix="staging/HTTPS-TLS][PATCH"*
>
> Then, you will get the patch with "[staging/HTTPS-TLS][PAT
On 04/26/16 13:04, Laszlo Ersek wrote:
> On 04/26/16 09:02, Cinnamon Shia wrote:
>> Add DEBUG messages in DxeImageerificationLib to help debug Secure Boot image
>> verification failures
>>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Cinnamon Shia
>> Reviewed-by: S
On 04/26/16 09:02, Cinnamon Shia wrote:
> Add DEBUG messages in DxeImageerificationLib to help debug Secure Boot image
> verification failures
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Cinnamon Shia
> Reviewed-by: Samer EL-Haj-Mahmoud
> ---
> .../DxeImageVeri
Hi,
Could someone please commit this change, if have no objection.
Thanks
AbduL
From: Qiu, Shumin
Sent: Friday, April 22, 2016 7:50:48 AM
To: Attar, Abdul Lateef; Carsey, Jaben; Ni, Ruiyu; edk2-devel@lists.01.org
Cc: Parthasarathy, Mohan (HPE Servers);
Need the timer check to avoid the indefinite wait case
in HttpDxe driver
A.HTTP receive Header process in HttpTcpReceiveHeader();
B.HTTP receive Body process in HttpTcpReceiveBody();
Cc: Hegde Nagaraj P
Cc: El-Haj-Mahmoud Samer
Cc: Ye Ting
Cc: Fu Siyuan
Cc: Zhang Lubo
Contributed-under: Tiano
On 04/26/16 09:28, Ni, Ruiyu wrote:
> Adding Laszlo & Jordan,
> It sounds like a trivial bug.
Sigh. This is my mess, from commit bcab71413407e. Thanks for the report,
I'll fix it up soon. :(
Thanks
Laszlo
>> -Original Message-
>> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org]
On 04/26/16 05:49, Zhang, Chao B wrote:
> Hi all:
> It looks like final decision on security fix procedure has not been
> made clear. Should I check-in the patch under review or block and
> wait for the final decision?
Sorry about the delay.
If you have received positive review feedback from the
On Tue, Apr 26, 2016 at 10:31:22AM +0100, Andrew Cooper wrote:
>
> > I tried to make RootBridgeIoConfiguration() return EFI_UNSUPPORTED
> > (see the attachment), and those asserts were gone. However, the system
> > stuck somewhere after loading shell.efi. Here are the messages from the
> > debug l
Gary,
I can reproduce the issue and have debugged to get the reason.
In MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c:
PciEnumeratorLight() calls PciRootBridgeIo->Configuration()
while the Configuration returns EFI_UNSUPPORTED resulting
the PciBus driver exits earlier.
You could try to manu
Reviewed-by: Jiaxin Wu
> -Original Message-
> From: Fu, Siyuan
> Sent: Tuesday, April 26, 2016 11:47 AM
> To: edk2-devel@lists.01.org
> Cc: Li Gary ; Ye, Ting ; Wu, Jiaxin
>
> Subject: [PATCH v2] NetworkPkg: Allow user to create a HTTP corporate boot
> option in setup page.
>
> This pa
On Tue, Apr 26, 2016 at 08:19:49AM +, Ni, Ruiyu wrote:
> Gary,
> Maybe the system boots to Shell well but the video isn't initialized properly.
> Can you build the firmware using "-D DEBUG_ON_SERIAL_PORT" switch and
> give me the boot log?
>
Hi Ray,
I already did and it's how I make the firmw
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Zeng, Star
> Sent: Friday, April 22, 2016 2:37 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen ; Tian, Feng
> Subject: [PATCH] MdeModulePkg DxeCore: Check free memory type by
> CoreUpdateProfile()
>
> It can improve profi
Reviewed-by: Qiu Shumin
-Original Message-
From: Bi, Dandan
Sent: Tuesday, April 26, 2016 4:25 PM
To: edk2-devel@lists.01.org
Cc: Qiu, Shumin; Dong, Eric
Subject: [patch] MdeModulePkg: BOOLEAN type needn't to compare to TRUE/FALSE
explicitly
Fix this issue to follow the coding style.
Fix this issue to follow the coding style.
Cc: Qiu Shumin
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi
---
MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MdeModulePkg/Un
Gary,
Maybe the system boots to Shell well but the video isn't initialized properly.
Can you build the firmware using "-D DEBUG_ON_SERIAL_PORT" switch and
give me the boot log?
Regards,
Ray
From: Gary Lin [mailto:g...@suse.com]
Sent: Tuesday, April 26, 2016 3:35 PM
To: Ni, Ruiyu
Cc: Anthony PERA
On Tue, Apr 26, 2016 at 06:43:56AM +, Ni, Ruiyu wrote:
>
>
> Regards,
> Ray
>
> >-Original Message-
> >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> >Anthony PERARD
> >Sent: Friday, April 22, 2016 10:48 PM
> >To: edk2-devel@lists.01.org
> >Cc: Xen Devel
>
Adding Laszlo & Jordan,
It sounds like a trivial bug.
Regards,
Ray
>-Original Message-
>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of wang
>xiaofeng
>Sent: Tuesday, April 26, 2016 3:02 PM
>To: Ni, Ruiyu
>Cc: edk2-devel@lists.01.org
>Subject: [edk2] A logic error
Cc: Simon (Xiang) Lian-SSI
Cc: Wu, Hao A
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Feng Tian
---
MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpress.h | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmEx
Reviewed-by: Hao Wu
Best Regards,
Hao Wu
> -Original Message-
> From: Tian, Feng
> Sent: Tuesday, April 26, 2016 3:01 PM
> To: edk2-devel@lists.01.org
> Cc: Simon Lian-SSI; Wu; Wu, Hao A
> Subject: [patch] MdeModulePkg/NvmExpressDxe: comments update to meet
> implementation
>
> Cc: Simo
Add DEBUG messages in DxeImageerificationLib to help debug Secure Boot image
verification failures
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Cinnamon Shia
Reviewed-by: Samer EL-Haj-Mahmoud
---
.../DxeImageVerificationLib.c | 38
Hi All ,
I found a logic error in SataControllerStop of
OvmfPkg\SataControllerDxe\SataController.c.
The following code will first free SataPrivateData ,then try to use
SataPrivateData
if (SataPrivateData != NULL) {
if (SataPrivateData->DisqualifiedModes != NULL) {
FreePoo
83 matches
Mail list logo