Re: [edk2] facing compilation failure : undefined reference to memcpy()

2016-05-11 Thread Andrew Fish
> On May 11, 2016, at 11:45 PM, Meenakshi Aggarwal > wrote: > > Hi, > > I am working on a 64 bit arm based SoC. > > I am uprev'ing my edk2 code base to latest master branch: > Commit id - ce1647fc608e8193b416a08da633019de611199c > > > I am able to compile my code successfully in DEBUG mode

[edk2] facing compilation failure : undefined reference to memcpy()

2016-05-11 Thread Meenakshi Aggarwal
Hi, I am working on a 64 bit arm based SoC. I am uprev'ing my edk2 code base to latest master branch: Commit id - ce1647fc608e8193b416a08da633019de611199c I am able to compile my code successfully in DEBUG mode but in RELEASE mode I am facing following error: Building ... /home/tools/meena

[edk2] [Patch] BaseTools/GenFw: enhance to use Magic Field to identify the image

2016-05-11 Thread Yonghong Zhu
Original use the File Header Machine Field to identify EFI_IMAGE_OPTIONAL_HEADER32 or EFI_IMAGE_OPTIONAL_HEADER64, it cannot correctly handle EBC arch PE32 image. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu --- BaseTools/Source/C/GenFw/GenF

Re: [edk2] [PATCH v2 1/1] MdeModulePkg:DxeHttpLib: Add checks in HttpGenRequestMessage API

2016-05-11 Thread Hegde, Nagaraj P
Hi Siyuan, Do you have any additional feedback on the patch v2? Regards, Nagaraj. -Original Message- From: Wu, Jiaxin [mailto:jiaxin...@intel.com] Sent: Monday, May 09, 2016 7:29 AM To: Hegde, Nagaraj P ; edk2-devel@lists.01.org Cc: Ye, Ting ; Fu, Siyuan Subject: RE: [edk2] [PATCH v2 1

[edk2] [patch] MdeModulePkg/SetupBrowser: Clean the BufferValue for string before use

2016-05-11 Thread Dandan Bi
When copy new string content to BufferValue, need to clean the BufferValue firstly, or the BufferValue may contain some content that doesn't belong to the new string. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/

Re: [edk2] [PATCH] OvmfPkg/PlatformBootManagerLib: Postpone the shell registration

2016-05-11 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Regards, Ray >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Wednesday, May 11, 2016 6:28 PM >To: Gary Lin ; edk2-de...@ml01.01.org >Cc: Justen, Jordan L ; Ni, Ruiyu > >Subject: Re: [PATCH] OvmfPkg/PlatformBootManagerLib: Postpone the

Re: [edk2] [PATCH] BaseTools: Add HII definitions from UEFI 2.6

2016-05-11 Thread Bi, Dandan
A minor comment: There are some whitespace in the line " typedef struct _EFI_HII_IIBT_PNG_BLOCK { " and the line below " (C) Copyright 2016 Hewlett Packard Enterprise Development LP ". Please remove them when commit the patch. You can use the patch check tool (BaseTools\Scripts\PatchCheck.py) t

Re: [edk2] [PATCH] MdePkg: Add HII definitions from UEFI 2.6

2016-05-11 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Bi, Dandan > Sent: Thursday, May 12, 2016 10:50 AM > To: Samer El-Haj-Mahmoud ; edk2- > de...@lists.01.org > Cc: Kinney, Michael D ; Samer El-Haj- > Mahmoud ; Gao, Liming > Subject: RE: [edk2] [PATCH] MdePkg: Add HII definitions from U

Re: [edk2] [PATCH] MdePkg: Add HII definitions from UEFI 2.6

2016-05-11 Thread Bi, Dandan
Reviewed-by: Dandan Bi Thanks, Dandan -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Samer El-Haj-Mahmoud Sent: Thursday, May 12, 2016 4:31 AM To: edk2-devel@lists.01.org Cc: Kinney, Michael D ; Samer El-Haj-Mahmoud ; Gao, Liming Subject: [edk

Re: [edk2] [PATCH v2 0/6] ATA PassThru & SATA device path PortMultiplier update

2016-05-11 Thread Tian, Feng
Looks good to me Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Wu, Hao A Sent: Tuesday, May 10, 2016 10:25 AM To: edk2-devel@lists.01.org; Tian, Feng Cc: Wu, Hao A Subject: [PATCH v2 0/6] ATA PassThru & SATA device path PortMultiplier update Changes compared with V1: 1

Re: [edk2] [PATCH 0/3] *** Add Nvme.h and NvmExpressLib ***

2016-05-11 Thread Tian, Feng
Hi, Darbin As you know, we take extra caution on interface changes. We expect it's stable enough. So I have the below questions: 1. I only see the NVME_ADMIN cmds are added, could you add NVME_IO cmds to Nvme.h as well? 2. Shall we be compliance with NVMe 1.2 spec to add missing cmds? 3. what's

Re: [edk2] [staging/HTTPS-TLS][PATCH] NetworkPkg: Handle HTTPS indefinite poll case

2016-05-11 Thread Ye, Ting
Looks good to me. Reviewed-by: Ye Ting -Original Message- From: Wu, Jiaxin Sent: Thursday, May 12, 2016 8:19 AM To: samer.el-haj-mahm...@hpe.com; edk2-devel@lists.01.org Cc: Ye, Ting ; Fu, Siyuan ; Long, Qin Subject: RE: [edk2] [staging/HTTPS-TLS][PATCH] NetworkPkg: Handle HTTPS inde

Re: [edk2] [patch] NetworkPkg: Bug fix of iSCSI to support MPIO

2016-05-11 Thread Wu, Jiaxin
Reviewed-By: Wu Jiaxin > -Original Message- > From: Zhang, Lubo > Sent: Wednesday, May 11, 2016 9:38 AM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Fu, Siyuan ; Wu, > Jiaxin > Subject: [patch] NetworkPkg: Bug fix of iSCSI to support MPIO > > If two attempts added on different NIC an

Re: [edk2] [staging/HTTPS-TLS][PATCH] NetworkPkg: Handle HTTPS indefinite poll case

2016-05-11 Thread Fu, Siyuan
The patch is good to me. Reviewed-by: Fu Siyuan From: Wu, Jiaxin Sent: Thursday, May 12, 2016 8:19 AM To: samer.el-haj-mahm...@hpe.com; edk2-devel@lists.01.org Cc: Ye, Ting ; Fu, Siyuan ; Long, Qin Subject: RE: [edk2] [staging/HTTPS-TLS][PATCH] NetworkPkg: Handle HTTPS indefinite poll case H

Re: [edk2] [PATCH 0/3] *** Add Nvme.h and NvmExpressLib ***

2016-05-11 Thread El-Haj-Mahmoud, Samer
Series Reviewed-By : Samer El-Haj-Mahmoud -Original Message- From: Reyes, Darbin [darbin.emm.re...@hpe.com] Received: Wednesday, 11 May 2016, 6:07PM To: edk2-devel@lists.01.org [edk2-devel@lists.01.org] CC: feng.t...@intel.com [feng.t...@intel.com]; star.z...@intel.com [star.z...@intel

Re: [edk2] [PATCH] SecurityPkg: Remove non-ASCII character from TPM warning strings

2016-05-11 Thread Zhang, Chao B
Reviewed-by: Chao Zhang Thanks & Best regards Chao Zhang -Original Message- From: Samer El-Haj-Mahmoud [mailto:samer.el-haj-mahm...@hpe.com] Sent: Thursday, May 12, 2016 4:58 AM To: edk2-devel@lists.01.org Cc: samer.el-haj-mahm...@hpe.com; Zhang, Chao B; Samer El-Haj-Mahmoud Subject

Re: [edk2] [staging/HTTPS-TLS][PATCH] NetworkPkg: Handle HTTPS indefinite poll case

2016-05-11 Thread Wu, Jiaxin
Thanks Samer. /Jiaxin From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hpe.com] Sent: Thursday, May 12, 2016 8:21 AM To: edk2-devel@lists.01.org; Wu, Jiaxin Cc: Ye, Ting ; Fu, Siyuan ; Long, Qin Subject: RE: [edk2] [staging/HTTPS-TLS][PATCH] NetworkPkg: Handle HTTPS indefinite poll cas

Re: [edk2] [staging/HTTPS-TLS][PATCH] NetworkPkg: Handle HTTPS indefinite poll case

2016-05-11 Thread El-Haj-Mahmoud, Samer
Sorry for the delay Jiaxin. I don't see issues with this. I did pull it into our build and didn't find any regression. Reviewed-by : Samer El-Haj-Mahmoud -Original Message- From: Wu, Jiaxin [jiaxin...@intel.com] Received: Wednesday, 11 May 2016, 7:18PM To: El-Haj-Mahmoud, Samer [same

Re: [edk2] [staging/HTTPS-TLS][PATCH] NetworkPkg: Handle HTTPS indefinite poll case

2016-05-11 Thread Wu, Jiaxin
Hi all, Any comments for this patch? Thanks. Jiaxin > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Jiaxin Wu > Sent: Wednesday, May 4, 2016 3:08 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Fu, Siyuan ; Long, > Qin > Subject: [edk2]

[edk2] [PATCH 2/3] QuarkPlatformPkg: Fix variable set but not used build errors

2016-05-11 Thread Lee Leahy
Fix variable set but not used errors detected by GCC 4.8. Change-Id: I83634f88cfa89ea8afdfebbd0c7487f04e440693 Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Lee Leahy --- QuarkPlatformPkg/Acpi/DxeSmm/SmmPowerManagement/Ppm.c | 14 +- .../Library/Platform

[edk2] [PATCH 3/3] QuarkSocPkg/SDControllerDxe: Add EFIAPI to SetHighSpeedMode

2016-05-11 Thread Lee Leahy
Fix 64-bit build error detected with GCC4.8 due to inconsistent routine declaration and implementation. Add EFIAPI to fix the build error. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Lee Leahy --- QuarkSocPkg/QuarkSouthCluster/Sdio/Dxe/SDControllerDxe/SDController.c |

[edk2] [PATCH 1/3] QuarkPlatformPkg: Fix build errors

2016-05-11 Thread Lee Leahy
Fix build errors detected with GCC 4.8.4: local variable set but not used! Change-Id: I5e3cfb46b367a72bd333fd762c22968fbac4e6f9 Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Lee Leahy --- QuarkPlatformPkg/Acpi/Dxe/AcpiPlatform/AcpiPciUpdate.c | 2 -- QuarkPl

[edk2] [PATCH 1/1] EmbeddedPkg/Lan9118Dxe: Do not return uninitialised TxBuff

2016-05-11 Thread Michael Brown
Conform to the specification for GetStatus(), which states that "if there are no transmit buffers to recycle and TxBuf is not NULL, *TxBuf will be set to NULL". Cc: Leif Lindholm Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael Brown --- Embedde

Re: [edk2] [PATCH] MdeModulePkg/DxeIplPeim: RISC-V arch DxeIpl.

2016-05-11 Thread Andrew Fish
> On May 9, 2016, at 11:24 AM, Mangefeste, Tony > wrote: > > Yao has the best idea, which is for Abner to package this into a RiscV*.pkg, > and perhaps into a platform branch or staging branch (depending on a number > of factors). > > Abner, run this through the PIWG as you stated, that's ex

Re: [edk2] [PATCH 2/7] CorebootPayloadPkg: Assume no PCI serial devices

2016-05-11 Thread Ma, Maurice
OK. Reviewed-by: Maurice Ma -Original Message- From: Leahy, Leroy P Sent: Wednesday, May 11, 2016 1:36 PM To: Ma, Maurice; edk2-devel@lists.01.org; Agyeman, Prince Subject: RE: [PATCH 2/7] CorebootPayloadPkg: Assume no PCI serial devices Hi Maurice, This is the intent. The entire PCD

Re: [edk2] [PATCH 3/7] CorebootPayloadPkg: Use correct BaseSerialPortLib16550

2016-05-11 Thread Ma, Maurice
OK, that is fine. Reviewed-by: Maurice Ma -Original Message- From: Leahy, Leroy P Sent: Wednesday, May 11, 2016 1:38 PM To: Ma, Maurice; edk2-devel@lists.01.org; Agyeman, Prince Subject: RE: [PATCH 3/7] CorebootPayloadPkg: Use correct BaseSerialPortLib16550 As we had discussed on the p

[edk2] [PATCH] SecurityPkg: Remove non-ASCII character from TPM warning strings

2016-05-11 Thread Samer El-Haj-Mahmoud
Remove a non-ASCII apostrophe character from TPM_WARNING_MAINTAIN message Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Samer El-Haj-Mahmoud --- .../Library/DxeTcgPhysicalPresenceLib/PhysicalPresenceStrings.uni | 3 ++- 1 file changed, 2 insertions(+

[edk2] [PATCH] MdePkg: Add NFIT definition from ACPI 6.1

2016-05-11 Thread Samer El-Haj-Mahmoud
Add NFIT definition from ACPI 6.1 for the NVDIMM Control Region Structure Valid Fields for Manufacturing Location and Manufacturing Date Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Samer El-Haj-Mahmoud --- MdePkg/Include/IndustrySt

Re: [edk2] [PATCH 3/7] CorebootPayloadPkg: Use correct BaseSerialPortLib16550

2016-05-11 Thread Leahy, Leroy P
As we had discussed on the phone last week. I am going to make these changes first in CorebootModulePkg and then post the patches to MdeModulePkg. When the patches get merged into MdeModulePkg then I will be able to remove the corresponding components from CorebootModulePkg. Lee Leahy (425) 8

Re: [edk2] [PATCH 2/7] CorebootPayloadPkg: Assume no PCI serial devices

2016-05-11 Thread Leahy, Leroy P
Hi Maurice, This is the intent. The entire PCD needs to be present. If coreboot uses a PCI device for its console then this PCD is written with the necessary values. The first two bytes are set to the vendor and device ID values of the PCI device that coreboot is using. Lee Leahy (425) 881-

[edk2] [PATCH] MdePkg: Add HII definitions from UEFI 2.6

2016-05-11 Thread Samer El-Haj-Mahmoud
Add HII definitions from UEFI 2.6 for HII Image Variability and PNG Blocks Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Samer El-Haj-Mahmoud --- MdePkg/Include/Uefi/UefiInternalFormRepresentation.h | 16 1 file chan

[edk2] [PATCH] BaseTools: Add HII definitions from UEFI 2.6

2016-05-11 Thread Samer El-Haj-Mahmoud
Add HII definitions from UEFI 2.6 for HII Image Variability and PNG Blocks Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Samer El-Haj-Mahmoud --- .../Common/UefiInternalFormRepresentation.h| 24 ++ 1 file chan

Re: [edk2] [PATCH 1/7] CorebootPayloadPkg: Use DOS line endings

2016-05-11 Thread Ma, Maurice
I think we probably should to conform to the EDK2 Coding standards. Maurice From: Michael Zimmermann [mailto:sigmaepsilo...@gmail.com] Sent: Wednesday, May 11, 2016 11:01 AM To: Ma, Maurice Cc: Leahy, Leroy P; edk2-devel@lists.01.org; Agyeman, Prince Subject: Re: [edk2] [PATCH 1/7] CorebootPayload

Re: [edk2] edk2 llvm branch

2016-05-11 Thread Andrew Fish
> On May 11, 2016, at 9:38 AM, Shi, Steven wrote: > > Hi Andrew, > > Attachment and below are my build map files and code size for your suggested > two modules with CLANGLTO38 and VS2013x86. Maybe I should use latest > VS2015x86 for the comparing next time. > Steven, Thanks for the data.

Re: [edk2] [PATCH 3/7] CorebootPayloadPkg: Use correct BaseSerialPortLib16550

2016-05-11 Thread Ma, Maurice
Hi, Leah, Is this flow control specific to coreboot? If not, why not suggest the change in MdeModulePkg instead ? Thanks Maurice -Original Message- From: Leahy, Leroy P Sent: Tuesday, May 10, 2016 3:34 PM To: edk2-devel@lists.01.org; Leahy, Leroy P; Agyeman, Prince; Ma, Maurice Subje

Re: [edk2] [PATCH 2/7] CorebootPayloadPkg: Assume no PCI serial devices

2016-05-11 Thread Ma, Maurice
Hi, Leah, Is this list really consumed? I saw the 0x terminator at the very beginning of the list. So it indicates an empty list.Is this the intention? Thanks Maurice -Original Message- From: Leahy, Leroy P Sent: Tuesday, May 10, 2016 3:34 PM To: edk2-devel@lists.01.org; Le

Re: [edk2] [PATCH 4/7] CorebootPayloadPkg: Set the proper Shell file GUID

2016-05-11 Thread Ma, Maurice
Looks fine to me. Reviewed-by: Maurice Ma -Original Message- From: Leahy, Leroy P Sent: Tuesday, May 10, 2016 3:35 PM To: edk2-devel@lists.01.org; Leahy, Leroy P; Agyeman, Prince; Ma, Maurice Subject: [PATCH 4/7] CorebootPayloadPkg: Set the proper Shell file GUID Set the proper Shell fi

Re: [edk2] [PATCH 7/7] CorebootPayloadPkg: Add BdsDxe support

2016-05-11 Thread Ma, Maurice
Any reason that we have to support both? I think we can just use MdeModulePkg/Universal/BdsDxe and remove IntelFrameworkModulePkg/Universal/BdsDxe reference from DSC/FDF. Thanks Maurice -Original Message- From: Leahy, Leroy P Sent: Tuesday, May 10, 2016 3:35 PM To: edk2-devel@lists.01.or

Re: [edk2] [PATCH 5/7] CorebootPayloadPkg: Add SD/eMMC support

2016-05-11 Thread Ma, Maurice
Looks fine to me. Reviewed-by: Maurice Ma -Original Message- From: Leahy, Leroy P Sent: Tuesday, May 10, 2016 3:35 PM To: edk2-devel@lists.01.org; Leahy, Leroy P; Agyeman, Prince; Ma, Maurice Subject: [PATCH 5/7] CorebootPayloadPkg: Add SD/eMMC support Add SD and eMMC DXE driver support

Re: [edk2] [PATCH 1/7] CorebootPayloadPkg: Use DOS line endings

2016-05-11 Thread Michael Zimmermann
I regularly see these commits, shouldn't we convert all files to DOS line endings recursively? there currently are 627 files with unix line endings. Michael On Wed, May 11, 2016 at 7:55 PM, Ma, Maurice wrote: > Looks fine. > > Reviewed-by: Maurice Ma > > -Original Message- > From: Leah

Re: [edk2] [PATCH 1/7] CorebootPayloadPkg: Use DOS line endings

2016-05-11 Thread Ma, Maurice
Looks fine. Reviewed-by: Maurice Ma -Original Message- From: Leahy, Leroy P Sent: Tuesday, May 10, 2016 3:34 PM To: edk2-devel@lists.01.org; Leahy, Leroy P; Agyeman, Prince; Ma, Maurice Subject: [PATCH 1/7] CorebootPayloadPkg: Use DOS line endings Convert to using DOS line endings. Ch

Re: [edk2] edk2 llvm branch

2016-05-11 Thread Shi, Steven
Hi Andrew, Attachment and below are my build map files and code size for your suggested two modules with CLANGLTO38 and VS2013x86. Maybe I should use latest VS2015x86 for the comparing next time. * CLANGLTO38: > build -a IA32 -t CLANGLTO38 -p OvmfPkg/OvmfPkgIa32.dsc -n 5 -m > IntelF

Re: [edk2] edk2 llvm branch

2016-05-11 Thread Andrew Fish
> On May 11, 2016, at 5:08 AM, Shi, Steven wrote: > > Hi Andrew, > From your data, it looks the XCode LTO is not enabled correctly for IA32, but > correct for X64. Attachment has my build map files, and below are my build > commands. FYI. > Sorry had a typo in the tools_def.txt, here are the

Re: [edk2] [PATCH 1/2] ArmPlatformPkg/PL031RealTimeClockLib: don't clobber gRT table

2016-05-11 Thread Leif Lindholm
On Wed, May 11, 2016 at 04:21:35PM +0200, Ard Biesheuvel wrote: > On 13 April 2016 at 10:10, Ard Biesheuvel wrote: > > PL031RealTimeClockLib is a base library that could potentially (although > > unlikely) be incorporated into other modules than the DXE_RUNTIME_DRIVER > > module that it was intend

Re: [edk2] [PATCH 1/2] ArmPlatformPkg/PL031RealTimeClockLib: don't clobber gRT table

2016-05-11 Thread Ard Biesheuvel
On 13 April 2016 at 10:10, Ard Biesheuvel wrote: > PL031RealTimeClockLib is a base library that could potentially (although > unlikely) be incorporated into other modules than the DXE_RUNTIME_DRIVER > module that it was intended to complement. > > This means the library has no business whatsoever

Re: [edk2] [PATCH] ArmPkg/PlatformBootManagerLib: implement new generic version

2016-05-11 Thread Ard Biesheuvel
On 11 May 2016 at 14:54, Laszlo Ersek wrote: > On 05/11/16 14:47, Ard Biesheuvel wrote: >> This implements the platform glue for the new generic BDS implementation. >> It is based on the ArmVirtQemu version, with the QEMU references removed. >> >> Contributed-under: TianoCore Contribution Agreemen

Re: [edk2] [PATCH] ArmPkg/PlatformBootManagerLib: implement new generic version

2016-05-11 Thread Laszlo Ersek
On 05/11/16 14:47, Ard Biesheuvel wrote: > This implements the platform glue for the new generic BDS implementation. > It is based on the ArmVirtQemu version, with the QEMU references removed. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > --- > Arm

[edk2] [PATCH] ArmPkg/PlatformBootManagerLib: implement new generic version

2016-05-11 Thread Ard Biesheuvel
This implements the platform glue for the new generic BDS implementation. It is based on the ArmVirtQemu version, with the QEMU references removed. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c

Re: [edk2] edk2 llvm branch

2016-05-11 Thread Shi, Steven
Hi Andrew, >From your data, it looks the XCode LTO is not enabled correctly for IA32, but >correct for X64. Attachment has my build map files, and below are my build >commands. FYI. VS2013x86: build -a IA32 -t VS2013x86 -p OvmfPkg\OvmfPkgIa32.dsc -n 5 -m MdeModulePkg\Core\Pei\PeiMain.inf -b REL

Re: [edk2] [PATCH v2 3/3] IntelFrameworkModulePkg/BdsDxe: Show boot timeout message

2016-05-11 Thread Ryan Harkin
On 5 May 2016 at 06:09, Ni, Ruiyu wrote: > > > Regards, > Ray > >>-Original Message- >>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Daniil >>Egranov >>Sent: Thursday, May 5, 2016 8:07 AM >>To: Ni, Ruiyu ; edk2-devel@lists.01.org >>Cc: Fan, Jeff >>Subject: Re: [e

Re: [edk2] [PATCH 17/19] IntelFspWrapperPkg/FspInit: Split FspInitPei to FspmWrapperPeim and FspsWrapperPeim.

2016-05-11 Thread Yao, Jiewen
I fork a new code base and push IntelFsp2Pkg and IntelFsp2WrapperPkg to g...@github.com:jyao1/edk2.git for review. The old IntelFspPkg and IntelFspWrapperPkg are kept. Thank you Yao Jiewen > -Original Message- > From: Yao, Jiewen > Sent: Wednesday, May 11, 2016 11:14 AM > To: 'Tim Lewis

Re: [edk2] OVMF boot order and efivars persistence questions

2016-05-11 Thread Laszlo Ersek
On 05/11/16 10:59, Thomas Lamprecht wrote: > I changed out the QEMU-pure-efi.fd with the QEMU_CODE-pure-efi.fd and Argh. I completely missed that. Sorry -- that was another problem (the main one). I couldn't immediately remember what file did what in Gerd's RPMs. Clearly, if you use two pflash ch

Re: [edk2] OVMF boot order and efivars persistence questions

2016-05-11 Thread Laszlo Ersek
On 05/11/16 06:53, Gary Lin wrote: > On Tue, May 10, 2016 at 05:29:33PM +0200, Laszlo Ersek wrote: >> On 05/10/16 06:34, Gary Lin wrote: >>> On Mon, May 09, 2016 at 02:58:00PM +0200, Laszlo Ersek wrote: On 05/09/16 13:39, Thomas Lamprecht wrote: > [snip] >>> Speaking of the boot order, I would

Re: [edk2] [PATCH] ArmPkg/ArmLib: don't invalidate entire I-cache on range operation

2016-05-11 Thread Mark Rutland
On Wed, May 11, 2016 at 12:23:58PM +0200, Ard Biesheuvel wrote: > On 11 May 2016 at 12:22, Mark Rutland wrote: > > On Wed, May 11, 2016 at 12:07:51PM +0200, Ard Biesheuvel wrote: > >> On 11 May 2016 at 11:35, Achin Gupta wrote: > >> >> diff --git > >> >> a/ArmPkg/Library/ArmCacheMaintenanceLib/A

Re: [edk2] [PATCH] OvmfPkg/PlatformBootManagerLib: Postpone the shell registration

2016-05-11 Thread Laszlo Ersek
On 05/11/16 10:40, Gary Lin wrote: > We currently register the shell before creating the boot options for > the block devices and the network devices, so the boot manager boots > into the internal shell if the user doesn't specify the boot order. > However, Xen doesn't support fw_cfg, so there is n

Re: [edk2] [PATCH] ArmPkg/ArmLib: don't invalidate entire I-cache on range operation

2016-05-11 Thread Ard Biesheuvel
On 11 May 2016 at 12:22, Mark Rutland wrote: > On Wed, May 11, 2016 at 12:07:51PM +0200, Ard Biesheuvel wrote: >> On 11 May 2016 at 11:35, Achin Gupta wrote: >> >> diff --git >> >> a/ArmPkg/Library/ArmCacheMaintenanceLib/ArmCacheMaintenanceLib.c >> >> b/ArmPkg/Library/ArmCacheMaintenanceLib/Arm

Re: [edk2] [PATCH] ArmPkg/ArmLib: don't invalidate entire I-cache on range operation

2016-05-11 Thread Mark Rutland
On Wed, May 11, 2016 at 12:07:51PM +0200, Ard Biesheuvel wrote: > On 11 May 2016 at 11:35, Achin Gupta wrote: > >> diff --git > >> a/ArmPkg/Library/ArmCacheMaintenanceLib/ArmCacheMaintenanceLib.c > >> b/ArmPkg/Library/ArmCacheMaintenanceLib/ArmCacheMaintenanceLib.c > >> index 1045f9068f4d..cc755

Re: [edk2] [PATCH] ArmPkg/ArmLib: don't invalidate entire I-cache on range operation

2016-05-11 Thread Achin Gupta
On Wed, May 11, 2016 at 12:07:51PM +0200, Ard Biesheuvel wrote: > On 11 May 2016 at 11:35, Achin Gupta wrote: > > Hi Ard, > > > > Some comments inline! > > > > On Wed, May 11, 2016 at 10:41:57AM +0200, Ard Biesheuvel wrote: > >> Instead of cleaning the data cache to the PoU by virtual address and

[edk2] [PATCH v2] ArmPkg/ArmLib: don't invalidate entire I-cache on range operation

2016-05-11 Thread Ard Biesheuvel
Instead of cleaning the data cache to the PoU by virtual address and subsequently invalidating the entire I-cache, invalidate only the range that we just cleaned. This way, we don't invalidate other cachelines unnecessarily. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ar

Re: [edk2] [PATCH] ArmPkg/ArmLib: don't invalidate entire I-cache on range operation

2016-05-11 Thread Ard Biesheuvel
On 11 May 2016 at 11:35, Achin Gupta wrote: > Hi Ard, > > Some comments inline! > > On Wed, May 11, 2016 at 10:41:57AM +0200, Ard Biesheuvel wrote: >> Instead of cleaning the data cache to the PoU by virtual address and >> subsequently invalidating the entire I-cache, invalidate only the >> range

Re: [edk2] [PATCH] ArmPkg/ArmLib: don't invalidate entire I-cache on range operation

2016-05-11 Thread Achin Gupta
Hi Ard, Some comments inline! On Wed, May 11, 2016 at 10:41:57AM +0200, Ard Biesheuvel wrote: > Instead of cleaning the data cache to the PoU by virtual address and > subsequently invalidating the entire I-cache, invalidate only the > range that we just cleaned. This way, we don't invalidate othe

[edk2] [Patch] BaseTools/GenFds: enhance INF built arch filter

2016-05-11 Thread Yonghong Zhu
The bug is use FILE_GUID override to build the same module more than once, GenFds report warning "xxx NOT found in DSC file; Is it really a binary module?". The root cause is the module path with FILE_GUID overridden has the file name FILE_GUIDmodule.inf, then PlatformDataBase.Modules use FILE_GUID

[edk2] [Patch] BaseTools: Fix bug to not mix comment into Asbuilt inf Depex section

2016-05-11 Thread Yonghong Zhu
in the generated Asbuilt inf would include the driver's complete dependency expression, and it would be wrote as comment format. Original bug is mix the depex expression with real comment in the depex section. this patch is ignore the real comment, and list the depex expression. Cc: Liming Gao Co

Re: [edk2] OVMF boot order and efivars persistence questions

2016-05-11 Thread Thomas Lamprecht
On 05/09/2016 06:06 PM, Laszlo Ersek wrote: > On 05/09/16 17:36, Thomas Lamprecht wrote: > > [snip] > >> Ok, the OS did sets this up but when I start qemu without disk it starts >> the UEFI shell nonetheless, if I pass a disk to the VM it will always >> boot from this disk, still won't keep the ch

[edk2] [PATCH] ArmPkg/ArmLib: don't invalidate entire I-cache on range operation

2016-05-11 Thread Ard Biesheuvel
Instead of cleaning the data cache to the PoU by virtual address and subsequently invalidating the entire I-cache, invalidate only the range that we just cleaned. This way, we don't invalidate other cachelines unnecessarily. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ar

[edk2] [PATCH] OvmfPkg/PlatformBootManagerLib: Postpone the shell registration

2016-05-11 Thread Gary Lin
We currently register the shell before creating the boot options for the block devices and the network devices, so the boot manager boots into the internal shell if the user doesn't specify the boot order. However, Xen doesn't support fw_cfg, so there is no way to change the boot order with the ext

[edk2] [PATCH 1/2] EmbeddedPkg/Lan9118Dxe: PcdLan9118NegotiationFeatureMask

2016-05-11 Thread Ryan Harkin
Add a PCD to allow the platform to mask in/out specific features of the LAN9118 device advertised during auto-negotiation. For example, the Juno ARM Development Platform doesn't support full duplex mode. This PCD will allow the platform developer to prevent the full duplex modes from being advert

[edk2] [PATCH 2/2] Platforms/ARM: Add PcdLan9118NegotiationFeatureMask

2016-05-11 Thread Ryan Harkin
The LAN9118 features mask us used to enable/disable certain features advertised by the device during auto-negotiation. Juno and TC2 do not support full duplex communication properly, causing intermittent failures, so we disable them using the mask. The feature mask used is effectively: ~(PHYANA

[edk2] [PATCH 0/2] LAN9118 Auto-Negotiation Feature Mask

2016-05-11 Thread Ryan Harkin
These two patches are destined for both EDK2 and OpenPlatformPkg. The EDK2 patch should be merged first. LAN9118 investigations by Mark Rutland has shown that the Juno ARM Development Platform does not work well when LAN9118 auto-negotiates in full duplex mode. It was suggested that a PCD coul

Re: [edk2] [Linaro-uefi] [RFC][PATCH] OpenPlatformPkg: HiKeyMem: Initialize the base system memory HOB before trying to create reservations

2016-05-11 Thread Ard Biesheuvel
On 6 May 2016 at 06:35, John Stultz wrote: > In the current edk2 code, as of 40a3f38f67cee > ("ArmPlatformPkg/MemoryInitPei: Check if the main System > Memory resource has been declared"), ArmPlatformGetVirtualMemoryMap() > is now called before the base system memory HOB is created in > MemoryPeim

Re: [edk2] [patch] NetworkPkg: Bug fix of iSCSI to support MPIO

2016-05-11 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan > -Original Message- > From: Zhang, Lubo > Sent: Wednesday, May 11, 2016 9:38 AM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Fu, Siyuan ; Wu, Jiaxin > > Subject: [patch] NetworkPkg: Bug fix of iSCSI to support MPIO > > If two attempts added on different NIC and

Re: [edk2] [patch] NetworkPkg: Bug fix of iSCSI to support MPIO

2016-05-11 Thread Ye, Ting
Reviewed-by: Ye Ting -Original Message- From: Zhang, Lubo Sent: Wednesday, May 11, 2016 9:38 AM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Fu, Siyuan ; Wu, Jiaxin Subject: [patch] NetworkPkg: Bug fix of iSCSI to support MPIO If two attempts added on different NIC and enable MPIO attr

[edk2] [patch] MdeModulePkg/SetupBrowser: Should free ConfigResp when it no longer be used

2016-05-11 Thread Dandan Bi
When submit form fail, the progress point to the first fail part in ConfigResp, so should free the ConfigResp after Progrss has been processed. Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Universal/SetupBrowserDxe/Setup.c | 3 +