Re: [edk2] [Patch 2/2] NetworkPkg: Stop the timer before clean IP service.

> -Original Message- > From: Bruce Cran [mailto:br...@cran.org.uk] > Sent: Thursday, June 2, 2016 12:54 PM > To: Wu, Jiaxin ; Fu, Siyuan ; > edk2-devel@lists.01.org > Cc: Ye, Ting ; Ni, Ruiyu ; Wu, Hao A >

Re: [edk2] out of tree build

Michael: For BaseTools, we have no plan for such change. For Build directory, if it is the relative directory described at OUTPUT_DIRECTORY of DSC file, it will be in WORKSPACE. If it is the absolute directory in DSC file, it may be out of WORKSPACE. Thanks Liming From: Michael Zimmermann

Re: [edk2] Unable to build a compressed ROM image via the .INF file

Hi Patrick, I sent a patch to fix this bug. [edk2] [Patch] BaseTools: fix the bug to build a compressed ROM image via .INF file Best Regards, Zhu Yonghong -Original Message- From: Zhu, Yonghong Sent: Wednesday, June 01, 2016 4:24 PM To: Mahan, Patrick ;

[edk2] [Patch] BaseTools: Add error handling for current_dir is not exist

Add the error handling to cover the case that current_dir is not exist. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu --- BaseTools/Source/Python/AutoGen/GenMake.py | 2 ++ 1 file changed, 2

[edk2] [Patch] BaseTools: fix the bug to build a compressed ROM image via .INF file

Fix the bug that always use the '-e' as OPTROM_FLAGS even the .INF file has statement 'PCI_COMPRESS = TRUE'. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu ---

Re: [edk2] [PATCH 0/2] UefiCpuPkg, OvmfPkg: prevent (unchecked) SMM stack overflow

Reviewed-by: Jeff Fan Good suggestion to set PcdCpuSmmStackGuard default to TRUE. But please hold on the check-in in UefiCpuPkg.dec till next week, I want more platforms to be validated on this change. -Original Message- From: Laszlo Ersek

Re: [edk2] [PATCH] MdeModulePkg NvmExpressDxe: Add check before creating an aync IO queue

I will update the commit subject to: MdeModulePkg NvmExpressDxe: Fix invalid queue size when creating IO queues when committing the patch. Best Regards, Hao Wu > -Original Message- > From: Tian, Feng > Sent: Thursday, June 02, 2016 9:58 AM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc:

Re: [edk2] ASSERT and static code analysis

Laszlo: I think this case is same to EFIAPI. For GCC tool chain, "-DEFIAPI=__attribute__((ms_abi))" is defined in CC_FLAGS in tools_def.txt. For this case, "-DCLANG_ANALYZER_NORETURN=__attribute__((analyzer_noreturn))" can only be added into CC_FLAGS for Clang Scan analysis tool chain, like

Re: [edk2] [PATCH] MdeModulePkg NvmExpressDxe: Add check before creating an aync IO queue

Sorry, I have an additional comment about the commit log title. I would suggest you to describe the problem you solved rather than the action you made. It would be more straightforward for others. If you refine the log title like this, you have my R-b. Reviewed-by: Feng Tian

Re: [edk2] [Patch 2/2] NetworkPkg: Stop the timer before clean IP service.

Hi Bruce, Thanks for your catching, I will check my git email setting. Best Regards! Jiaxin > -Original Message- > From: Bruce Cran [mailto:br...@cran.org.uk] > Sent: Thursday, June 2, 2016 8:33 AM > To: Fu, Siyuan ; edk2-devel@lists.01.org > Cc: Ye, Ting

Re: [edk2] ASSERT and static code analysis

Hi Marvin, For Clang Static Analyzer, you might look at this edk2 llvm branch. https://github.com/shijunjing/edk2/tree/llvm There is a new tool chain dedicated for clang scan-build checkers: CLANGSCAN38: Base on CLANG38 to seamlessly integrate Clang scan-build analyzer infrastructure into

Re: [edk2] [PATCH 0/2] UefiCpuPkg, OvmfPkg: prevent (unchecked) SMM stack overflow

Good catch. Agree to enlarge stack size. And it is a good idea to enable stack guard by default. Reviewed-by: jiewen@intel.com > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, June 2, 2016 3:03 AM > To: edk2-devel-01 >

Re: [edk2] [PATCH 0/2] Add IntelSiliconPkg

Intel has internal discussion on the naming. (Mike is included) We decide to choose IntelSiliconPkg because it is for Intel silicon. -- IntelPkg is confusing - is that Intel platform? -- IntelDevicePkg is confusing - is that for intel NIC? Yes, I know Mike is working on restructuring package

Re: [edk2] [Patch 2/2] NetworkPkg: Stop the timer before clean IP service.

On 5/25/16 7:04 PM, Fu Siyuan wrote: In Ip6CleanService()it first cleaned some resources, then stop the timer . While before the timer stopped it may try to access some already freed data, which may generate an exception. This patch updates the driver to stop the timer event before starting to

Re: [edk2] ASSERT and static code analysis

Hey Andrew, Thanks for your reply! In case you haven't read Laszlo's reply, he pointed out the same issue and proposed that both CpuDeadLoop() and Breakpoint() should be flagged as ' analyzer_noreturn', which is ignored by the compiler and thus should not break anyone's code, but only

Re: [edk2] [PATCH 0/2] Add IntelSiliconPkg

> On Jun 1, 2016, at 1:39 PM, Jordan Justen wrote: > > Mike is looking to restructure the tree soon. Should we hold off on > adding this, or perhaps try to add it using the new structure? > > If not, then what about IntelPkg or IntelDevicePkg instead? Since > nothing

Re: [edk2] ASSERT and static code analysis

> On Jun 1, 2016, at 1:12 PM, Marvin H?user wrote: > > Recently I was told that ASSERT() calls to check whether a variable is NULL > breaks the Clang Static Analyzer in terms of generating wrong warnings. The > reason is that, when a variable/parameter is checked

Re: [edk2] ASSERT and static code analysis

On 06/01/16 22:41, Marvin H?user wrote: > Hey Laszlo, > > Thank you very much for your comment! > > About the comment in CpuDeadLoop(), once more, I wasn't aware, thanks for the > hint! > Do you think a define should be introduced ('NORETURN'/'ANALYZE_NORETURN') to > keep the code style

Re: [edk2] ASSERT and static code analysis

Hey Laszlo, Thank you very much for your comment! About the comment in CpuDeadLoop(), once more, I wasn't aware, thanks for the hint! Do you think a define should be introduced ('NORETURN'/'ANALYZE_NORETURN') to keep the code style consistent and also allow support for more static analyzers

Re: [edk2] [PATCH 0/2] Add IntelSiliconPkg

Mike is looking to restructure the tree soon. Should we hold off on adding this, or perhaps try to add it using the new structure? If not, then what about IntelPkg or IntelDevicePkg instead? Since nothing in the tree is using this, what external platforms will depend on it? Will they be able to

Re: [edk2] ASSERT and static code analysis

On 06/01/16 22:12, Marvin H?user wrote: > Recently I was told that ASSERT() calls to check whether a variable > is NULL breaks the Clang Static Analyzer in terms of generating wrong > warnings. The reason is that, when a variable/parameter is checked > for NULL, this analyzer assumes that it can

Re: [edk2] [PATCH] IntelFsp2Pkg/Tools: Add FSP rebasing function into SplitFspBin tool

Thanks Maurice, for extending the capability of the split tool to support rebasing. Reviewed-by: Giri P Mudusuru -Original Message- From: Ma, Maurice Sent: Friday, May 27, 2016 2:12 PM To: edk2-devel@lists.01.org Cc: Ma, Maurice ; Yao,

Re: [edk2] [RFC V2] Proposal to organize packages into directories

On 2016-05-25 19:03:38, Kinney, Michael D wrote: > # Top Level Directory Structure (Listed Alphabetically) > ``` > edk2 > Application Applications and application support libraries > BaseTools EDK II build tools/scripts > Conf EDK II build configuration files >

Re: [edk2] Q: Which module type fits my library?

Hi Andrew, Marvin, thanks for the explanation, I think I understand now. @Andrew: Almost all command lines support the CTRL+C input to stop an executable from executing (https://en.wikipedia.org/wiki/Control-C). The EDKII Shell doesn't seem to support such thing, right? However, today it may be

Re: [edk2] Memory Consumption after BLT (GOP)

I did that :) To get the available memory I did the following function: EFI_STATUS CalculateAvaiableMemoryForDebug (VOID) { EFI_STATUS Status = EFI_SUCCESS; EFI_MEMORY_DESCRIPTOR *MemMap = NULL; EFI_MEMORY_DESCRIPTOR *Desc; UINTN DescriptorSize = 0; UINT32 DescriptorVersion = 0; UINTN

Re: [edk2] Memory Consumption after BLT (GOP)

Well... sadly the best way to debug would be to get the memory map yourself, run your graphical operation, and then compare all inside the same program (assuming that you allocate no memory within your memory map acquisitions). -Jaben > -Original Message- > From: edk2-devel

Re: [edk2] Memory Consumption after BLT (GOP)

The system has one page decreased after some executions. I used the following script to check this: FS1: echo -off memmap >> memmapShellBefore.txt for %a run (1 10) TestesImagemBMP.efi memmap >> memmapShellAfter_%a.txt endfor The decrease happened at execution number 4 and 9 From execution 1

[edk2] Memory Consumption after BLT (GOP)

Hi Everyone. I'm doing some tests related to the GOP and graphical applications. What I've seeing is that after calling the GOP->BLT several times the available memory from the system decrease. For example. When the system just boot I have the following at the uefi shell memmap command:

Re: [edk2] [PATCH] [BaseTools/BinWrappers] bash script fix for PosixLike/LzmaF86Compress

> On Jun 1, 2016, at 9:37 AM, Palmer, Thomas wrote: > > > V2 patch submitted, thank you. > > For my own enlightenment, does the community maintain a list of which > directories and files are intended to remain UNIX style? > Only things that require UNIX style to

Re: [edk2] Q: Which module type fits my library?

> On Jun 1, 2016, at 9:08 AM, Peter Kirmeier wrote: > > Hi there, > > > > today I wasn't sure which module types my (DXE) library actually supports, > so I had a look at the modules writers guide here: > >

Re: [edk2] [PATCH v1 1/1] MdePkg/DebugLib: Ignore DEBUG variables in RELEASE builds.

Thank you in advance for your comprehensive example, I understood it now. I just haven't considered that the macros need to ensure var-changing instructions may only be ran once. :) Regards, Marvin. > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Monday,

Re: [edk2] Q: Which module type fits my library?

Sorry, I forgot to add edk2-devel to the sender list. :) > -Original Message- > From: Marvin Häuser > Sent: Wednesday, June 1, 2016 6:39 PM > To: 'Peter Kirmeier' > Subject: RE: [edk2] Q: Which module type fits my library? > > Hey Peter, > > UEFI Drivers are pretty

Re: [edk2] [PATCH] [BaseTools/BinWrappers] bash script fix for PosixLike/LzmaF86Compress

V2 patch submitted, thank you. For my own enlightenment, does the community maintain a list of which directories and files are intended to remain UNIX style? Thomas -Original Message- From: Gao, Liming [mailto:liming@intel.com] Sent: Tuesday, May 31, 2016 8:40 PM To: Palmer,

[edk2] [PATCH v2] [BaseTools/BinWrappers] bash script fix for PosixLike/LzmaF86Compress

Add missing "done" token needed to complete the for loop. Tested in Ubuntu 14.04 Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Thomas Palmer --- BaseTools/BinWrappers/PosixLike/LzmaF86Compress | 6 -- 1 file changed, 4 insertions(+), 2

[edk2] Q: Which module type fits my library?

Hi there, today I wasn't sure which module types my (DXE) library actually supports, so I had a look at the modules writers guide here: https://github.com/tianocore-docs/Docs/raw/master/User_Docs/EDK_II%20Module% 20Writer_s%20Guide_0_7.pdf At section 3.1.1 there is a list of module types

Re: [edk2] a "strange" branch taken in the SMM fault handler in PiSmmCpuDxe

On 06/01/16 14:41, Paolo Bonzini wrote: > > > On 01/06/2016 14:26, Laszlo Ersek wrote: >> On 06/01/16 13:30, Paolo Bonzini wrote: >>> >>> >>> On 01/06/2016 12:50, Laszlo Ersek wrote: In other words, the fault is raised and delivered (== the handler is entered) entirely within non-root

Re: [edk2] KVM Forum 2016: Call For Participation

On 10/03/2016 19:09, Paolo Bonzini wrote: > === > IMPORTANT DATES > === > Notification: May 27, 2015 On behalf of the program committee, I apologize for the delay in sending out the notifications. If you need to know in advance whether your talk has been accepted,

Re: [edk2] a "strange" branch taken in the SMM fault handler in PiSmmCpuDxe

On 01/06/2016 14:26, Laszlo Ersek wrote: > On 06/01/16 13:30, Paolo Bonzini wrote: >> >> >> On 01/06/2016 12:50, Laszlo Ersek wrote: >>> In other words, the fault is raised and delivered (== the handler is >>> entered) entirely within non-root operation, inside the VM. I find >>> this amazing.

Re: [edk2] a "strange" branch taken in the SMM fault handler in PiSmmCpuDxe

On 01/06/2016 12:50, Laszlo Ersek wrote: > In other words, the fault is raised and delivered (== the handler is > entered) entirely within non-root operation, inside the VM. I find this > amazing. (Amazingly annoying.) It is indeed. You can try using ept=0 to see the page faults. Paolo

Re: [edk2] [PATCH v2] OvmfPkg/PlatformBootManagerLib: Connect the Xen drivers before loading NvVars

On Wed, Jun 01, 2016 at 11:12:17AM +0200, Laszlo Ersek wrote: > On 06/01/16 09:51, Gary Lin wrote: > > On Tue, May 31, 2016 at 12:21:45AM -0700, Jordan Justen wrote: > >> On 2016-05-30 20:19:42, Gary Lin wrote: > >>> When OVMF tried to load the file-based NvVars, > >> > >> Tangent: Will Xen ever

Re: [edk2] [PATCH v2] OvmfPkg/PlatformBootManagerLib: Connect the Xen drivers before loading NvVars

On 06/01/16 09:51, Gary Lin wrote: > On Tue, May 31, 2016 at 12:21:45AM -0700, Jordan Justen wrote: >> On 2016-05-30 20:19:42, Gary Lin wrote: >>> When OVMF tried to load the file-based NvVars, >> >> Tangent: Will Xen ever add a r/w flash emulation for variables like >> QEMU/KVM? >> >>> it checked

Re: [edk2] [Patch] MdePkg: Follow PI1.4a to update EFI_SMM_SW_REGISTER2 return status

Jeff: The patch is good. Please also update PI version to PI1.4a in comments. > -Original Message- > From: Fan, Jeff > Sent: Wednesday, June 01, 2016 4:25 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming ; Kinney, Michael D > >

[edk2] [patch] MdeModulePkg/HiiDatabase: Preinit background when render string to screen

When render string to screen, for proportional fonts, the background color may not set to the whole BltBuffer. And this will cause incorrect display. Now initialize the background color to fix this issue. Cc: Liming Gao Cc: Eric Dong Contributed-under:

[edk2] [patch] MdeModulePkg/HiiDatabase: Remove the incorrect calculation of font baseline

When add Font Package, the cell in EFI_HII_FONT_PACKAGE_HDR contains the measurement of the widest and tallest characters in the font. The measurement may be not absolutely correct, so when use this cell information to calculate the baseline may cause incorrect result. Besides this calculation is

Re: [edk2] [PATCH] MdeModulePkg NvmExpressDxe: Add check before creating an aync IO queue

Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Wu, Hao A Sent: Wednesday, June 1, 2016 4:48 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Tian, Feng Subject: [PATCH] MdeModulePkg NvmExpressDxe: Add check

[edk2] [Patch] MdePkg: Follow PI1.4a to update EFI_SMM_SW_REGISTER2 return status

Cc: Liming Gao Cc: Michael Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan --- MdePkg/Include/Protocol/SmmSwDispatch2.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[edk2] [Patch] MdePkg: Follow PI1.4a update SmmStartupThisAP() description

Cc: Liming Gao Cc: Michael Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan --- MdePkg/Include/Pi/PiSmmCis.h | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-)

Re: [edk2] [Patch 0/9] UefiCpuPkg/PeiCpuExceptionHandlerLib

Thanks your comments. I will check-in the patches after updated them per your comments. -Original Message- From: Tian, Feng Sent: Wednesday, June 01, 2016 1:56 PM To: Fan, Jeff; edk2-devel@lists.01.org Cc: Tian, Feng Subject: RE: [edk2] [Patch 0/9] UefiCpuPkg/PeiCpuExceptionHandlerLib