Re: [edk2] [PATCH 2/2] MdeModulePkg DxeS3BootScriptLib: Add DESTRUCTOR S3BootScriptLibDeinitialize

2016-06-03 Thread Yao, Jiewen
HI Laszlo/Star That is a good catch that this patch does not consider DriverX load, DriverY load, then DriverX unload. Technically, it is possible for a UEFI driver according UEFI spec, by using EFI_BOOT_SERVICES.Exit() to terminates a loaded EFI image and returns control to boot services. It

Re: [edk2] [PATCH] MdeModulePkg/RamDiskDxe: Add RAW Ramdisk size change support in HII form

2016-06-03 Thread Shah, Tapan
Hao, HiiGetBrowserData() is only retrieving uncommitted data from the browser, so changed "size" value will not be stored into 'Configuration' until HiiSetBrowserData() is called at the end of the function. Without this patch, I don't see 'size' value updated on a real HW system. Thanks,

Re: [edk2] [PATCH 2/2] MdeModulePkg DxeS3BootScriptLib: Add DESTRUCTOR S3BootScriptLibDeinitialize

2016-06-03 Thread Zeng, Star
On 2016/6/3 16:22, Laszlo Ersek wrote: On 06/03/16 04:09, Star Zeng wrote: PiDxeS3BootScriptLib has a constructor S3BootScriptLibInitialize() that registers ready-to-lock callback S3BootScriptSmmEventCallBack() and several more. The library is linked to SMM modules. If the module entry-point

Re: [edk2] [PATCH 2/2] MdeModulePkg DxeS3BootScriptLib: Add DESTRUCTOR S3BootScriptLibDeinitialize

2016-06-03 Thread Laszlo Ersek
On 06/03/16 04:09, Star Zeng wrote: > PiDxeS3BootScriptLib has a constructor S3BootScriptLibInitialize() that > registers ready-to-lock callback S3BootScriptSmmEventCallBack() and several > more. The library is linked to SMM modules. If the module entry-point > function returns error (because of

Re: [edk2] [PATCH 1/2] MdeModulePkg SmmLockBoxSmmLib: Add DESTRUCTOR SmmLockBoxSmmDestructuor

2016-06-03 Thread Laszlo Ersek
On 06/03/16 04:09, Star Zeng wrote: > SmmLockBoxSmmLib is linked to SMM modules. If the module entry-point > function returns error, the module will be unloaded and the global > variables will point to undefined memory. > > This patch is to add DESTRUCTOR SmmLockBoxSmmDestructuor to uninstall >

Re: [edk2] [PATCH v2] MdeModulePkg:Prevent the BmRepairAllControllers routine in an infinite loop

2016-06-03 Thread Li, Gary (HPS SW)
Thanks for your help! Regards, Gary Li Platform SW Engineering Servers Office: +886 (2) 8722 9977 -Original Message- From: Gao, Liming [mailto:liming@intel.com] Sent: Friday, June 03, 2016 3:50 PM To: Li, Gary (HPS SW) ; Ni, Ruiyu Cc:

Re: [edk2] [PATCH v2] MdeModulePkg:Prevent the BmRepairAllControllers routine in an infinite loop

2016-06-03 Thread Gao, Liming
I will help push this patch. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Li, > Gary (HPS SW) > Sent: Friday, June 03, 2016 3:45 PM > To: Ni, Ruiyu > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH v2]

Re: [edk2] [PATCH v2] MdeModulePkg:Prevent the BmRepairAllControllers routine in an infinite loop

2016-06-03 Thread Li, Gary (HPS SW)
Hi Ray, Thanks for your review. Could you please commit this change? Regards, Gary Li Platform SW Engineering Servers Office: +886 (2) 8722 9977 -Original Message- From: Ni, Ruiyu [mailto:ruiyu...@intel.com] Sent: Friday, June 03, 2016 3:29 PM To: Li, Gary (HPS SW)

[edk2] [patch][edk2-platforms/branch]: Add new platform branch pentium-celeron-n-udk2015

2016-06-03 Thread Guo, Mang
This branch is used to contribute N-series Intel Pentium Processor and Intel Celeron Processor Families (formerly Braswell) to EDK2. All code are ready in https://github.com/mangguo321/edk2-platforms.git -b pentium-celeron-n-udk2015 Contributed-under: TianoCore Contribution Agreement 1.0

Re: [edk2] [PATCH v2] MdeModulePkg:Prevent the BmRepairAllControllers routine in an infinite loop

2016-06-03 Thread Ni, Ruiyu
I am ok for the code logic. Reviewed-by: ruiyu...@intel.com Thanks, Ray > 在 2016年6月3日,下午3:23,Gary Li 写道: > > Prevent the BmRepairAllControllers routine in an infinite loop > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Gary Li

[edk2] [PATCH v2] MdeModulePkg:Prevent the BmRepairAllControllers routine in an infinite loop

2016-06-03 Thread Gary Li
Prevent the BmRepairAllControllers routine in an infinite loop Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Gary Li --- MdeModulePkg/Library/UefiBootManagerLib/BmDriverHealth.c | 11 +--

Re: [edk2] [PATCH] MdeModulePkg:Prevent the BmRepairAllControllers routine in an infinite loop

2016-06-03 Thread Li, Gary (HPS SW)
Hi Liming, Thanks for your feedback, I will update this patch. Regards, Gary Li Platform SW Engineering Servers Office: +886 (2) 8722 9977 -Original Message- From: Gao, Liming [mailto:liming@intel.com] Sent: Friday, June 03, 2016 12:31 PM To: Li, Gary (HPS SW) ;