Re: [edk2] [PATCH v1 1/1] MdePkg: MTftp6: Correct #define value in Mtfp6.h

Reviewed-By: Wu Jiaxin > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > hegdenag > Sent: Thursday, June 16, 2016 12:51 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Fu, Siyuan

Re: [edk2] [PATCH v1 1/1] MdePkg: MTftp6: Correct #define value in Mtfp6.h

Reviewed-by: Sriram Subramanian -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hegde, Nagaraj P Sent: Thursday, June 16, 2016 10:21 AM To: edk2-devel@lists.01.org Cc: ting...@intel.com; siyuan...@intel.com; jiaxin...@intel.com

Re: [edk2] [PATCH v1 1/1] MdePkg: MTftp6: Correct #define value in Mtfp6.h

Thanks for capturing and fixing the issue. Reviewed-by: Ye Ting -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of hegdenag Sent: Thursday, June 16, 2016 12:51 PM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Fu,

[edk2] [PATCH v1 1/1] MdePkg: MTftp6: Correct #define value in Mtfp6.h

defined values of EFI_MTFTP6_ERRORCODE_ILLEGAL_OPERATION and EFI_MTFTP6_ERRORCODE_FILE_ALREADY_EXISTS are the same. This patch corrects the value of EFI_MTFTP6_ERRORCODE_ILLEGAL_OPERATION to 4. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hegde Nagaraj P

Re: [edk2] [PATCH] IntelFsp2WrapperPkg: Change FspsBaseAddress from Fixed PCD to Dynamic PCD

Yes. I will change the subject. Initially I planned to change the PCD from static to dynamic but later realized that some projects(example KBL) already using the fixed PCD. Thanks, Satya > -Original Message- > From: Yao, Jiewen > Sent: Thursday, June 16, 2016 6:42 AM > To: Ma, Maurice;

Re: [edk2] [PATCH v2 1/2] ShellPkg: Use ".." to indicate device path is partially displayed

Thanks. It looks more reasonable. Reviewed-by: jiewen@intel.com > -Original Message- > From: Ni, Ruiyu > Sent: Thursday, June 16, 2016 11:20 AM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Carsey, Jaben > > Subject: [PATCH v2 1/2]

[edk2] [PATCH v2 0/2] ShellPkg: Use ".." to indicate device path is partially displayed

The output of "dh " originally is like below: 12C: USBIO DevicePath(x0)/Pci(0x14,0x0)/USB(0x6,0x0)) The device path part is very confusing. Use ".." in front of the partially displayed device path is better and it also aligns to the example output in Shell spec. 12C: USBIO

[edk2] [PATCH v2 2/2] ShellPkg/UefiHandleParsingLib.c: Change EOL to Windows style

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jiewen Yao Cc: Jaben Carsey --- .../UefiHandleParsingLib/UefiHandleParsingLib.c| 352 ++--- 1 file changed, 171

[edk2] [PATCH v2 2/2] ShellPkg/UefiHandleParsingLib.c: Unify EOL and remove trailing space

The patch doesn't change any code logic. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jiewen Yao Cc: Jaben Carsey --- .../UefiHandleParsingLib/UefiHandleParsingLib.c| 356

[edk2] [PATCH v2 1/2] ShellPkg: Use ".." to indicate device path is partially displayed

The output of "dh " originally is like below: 12C: USBIO DevicePath(x0)/Pci(0x14,0x0)/USB(0x6,0x0)) The device path part is very confusing. Use ".." in front of the partially displayed device path is better and it also aligns to the example output in Shell spec. 12C: USBIO

Re: [edk2] [PATCH 8/8] MdePkg: Indicate UnicodeStrToAsciiStr/AsciiStrToUnicodeStr to be deprecated

Reviewed-by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Wednesday, June 15, 2016 4:44 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Gao, Liming > ; Kinney, Michael D > Subject: [PATCH

Re: [edk2] [PATCH 1/8] MdePkg: Replace UnicodeStrToAsciiStr() with UnicodeStrToAsciiStrS()

Reviewed-by: Liming Gao > -Original Message- > From: Zeng, Star > Sent: Wednesday, June 15, 2016 4:44 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Gao, Liming > ; Kinney, Michael D >

Re: [edk2] [PATCH 8/8] MdePkg: Indicate UnicodeStrToAsciiStr/AsciiStrToUnicodeStr to be deprecated

Reviewed-by: Liming Gao > -Original Message- > From: Zeng, Star > Sent: Wednesday, June 15, 2016 4:44 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Gao, Liming > ; Kinney, Michael D >

[edk2] [PATCH] ShellPkg: Use ".." to indicate device path is partially displayed

The output of "dh " originally is like below: 12C: USBIO DevicePath(x0)/Pci(0x14,0x0)/USB(0x6,0x0)) The device path part is very confusing. Use ".." in front of the partially displayed device path is better and it also aligns to the example output in Shell spec. 12C: USBIO

Re: [edk2] [PATCH] IntelFsp2WrapperPkg: Change FspsBaseAddress from Fixed PCD to Dynamic PCD

Yes, I like this better. Thanks Maurice -Original Message- From: Yao, Jiewen Sent: Wednesday, June 15, 2016 6:12 PM To: Ma, Maurice; Yarlagadda, Satya P Cc: Mudusuru, Giri P; edk2-devel@lists.01.org Subject: RE: [PATCH] IntelFsp2WrapperPkg: Change FspsBaseAddress from Fixed PCD to

Re: [edk2] [PATCH v2] MdeModulePkg/UiApp: Retrieve the value of language menu

Reviewed-by: Liming Gao > -Original Message- > From: Bi, Dandan > Sent: Thursday, June 16, 2016 9:51 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming ; Dong, Eric > Subject: [PATCH v2] MdeModulePkg/UiApp: Retrieve the

[edk2] [PATCH v2] MdeModulePkg/UiApp: Retrieve the value of language menu

In current UI code, we use oneof opcode without storage for language menu. If we change the language form A->B, then go to another form and then go back to the front page, the language menu always shows A. Now we fix this issue by retrieving the value of oneof opcode(language menu) when display

[edk2] [Patch 000/351] Convert EDK II core packages to NASM for IA32/X64

These patches are available in https://github.com/lgao4/edk2.git nasm-v1. The nasm-v1 branch sha1 is 42bec457c575b6cb7c9fc1730cbea263ffce7b1c Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao Signed-off-by: Jordan Justen

Re: [edk2] [PATCH 3/8] NetworkPkg: Replace UnicodeStrToAsciiStr/AsciiStrToUnicodeStr

Reviewed-By: Wu Jiaxin Best Regards! Jiaxin > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Star Zeng > Sent: Wednesday, June 15, 2016 4:44 PM > To: edk2-devel@lists.01.org > Cc: Fu, Siyuan ; Wu,

[edk2] [patch 2/2] MdeModulePkg/BootManagerUiLib: No need to connect all devices

The connect all action has been done in UiApp, no need to do it when update boot manager form. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi Reviewed-by: Eric Dong

[edk2] [patch 1/2] MdeModulePkg/UiApp: Connect all devices in UiApp if needed

If the connect all action has not been performed before. We do it in UiApp now. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi Reviewed-by: Eric Dong

[edk2] [patch 0/2] Connect all devices in UiApp if needed

Do the connect all action in UiApp if needed, and no need to do the connect action in other UI library. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi Reviewed-by:

Re: [edk2] [PATCH] IntelFsp2WrapperPkg: Change FspsBaseAddress from Fixed PCD to Dynamic PCD

Agree with Maurice. How about "Add dynamic PCD capability for PcdFspsBaseAddress"? With that comment change, reviewed-by: jiewen@intel.com > -Original Message- > From: Ma, Maurice > Sent: Thursday, June 16, 2016 1:22 AM > To: Yarlagadda, Satya P > Cc:

Re: [edk2] [PATCH 0/2] Update UNIXGCC toolchain and make it work again

Can you use git send-email rather than KMail to send your patches, so they will be threaded? On 2016-06-15 16:36:12, Bill Paul wrote: > A while ago there was some talk of updating the UNIXGCC toolchain to > support a newer version of GCC and binutils. Unfortunately after almost > a year, nothing

Re: [edk2] [PATCH 5/8] SecurityPkg: Replace UnicodeStrToAsciiStr/AsciiStrToUnicodeStr

Reviewed-by: Chao Zhang Thanks & Best regards Chao Zhang -Original Message- From: Zeng, Star Sent: Wednesday, June 15, 2016 4:44 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen; Zhang, Chao B Subject: [PATCH 5/8] SecurityPkg: Replace

[edk2] [PATCH 1/2] BaseTools: This commit updates the support for MinGW/UNIXGCC cross-build toolchain.

The following changes have been made: - The mingw-gcc-build.py script now uses GCC 4.9.3 and binutils 2.25. - GCC 4.3.0 used underscore decoration for both IA32 and X64 builds, but the official convention is that it's only used on IA32 and newer versions of GCC MinGW now follow this convention.

[edk2] [PATCH 2/2] OvmfPkg: This commit makes OvmfPkg builds work with UNIXGCC again.

Previously, a linker rule was added to the ,dsc files to force section alignment to 4096 bytes. This rule was wildcarded to apply to all GCC builds. Unfortunately this only works for GCC/binutils that are targeted for ELF. It doesn't work with UNIXGCC, because the MinGW version of the GNU linker

[edk2] [PATCH 0/2] Update UNIXGCC toolchain and make it work again

A while ago there was some talk of updating the UNIXGCC toolchain to support a newer version of GCC and binutils. Unfortunately after almost a year, nothing has happened. (I think Ard Biesheuvel said he had plans to fix this, but apparently nothing came of this.) In fact things have gotten

Re: [edk2] [PATCH V3 1/3] MdeModulePkg: Define and install performance property configuration table

> On Jun 14, 2016, at 10:36 PM, Zeng, Star wrote: > > https://github.com/lzeng14/edk2/tree/DpNoTimerLibV2 > https://github.com/lzeng14/edk2/tree/DpNoTimerLibV3 > I see V3 added typedef struct { UINT32Revision; UINT32Reserved; UINT64

[edk2] [Announcement] Tianocore Community Leadership

Dear Community, I want to take this opportunity to announce that I will be stepping aside as the Tianocore Community Manager. Michael Kinney, one of our stewards, is taking on the role. Nothing changes, all the initiatives move forward. And we have a gentlemen you will soon meet, Neil, who

Re: [edk2] [PATCH] IntelFsp2WrapperPkg: Change FspsBaseAddress from Fixed PCD to Dynamic PCD

Hi, Satya, Looks fine to me. But the subject is a little bit confusing. The subject says "Change FspsBaseAddress from Fixed PCD to Dynamic PCD". But the change is actually in DEC file, which just means it is possible to allow this PCD to be defined as Dynamic PCD type. It doesn't really

Re: [edk2] [PATCH] InterFsp2Pkg:Tool: Add user manual for SplitFspBin tool.

Thank you for adding the user manual for this new tool in .md format. Reviewed-by: Giri P Mudusuru -Original Message- From: Ma, Maurice Sent: Wednesday, June 15, 2016 8:18 AM To: Yao, Jiewen Cc: Mudusuru, Giri P

Re: [edk2] [PATCH v2] ArmPkg/ArmLib: avoid cache maintenance in PEIMs when executing in place

On 15 June 2016 at 17:10, Leif Lindholm wrote: > On 13 June 2016 at 16:26, Ard Biesheuvel wrote: >> On some platforms, performing cache maintenance on regions that are backed >> by NOR flash result in SErrors. Since cache maintenance is

Re: [edk2] [PATCH 0/8] Replace UnicodeStrToAsciiStr/AsciiStrToUnicodeStr

Series. Reviewed-by: Jaben Carsey > -Original Message- > From: Zeng, Star > Sent: Wednesday, June 15, 2016 1:44 AM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Gao, Liming > ; Kinney, Michael D

Re: [edk2] [PATCH] InterFsp2Pkg:Tool: Add user manual for SplitFspBin tool.

It looks good to me. Reviewed by: Maurice Ma Thanks Maurice -Original Message- From: Yao, Jiewen Sent: Tuesday, June 14, 2016 7:47 PM To: edk2-devel@lists.01.org Cc: Mudusuru, Giri P; Ma, Maurice; Yarlagadda, Satya P Subject: [PATCH] InterFsp2Pkg:Tool: Add user

Re: [edk2] [PATCH v2] ArmPkg/ArmLib: avoid cache maintenance in PEIMs when executing in place

On 13 June 2016 at 16:26, Ard Biesheuvel wrote: > On some platforms, performing cache maintenance on regions that are backed > by NOR flash result in SErrors. Since cache maintenance is unnecessary in > that case, create a PEIM specific version that only performs said

Re: [edk2] [PATCH v3 0/6] Pl011 Driver improvements

On 15 June 2016 at 14:52, wrote: > From: Evan Lloyd > > Updates and bug fixes for the PL011 driver in ArmPlatformPkg. > > Because of an interface change, ArmVirtPkg/FdtPL011SerialPortLib is also > updated. > > This patchset is a resubmit in response to

Re: [edk2] [PATCH v3 5/6] ArmVirtPkg/FdtPL011SerialPortLib: Set the PL011 UART clock rate

On 06/15/16 14:52, evan.ll...@arm.com wrote: > From: Evan Lloyd > > The interface to PL011UartInitializePort has changed in > ArmPlatformPkg/Drivers/PL011Uart with the title: > "ArmPlatformPkg: Add support to configure PL011 UART clock" > > This patch updates the calls to

Re: [edk2] [RFC] EDK2 Platforms Proposal

Comments inline. On Tue, Jun 14, 2016 at 11:12:20PM +, Kinney, Michael D wrote: > Leif, > > Responses below. > > Mike > > > -Original Message- > > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > > Sent: Monday, June 13, 2016 9:32 AM > > To: Kinney, Michael D

[edk2] [PATCH v3 4/6] ArmPlatformPkg: Add support to configure PL011 UART clock

From: Evan Lloyd On some platforms the UART clock is not the same for all the serial ports. The PL011 driver must be capable of handling serial ports with different clock rates, so must not rely on a PCD for the clock rate. This patch allows the UART clock rate to be passed

[edk2] [PATCH v3 1/6] ArmPlatformPkg: Tidy PL011 UART driver

From: Evan Lloyd This cosmetic change only tidies things up in preparation for actual updates. (This reflects responses to a previously submitted patch, which has been split into several discrete changes.) There are no functional changes in this commit. Changes comprise:

[edk2] [PATCH v3 2/6] ArmPlatformPkg: Update PL011 Serial PCDs to Fixed PCDs

From: Evan Lloyd The PCDs used in the PL011 UART Driver and Serial Port Library are inherently "fixed at build". This change updates the source to use Fixed PCDs for these values. This improves clarity and efficiency. Contributed-under: TianoCore Contribution Agreement 1.0

[edk2] [PATCH v3 6/6] ArmPlatformPkg: Fix PL011 Glitches.

From: Evan Lloyd This change corrects 3 problems in the PL011 driver. 1. The TRM states "The UARTLCR_H, UARTIBRD, and UARTFBRD registers must not be changed:...when the UART is enabled" 2. The TRM (3.3.8) describes logic requiring the UART to be disabled and flushed

[edk2] [PATCH v3 3/6] ArmPlatformPkg: Remove double write in PL011

From: Evan Lloyd The variable LineControl was initialised to zero, then updated in a condition. This change converts that to a write in each branch of the condition, removing the Write/Read/Modify/Write sequence. Contributed-under: TianoCore Contribution Agreement 1.0

[edk2] [PATCH v3 0/6] Pl011 Driver improvements

From: Evan Lloyd Updates and bug fixes for the PL011 driver in ArmPlatformPkg. Because of an interface change, ArmVirtPkg/FdtPL011SerialPortLib is also updated. This patchset is a resubmit in response to comments. V3 updates are largely cosmetic: Patch 1 Additional line

[edk2] [PATCH v3 5/6] ArmVirtPkg/FdtPL011SerialPortLib: Set the PL011 UART clock rate

From: Evan Lloyd The interface to PL011UartInitializePort has changed in ArmPlatformPkg/Drivers/PL011Uart with the title: "ArmPlatformPkg: Add support to configure PL011 UART clock" This patch updates the calls to PL011UartInitializePort(), in line with that change, adding a

[edk2] [PATCH] MdePkg/PCI: Add missing PCI/PCIE definitions

The definitions are required by certain platform initialization code. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jeff Fan Cc: Feng Tian Cc: Amy Chan ---

[edk2] [PATCH 1/8] MdePkg: Replace UnicodeStrToAsciiStr() with UnicodeStrToAsciiStrS()

It is the follow up of 3ab41b7a325ca11a12b42f5ad1661c4b6791cb49 to replace UnicodeStrToAsciiStr/AsciiStrToUnicodeStr with UnicodeStrToAsciiStrS/AsciiStrToUnicodeStrS. Cc: Jiewen Yao Cc: Liming Gao Cc: Michael D Kinney

[edk2] [PATCH 6/8] ShellPkg: Replace UnicodeStrToAsciiStr/AsciiStrToUnicodeStr

It is the follow up of 3ab41b7a325ca11a12b42f5ad1661c4b6791cb49 to replace UnicodeStrToAsciiStr/AsciiStrToUnicodeStr with UnicodeStrToAsciiStrS/AsciiStrToUnicodeStrS. Cc: Jiewen Yao Cc: Jaben Carsey Contributed-under: TianoCore Contribution

[edk2] [PATCH 8/8] MdePkg: Indicate UnicodeStrToAsciiStr/AsciiStrToUnicodeStr to be deprecated

Cc: Jiewen Yao Cc: Liming Gao Cc: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng --- MdePkg/Include/Library/BaseLib.h | 11 +++

[edk2] [PATCH 5/8] SecurityPkg: Replace UnicodeStrToAsciiStr/AsciiStrToUnicodeStr

It is the follow up of 3ab41b7a325ca11a12b42f5ad1661c4b6791cb49 to replace UnicodeStrToAsciiStr/AsciiStrToUnicodeStr with UnicodeStrToAsciiStrS/AsciiStrToUnicodeStrS. Cc: Jiewen Yao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement

[edk2] [PATCH 4/8] PerformancePkg: Replace UnicodeStrToAsciiStr/AsciiStrToUnicodeStr

It is the follow up of 3ab41b7a325ca11a12b42f5ad1661c4b6791cb49 to replace UnicodeStrToAsciiStr/AsciiStrToUnicodeStr with UnicodeStrToAsciiStrS/AsciiStrToUnicodeStrS. Cc: Jiewen Yao Cc: Liming Gao Cc: Jaben Carsey

[edk2] [PATCH 2/8] MdeModulePkg: Replace UnicodeStrToAsciiStr/AsciiStrToUnicodeStr

It is the follow up of 3ab41b7a325ca11a12b42f5ad1661c4b6791cb49 to replace UnicodeStrToAsciiStr/AsciiStrToUnicodeStr with UnicodeStrToAsciiStrS/AsciiStrToUnicodeStrS. Cc: Jiewen Yao Cc: Liming Gao Cc: Eric Dong Cc: Feng Tian

[edk2] [PATCH 0/8] Replace UnicodeStrToAsciiStr/AsciiStrToUnicodeStr

It is the follow up of 3ab41b7a325ca11a12b42f5ad1661c4b6791cb49 to replace UnicodeStrToAsciiStr/AsciiStrToUnicodeStr with UnicodeStrToAsciiStrS/AsciiStrToUnicodeStrS. Cc: Jiewen Yao Cc: Liming Gao Cc: Michael D Kinney Cc:

[edk2] [PATCH 3/8] NetworkPkg: Replace UnicodeStrToAsciiStr/AsciiStrToUnicodeStr

It is the follow up of 3ab41b7a325ca11a12b42f5ad1661c4b6791cb49 to replace UnicodeStrToAsciiStr/AsciiStrToUnicodeStr with UnicodeStrToAsciiStrS/AsciiStrToUnicodeStrS. Cc: Jiewen Yao Cc: Siyuan Fu Cc: Jiaxin Wu Contributed-under:

[edk2] [PATCH 7/8] IntelFrameworkModulePkg: Replace UnicodeStrToAsciiStr/AsciiStrToUnicodeStr

It is the follow up of 3ab41b7a325ca11a12b42f5ad1661c4b6791cb49 to replace UnicodeStrToAsciiStr/AsciiStrToUnicodeStr with UnicodeStrToAsciiStrS/AsciiStrToUnicodeStrS. Cc: Jiewen Yao Cc: Jeff Fan Cc: Ruiyu Ni Contributed-under:

Re: [edk2] [Patch] NetworkPkg: Fix unspecified address use case in IpsecConfig

Thanks for catching. I will update it before commit. /Jiaxin. > -Original Message- > From: Zeng, Star > Sent: Wednesday, June 15, 2016 4:32 PM > To: Wu, Jiaxin ; edk2-devel@lists.01.org > Cc: Fu, Siyuan ; Ye, Ting ; Zeng, >

Re: [edk2] [Patch] NetworkPkg: Fix unspecified address use case in IpsecConfig

Please also update the comments below in SPD_ENTRY_INDEXER structure. UINTNIndex;// Used only if Name is NULL. With the comments updated, you can have my Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Wu, Jiaxin Sent: Wednesday, June 15,

[edk2] [Patch] NetworkPkg: Fix unspecified address use case in IpsecConfig

This patch is used to fix unspecified address use case in ConstructSpdIndexer() function. Indexer->Name for ConstructSpdIndexer is unspecified, that will be a problem for UnicodeStrToAsciiStr. This patch also refine the code by removing ASSERT and user error handling. Cc: Fu Siyuan

[edk2] [PATCH] IntelFsp2WrapperPkg: Change FspsBaseAddress from Fixed PCD to Dynamic PCD

Cc: Giri P Mudusuru Cc: Maurice Ma Cc: Yao, Jiewen Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Satya Yarlagadda --- IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec | 5

Re: [edk2] [Patch] SecurityPkg OpalPasswordDxe: grayout instead of suppress the menu.

Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Dong, Eric Sent: Sunday, June 12, 2016 3:47 PM To: edk2-devel@lists.01.org Cc: Tian, Feng Subject: [Patch] SecurityPkg OpalPasswordDxe: grayout instead of suppress the menu. For