On 21 Jun 2016 04:43, "Wu, Jiaxin" wrote:
>
> Hi Ryan,
>
> Feedback see below:
>
> Thanks and Best Regards!
> Jiaxin
>
> > -Original Message-
> > From: Ryan Harkin [mailto:ryan.har...@linaro.org]
> > Sent: Tuesday, June 21, 2016 2:09 AM
> > To: Wu, Jiaxin
> > Cc: edk2-devel-01 ; Ye, Ting
Reviewed-by: Zhang Lubo
-Original Message-
From: Wu, Jiaxin
Sent: Monday, June 20, 2016 9:46 AM
To: edk2-devel@lists.01.org
Cc: Ye, Ting ; Fu, Siyuan ; Zhang, Lubo
Subject: [PATCH v2] NetworkPkg: Replace ASSERT with error handling in DnsDxe
v2:
*Use goto to simplify code logic.
This
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Zeng, Star
> Sent: Monday, June 20, 2016 9:20 AM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen
> Subject: [PATCH 1/2] MdeModulePkg CapsulePei: Fix some typos
>
> Cc: Jiewen Yao
> Contributed-under: TianoCore Contribution A
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Zeng, Star
> Sent: Monday, June 20, 2016 9:20 AM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen
> Subject: [PATCH 2/2] MdeModulePkg CapsulePei: Validate capsule integrity
> by memory resource hob
>
> Cc: Jiewen Yao
> Contri
Looks good to me. Thanks for eliminating the binaries and using the UefiCpuPkg.
One feedback is to remove the commented lines like comment is to remove
DigitalThermalSensor
Reviewed-by: Giri P Mudusuru
Thanks,
-Giri
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@l
Hi Ryan,
Feedback see below:
Thanks and Best Regards!
Jiaxin
> -Original Message-
> From: Ryan Harkin [mailto:ryan.har...@linaro.org]
> Sent: Tuesday, June 21, 2016 2:09 AM
> To: Wu, Jiaxin
> Cc: edk2-devel-01 ; Ye, Ting ;
> Fu, Siyuan
> Subject: Re: [edk2] [Patch 1/4] MdeModulePkg: Ch
Hi Jaben,
If level 3 command is not elected the 'echo' node won't be added into
'SHELL_COMMAND_INTERNAL_LIST_ENTRY mCommandList' list. If the user run 'echo'
Shell couldn't recognize this command.
-Shumin
From: Carsey, Jaben
Sent: Monday, June 20, 2016 10:45 PM
To: Qiu, Shumin; edk2-devel@lis
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: lushifex
Reviewed-by: David Wei
---
Vlv2DeviceRefCodePkg/AcpiTablesPCAT/GloblNvs.asl |2 +-
Vlv2DeviceRefCodePkg/AcpiTablesPCAT/Pch.asl|1 +
Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.c | 24 +-
Vlv2
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: lushifex
Reviewed-by: David Wei
---
Vlv2TbltDevicePkg/PlatformDxe/PlatformDxe.inf | 22 ++---
Vlv2TbltDevicePkg/PlatformPkg.dec | 28 ++-
2 files changed, 30 insertions(+),
On 06/21/16 03:54, Gao, Liming wrote:
> Laszlo:
> Thanks for your test and finding. I notice this difference between
> asm and nasm output file. I read IA32 manual to try understanding 66
> and 67 prefix operand. I wrongly think 66 has the same functionality
> to 66 67. So, I think they are same. I
Thanks David, I will correct this change in the commit-log.
Shifei
-Original Message-
From: Wei, David
Sent: Tuesday, June 21, 2016 10:28 AM
To: Lu, ShifeiX A; edk2-devel@lists.01.org
Cc: Wei, David; Yao, Jiewen
Subject: RE: [Patch] Vlv2TbltDevicePkg:Use PiSmmCpu of UefiCpuPkg replace
I
Looks like PiSmmCommunicationSmm are also replaced. Could you also describe
this change in the commit-log? And also there is grammar error in the title "
Use PiSmmCpu of UefiCpuPkg replace IA32FamilyCpuPkg."
Thanks,
David Wei
Intel SSG BIOS Team
-Original Message---
Reviewed-by: Liming Gao
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Dandan Bi
> Sent: Thursday, June 16, 2016 9:38 AM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric ; Gao, Liming
> Subject: [edk2] [patch 0/2] Connect all devices in UiAp
Reviewed-by: Liming Gao for this series.
> -Original Message-
> From: Marvin Häuser [mailto:marvin.haeu...@outlook.com]
> Sent: Sunday, June 19, 2016 9:29 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming ; Kinney, Michael D
>
> Subject: [PATCH v2 1/4] MdePkg: Add NORETURN attribute an
Marvin:
Thanks for your clarification. I don't realize it will break CR macro. I
agree your patch is enough.
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Marvin Häuser
> Sent: Tuesday, June 21, 2016 12:10 AM
> To: edk2-devel@lists.01.
Got it. I miss this sentence.
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Marvin Häuser
> Sent: Tuesday, June 21, 2016 12:13 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: Re: [edk2] [PATCH v2 3/4] MdeModulePkg/Core: Deco
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: lushifex
---
Vlv2TbltDevicePkg/PlatformPkg.fdf | 4 ++--
Vlv2TbltDevicePkg/PlatformPkgGcc.fdf| 4 ++--
Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 6 --
Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 6 --
Vlv2TbltD
> On Jun 20, 2016, at 9:10 AM, Bruce Cran wrote:
>
> On 6/19/16 9:21 PM, Zeng, Star wrote:
>
>> 2. According to UEFI 2.6 spec page 222 below, the UEFI OS loader should have
>> got the memory map before ExitBootServices.
>> That means the memory free should not impact the memory map *got by UEF
Laszlo:
Thanks for your test and finding. I notice this difference between asm and
nasm output file. I read IA32 manual to try understanding 66 and 67 prefix
operand. I wrongly think 66 has the same functionality to 66 67. So, I think
they are same. I will go through all patches to make sure t
Got it , I will update it when to check in.
Thanks
lubo
-Original Message-
From: Ye, Ting
Sent: Tuesday, June 21, 2016 9:29 AM
To: Zhang, Lubo ; edk2-devel@lists.01.org
Cc: Fu, Siyuan ; Wu, Jiaxin
Subject: RE: [PATCH v2] NetworkPkg: Replace ASSERT with error handling in Http
boot and
Hi, Marcin
Patch 2 could get my RB. Reviewed-by: Feng Tian
I have comments on other patches.
1. Patch 1 is correct fix. But could you also help fix the problem in
EmmcPeimSetBusMode(), which also pass down a wrong argument order to
EmmcPeimSwitchToHighSpeed()?
2. Other patches are all related
Marvin,
I guess there should be other places also have CloseEvent() in ExitBootServices
callback.
I am curious what is the real issue you met. If no, how about to just keep
current code implementation? :)
Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.
Sorry, Macrin. Could you explain more about this fix?
According to AHCI spec, " When PxCMD.FRE is set (causing PxCMD.FR to be set to
‘1’), the HBA receives FISes from the device and copies them into system
memory. "
The lines you removed in the patch is waiting for PxCMD.FR to be set to 1
rath
In my opinion, when AttemptConfigData->AttemptTitleHelpToken equals to 0, the
system is running out of resources. So we 'd better to return the error now
instead of continue processing.
Best Regards,
Ye Ting
-Original Message-
From: Zhang, Lubo
Sent: Monday, June 20, 2016 5:57 PM
To: Y
Liming,
Where these 2 files missed in your binary compare of output?
Thanks,
Mike
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
> Ersek
> Sent: Monday, June 20, 2016 5:59 PM
> To: Justen, Jordan L ; Gao, Liming
>
> Cc: edk2-de...
On 06/21/16 01:36, Laszlo Ersek wrote:
> See the discussion in the parent post.
>
> Cc: Liming Gao
> Cc: Jordan Justen
>
> Thanks
> Laszlo
>
> Laszlo Ersek (2):
> UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/MpFuncs.nasm: add 0x67 prefix to far
> jump
> UefiCpuPkg/PiSmmCpuDxeSmm/X64/MpFuncs.nasm: ad
On 06/21/16 02:00, Iuliu Rus wrote:
> Hello,
> I'm trying to use OVMF with Google's virtual machine manager. For this, i
> need to add a new WAET table. We don't support the full QEMU config
> interface so this has to be a default table.
> I added a new WAET.aslc file under OVMFPkg/AcpiTables and a
From: Jan Dąbroś
In order to force SD stack to use PIO mode, PcdSdForcePioMode flag is
added. If it's set, driver will use this mode regardless controller
capabilities.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jan Dabros
Signed-off-by: Marcin Wojtas
---
MdeModule
From: Jan Dąbroś
For multiple block write operation it is necessary to poll for device status
to be ready for next transaction. For sending SD_DEVICE_STATUS command it is
necessary to know device RCA. In order to make it possible, there is new
field added to SD_DEVICE structure called "Rca".
Con
From: Joe Zhou
This delay is necessary for eMMC reset to working properly.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Joe Zhou
Signed-off-by: Marcin Wojtas
---
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Md
From: Jan Dąbroś
SD_STOP_TRANSMISSION command is necessary for multi block operations
(read and write). This patch adds this functionality.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jan Dabros
Signed-off-by: Marcin Wojtas
---
MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.c
From: Jan Dąbroś
This patch adds SetBlockLen function, which sends transfer blocks
size setting to device.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jan Dabros
Signed-off-by: Marcin Wojtas
---
MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.c | 33
Hello,
Changes implemented in this patchset:
* Add fixes for MMC devices
Small fixes including adding proper delay, and reorder function
parameters are implemented
* Add PIO mode support
There are adjustments necessary for SdBlockIo layer to perform data transfer
in PIO mode. PcdSdForceP
From: Joe Zhou
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Joe Zhou
Signed-off-by: Marcin Wojtas
---
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c
b
On 06/21/16 02:31, Jordan Justen wrote:
> On 2016-06-20 16:28:04, Laszlo Ersek wrote:
>> On 06/20/16 10:07, Gao, Liming wrote:
>>> Laszlo:
>>> New changes:
>>>
>>> 1. Yes. nasm is listed first in BUILDRULEORDER so nasm source file
>>> will be used.
>>>
>>> 3. The files in MdePkg are
On 2016-06-20 17:08:58, Kinney, Michael D wrote:
> Jordan,
>
> There is a "Driver" directory in the proposal and the types of
> components you refer to would go into packages under "Driver".
>
> An OS does not need to initialize the CPU/Chipset/Memory/SoC
> from reset. These are actions that ar
From: Jan Dąbroś
It is enough to set PxCMD.FRE bit, which cause HBA to post received FISes
into the FIS receive area. According to AHCI Specification, only polling on
PxCMD.FRE to be cleared is necessary, when it is needeed to stop FIS engine
(eg. in order to change PxCMD.FB address).
Contribute
On 2016-06-20 16:28:04, Laszlo Ersek wrote:
> On 06/20/16 10:07, Gao, Liming wrote:
> > Laszlo:
> > New changes:
> >
> > 1. Yes. nasm is listed first in BUILDRULEORDER so nasm source file
> > will be used.
> >
> > 3. The files in MdePkg are auto converted. Most of the files in othe
Jordan,
There is a "Driver" directory in the proposal and the types of
components you refer to would go into packages under "Driver".
An OS does not need to initialize the CPU/Chipset/Memory/SoC
from reset. These are actions that are either done by HW
or firmware, which is why I am proposing a
Hello,
I'm trying to use OVMF with Google's virtual machine manager. For this, i
need to add a new WAET table. We don't support the full QEMU config
interface so this has to be a default table.
I added a new WAET.aslc file under OVMFPkg/AcpiTables and added it to the
AcpiTables.inf file.
When i bui
On 2016-06-17 15:58:38, Mudusuru, Giri P wrote:
> Thanks Mike. My preference is Silicon as it is generic and
> represents broadly CPU/Memory/Chipset/SoC etc...
>
I believe Silicon can be used to manufacture other items as well. And,
it is possible to manufacture electronics without it being based
Without the a32 modifier under FLAT32_JUMP, and the a16 modifier under
LONG_JUMP, nasm doesn't generate the 0x67 prefixes, and the far jumps
don't work. (For the former, KVM returns an emulation failure. For the
latter, KVM performs a triple fault (guest reboot).) By forcing the 0x67
prefixes we en
See the discussion in the parent post.
Cc: Liming Gao
Cc: Jordan Justen
Thanks
Laszlo
Laszlo Ersek (2):
UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/MpFuncs.nasm: add 0x67 prefix to far
jump
UefiCpuPkg/PiSmmCpuDxeSmm/X64/MpFuncs.nasm: add 0x67 prefixes to far
jumps
UefiCpuPkg/PiSmmCpuDxeSmm/Ia
When we enter protected mode, with the far jump still in big real mode,
the JMP instruction not only needs the 0x66 prefix (for 32-bit operand
size), but also the 0x67 prefix (for 32-bit address size). Use the a32
nasm modifier to enforce this.
This bug breaks S3 resume in the Ia32 + SMM_REQUIRE b
On 06/20/16 10:07, Gao, Liming wrote:
> Laszlo:
> New changes:
>
> 1. Yes. nasm is listed first in BUILDRULEORDER so nasm source file will
> be used.
>
> 3. The files in MdePkg are auto converted. Most of the files in other
> packages manually are updated. They are updated based o
Hi Jiaxin,
Ever since this patch (below), I've been having problems with DHCP on my boards.
I've isolated the problem and can reproduce it every time now.
If I allow the board to auto boot, it tries to PXE boot, fails (I've
stopped my TFTP server on purpose to trigger the failure), drops to
shel
Hey Bruce,
I think the exact behavior is not defined, though I remember reading (I'm not
sure if from the specification) that the OS loader should only keep calling
GetMemoryMap() and ExitBootServices() after the first ExitBootServices() call;
this would apply to drivers hooking the event as we
Hey Star,
Thanks for your input! I agree, this has been a plain oversight by me.
Would you be fine with a V2 of this patch lacking the modifications to the SMM
code? There has been another place this change has been applied to -
IScsiMisc.c.
Thanks,
Marvin.
> -Original Message-
> From
Hey Liming,
As said in the commit message: 'DxeIpl has been excluded as its main function
returns a status.'
The function has a return value, so, when we add the UNREACHABLE() call, the
supported compilers will complain about a return statement past unreachable
code - or about a function with a
On 6/19/16 9:21 PM, Zeng, Star wrote:
2. According to UEFI 2.6 spec page 222 below, the UEFI OS loader should have
got the memory map before ExitBootServices.
That means the memory free should not impact the memory map *got by UEFI OS
loader*, it will only impact the memory map if the UEFI OS
Hey Liming,
Thanks for your comment! That is actually how my first local change looked
like, though I noticed that this breaks the 'CR' macro in DebugLib.h, which
uses _ASSERT() 'inline'.
Furthermore, I cannot think of any usage case where it would be beneficial
other than NULL-checks.
Thanks,
On Mon, 20 Jun 2016 16:02:59 +0200
Laszlo Ersek wrote:
> Hi,
>
> I posted a related question in
>
> http://thread.gmane.org/gmane.comp.bios.edk2.devel/13381
>
> but I thought I'd approach it from another angle, more succinctly.
>
> If I set PcdSrIovSupport to FALSE, what functionality exact
I think we need to revisit this. If the user elects to build a shell that does
not contain level 3 commands, this looks like the echo command would still
exist and function which would violate the spec.
-Jaben
> -Original Message-
> From: Qiu, Shumin
> Sent: Monday, June 20, 2016 12:30
Hi,
I posted a related question in
http://thread.gmane.org/gmane.comp.bios.edk2.devel/13381
but I thought I'd approach it from another angle, more succinctly.
If I set PcdSrIovSupport to FALSE, what functionality exactly will
become unavailable in the firmware? I tried to grep the source for
Sunny,
Failure of GetSectionFromFv() only means the BootManagerMenu FFS doesn't have
UI section.
So it cannot be the indicator of the absence of BootManagerMenu FFS.
Secondly, BDS core assumes firmware would have the Boot Manager Menu. Absence
is a fatal error I think.
Lots of code calls EfiBoot
Do you mean that if we already find an attempt from the Variable and configure
some parameters, but finally get string Id AttemptTitleHelpToken failed. If we
continue, this attempt will not be added to global link list which will be used
frequently and lead to a wrong code logic later, so we sh
On 06/20/16 06:16, Ni, Ruiyu wrote:
> Laszlo, Jaben,
>
> The dotdot style is copied from Shell spec V2.2 page 120 “dh” command
> output sample.
Hmmm, indeed. I think that's a bit unfortunate for the spec, but then
again I agree that the code follows the example.
Thanks
Laszlo
> *From:*Carsey, J
Sunny,
I don't agree to keep the RAM disk. Because every HTTP boot will create a new
one. Then there will be many RAM disk instances.
Regards,
Ray
>-Original Message-
>From: Sunny Wang [mailto:sunnyw...@hpe.com]
>Sent: Monday, June 20, 2016 4:13 PM
>To: edk2-devel@lists.01.org
>Cc: el...
Sunny,
Under what circumstance the memory usage statistics don't count the allocation?
Regards,
Ray
>-Original Message-
>From: Sunny Wang [mailto:sunnyw...@hpe.com]
>Sent: Monday, June 20, 2016 4:03 PM
>To: edk2-devel@lists.01.org
>Cc: el...@hpe.com; Ni, Ruiyu ; Sunny Wang
>
>Subject: [P
This is a enhancement.
For now, if BootManagerMenu FFS can not be found from FV, BDS core code will
still register a boot option for it. Then, this non-functional boot option will
still be booted by user's request (like HotKey or Exit from shell) to cause
additional boot time and error status co
On 06/20/16 02:50, Bi, Dandan wrote:
> Hi Laszlo,
>
> Yes, this is a performance improvement!
> We remove the connect-all action in BootManagerUiLib,
> so improve the performance when enter Boot Manager form.
That's cool; I've noticed a brief pause there.
Thanks!
Laszlo
> -Original Message
Hi Lubo,
I recommend to return EFI_OUT_OF_RESOURCES instead of continue to process the
attempts in below codes. What do you think?
EFI_STATUS
IScsiGetConfigData (
IN ISCSI_DRIVER_DATA *Private
@@ -1290,11 +1291,13 @@ IScsiGetConfigData (
m
Reviewed-by: Ye Ting
-Original Message-
From: Wu, Jiaxin
Sent: Monday, June 20, 2016 9:46 AM
To: edk2-devel@lists.01.org
Cc: Ye, Ting ; Fu, Siyuan ; Zhang, Lubo
Subject: [PATCH v2] NetworkPkg: Replace ASSERT with error handling in DnsDxe
v2:
*Use goto to simplify code logic.
This pa
Marvin:
One is missing. Could you add it?
https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Core/DxeIplPeim/DxeLoad.c#L432
Thanks
Liming
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Marvin Häuser
> Sent: Sunday, June 19, 2016 9:
Marvin:
I prefer to update _ASSERT macro like below. If so, ASSERT, ASSERT_EFI_ERROR
and ASSERT_PROTOCOL_ALREADY_INSTALLED can all be hooked.
+#define _ASSERT(Expression) \
+do { \
+ DebugAssert (__FILE__, __
There may be some use cases which need to keep HTTP boot mounted RAM disk
(downloaded image) after image returns back to save the time for downloading
the same image again.
Therefore, this code change is to remove BmDestroyRamDisk() function call to
keep the mounted RAM disk for these cases.
Co
Reviewed-by: Liming Gao
> -Original Message-
> From: Zeng, Star
> Sent: Friday, June 17, 2016 10:04 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [PATCH] MdeModulePkg PCD: Avoid DynamicHii PCD set to override
> other values
>
> When Hii variable is not present and if we
Laszlo:
New changes:
1. Yes. nasm is listed first in BUILDRULEORDER so nasm source file will
be used.
3. The files in MdePkg are auto converted. Most of the files in other
packages manually are updated. They are updated based on the auto converted
version.
Verification
1.
After booting a large-size ISO RAM disk (HTTP boot option pointing to a ISO
file) and rebooting the system, system will possibly run into the following
ASSERT because the BDS core code doesn't consider the case that Memory page
management (Page.c) would possibly skip updating current memory usag
Currently run 'echo -t' will get the result:
echo: Unknown flag - '-t'
The expected result is to display '-t' literally.
This patch adds special handle for 'echo'. 'echo' will not use the
general parameter parsing library .
Cc: Jaben Carsey
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution
v2:
*Since we have redefined the name of arch types in Dhcp.h for http boot,
it need to change corresponding codes.
Add a new head file Dhcp.h in Mde/Include/IndustryStandard, normalize the
universal option numbers and other network number tags.
Cc: Sriram Subramanian
Cc: Ye Ting
Cc: Fu Siyuan
71 matches
Mail list logo
