Reviewed-by: Liming Gao
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Tuesday, June 28, 2016 9:26 PM
To: edk2-devel-01
Cc: Gao, Liming
Subject: [PATCH 1/6] EdkCompatibilityPkg: fix ASSERT_EFI_ERROR() typos
A number of code locations use
ASSERT_EFI_ERROR (Bo
Laszlo,
Thanks for fixing such a big bug.
I am curious how you detect such buggy code? By code review?
Regards,
Ray
>-Original Message-
>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
>Ersek
>Sent: Tuesday, June 28, 2016 9:26 PM
>To: edk2-devel-01
>Cc: Ca
Andrew:
Could you give one example to reproduce it?
Thanks
Liming
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Andrew Fish
> Sent: Wednesday, June 29, 2016 5:17 AM
> To: edk2-devel
> Subject: [edk2] [BaseTools] I had an issue with diff
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Guo Mang
---
Vlv2TbltDevicePkg/PlatformSetupDxe/SouthClusterConfig.vfi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Vlv2TbltDevicePkg/PlatformSetupDxe/SouthClusterConfig.vfi
b/Vlv2TbltDevicePkg/Pla
Hi Cran,
You know to support X64 Microsoft variable argument (VA) ABI, we need two parts
work together in edk2:
First is to the define "DEFIAPI=__attribute__((ms_abi)) in CC_FLAGS.
Second is to use below __builtin_ms_va_* builtins as the VA macro.
__builtin_ms_va_list ap;
__builtin_ms_va_
All,
I will check in this fix soon as it breaks all build.
Thanks
Feng
-Original Message-
From: Gao, Liming
Sent: Wednesday, June 29, 2016 11:26 AM
To: Tian, Feng
Cc: edk2-devel@lists.01.org
Subject: RE: [edk2] [patch] MdePkg/IndustryStandard: fix build break due to
latest Atapi.h cha
On 6/28/2016 10:40 PM, Shi, Steven wrote:
OK. Could you let me know your driver code size change from GCC49 to GCC53? I
wish GCC53 can improve it.
The change from GCC49 to GCC53 is rather good - the driver .efi file has
reduced from 751K to 589KB.
Thanks for implementing this!
--
Bruce
___
> On Jun 28, 2016, at 9:34 PM, Bruce Cran wrote:
>
>
> On 6/28/2016 10:28 PM, Shi, Steven wrote:
>
>> OK. How about GCC53? Can GCC53 build your driver?
>
> Yes, GCC53 works fine (the"gcc" it runs actually being gcc 6.1.1). Sorry, I
> know not having access to the driver binary will make it
OK. Could you let me know your driver code size change from GCC49 to GCC53? I
wish GCC53 can improve it.
To debug your GenFW issue, please check whether it is a R_X86_64_REX_GOTPCRELX
type. Maybe the R_X86_64_REX_GOTPCRELX need use different convert rule from
R_X86_64_GOTPCREL.
Steven Shi
Int
On 6/28/2016 10:28 PM, Shi, Steven wrote:
OK. How about GCC53? Can GCC53 build your driver?
Yes, GCC53 works fine (the"gcc" it runs actually being gcc 6.1.1).
Sorry, I know not having access to the driver binary will make it almost
impossible to debug!
--
Bruce
___
Just a update. After offline discussing with Ray, I will send patch v3 based on
some of his comments listed below and some further updates coming from our
offline discussion.
Regards,
Sunny Wang
-Original Message-
From: Ni, Ruiyu [mailto:ruiyu...@intel.com]
Sent: Wednesday, June 29, 20
OK. How about GCC53? Can GCC53 build your driver?
Steven Shi
Intel\SSG\STO\UEFI Firmware
Tel: +86 021-61166522
iNet: 821-6522
> -Original Message-
> From: Bruce Cran [mailto:br...@cran.org.uk]
> Sent: Wednesday, June 29, 2016 12:12 PM
> To: Shi, Steven ; edk2-devel@lists.01.org
> Subj
On 6/28/2016 9:51 PM, Shi, Steven wrote:
Can you build the OVMF with CLANG38 in your side?
And if possible, pls send me your driver .dll Elf image and I can try to debug
the GenFw convert in my side.
Yes, both DEBUG and RELEASE X64 builds of OVMF complete fine.
I wish I could send the driver
Hi Cran,
Can you build the OVMF with CLANG38 in your side?
And if possible, pls send me your driver .dll Elf image and I can try to debug
the GenFw convert in my side.
Steven Shi
Intel\SSG\STO\UEFI Firmware
Tel: +86 021-61166522
iNet: 821-6522
> -Original Message-
> From: Bruce Cran
After applying Steven's (cc'd) patch set and building our driver with
the CLANG38 toolchain, GenFw crashes with a segmentation fault. Due to
unresolved memset and memcpy symbols, I've added the flags "-fbuiltin
-fno-lto".
#0 0x0040bccf in WriteRelocations64 () at Elf64Convert.c:975
#
Reviewed-by: Liming Gao
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Feng Tian
> Sent: Wednesday, June 29, 2016 11:12 AM
> To: Gao, Liming
> Cc: edk2-devel@lists.01.org
> Subject: [edk2] [patch] MdePkg/IndustryStandard: fix build break d
This change is to avoid UEFI SCT failure as UEFI SCT has no knowledge
about how to accessing a EMMC RPMB partition.
The user needs to access RPMB partition should get access through
EFI_SD_MMC_PASS_THRU protocol with authentication key & mac.
Cc: Hao Wu
Contributed-under: TianoCore Contribution
Update the new introduced ATA_CMD_SEEK to ATA_CMD_ATAPI_SEEK.
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Feng Tian
---
MdePkg/Include/IndustryStandard/Atapi.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MdePkg/Include/Indust
Hi, Anandakrishnan
Your patch makes the build break.
warning C4005: 'ATA_CMD_SEEK': macro redefinition
I would submit patch to update those ATPI cmds prefix from ATA_ to ATAPI_.
Thanks
Feng
-Original Message-
From: Tian, Feng
Sent: Tuesday, June 28, 2016 9:37 PM
To: Gao, Liming ; Anan
Andrew:
Thanks for your report it. It may be caused by self.CurrentFvName =
FvName.upper()
https://github.com/tianocore/edk2/blob/master/BaseTools/Source/Python/GenFds/FdfParser.py#L2134
Thanks
Liming
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On B
On 6/28/2016 8:09 PM, Gao, Liming wrote:
Yes. We add EFIAPI in such function, and define
"-DEFIAPI=__attribute__((ms_abi))" in GCC CC_FLAGS.
Thanks. Unfortunately the code needs to remain portable across Windows,
Linux and other systems, so the best solution is probably a macro
similar to
PI specification Vol 4 - SMM does not have any limitation of BASE_4GB for SMM.
So we should replace BASE_4GB check with MAX_ADDRESS check to make sure
the SMM memory is accessible by SMM Core.
Cc: Jeff Fan
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by
Reviewed-by: Giri P Mudusuru
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fan,
> Jeff
> Sent: Tuesday, June 28, 2016 7:02 PM
> To: Laszlo Ersek ; edk2-devel-01 de...@ml01.01.org>
> Subject: Re: [edk2] [PATCH 5/6] UefiCpuPkg: fix ASSERT_EF
Sunny,
I have 7 minor comments. Please check below.
Regards,
Ray
>-Original Message-
>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Sunny
>Wang
>Sent: Tuesday, June 28, 2016 10:27 AM
>To: edk2-devel@lists.01.org
>Cc: Ni, Ruiyu
>Subject: [edk2] [PATCH v2] MdeModu
Reviewed-by: Giri P Mudusuru
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
> Ersek
> Sent: Tuesday, June 28, 2016 6:26 AM
> To: edk2-devel-01
> Cc: Kinney, Michael D
> Subject: [edk2] [PATCH 3/6] QuarkPlatformPkg: fix ASSERT_EFI_ER
Reviewed-by: Giri P Mudusuru
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
> Ersek
> Sent: Tuesday, June 28, 2016 6:26 AM
> To: edk2-devel-01
> Cc: He, Tim ; Wei, David
> Subject: [edk2] [PATCH 6/6] Vlv2TbltDevicePkg: fix ASSERT_EF
> On Jun 28, 2016, at 7:09 PM, Gao, Liming wrote:
>
> Bruce:
> Yes. We add EFIAPI in such function, and define
> "-DEFIAPI=__attribute__((ms_abi))" in GCC CC_FLAGS.
>
I don't know how the version of clang used was constructed, but clang is
inherently a cross compiler and it can easily supp
Reviewed-by: Giri P Mudusuru
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
> Ersek
> Sent: Tuesday, June 28, 2016 6:26 AM
> To: edk2-devel-01
> Cc: Carsey, Jaben ; Qiu, Shumin
>
> Subject: [edk2] [PATCH 4/6] ShellPkg: don't call fu
Reviewed-by: Giri P Mudusuru
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
> Ersek
> Sent: Tuesday, June 28, 2016 6:26 AM
> To: edk2-devel-01
> Cc: Gao, Liming
> Subject: [edk2] [PATCH 1/6] EdkCompatibilityPkg: fix ASSERT_EFI_ERROR
Bruce:
Yes. We add EFIAPI in such function, and define
"-DEFIAPI=__attribute__((ms_abi))" in GCC CC_FLAGS.
Thanks
Liming
> -Original Message-
> From: Bruce Cran [mailto:br...@cran.org.uk]
> Sent: Wednesday, June 29, 2016 6:45 AM
> To: Shi, Steven ; edk2-devel@lists.01.org; Gao,
> Limin
Reviewed-by: Jeff Fan
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Tuesday, June 28, 2016 9:26 PM
To: edk2-devel-01
Cc: Fan, Jeff
Subject: [PATCH 5/6] UefiCpuPkg: fix ASSERT_EFI_ERROR() typos
A number of code locations use
ASSERT_EFI_ERROR (BooleanExpression
On Tue, Jun 28, 2016 at 01:43:31PM +0100, Michael Brown wrote:
> On 28/06/16 13:34, Michael Brown wrote:
> > On 28/06/16 13:30, Laszlo Ersek wrote:
> > > On 06/24/16 06:39, Gary Lin wrote:
> > > > It seems that iPXE didn't initialize Scope, so the value was assigned
> > > > randomly (sort of).
> >
On 6/28/16 9:18 AM, Shi, Steven wrote:
Introduce three new toolchains in edk2. The first two ones support Link Time
Optimization (LTO) for aggressive code size improvement and the third one is
for static analysis.
CLANG38: Enable LLVM Link Time Optimization (LTO) and code size
optimizatio
On 06/28/16 21:24, Bruce Cran wrote:
> Change-Id: I2973d251e18583531bf4579ba8dfa8101bea0939
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Bruce Cran
> ---
> ArmVirtPkg/ArmVirtQemu.dsc | 1 +
> ArmVirtPkg/ArmVirtQemu.fdf | 1 +
> ArmVirtPkg/ArmVirtQemuKerne
On 06/28/16 21:09, Bruce Cran wrote:
> From: Bruce Cran
>
> Change-Id: I7549947ccb78aa316ff9082f336a3ad32769a0c6
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Bruce Cran
> ---
> OvmfPkg/OvmfPkgIa32.dsc| 1 +
> OvmfPkg/OvmfPkgIa32.fdf| 1 +
> OvmfPkg/OvmfPkgI
I hit an issue with this code.
https://github.com/tianocore/edk2/blob/master/BaseTools/Source/Python/AutoGen/AutoGen.py#L2510
self.SourceDir = mws.relpath(self.SourceDir, self.WorkspaceDir)
I had a combination of relative and absolute references in the DSC and FDF and
the build did not
I ran into a case issue with this code.
FvReportFileName = os.path.join(self._FvDir, FvName + ".Fv.txt")
https://github.com/tianocore/edk2/blob/master/BaseTools/Source/Python/build/BuildReport.py#L1462
I ended up testing FvReportFileName and if it was not found I forced FvName to
al
Change-Id: I2973d251e18583531bf4579ba8dfa8101bea0939
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Bruce Cran
---
ArmVirtPkg/ArmVirtQemu.dsc | 1 +
ArmVirtPkg/ArmVirtQemu.fdf | 1 +
ArmVirtPkg/ArmVirtQemuKernel.dsc | 1 +
ArmVirtPkg/ArmVirtQemuKernel.fdf | 1 +
From: Bruce Cran
Change-Id: I7549947ccb78aa316ff9082f336a3ad32769a0c6
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Bruce Cran
---
OvmfPkg/OvmfPkgIa32.dsc| 1 +
OvmfPkg/OvmfPkgIa32.fdf| 1 +
OvmfPkg/OvmfPkgIa32X64.dsc | 1 +
OvmfPkg/OvmfPkgIa32X64.fdf | 1 +
Ovm
Print's "%g" argument requires a EFI_GUID pointer, not the EFI_GUID
value.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Thomas Palmer
---
ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
On 2016-06-28 03:35:57, Laszlo Ersek wrote:
>
> Leif recommended "efi-virt" elsewhere, as an arch-less / catch-all name.
> I think I prefer it a bit over ovmf-*: in case ovmf- is
> mentioned, the idea is clear, but if you just want to say "guest UEFI",
> without mentioning the guest arch, "ovmf" w
Introduce three new toolchains in edk2. The first two ones support Link Time
Optimization (LTO) for aggressive code size improvement and the third one is
for static analysis.
CLANG38: Enable LLVM Link Time Optimization (LTO) and code size
optimization flag (-Os) by default for aggressive c
Enable three new toolchains: CLANG38, CLANGSCAN38 and GCC53.
(1)CLANG38 uses Clang3.8.0, enable LLVM Link Time Optimization (LTO)
and code size optimization flag (-Oz) by default for aggressive code
size improvement. CLANG38 X64 code is small code model + PIE.
(2)CLANGSCAN38 is based on CLANG38 to
The MRC use the memset() in the code and assume the compiler to offer
such builtin fuctions. Add work around to permit compiler add builtin
functions in this module. Also MRC mix some inline assembly,
e.g. asm("rdtsc":"=a"(tscL),"=d"(tscH)),in the C code, and CLANG38
could wrongly remove them if en
LANG38 find a bug and give a warning that Ohci silicon code wrongly
use '||' as '|'.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Steven Shi
---
QuarkSocPkg/QuarkSouthCluster/Usb/Ohci/Pei/OhciReg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
mode change 10064
Use explicit CopyMem to replace compiler builtin to do the structure
values assignment.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Steven Shi
---
ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
mode change 100644
Both GCC and LLVM 3.8 64bits support new variable argument (VA)
intrinsics for Microsoft ABI, enable these new VA intrinsics for
GNUC family 64bits code build. These VA intrinsics are only
permitted use in 64bits code, so not use them in 32bits code build.
The original 32bits GNU VA intrinsics has
Quark AcpiPlatform module cannot link successfully by CLANG38
with Oz optimization level. Add a work around to downgrade the
optimization to O1.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Steven Shi
---
QuarkPlatformPkg/Acpi/Dxe/AcpiPlatform/AcpiPlatform.inf | 4
Add support to convert missing Elf relocation types
(R_X86_64_PLT32, R_X86_64_GOTPCREL, R_X86_64_REX_GOTPCRELX)
to PeCoff, which are required by LTO image.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Steven Shi
---
BaseTools/Source/C/GenFw/Elf64Convert.c | 98 +
Hi, Anandakrishnan
Reviewed-by: Feng Tian
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Gao,
Liming
Sent: Monday, June 27, 2016 5:15 PM
To: Anandakrishnan Loganathan ; edk2-devel@lists.01.org
Subject: Re: [edk2] [PATCH] [MdePkg ] Additional At
A number of code locations use
ASSERT_EFI_ERROR (BooleanExpression)
instead of
ASSERT (BooleanExpression)
Fix them.
Cc: Jeff Fan
Reported-by: Gerd Hoffmann
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmProfileAr
A number of code locations use
ASSERT_EFI_ERROR (BooleanExpression)
instead of
ASSERT (BooleanExpression)
Fix them.
Cc: David Wei
Cc: Tim He
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
Notes:
not even build tested
Vlv2TbltDevicePkg/FvbR
When ASSERT_EFI_ERROR() is compiled out, dependent on build flags, only
the status checking should be removed; the function calls should stay.
Cc: Jaben Carsey
Cc: Shumin Qiu
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
Notes:
build tested
Shell
Gerd's Jenkins CI worker has recently tried to build a few edk2 packages
with gcc-6. Gcc-6 introduces a new warning (among many others, likely)
called "bool-compare":
https://gcc.gnu.org/onlinedocs/gcc-6.1.0/gcc/Warning-Options.html#index-Wbool-compare-453
The build broke subsequently, exposin
A number of code locations use
ASSERT_EFI_ERROR (BooleanExpression)
instead of
ASSERT (BooleanExpression)
Fix them.
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
Notes:
build tested only
EdkCompatibilityPkg/Compatibility/Fra
A number of code locations use
ASSERT_EFI_ERROR (BooleanExpression)
instead of
ASSERT (BooleanExpression)
Fix them.
Cc: Michael D Kinney
Cc: Kelly Steele
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
Notes:
not even build tested
QuarkPlat
A number of code locations use
ASSERT_EFI_ERROR (BooleanExpression)
instead of
ASSERT (BooleanExpression)
Fix them.
Cc: Siyuan Fu
Cc: Jiaxin Wu
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
Notes:
build tested only
NetworkPkg/IpSecDxe/Ike
On 06/28/16 14:43, Michael Brown wrote:
> On 28/06/16 13:34, Michael Brown wrote:
>> On 28/06/16 13:30, Laszlo Ersek wrote:
>>> On 06/24/16 06:39, Gary Lin wrote:
It seems that iPXE didn't initialize Scope, so the value was assigned
randomly (sort of).
diff --git a/src/interface
On 28/06/16 13:34, Michael Brown wrote:
On 28/06/16 13:30, Laszlo Ersek wrote:
On 06/24/16 06:39, Gary Lin wrote:
It seems that iPXE didn't initialize Scope, so the value was assigned
randomly (sort of).
diff --git a/src/interface/efi/efi_hii.c b/src/interface/efi/efi_hii.c
index 0ea970e..4b5a
On 28/06/16 13:30, Laszlo Ersek wrote:
On 06/24/16 06:39, Gary Lin wrote:
It seems that iPXE didn't initialize Scope, so the value was assigned
randomly (sort of).
diff --git a/src/interface/efi/efi_hii.c b/src/interface/efi/efi_hii.c
index 0ea970e..4b5aa9a 100644
--- a/src/interface/efi/efi_hi
On 06/24/16 10:41, Gerd Hoffmann wrote:
> Hi,
>
>> Thanks, I guess we can remove these if building with
>> DEBUG=virtio-net:2 was intentional and it interferes with other
>> output. But then again, if you build for example with DEBUG=tcp:2,
>> you'll see a debug message for each transmitted or r
On 06/24/16 06:39, Gary Lin wrote:
> On Fri, Jun 24, 2016 at 10:19:30AM +0800, Gary Lin wrote:
>> On Thu, Jun 23, 2016 at 02:57:49PM +0200, Laszlo Ersek wrote:
>>> On 06/23/16 06:43, Gary Lin wrote:
On Wed, Jun 22, 2016 at 07:24:32PM +0200, Laszlo Ersek wrote:
> Gary,
>
> On 06/22/
On 28 June 2016 at 14:06, Julien Grall wrote:
> Hi Ard,
>
> On 28/06/16 12:39, Ard Biesheuvel wrote:
>>
>> On 25 June 2016 at 09:16, Shannon Zhao wrote:
>>>
>>> From: Shannon Zhao
>>>
>>> Add ACPI support for Virt Xen ARM and only for aarch64. It gets the
>>> ACPI tables through Xen ARM multiboo
On 25 June 2016 at 09:16, Shannon Zhao wrote:
> From: Shannon Zhao
>
> Add ACPI support for Virt Xen ARM and only for aarch64. It gets the
> ACPI tables through Xen ARM multiboot protocol.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Shannon Zhao
Reviewed-by: Ard
On 06/28/16 04:02, Gao, Liming wrote:
> MdeModulePkg\Universal\DriverHealthManagerDxe\DriverHealthManagerDxe.inf is
> missing after new MdeModulePkg/Universal/BdsDxe/BdsDxe.inf is applied.
Thanks for the info, Liming!
Bruce, could you please submit two patches that add this driver to
OvmfPkg an
On 06/28/16 09:27, Jordan Justen wrote:
> On 2016-06-26 08:44:04, Leif Lindholm wrote:
>>
>> On Fri, Jun 17, 2016 at 10:51:47PM +, Kinney, Michael D wrote:
>>> Common
>>> CorebootPayloadPkg
>>> DuetPkg
>>> EmulatorPkg
>>> Nt32Pkg
>>> OvmfPkg
>>
>> So, I would l
Let data of DXE memory status code can be used by other modules.
1. Save the address of DXE memory status code table to DxeConfigurationTable.
2. Save the address of SMM memory status code table to SmmConfigurationTable.
3. Move RUNTIME_MEMORY_STATUSCODE_HEADER to its public header file.
Contribut
Reviewed-by: Ye Ting
-Original Message-
From: Fu, Siyuan
Sent: Tuesday, June 28, 2016 4:32 PM
To: edk2-devel@lists.01.org
Cc: Ye, Ting ; Wu, Jiaxin
Subject: [Patch] NetworkPkg: Stop the HTTP Boot service after the boot image
download complete.
After boot image has been downloaded, th
Hi,
I have PCI 3.0 controller driver written, which is platform specific and is
integrated with MdeModule/Bus/Pci/PciBusDxe code.
On top of it is the E1000 Intel NIC card driver integrated with
"MdeModulePkg/Universal/Network/".
The whole network stack is working fine functionally.
But tf
Looks good to me!
Reviewed-By: Wu Jiaxin
Best Regards!
Jiaxin
> -Original Message-
> From: Fu, Siyuan
> Sent: Tuesday, June 28, 2016 4:32 PM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting ; Wu, Jiaxin
> Subject: [Patch] NetworkPkg: Stop the HTTP Boot service after the boot
> image downlo
After boot image has been downloaded, the HTTP boot driver leaves the service
in the started state, with an active TCP child. This may cause some problems:
1. The HTTP session may become unavaiable after a while, then a following HTTP
Boot will fail.
2. An active TCP child will send RST to any inco
Hi Liming,
Thanks for your feedback. Will fix it in v3.
Thanks,
Cinnamon Shia
-Original Message-
From: Gao, Liming [mailto:liming@intel.com]
Sent: Tuesday, June 28, 2016 1:16 PM
To: Shia, Cinnamon ; edk2-devel@lists.01.org
Cc: Tian, Feng ; Zeng, Star
Subject: RE: [PATCH v2] MdeModu
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Zeng, Star
> Sent: Tuesday, June 28, 2016 2:12 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen
> Subject: [PATCH] MdeModulePkg VariableInfo: Use fixed buffer for smm
> comm buffer
>
> Cc: Jiewen Yao
> Contributed-under:
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Zeng, Star
> Sent: Tuesday, June 28, 2016 2:11 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen ; Gao, Liming
>
> Subject: [PATCH] MdeModulePkg DxeSmmPerformanceLib: Add missing
> UefiLib in *.inf at de2459d
>
> Cc: Jiewen
On 2016-06-26 08:44:04, Leif Lindholm wrote:
>
> On Fri, Jun 17, 2016 at 10:51:47PM +, Kinney, Michael D wrote:
> > Common
> > CorebootPayloadPkg
> > DuetPkg
> > EmulatorPkg
> > Nt32Pkg
> > OvmfPkg
>
> So, I would like to propose a semi-tedious change here:
>
75 matches
Mail list logo
