Re: [edk2] [PATCH v2 4/5] OvmfPkg: include UefiCpuPkg/CpuMpPei

On 07/13/16 02:40, Fan, Jeff wrote: > Laszlo, > > Even I have r-b this patch before, I have one comment now. :-) > > It's better to move PeiCpuExceptionHandlerLib instance from CpuMpPei to > > [LibraryClasses.common.PEIM] > + > CpuExceptionHandlerLib|UefiCpuPkg/Library/CpuExceptionHandlerLib

Re: [edk2] [PATCH v2 0/4] PCI resource reservation changes for better hotpluggability

On 07/13/16 03:05, Ni, Ruiyu wrote: > All of the serials, Reviewed-by: Ruiyu Ni > > I think it's now a PCIE world. The change #2/4 should be fine though it > changes > the PciBus behavior. > #3/4 isn't conflict with the existing platform PciHotPlugInitDxe driver which > still reports such PCIE p

[edk2] [Patch 1/5] UefiCpuPkg/PiSmmCpuDxeSmm: Remove duplicate aligned buffer on S3 path

From: Jeff Fan InitializeMpSyncData() invokes InitializeSmmCpuSemaphores() to allocate an aligned buffer for all locks and semaphores. However, this function is invoked on S3 resume path again to reset mSmmMpSyncData. It causes an additional aligned buffer to be allocated. This update moves Init

[edk2] [Patch 0/5] UefiCpuPkg/PiSmmCpuDxeSmm: S3 resume clean ups

This patch series fixes a number of small issues in the S3 resume path. * Remove duplicate aligned buffer allocation on S3 resume path * Add support for MemoryMapped REGISTER_TYPE in SetProcessorRegister() * Move XD/BTS feature detection to SmmInitHandler() to improve performance. Jeff Fan (5):

[edk2] [Patch 3/5] UefiCpuPkg/PiSmmCpuDxeSmm: Add SMM S3 boot flag

From: Jeff Fan It will be set to TRUE during S3 resume. Cc: Michael Kinney Cc: Feng Tian Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan --- UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/UefiCpuPkg/PiSmmC

[edk2] [Patch 5/5] UefiCpuPkg/PiSmmCpuDxeSmm: Clean up CheckFeatureSupported()

From: Jeff Fan Removed EFIAPI and parameter from CheckFeatureSupported() and removed CheckProcessorFeature() totally. Cc: Michael Kinney Cc: Feng Tian Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan --- UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 2 +- UefiC

[edk2] [Patch 4/5] UefiCpuPkg/PiSmmCpuDxeSmm: Check XD/BTS features in SMM relocation

From: Jeff Fan CheckProcessorFeature() invokes MpService->StartupAllAps() to detect XD/BTS features on normal boot path. It's not necessary and may cause performance impact, because INIT-SIPI-SIPI must be sent to APs if APs are in hlt-loop mode. XD/BTS feature detection is moved to SmmInitHandler

[edk2] [Patch 2/5] UefiCpuPkg/PiSmmCpuDxeSmm: Add MemoryMapped in SetProcessorRegister()

From: Jeff Fan REGISTER_TYPE in UefiCpuPkg/Include/AcpiCpuData.h defines a MemoryMapped enum value. However support for the MemoryMapped enum is missing from the implementation of SetProcessorRegister(). This patch adds support for MemoryMapped type SetProcessorRegister(). One spin lock is add

Re: [edk2] [Patch] UefiCpuPkg/MtrrLib: Remove MTRRs display from MtrrSetAllMtrrs()

On 07/13/16 08:20, Laszlo Ersek wrote: > - Audit all current uses of MtrrSetAllMtrrs(), and wherever it is > obviously called from the BSP, append the following explicit code: > > DEBUG_CODE (MtrrDebugPrintAllMtrrs()); Sorry, that should be DEBUG_CODE (MtrrDebugPrintAllMtrrs ()); (whites

Re: [edk2] [Patch] UefiCpuPkg/MtrrLib: Remove MTRRs display from MtrrSetAllMtrrs()

On 07/13/16 02:33, Jeff Fan wrote: > MtrrSetAllMtrrs() maybe used by APs to sync BSP's MTRR settings. BSP's MTRR > setting should be displayed if EFI_D_CACHE flag is set when MTRR updated. In > MtrrSetAllMtrrs(), it's not necessary to display MTRR setting again due to the > MTRR settings should be

[edk2] [Patch] CryptoPkg/OpensslLib: Upgrade OpenSSL version to 1.0.2h

OpenSSL 1.0.2h was released with several severity fixes at 03-May-2016 (https://www.openssl.org/news/secadv/20160503.txt). Upgrade the supported OpenSSL version in CryptoPkg/OpensslLib to catch the latest release 1.0.2h. Cc: Ting Ye Cc: David Woodhouse Contributed-under: TianoCore Contribution A

Re: [edk2] [Patch] Vlv2TbltDevicePkg:Fix Gcc Debug image can't boot to Yocto.

Reviewed-by: David Wei Thanks, David Wei Intel SSG BIOS Team -Original Message- From: Lu, ShifeiX A Sent: Wednesday, July 13, 2016 10:21 AM To: edk2-devel@lists.01.org Cc: Wei; Wei, David Subject: [Patch] Vlv2TbltDevicePkg:Fix Gcc Debug image ca

[edk2] [Patch] Vlv2TbltDevicePkg:Fix Gcc Debug image can't boot to Yocto.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: lushifex --- Vlv2TbltDevicePkg/PlatformPkgGcc.fdf| 9 - Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 23 --- 2 files changed, 24 insertions(+), 8 deletions(-) diff --git a/Vlv2TbltDevicePkg/Platf

Re: [edk2] [Patch] Vlv2TbltDevicePkg:Fix incompatible pointer with Gcc build

Reviewed-by: David Wei Thanks, David Wei Intel SSG BIOS Team -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of lushifex Sent: Wednesday, July 13, 2016 9:35 AM To: edk2-devel@lists.01.org Cc: w...@ml01.01.org

Re: [edk2] [Patch 0/2] Fix bug in TCP which not sending out ACK

Series Reviewed-By: Wu Jiaxin Best Regards! Jiaxin > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Fu Siyuan > Sent: Tuesday, July 12, 2016 9:50 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch 0/2] Fix bug in TCP which not sendin

Re: [edk2] [PATCH] ArmVirtPkg/HighMemDxe: allow patchable PCD for PcdSystemMemoryBase

On 2016/7/12 21:28, Laszlo Ersek wrote: > On 07/12/16 15:25, Laszlo Ersek wrote: >> > On 07/12/16 15:18, Ard Biesheuvel wrote: >>> >> On 12 July 2016 at 15:07, Laszlo Ersek wrote: >>> On 07/12/16 15:00, Ard Biesheuvel wrote: > Redefine the reference to PcdSystemMemoryBase in HighMe

[edk2] [Patch] Vlv2TbltDevicePkg:Fix incompatible pointer with Gcc build

Fixed an incompatible pointer issue to pass Gcc build Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: lushifex --- Vlv2TbltDevicePkg/PlatformRtcRuntimeDxe/PlatformRtc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/Vlv2TbltDevicePkg/PlatformRtcRuntimeDxe/PlatformRtc.

Re: [edk2] [PATCH] MdeModulePkg RamDiskDxe: Not use hardcode 'SectionInstance' to locate SSDT

Reviewed-by: Chao Zhang Thanks & Best regards Chao Zhang -Original Message- From: Wu, Hao A Sent: Wednesday, July 13, 2016 9:18 AM To: edk2-devel@lists.01.org Cc: Wu, Hao A; Tian, Feng; Zhang, Chao B Subject: [PATCH] MdeModulePkg RamDiskDxe: Not use hardcode 'SectionInstance' to l

[edk2] [PATCH] MdeModulePkg RamDiskDxe: Not use hardcode 'SectionInstance' to locate SSDT

This commit will scan all the EFI raw section instances within the module's FV to make sure the NVDIMM root device SSDT can be properly located. Cc: Feng Tian Cc: Zhang Chao B Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- .../Universal/Disk/RamDiskDxe/RamDis

Re: [edk2] [Patch 5/5] IntelFsp2Pkg SecFspSecPlatformLibNull: Remove MASM/GAS files

Reviewed by: jiewen@intel.com > -Original Message- > From: Gao, Liming > Sent: Friday, July 8, 2016 10:49 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Mudusuru, Giri P > > Subject: [Patch 5/5] IntelFsp2Pkg SecFspSecPlatformLibNull: Remove > MASM/GAS files > > Keep NASM file o

Re: [edk2] [Patch 3/5] IntelFsp2Pkg BaseFspDebugLibSerialPort: Remove MASM/GAS files

Reviewed by: jiewen@intel.com > -Original Message- > From: Gao, Liming > Sent: Friday, July 8, 2016 10:49 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Mudusuru, Giri P > > Subject: [Patch 3/5] IntelFsp2Pkg BaseFspDebugLibSerialPort: Remove > MASM/GAS files > > Keep NASM file

Re: [edk2] [Patch 1/4] SecurityPkg SecureBootConfigDxe: Add check for the external PE/COFF image.

I think this is a setup UI driver. Should we pomp up a dialog to tell end user that PE image is corrupted? Thank you Yao Jiewen > -Original Message- > From: Gao, Liming > Sent: Tuesday, July 12, 2016 3:55 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Zhang, Chao B > > Subject: [Pa

Re: [edk2] [Patch 4/5] IntelFsp2Pkg BaseFspSwitchStackLib: Remove MASM/GAS files

Reviewed by: jiewen@intel.com > -Original Message- > From: Gao, Liming > Sent: Friday, July 8, 2016 10:49 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Mudusuru, Giri P > > Subject: [Patch 4/5] IntelFsp2Pkg BaseFspSwitchStackLib: Remove > MASM/GAS files > > Keep NASM file only

Re: [edk2] [Patch 1/5] IntelFsp2WrapperPkg BaseFspWrapperApiLib: Remove MASM/GAS files

Reviewed by: jiewen@intel.com > -Original Message- > From: Gao, Liming > Sent: Friday, July 8, 2016 10:49 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Mudusuru, Giri P > > Subject: [Patch 1/5] IntelFsp2WrapperPkg BaseFspWrapperApiLib: Remove > MASM/GAS files > > Keep NASM fil

Re: [edk2] [Patch 3/4] SecurityPkg Tcg2Dxe: Add check for the PE/COFF image

Reviewed by: jiewen@intel.com > -Original Message- > From: Gao, Liming > Sent: Tuesday, July 12, 2016 3:55 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Zhang, Chao B > > Subject: [Patch 3/4] SecurityPkg Tcg2Dxe: Add check for the PE/COFF image > > Use BasePeCoffLib PeCoffLoad

Re: [edk2] [Patch 4/4] SecurityPkg DxeImageVerificationLib: Add comments in HashPeImage()

Reviewed by: jiewen@intel.com > -Original Message- > From: Gao, Liming > Sent: Tuesday, July 12, 2016 3:55 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Zhang, Chao B > > Subject: [Patch 4/4] SecurityPkg DxeImageVerificationLib: Add comments in > HashPeImage() > > The input Pe

Re: [edk2] [Patch 2/4] SecurityPkg TrEEDxe: Add check for the PE/COFF image.

Reviewed by: jiewen@intel.com > -Original Message- > From: Gao, Liming > Sent: Tuesday, July 12, 2016 3:55 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Zhang, Chao B > > Subject: [Patch 2/4] SecurityPkg TrEEDxe: Add check for the PE/COFF image. > > Use BasePeCoffLib PeCoffLoa

Re: [edk2] [Patch] SecurityPkg DxeTpmMeasureBootLib: Add comments in TcgMeasurePeImage()

Reviewed by: jiewen@intel.com > -Original Message- > From: Gao, Liming > Sent: Tuesday, July 12, 2016 10:46 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Zhang, Chao B > > Subject: [Patch] SecurityPkg DxeTpmMeasureBootLib: Add comments in > TcgMeasurePeImage() > > The input Pe

Re: [edk2] [PATCH v2 0/4] PCI resource reservation changes for better hotpluggability

All of the serials, Reviewed-by: Ruiyu Ni I think it's now a PCIE world. The change #2/4 should be fine though it changes the PciBus behavior. #3/4 isn't conflict with the existing platform PciHotPlugInitDxe driver which still reports such PCIE port through GetRootHpcList(). Regards, Ray >-

Re: [edk2] [PATCH v2 2/5] OvmfPkg/PlatformPei: rebase and resize the permanent PEI memory for S3

Reviewed-by: Jeff Fan -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, July 13, 2016 8:18 AM To: edk2-devel-01 Cc: Fan, Jeff; Justen, Jordan L; Kinney, Michael D Subject: [PATCH v2 2/5] OvmfPkg/PlatformPei: rebase and resize the permanent PEI memory for

Re: [edk2] [PATCH v2 3/5] OvmfPkg: remove PcdS3AcpiReservedMemoryBase, PcdS3AcpiReservedMemorySize

Reviewed-by: Jeff Fan -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, July 13, 2016 8:18 AM To: edk2-devel-01 Cc: Fan, Jeff; Justen, Jordan L; Kinney, Michael D Subject: [PATCH v2 3/5] OvmfPkg: remove PcdS3AcpiReservedMemoryBase, PcdS3AcpiReservedMemory

Re: [edk2] [PATCH v2 4/5] OvmfPkg: include UefiCpuPkg/CpuMpPei

Laszlo, Even I have r-b this patch before, I have one comment now. :-) It's better to move PeiCpuExceptionHandlerLib instance from CpuMpPei to [LibraryClasses.common.PEIM] + CpuExceptionHandlerLib|UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuExceptionHandlerLib.inf It's more generic and

[edk2] [Patch] UefiCpuPkg/MtrrLib: Remove MTRRs display from MtrrSetAllMtrrs()

MtrrSetAllMtrrs() maybe used by APs to sync BSP's MTRR settings. BSP's MTRR setting should be displayed if EFI_D_CACHE flag is set when MTRR updated. In MtrrSetAllMtrrs(), it's not necessary to display MTRR setting again due to the MTRR settings should be always same among BSP/APs. This updating co

[edk2] [PATCH v2 3/5] OvmfPkg: remove PcdS3AcpiReservedMemoryBase, PcdS3AcpiReservedMemorySize

No module in OvmfPkg uses these PCDs any longer. The first PCD mentioned is declared by OvmfPkg, so we can remove even the declaration. The second PCD comes from IntelFrameworkModulePkg. The module that consumes PcdS3AcpiReservedMemorySize is called "IntelFrameworkModulePkg/Universal/Acpi/AcpiS3S

[edk2] [PATCH v2 4/5] OvmfPkg: include UefiCpuPkg/CpuMpPei

In the next patch we're going to put EFI_PEI_MP_SERVICES_PPI to use. CpuMpPei uses the following PCDs from gUefiCpuPkgTokenSpaceGuid, beyond those already used by CpuDxe: - PcdCpuMicrocodePatchAddress and PcdCpuMicrocodePatchRegionSize: these control whether CpuMpPei performs microcode update.

[edk2] [PATCH v2 1/5] OvmfPkg/PlatformPei: create one memory HOB at S3 resume too, for CpuMpPei

CpuMpPei will have to place the AP startup vector in memory under 1MB. For this, CpuMpPei borrows memory under 1MB, but it needs a memory resource descriptor HOB to exist there even on the S3 resume path (see the GetWakeupBuffer() function). Produce such a HOB as an exception on the S3 resume path.

[edk2] [PATCH v2 5/5] OvmfPkg/PlatformPei: program MSR_IA32_FEATURE_CONTROL from fw_cfg

Under certain circumstances, QEMU exposes the "etc/msr_feature_control" fw_cfg file, with a 64-bit little endian value. The firmware is supposed to write this value to MSR_IA32_FEATURE_CONTROL (0x3a), on all processors, on the normal and the S3 resume boot paths. Utilize EFI_PEI_MPSERVICES_PPI to

[edk2] [PATCH v2 2/5] OvmfPkg/PlatformPei: rebase and resize the permanent PEI memory for S3

Move the permanent PEI memory for the S3 resume boot path to the top of the low RAM (just below TSEG if the SMM driver stack is included in the build). The new size is derived from CpuMpPei's approximate memory demand. Save the base address and the size in new global variables, regardless of the b

[edk2] [PATCH v2 0/5] OvmfPkg: program MSR_IA32_FEATURE_CONTROL from fw_cfg on all processors

This is v2 of . Changes relative to v1 (see also per patch): - Picked up Jeff's R-b for patch #1. - Patch v1 #2 has been replaced by patches v2 #2 and #3. The S3 permanent PEI memory is no longer specified in the FDF files; it is comp

Re: [edk2] [PATCH v2 0/2] OvmfPkg: remove stale FvFile boot options

On 07/12/16 23:46, Jordan Justen wrote: > Series Reviewed-by: Jordan Justen Thank you. Commit range a78b518b6edd..2eb358986052. Cheers Laszlo > On 2016-07-12 10:04:32, Laszlo Ersek wrote: >> This is version 2 of >> . Changes >> relative

Re: [edk2] [PATCH v2 0/2] OvmfPkg: remove stale FvFile boot options

Series Reviewed-by: Jordan Justen On 2016-07-12 10:04:32, Laszlo Ersek wrote: > This is version 2 of > . Changes > relative to v1: > > - Patch #1 is new. It adds an FvNameGuid statement to each [FV] section > in the OVMF FDF files. Ray

Re: [edk2] [PATCH v2 1/7] BaseTools-GenFw:Use EXE flag to check Elf section type

> On Jul 12, 2016, at 9:55 AM, Ard Biesheuvel wrote: > > On 11 July 2016 at 17:52, Shi, Steven wrote: >> If the cost of the large model is due to its use of 64-bit quantities, how >> is this any better with PIC/PIE binaries? The primary difference is that you >> now have a Global Offset Table (

[edk2] [PATCH v2 0/2] OvmfPkg: remove stale FvFile boot options

This is version 2 of . Changes relative to v1: - Patch #1 is new. It adds an FvNameGuid statement to each [FV] section in the OVMF FDF files. Ray advised us that FvNameGuid is the modern approach and that it improves stability of device

[edk2] [PATCH v2 2/2] OvmfPkg/PlatformBootManagerLib: remove stale FvFile boot options

Removes any boot options that point to binaries built into the firmware and have become stale due to any of the following: - DXEFV's base address or size changed (historical), - DXEFV's FvNameGuid changed, - the FILE_GUID of the pointed-to binary changed, - the referenced binary is no longer built

[edk2] [PATCH v2 1/2] OvmfPkg: add a Name GUID to each Firmware Volume

The FDF spec mentions the FvNameGuid statement for [FV.] sections, but the detailed description can be found in Volume 3 of the Platform Init spec (which is at 1.4a currently). Adding an FvNameGuid statement to [FV.xxx] has the following effects (implemented by "BaseTools/Source/C/GenFv/GenFvI

Re: [edk2] [PATCH v2 1/7] BaseTools-GenFw:Use EXE flag to check Elf section type

On 11 July 2016 at 17:52, Shi, Steven wrote: > If the cost of the large model is due to its use of 64-bit quantities, how > is this any better with PIC/PIE binaries? The primary difference is that you > now have a Global Offset Table (GOT) entry for all symbol references, which > also contains 64-

Re: [edk2] Criteria for header inclusion order

I think that meaningful include file organization is important, as that is commonly one of the first things one looks at to understand a component. Start with INF, then .h, then entrypoint and so on. As the included files are such a big part of understanding a component and its relationship to

Re: [edk2] [PATCH 4/6] ShellPkg: don't call functions with side effects in ASSERT_EFI_ERROR()

That sounds like the best way to proceed. I do not think there will be other issues. We will have to update both the library and the package GUID/Version since this is non backwards compatible. -Jaben > -Original Message- > From: Ni, Ruiyu > Sent: Tuesday, July 12, 2016 12:13 AM > To:

Re: [edk2] [Patch] SecurityPkg DxeTpmMeasureBootLib: Add comments in TcgMeasurePeImage()

Reviewed-by: Chao Zhang Thanks & Best regards Chao Zhang -Original Message- From: Gao, Liming Sent: Tuesday, July 12, 2016 10:46 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen; Zhang, Chao B Subject: [Patch] SecurityPkg DxeTpmMeasureBootLib: Add comments in TcgMeasurePeImage() Th

[edk2] [Patch] SecurityPkg DxeTpmMeasureBootLib: Add comments in TcgMeasurePeImage()

The input PeImage in TcgMeasurePeImage() has been checked. Cc: Jiewen Yao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(

Re: [edk2] [URGENT PATCH] BaseTools/GenFds: unbreak Region.PadBuffer

On 07/12/16 16:12, Ard Biesheuvel wrote: > On 12 July 2016 at 16:11, Laszlo Ersek wrote: >> In its current form, Region.PadBuffer() fills every second byte with 0x20, >> the default separator string of Python's string.join(): >> >> https://docs.python.org/2/library/string.html#string.join >> >> Th

Re: [edk2] [PATCH 2/2] BaseTools/GenFds: speed up Region.PadBuffer()

Got it. Thanks for your quick fix. From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Tuesday, July 12, 2016 10:18 PM To: Gao, Liming ; Ard Biesheuvel Cc: edk2-devel-01 Subject: Re: [edk2] [PATCH 2/2] BaseTools/GenFds: speed up Region.PadBuffer() On 07/1

Re: [edk2] [PATCH 2/2] BaseTools/GenFds: speed up Region.PadBuffer()

On 07/12/16 16:06, Gao, Liming wrote: > Will you verify the generated file is the expected one? Yes, I compared SHA1 checksums for QEMU_EFI.fd (the build output of ArmVirtQemu.dsc). The first checksum is from the state of BaseTools at git commit 5588565f4845^ -- note the caret (^) at the end --, t

Re: [edk2] [Patch 4/4] SecurityPkg DxeImageVerificationLib: Add comments in HashPeImage()

Liming: Please also cover TpmDxeMeasureLib.TcgMeasurePeImage(). Others are good to me. Thanks & Best regards Chao Zhang -Original Message- From: Gao, Liming Sent: Tuesday, July 12, 2016 3:55 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen; Zhang, Chao B Subject: [Patch 4/4] Secu

Re: [edk2] [URGENT PATCH] BaseTools/GenFds: unbreak Region.PadBuffer

On 12 July 2016 at 16:11, Laszlo Ersek wrote: > In its current form, Region.PadBuffer() fills every second byte with 0x20, > the default separator string of Python's string.join(): > > https://docs.python.org/2/library/string.html#string.join > > This corrupts some firmware because (a) 0x20 never

[edk2] [URGENT PATCH] BaseTools/GenFds: unbreak Region.PadBuffer

In its current form, Region.PadBuffer() fills every second byte with 0x20, the default separator string of Python's string.join(): https://docs.python.org/2/library/string.html#string.join This corrupts some firmware because (a) 0x20 never corresponds to any ErasePolarity, (b) the PadData produce

Re: [edk2] [PATCH 2/2] BaseTools/GenFds: speed up Region.PadBuffer()

Will you verify the generated file is the expected one? Thanks Liming From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, July 12, 2016 10:04 PM To: Ard Biesheuvel Cc: Gao, Liming ; edk2-devel-01 Subject: Re: [edk2] [PATCH 2/2] BaseTools/GenFds: speed up Region.PadBuffer() On 07/12/16

Re: [edk2] [PATCH 2/2] BaseTools/GenFds: speed up Region.PadBuffer()

On 07/12/16 15:53, Ard Biesheuvel wrote: > On 12 July 2016 at 15:50, Ard Biesheuvel wrote: >> On 12 July 2016 at 15:48, Laszlo Ersek wrote: > [...] >>> In commit bd907fb6386560e621112beca7b7d381d0003967, I used the >>> string.join() method, but I forgot to set the separator to the empty string. >

Re: [edk2] [PATCH v2 0/5] ArmVirtPkg: fdf cleanup

On 12 July 2016 at 13:18, Ard Biesheuvel wrote: > This may be a bit premature, with Laszlo's stale boot entry removal patch > still under review, but since it addresses an issue that I had noticed > myself already, and since Ray has provided a useful suggestion to prevent > this from occurring in

Re: [edk2] [PATCH 2/2] BaseTools/GenFds: speed up Region.PadBuffer()

On 12 July 2016 at 15:50, Ard Biesheuvel wrote: > On 12 July 2016 at 15:48, Laszlo Ersek wrote: [...] >> In commit bd907fb6386560e621112beca7b7d381d0003967, I used the >> string.join() method, but I forgot to set the separator to the empty string. >> >> https://docs.python.org/2/library/string.ht

Re: [edk2] [PATCH 2/2] BaseTools/GenFds: speed up Region.PadBuffer()

On 12 July 2016 at 15:48, Laszlo Ersek wrote: > On 07/12/16 15:34, Laszlo Ersek wrote: >> On 07/12/16 15:28, Ard Biesheuvel wrote: >>> On 12 July 2016 at 13:21, Laszlo Ersek wrote: On 07/12/16 10:39, Laszlo Ersek wrote: > On 07/12/16 07:18, Gao, Liming wrote: >> Laszlo: >> This

Re: [edk2] [PATCH 2/2] BaseTools/GenFds: speed up Region.PadBuffer()

On 07/12/16 15:34, Laszlo Ersek wrote: > On 07/12/16 15:28, Ard Biesheuvel wrote: >> On 12 July 2016 at 13:21, Laszlo Ersek wrote: >>> On 07/12/16 10:39, Laszlo Ersek wrote: On 07/12/16 07:18, Gao, Liming wrote: > Laszlo: > This patch serial is good. It will improve GenFds performan

Re: [edk2] [PATCH 2/2] BaseTools/GenFds: speed up Region.PadBuffer()

On 07/12/16 15:28, Ard Biesheuvel wrote: > On 12 July 2016 at 13:21, Laszlo Ersek wrote: >> On 07/12/16 10:39, Laszlo Ersek wrote: >>> On 07/12/16 07:18, Gao, Liming wrote: Laszlo: This patch serial is good. It will improve GenFds performance if there are more padding in FD regio

Re: [edk2] [PATCH] ArmVirtPkg/HighMemDxe: allow patchable PCD for PcdSystemMemoryBase

On 07/12/16 15:25, Laszlo Ersek wrote: > On 07/12/16 15:18, Ard Biesheuvel wrote: >> On 12 July 2016 at 15:07, Laszlo Ersek wrote: >>> On 07/12/16 15:00, Ard Biesheuvel wrote: Redefine the reference to PcdSystemMemoryBase in HighMemDxe.inf as a plain [Pcd] rather than [FixedPcd] (and fix

Re: [edk2] [PATCH 2/2] BaseTools/GenFds: speed up Region.PadBuffer()

On 12 July 2016 at 13:21, Laszlo Ersek wrote: > On 07/12/16 10:39, Laszlo Ersek wrote: >> On 07/12/16 07:18, Gao, Liming wrote: >>> Laszlo: >>> This patch serial is good. It will improve GenFds performance if there >>> are more padding in FD region. >>> >>> Reviewed-by: Liming Gao >> >> Than

Re: [edk2] [PATCH] ArmVirtPkg/HighMemDxe: allow patchable PCD for PcdSystemMemoryBase

On 07/12/16 15:18, Ard Biesheuvel wrote: > On 12 July 2016 at 15:07, Laszlo Ersek wrote: >> On 07/12/16 15:00, Ard Biesheuvel wrote: >>> Redefine the reference to PcdSystemMemoryBase in HighMemDxe.inf as >>> a plain [Pcd] rather than [FixedPcd] (and fix up the code as >>> appropriate). This allows

Re: [edk2] [PATCH] ArmVirtPkg/HighMemDxe: allow patchable PCD for PcdSystemMemoryBase

On 12 July 2016 at 15:07, Laszlo Ersek wrote: > On 07/12/16 15:00, Ard Biesheuvel wrote: >> Redefine the reference to PcdSystemMemoryBase in HighMemDxe.inf as >> a plain [Pcd] rather than [FixedPcd] (and fix up the code as >> appropriate). This allows us to align ArmVirtQemuKernel with >> ArmVirtQ

Re: [edk2] [PATCH] ArmVirtPkg/HighMemDxe: allow patchable PCD for PcdSystemMemoryBase

On 07/12/16 15:00, Ard Biesheuvel wrote: > Redefine the reference to PcdSystemMemoryBase in HighMemDxe.inf as > a plain [Pcd] rather than [FixedPcd] (and fix up the code as > appropriate). This allows us to align ArmVirtQemuKernel with > ArmVirtQemu, given that the former uses a patchable PCD not a

[edk2] [PATCH] ArmVirtPkg/HighMemDxe: allow patchable PCD for PcdSystemMemoryBase

Redefine the reference to PcdSystemMemoryBase in HighMemDxe.inf as a plain [Pcd] rather than [FixedPcd] (and fix up the code as appropriate). This allows us to align ArmVirtQemuKernel with ArmVirtQemu, given that the former uses a patchable PCD not a fixed PCD. Contributed-under: TianoCore Contrib

Re: [edk2] [Patch] UefiCpuPkg/CpuDxe: StartupAllAPs in parallel mode

On 07/12/16 13:58, Fan, Jeff wrote: > Laszlo, > > I think of it. We could just remove the MtrrDebugPrintAllMtrrs() call from > MtrrSetAllMtrrs() implementation in MtrrLib. > > The reason is that Aps' MTRR settings should be always same with the BPS's. > BSP will set the MTRRs setting by MtrrSet

Re: [edk2] [Patch] UefiCpuPkg/CpuDxe: StartupAllAPs in parallel mode

Laszlo, I think of it. We could just remove the MtrrDebugPrintAllMtrrs() call from MtrrSetAllMtrrs() implementation in MtrrLib. The reason is that Aps' MTRR settings should be always same with the BPS's. BSP will set the MTRRs setting by MtrrSetMemoryAttribute() or other APIs. And Aps will alw

[edk2] [Patch v3 1/7] UefiCpuPkg/CpuMpPei: Add CodeSegment and DataSegment fields

Added CodeSegment and DataSegment fields in MP_CPU_EXCHANGE_INFO. They are set to the values of current BSP's CS and DS. Cc: Feng Tian Cc: Michael Kinney Cc: Giri Mudusuru Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan --- UefiCpuPkg/CpuMpPei/CpuMpPei.c |

[edk2] [Patch v3 0/7] Do not overwrite existing GDT table

CpuMpPei driver will load its own GDT table. It will overwrite the existing BSP GDT table setup before by other module (for example, by SEC). This serial of patches are try to use the existing GDT table for AP mode switch. v3: In Patch 4/7: Use 0x66 prefix for some more operation. In Patch 7/7

[edk2] [Patch v3 5/7] UefiCpuPkg/CpuMpPei: Do not load new GDT table

Do not load the new GDT table and just to use the exiting BSP's GDT table set up by SEC phase. Cc: Feng Tian Cc: Michael Kinney Cc: Giri Mudusuru Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan --- UefiCpuPkg/CpuMpPei/CpuMpPei.c | 6 +- 1 file changed, 1 in

[edk2] [Patch v3 4/7] UefiCpuPkg/CpuMpPei/X64: Use CodeSegment and DataSegment fields

Using CodeSegment and DataSegment fields in ExchangeInfo instead of the hardcode MACROs for x64 arch. Switch AP from real mode to long mode directly, so needn't the CS/DS of protected mode. Cc: Feng Tian Cc: Michael Kinney Cc: Giri Mudusuru Contributed-under: TianoCore Contribution Agreement 1.

[edk2] [Patch v3 6/7] UefiCpuPkg/CpuMpPei: Remove un-used variables and functions

Cc: Feng Tian Cc: Michael Kinney Cc: Giri Mudusuru Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan --- UefiCpuPkg/CpuMpPei/CpuMpPei.c| 24 UefiCpuPkg/CpuMpPei/CpuMpPei.h| 19 --- UefiCpuPkg/CpuMpPei/Ia32/M

[edk2] [Patch v3 7/7] UefiCpuPkg/CpuMpPei: Remove PmodeOffset and LmodeOffset

Remove Pmode(Entry)Offset/Lmode(Entry)Offset and use unified Mode(Entry)Offset to clean up the definition of MP_ASSEMBLY_ADDRESS_MAP and MP_CPU_EXCHANGE_INFO. Cc: Feng Tian Cc: Michael Kinney Cc: Giri Mudusuru Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan ---

[edk2] [Patch v3 3/7] UefiCpuPkg/CpuMpPei/X64: Remove hard code CPU BIST value

Cc: Feng Tian Cc: Michael Kinney Cc: Giri Mudusuru Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan --- UefiCpuPkg/CpuMpPei/X64/MpFuncs.nasm | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/UefiCpuPkg/CpuMpPei/X64/MpFuncs.nasm b/UefiCpu

[edk2] [Patch v3 2/7] UefiCpuPkg/CpuMpPei/Ia32: Use CodeSegment and DataSegment fields

Using CodeSegment and DataSegment fields in ExchangeInfo instead of the hardcode MACROs. Cc: Feng Tian Cc: Michael Kinney Cc: Giri Mudusuru Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan --- UefiCpuPkg/CpuMpPei/Ia32/MpFuncs.asm | 38 +-

Re: [edk2] [PATCH v2 2/5] ArmVirtPkg: align ArmVirtQemuKernel with ArmVirtQemu

On 07/12/16 13:18, Ard Biesheuvel wrote: > The platform ArmVirtQemuKernel is intended as an alternative for > ArmVirtQemu that only deviates in the way it is invoked by QEMU, either > from flash address 0x0 (the default ARM reset vector) or via the Linux > kernel boot protocol. So add VirtioRngDxe

Re: [edk2] [PATCH v2 1/5] ArmVirtPkg: ArmVirtQemuKernel: make ACPI support AARCH64 only

On 07/12/16 13:18, Ard Biesheuvel wrote: > The reasoning of patch 8e2efec6b206: > > No ARM support for ACPI is planned under any OS we intend to run under > ArmVirtQemu-ARM, so remove the drivers from the ARM build. > > applies equally to ArmVirtQemuKernel, so apply the same change there. >

Re: [edk2] [PATCH 2/2] BaseTools/GenFds: speed up Region.PadBuffer()

On 07/12/16 10:39, Laszlo Ersek wrote: > On 07/12/16 07:18, Gao, Liming wrote: >> Laszlo: >> This patch serial is good. It will improve GenFds performance if there are >> more padding in FD region. >> >> Reviewed-by: Liming Gao > > Thanks! > > Your R-b applies to patch #1 in the series as

[edk2] [PATCH v2 4/5] ArmVirtPkg: factor out Rules FDF section

All three current ArmVirtPkg have identical [Rules] sections in their FDF definitions, and ideally, they should remain that way. So factor out the definitions into a separate include file, and replace the existing definitions with !include directives. Contributed-under: TianoCore Contribution Agre

[edk2] [PATCH v2 3/5] ArmVirtPkg/ArmVirtQemu: factor out shared FV.FvMain definition

The FDF definition of [FV.FvMain] is identical between ArmVirtQemu and ArmVirtQemuKernel, and needs to remain that way. So factor it out into a separate include file, and replace both definitions with an !include directive. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard

[edk2] [PATCH v2 1/5] ArmVirtPkg: ArmVirtQemuKernel: make ACPI support AARCH64 only

The reasoning of patch 8e2efec6b206: No ARM support for ACPI is planned under any OS we intend to run under ArmVirtQemu-ARM, so remove the drivers from the ARM build. applies equally to ArmVirtQemuKernel, so apply the same change there. Contributed-under: TianoCore Contribution Agreement 1.0

[edk2] [PATCH v2 5/5] ArmVirtPkg: add name GUIDs to FvMain instances

Assign name GUIDs to the FVs that may appear in DevicePath references to things like the UiApp and the UEFI Shell. This prevents these device paths from changing inadvertently when the FV ends up in a different memory location due to external occurrences such as, e.g., a change in the amount of sys

[edk2] [PATCH v2 0/5] ArmVirtPkg: fdf cleanup

This may be a bit premature, with Laszlo's stale boot entry removal patch still under review, but since it addresses an issue that I had noticed myself already, and since Ray has provided a useful suggestion to prevent this from occurring in the future, it makes sense to simply add the FvNameGuids

[edk2] [PATCH v2 2/5] ArmVirtPkg: align ArmVirtQemuKernel with ArmVirtQemu

The platform ArmVirtQemuKernel is intended as an alternative for ArmVirtQemu that only deviates in the way it is invoked by QEMU, either from flash address 0x0 (the default ARM reset vector) or via the Linux kernel boot protocol. So add VirtioRngDxe and HighMemDxe here as well. Contributed-under:

Re: [edk2] [PATCH 4/4] ArmVirtPkg: add name GUIDs to FvMain instances

On 07/12/16 12:09, Ard Biesheuvel wrote: > On 12 July 2016 at 11:53, Laszlo Ersek wrote: >> On 07/12/16 11:16, Ard Biesheuvel wrote: >>> Assign name GUIDs to the FVs that may appear in DevicePath references to >>> things like the UiApp and the UEFI Shell. This prevents these device >>> paths from

Re: [edk2] [PATCH 4/4] ArmVirtPkg: add name GUIDs to FvMain instances

On 12 July 2016 at 11:53, Laszlo Ersek wrote: > On 07/12/16 11:16, Ard Biesheuvel wrote: >> Assign name GUIDs to the FVs that may appear in DevicePath references to >> things like the UiApp and the UEFI Shell. This prevents these device >> paths from changing inadvertently when the FV ends up in a

Re: [edk2] [PATCH] Vlv2TbltDevicePkg: Enabled spread spectrum control

Reviewed-by: David Wei Thanks, David Wei Intel SSG BIOS Team -Original Message- From: Guo, Mang Sent: Tuesday, July 12, 2016 3:01 PM To: edk2-devel@lists.01.org Cc: Wei, David Subject: [PATCH] Vlv2TbltDevicePkg: Enabled spread spectrum control and

Re: [edk2] [Patch] Vlv2TbltDevicePkg:Update BIOS ID to V0.93.

Reviewed-by: David Wei Thanks, David Wei Intel SSG BIOS Team -Original Message- From: Lu, ShifeiX A Sent: Tuesday, July 12, 2016 6:00 PM To: edk2-devel@lists.01.org Cc: Wei; Wei, David Subject: [Patch] Vlv2TbltDevicePkg:Update BIOS ID to V0.93. Co

[edk2] [Patch] Vlv2TbltDevicePkg:Update BIOS ID to V0.93.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: lushifex --- Vlv2TbltDevicePkg/BiosIdD.env| 4 ++-- Vlv2TbltDevicePkg/BiosIdR.env| 4 ++-- Vlv2TbltDevicePkg/BiosIdx64D.env | 4 ++-- Vlv2TbltDevicePkg/BiosIdx64R.env | 4 ++-- 4 files changed, 8 insertions(+), 8 delet

Re: [edk2] [PATCH 4/4] ArmVirtPkg: add name GUIDs to FvMain instances

On 07/12/16 11:16, Ard Biesheuvel wrote: > Assign name GUIDs to the FVs that may appear in DevicePath references to > things like the UiApp and the UEFI Shell. This prevents these device > paths from changing inadvertently when the FV ends up in a different > memory location due to external occurre

Re: [edk2] [PATCH 3/4] ArmVirtPkg: factor out Rules FDF section

On 07/12/16 11:16, Ard Biesheuvel wrote: > All three current ArmVirtPkg have identical [Rules] sections in their > FDF definitions, and ideally, they should remain that way. So factor > out the definitions into a separate include file, and replace the > existing definitions with !include directives

Re: [edk2] [PATCH 2/4] ArmVirtPkg/ArmVirtQemu: factor out shared FV.FvMain definition

On 07/12/16 11:16, Ard Biesheuvel wrote: > The FDF definition of [FV.FvMain] is identical between ArmVirtQemu and > ArmVirtQemuKernel, and needs to remain that way. So factor it out into > a separate include file, and replace both definitions with an !include > directive. > > Contributed-under: Ti

Re: [edk2] [PATCH 1/4] ArmVirtPkg: align ArmVirtQemuKernel.fdf with ArmVirtQemu.fdf

On 12 July 2016 at 11:33, Laszlo Ersek wrote: > On 07/12/16 11:16, Ard Biesheuvel wrote: >> The platform ArmVirtQemuKernel is intended as an alternative for >> ArmVirtQemu that only deviates in the way it is invoked by QEMU, either >> from flash address 0x0 (the default ARM reset vector) or via th

Re: [edk2] [PATCH 1/4] ArmVirtPkg: align ArmVirtQemuKernel.fdf with ArmVirtQemu.fdf

On 07/12/16 11:16, Ard Biesheuvel wrote: > The platform ArmVirtQemuKernel is intended as an alternative for > ArmVirtQemu that only deviates in the way it is invoked by QEMU, either > from flash address 0x0 (the default ARM reset vector) or via the Linux > kernel boot protocol. So clean up a couple

[edk2] [PATCH 0/4] ArmVirtPkg: fdf cleanup

This may be a bit premature, with Laszlo's stale boot entry removal patch still under review, but since it addresses an issue that I had noticed myself already, and since Ray has provided a useful suggestion to prevent this from occurring in the future, it makes sense to simply add the FvNameGuids

[edk2] [PATCH 2/4] ArmVirtPkg/ArmVirtQemu: factor out shared FV.FvMain definition

The FDF definition of [FV.FvMain] is identical between ArmVirtQemu and ArmVirtQemuKernel, and needs to remain that way. So factor it out into a separate include file, and replace both definitions with an !include directive. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard

  1   2   >