[edk2] [staging/HTTPS-TLS][PATCH 1/4] MdePkg: Add a header to standardize TLS definitions

2016-07-13 Thread Jiaxin Wu
This path is used to standardize TLS definitions from related RFCs. Including TLS Cipher Suites, TLS Version, TLS Content Type and TLS Record Header, etc. Cc: Liming Gao Cc: Palmer Thomas Cc: Long Qin Cc: Ye Ting

[edk2] [staging/HTTPS-TLS][PATCH 4/4] NetworkPkg/HttpDxe: Replace the definitions with the standardized one

2016-07-13 Thread Jiaxin Wu
Cc: Palmer Thomas Cc: Long Qin Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin Signed-off-by: Jiaxin Wu ---

[edk2] [staging/HTTPS-TLS][PATCH 3/4] NetworkPkg/TlsDxe: Replace the definitions with the standardized one

2016-07-13 Thread Jiaxin Wu
Cc: Palmer Thomas Cc: Long Qin Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin Signed-off-by: Jiaxin Wu ---

[edk2] [staging/HTTPS-TLS][PATCH 2/4] CryptoPkg: Add more TLS cipher suite mapping

2016-07-13 Thread Jiaxin Wu
This patch is used to add more TLS cipher suite mapping between Cipher Suite definitions and OpenSSL-used Cipher Suite name. Cc: Palmer Thomas Cc: Long Qin Cc: Ye Ting Contributed-under: TianoCore Contribution Agreement 1.0

[edk2] [staging/HTTPS-TLS][PATCH 0/4] Replace the TLS definitions with the standardized one

2016-07-13 Thread Jiaxin Wu
The series patches are used to replace the TLS definitions with the standardized one. In addition, more TLS cipher suite mapping between Cipher Suite definitions and OpenSSL-used Cipher Suite name are added. Cc: Liming Gao Cc: Palmer Thomas Cc: Long

Re: [edk2] [Patch] IntelFsp2WrapperPkg: Remove unused header files from Fspm and Fsps WrapperPeim

2016-07-13 Thread Mudusuru, Giri P
Reviewed-by: Giri P Mudusuru > -Original Message- > From: Gao, Liming > Sent: Wednesday, July 13, 2016 7:16 PM > To: edk2-devel@lists.01.org > Cc: Mudusuru, Giri P ; Yao, Jiewen > > Subject: [Patch]

[edk2] [Patch] IntelFsp2WrapperPkg: Remove unused header files from Fspm and Fsps WrapperPeim

2016-07-13 Thread Liming Gao
PlatformSecLib.h is not used and removed. Cc: Giri P Mudusuru Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.c | 1 -

Re: [edk2] [Patch v3 4/7] UefiCpuPkg/CpuMpPei/X64: Use CodeSegment and DataSegment fields

2016-07-13 Thread Fan, Jeff
Fixed typo: *add* whitespace. :-) -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fan, Jeff Sent: Thursday, July 14, 2016 9:15 AM To: Mudusuru, Giri P; edk2-de...@ml01.01.org Cc: Kinney, Michael D; Tian, Feng Subject: Re: [edk2] [Patch v3 4/7]

Re: [edk2] [Patch v3 2/7] UefiCpuPkg/CpuMpPei/Ia32: Use CodeSegment and DataSegment fields

2016-07-13 Thread Fan, Jeff
Thanks! I will add one whitespace before eax in comments when commit. -Original Message- From: Mudusuru, Giri P Sent: Wednesday, July 13, 2016 11:21 PM To: Fan, Jeff; edk2-de...@ml01.01.org Cc: Tian, Feng; Kinney, Michael D Subject: RE: [Patch v3 2/7] UefiCpuPkg/CpuMpPei/Ia32: Use

Re: [edk2] [Patch v3 4/7] UefiCpuPkg/CpuMpPei/X64: Use CodeSegment and DataSegment fields

2016-07-13 Thread Fan, Jeff
Thanks! I will remove white space after "," in comments when commit. -Original Message- From: Mudusuru, Giri P Sent: Wednesday, July 13, 2016 11:42 PM To: Fan, Jeff; edk2-de...@ml01.01.org Cc: Tian, Feng; Kinney, Michael D Subject: RE: [Patch v3 4/7] UefiCpuPkg/CpuMpPei/X64: Use

Re: [edk2] [PATCH v3 0/5] OvmfPkg: program MSR_IA32_FEATURE_CONTROL from fw_cfg on all processors

2016-07-13 Thread Fan, Jeff
Reviewed-by: Jeff Fan -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, July 13, 2016 10:37 PM To: edk2-devel-01 Cc: Fan, Jeff; Justen, Jordan L; Kinney, Michael D Subject: [PATCH v3 0/5] OvmfPkg: program MSR_IA32_FEATURE_CONTROL from

Re: [edk2] [PATCH v3 4/5] OvmfPkg: include UefiCpuPkg/CpuMpPei

2016-07-13 Thread Fan, Jeff
Reviewed-by: Jeff Fan -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, July 13, 2016 10:37 PM To: edk2-devel-01 Cc: Fan, Jeff; Justen, Jordan L; Kinney, Michael D Subject: [PATCH v3 4/5] OvmfPkg: include UefiCpuPkg/CpuMpPei In the

Re: [edk2] [Patch] UefiCpuPkg/MtrrLib: Remove MTRRs display from MtrrSetAllMtrrs()

2016-07-13 Thread Fan, Jeff
Brian, Good point on BSP bit in MSR_IA32_APIC_BASE register. But some processor(for example, Quark) does not support this MSR. // // CPUs with a FamilyId of 0x04 or 0x05 do not support the // Local APIC Base Address MSR // I think the generic solution is still to remove MTRRs

Re: [edk2] [Patch] BaseTools: Update the FV region name as upper letter

2016-07-13 Thread Andrew Fish
> On Jul 13, 2016, at 5:42 PM, Gao, Liming wrote: > > Reviewed-by: Liming Gao > Reviewed-by: Andrew Fish >> -Original Message- >> From: Zhu, Yonghong >> Sent: Monday, July 11, 2016 4:10 PM >> To: edk2-devel@lists.01.org

Re: [edk2] [Patch] BaseTools: Update the FV region name as upper letter

2016-07-13 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Zhu, Yonghong > Sent: Monday, July 11, 2016 4:10 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [Patch] BaseTools: Update the FV region name as upper letter > > Since in the

Re: [edk2] [PATCH] ArmVirtPkg/PlatformBootManagerLib: remove stale FvFile boot options

2016-07-13 Thread Laszlo Ersek
On 07/13/16 22:31, Ard Biesheuvel wrote: > On 13 July 2016 at 22:17, Laszlo Ersek wrote: >> On 07/13/16 22:03, Ard Biesheuvel wrote: >>> On 13 July 2016 at 18:44, Laszlo Ersek wrote: +DEBUG_CODE ( + CHAR16 *DevicePathString; + +

Re: [edk2] [PATCH] ArmVirtPkg/PlatformBootManagerLib: remove stale FvFile boot options

2016-07-13 Thread Ard Biesheuvel
On 13 July 2016 at 22:17, Laszlo Ersek wrote: > On 07/13/16 22:03, Ard Biesheuvel wrote: >> On 13 July 2016 at 18:44, Laszlo Ersek wrote: >>> (This patch ports OvmfPkg commit 2eb358986052 to ArmVirtPkg. That >>> functionality was not added to

Re: [edk2] [PATCH] ArmVirtPkg/PlatformBootManagerLib: remove stale FvFile boot options

2016-07-13 Thread Laszlo Ersek
On 07/13/16 22:03, Ard Biesheuvel wrote: > On 13 July 2016 at 18:44, Laszlo Ersek wrote: >> (This patch ports OvmfPkg commit 2eb358986052 to ArmVirtPkg. That >> functionality was not added to QemuBootOrderLib, because it was (and is) >> independent from QEMU and fw_cfg.) >> >>

Re: [edk2] [PATCH] ArmVirtPkg/PlatformBootManagerLib: remove stale FvFile boot options

2016-07-13 Thread Ard Biesheuvel
On 13 July 2016 at 18:44, Laszlo Ersek wrote: > (This patch ports OvmfPkg commit 2eb358986052 to ArmVirtPkg. That > functionality was not added to QemuBootOrderLib, because it was (and is) > independent from QEMU and fw_cfg.) > > Remove any boot options that point to binaries

Re: [edk2] [Patch] UefiCpuPkg/MtrrLib: Remove MTRRs display from MtrrSetAllMtrrs()

2016-07-13 Thread Brian J. Johnson
On 07/13/2016 11:19 AM, Laszlo Ersek wrote: On 07/13/16 17:46, Kinney, Michael D wrote: Laszlo, I agree that the DEBUG() messages for this are very valuable to debug MTRR cache settings. Another option is to add logic to detect if the calling CPU is the BSP or not and only invoke DEBUG()

[edk2] [PATCH] ArmVirtPkg/PlatformBootManagerLib: remove stale FvFile boot options

2016-07-13 Thread Laszlo Ersek
(This patch ports OvmfPkg commit 2eb358986052 to ArmVirtPkg. That functionality was not added to QemuBootOrderLib, because it was (and is) independent from QEMU and fw_cfg.) Remove any boot options that point to binaries built into the firmware and have become stale due to any of the following: -

Re: [edk2] [Patch] UefiCpuPkg/MtrrLib: Remove MTRRs display from MtrrSetAllMtrrs()

2016-07-13 Thread Laszlo Ersek
On 07/13/16 18:13, Kinney, Michael D wrote: > Hi Laszlo, > > I missed this other part of this thread. I agree with the direction here. > > Reviewed-by: Michael Kinney > > If anyone notices a loss of messages from BSP when DEBUG_CACHE is enabled, > then the correct

Re: [edk2] [Patch] UefiCpuPkg/MtrrLib: Remove MTRRs display from MtrrSetAllMtrrs()

2016-07-13 Thread Laszlo Ersek
On 07/13/16 17:46, Kinney, Michael D wrote: > Laszlo, > > I agree that the DEBUG() messages for this are very valuable to debug > MTRR cache settings. > > Another option is to add logic to detect if the calling CPU is the BSP or > not and only invoke DEBUG() macros if the caller is the BSP.

Re: [edk2] [Patch] UefiCpuPkg/MtrrLib: Remove MTRRs display from MtrrSetAllMtrrs()

2016-07-13 Thread Kinney, Michael D
Hi Laszlo, I missed this other part of this thread. I agree with the direction here. Reviewed-by: Michael Kinney If anyone notices a loss of messages from BSP when DEBUG_CACHE is enabled, then the correct fix is to add an explicit call to MtrrDebugPrintAllMtrrs().

Re: [edk2] [PATCH v2 3/7] MdePkg: Enable new MS VA intrinsics for GNUC x86 64bits build

2016-07-13 Thread Ard Biesheuvel
On 13 July 2016 at 16:35, Ard Biesheuvel wrote: > On 8 July 2016 at 10:42, Shi, Steven wrote: >> Both GCC and LLVM 3.8 64bits support new variable argument (VA) >> intrinsics for Microsoft ABI, enable these new VA intrinsics for >> GNUC family

Re: [edk2] [Patch] UefiCpuPkg/MtrrLib: Remove MTRRs display from MtrrSetAllMtrrs()

2016-07-13 Thread Kinney, Michael D
Laszlo, I agree that the DEBUG() messages for this are very valuable to debug MTRR cache settings. Another option is to add logic to detect if the calling CPU is the BSP or not and only invoke DEBUG() macros if the caller is the BSP. That would not require any changes to the MtrrLib APIs or

Re: [edk2] [PATCH v2 1/7] BaseTools-GenFw:Use EXE flag to check Elf section type

2016-07-13 Thread Andrew Fish
> On Jul 13, 2016, at 8:05 AM, Ard Biesheuvel wrote: > > On 12 July 2016 at 19:33, Andrew Fish wrote: >> >>> On Jul 12, 2016, at 9:55 AM, Ard Biesheuvel >>> wrote: > [...] >>> OK, so in summary, the AMD64 small model not

Re: [edk2] [Patch v3 7/7] UefiCpuPkg/CpuMpPei: Remove PmodeOffset and LmodeOffset

2016-07-13 Thread Mudusuru, Giri P
Reviewed-by: Giri P Mudusuru > -Original Message- > From: Fan, Jeff > Sent: Tuesday, July 12, 2016 4:45 AM > To: edk2-de...@ml01.01.org > Cc: Tian, Feng ; Kinney, Michael D > ; Mudusuru, Giri P >

Re: [edk2] [Patch v3 6/7] UefiCpuPkg/CpuMpPei: Remove un-used variables and functions

2016-07-13 Thread Mudusuru, Giri P
Reviewed-by: Giri P Mudusuru > -Original Message- > From: Fan, Jeff > Sent: Tuesday, July 12, 2016 4:45 AM > To: edk2-de...@ml01.01.org > Cc: Tian, Feng ; Kinney, Michael D > ; Mudusuru, Giri P >

Re: [edk2] [Patch v3 5/7] UefiCpuPkg/CpuMpPei: Do not load new GDT table

2016-07-13 Thread Mudusuru, Giri P
Reviewed-by: Giri P Mudusuru > -Original Message- > From: Fan, Jeff > Sent: Tuesday, July 12, 2016 4:44 AM > To: edk2-de...@ml01.01.org > Cc: Tian, Feng ; Kinney, Michael D > ; Mudusuru, Giri P >

Re: [edk2] [Patch v3 4/7] UefiCpuPkg/CpuMpPei/X64: Use CodeSegment and DataSegment fields

2016-07-13 Thread Mudusuru, Giri P
Reviewed-by: Giri P Mudusuru Please review and add white space after "," in comments during submission > -Original Message- > From: Fan, Jeff > Sent: Tuesday, July 12, 2016 4:44 AM > To: edk2-de...@ml01.01.org > Cc: Tian, Feng ; Kinney,

Re: [edk2] [Patch 0/5] UefiCpuPkg/PiSmmCpuDxeSmm: S3 resume clean ups

2016-07-13 Thread Laszlo Ersek
On 07/13/16 08:26, Michael Kinney wrote: > This patch series fixes a number of small issues in the S3 resume path. > > * Remove duplicate aligned buffer allocation on S3 resume path > * Add support for MemoryMapped REGISTER_TYPE in SetProcessorRegister() > * Move XD/BTS feature detection to

Re: [edk2] [Patch v3 3/7] UefiCpuPkg/CpuMpPei/X64: Remove hard code CPU BIST value

2016-07-13 Thread Mudusuru, Giri P
Reviewed-by: Giri P Mudusuru > -Original Message- > From: Fan, Jeff > Sent: Tuesday, July 12, 2016 4:44 AM > To: edk2-de...@ml01.01.org > Cc: Tian, Feng ; Kinney, Michael D > ; Mudusuru, Giri P >

Re: [edk2] [Patch v3 2/7] UefiCpuPkg/CpuMpPei/Ia32: Use CodeSegment and DataSegment fields

2016-07-13 Thread Mudusuru, Giri P
Reviewed-by: Giri P Mudusuru Please add a whitespace before eax in the comments during submission. mov[di],eax > -Original Message- > From: Fan, Jeff > Sent: Tuesday, July 12, 2016 4:44 AM > To: edk2-de...@ml01.01.org > Cc: Tian, Feng

Re: [edk2] [PATCH] IntelFsp2Pkg-BaseFspPlatformLib: Remove Boot Loader tempram Migration

2016-07-13 Thread Yao, Jiewen
Reviewed by: jiewen@intel.com > -Original Message- > From: Yarlagadda, Satya P > Sent: Wednesday, July 13, 2016 9:03 PM > To: edk2-devel@lists.01.org > Cc: Mudusuru, Giri P ; Yao, Jiewen > > Subject: [PATCH]

Re: [edk2] [PATCH] OvmfPkg/PlatformPei: add missing auto variable initialization

2016-07-13 Thread Ard Biesheuvel
On 13 July 2016 at 17:00, Laszlo Ersek wrote: > On 07/13/16 16:55, Ard Biesheuvel wrote: >> The E820EntriesCount variable in XenPublishRamRegions() may be >> referenced without being initialized on RELEASE builds, since the >> ASSERT that fires if the call to XenGetE820Map()

Re: [edk2] [PATCH v2 1/7] BaseTools-GenFw:Use EXE flag to check Elf section type

2016-07-13 Thread Ard Biesheuvel
On 12 July 2016 at 19:33, Andrew Fish wrote: > >> On Jul 12, 2016, at 9:55 AM, Ard Biesheuvel >> wrote: [...] >> OK, so in summary, the AMD64 small model not only limits the relative >> range but also the absolute placement of the code? This is

Re: [edk2] [PATCH] OvmfPkg/PlatformPei: add missing auto variable initialization

2016-07-13 Thread Laszlo Ersek
On 07/13/16 16:55, Ard Biesheuvel wrote: > The E820EntriesCount variable in XenPublishRamRegions() may be > referenced without being initialized on RELEASE builds, since the > ASSERT that fires if the call to XenGetE820Map() fails is compiled > out in that case. So initialize it to 0. > >

Re: [edk2] [Patch v3 1/7] UefiCpuPkg/CpuMpPei: Add CodeSegment and DataSegment fields

2016-07-13 Thread Mudusuru, Giri P
Reviewed-by: Giri P Mudusuru > -Original Message- > From: Fan, Jeff > Sent: Tuesday, July 12, 2016 4:44 AM > To: edk2-de...@ml01.01.org > Cc: Tian, Feng ; Kinney, Michael D > ; Mudusuru, Giri P >

Re: [edk2] [PATCH] ArmPkg/ArmGicLib: manage GICv3 SPI state at the distributor

2016-07-13 Thread Leif Lindholm
On Wed, Jul 13, 2016 at 03:29:03PM +0200, Ard Biesheuvel wrote: > On 7 July 2016 at 19:22, Ard Biesheuvel wrote: > > Unlike SGIs and PPIs, which are private to the CPU and are managed at > > the redistributor level (which is also a per-CPU construct), shared > >

[edk2] [PATCH v3 5/5] OvmfPkg/PlatformPei: program MSR_IA32_FEATURE_CONTROL from fw_cfg

2016-07-13 Thread Laszlo Ersek
Under certain circumstances, QEMU exposes the "etc/msr_feature_control" fw_cfg file, with a 64-bit little endian value. The firmware is supposed to write this value to MSR_IA32_FEATURE_CONTROL (0x3a), on all processors, on the normal and the S3 resume boot paths. Utilize EFI_PEI_MPSERVICES_PPI to

[edk2] [PATCH v3 3/5] OvmfPkg: remove PcdS3AcpiReservedMemoryBase, PcdS3AcpiReservedMemorySize

2016-07-13 Thread Laszlo Ersek
No module in OvmfPkg uses these PCDs any longer. The first PCD mentioned is declared by OvmfPkg, so we can remove even the declaration. The second PCD comes from IntelFrameworkModulePkg. The module that consumes PcdS3AcpiReservedMemorySize is called

Re: [edk2] [PATCH] ArmPkg/ArmGicLib: manage GICv3 SPI state at the distributor

2016-07-13 Thread Ard Biesheuvel
On 13 July 2016 at 16:32, Leif Lindholm wrote: > On Wed, Jul 13, 2016 at 03:29:03PM +0200, Ard Biesheuvel wrote: >> On 7 July 2016 at 19:22, Ard Biesheuvel wrote: >> > Unlike SGIs and PPIs, which are private to the CPU and are managed at >> >

[edk2] [PATCH v3 2/5] OvmfPkg/PlatformPei: rebase and resize the permanent PEI memory for S3

2016-07-13 Thread Laszlo Ersek
Move the permanent PEI memory for the S3 resume boot path to the top of the low RAM (just below TSEG if the SMM driver stack is included in the build). The new size is derived from CpuMpPei's approximate memory demand. Save the base address and the size in new global variables, regardless of the

[edk2] [PATCH v3 4/5] OvmfPkg: include UefiCpuPkg/CpuMpPei

2016-07-13 Thread Laszlo Ersek
In the next patch we're going to put EFI_PEI_MP_SERVICES_PPI to use. CpuMpPei uses the following PCDs from gUefiCpuPkgTokenSpaceGuid, beyond those already used by CpuDxe: - PcdCpuMicrocodePatchAddress and PcdCpuMicrocodePatchRegionSize: these control whether CpuMpPei performs microcode update.

[edk2] [PATCH v3 0/5] OvmfPkg: program MSR_IA32_FEATURE_CONTROL from fw_cfg on all processors

2016-07-13 Thread Laszlo Ersek
v1: http://thread.gmane.org/gmane.comp.bios.edk2.devel/14214 v2: http://thread.gmane.org/gmane.comp.bios.edk2.devel/14471 Changes relative to v2: - Patches 2 and 3: pick up Jeff's R-b. - Patch 4: resolve CpuExceptionHandlerLib to PeiCpuExceptionHandlerLib for all PEIMs (suggested by Jeff). Drop

[edk2] [PATCH v3 1/5] OvmfPkg/PlatformPei: create one memory HOB at S3 resume too, for CpuMpPei

2016-07-13 Thread Laszlo Ersek
CpuMpPei will have to place the AP startup vector in memory under 1MB. For this, CpuMpPei borrows memory under 1MB, but it needs a memory resource descriptor HOB to exist there even on the S3 resume path (see the GetWakeupBuffer() function). Produce such a HOB as an exception on the S3 resume

Re: [edk2] [PATCH v2 3/7] MdePkg: Enable new MS VA intrinsics for GNUC x86 64bits build

2016-07-13 Thread Ard Biesheuvel
On 8 July 2016 at 10:42, Shi, Steven wrote: > Both GCC and LLVM 3.8 64bits support new variable argument (VA) > intrinsics for Microsoft ABI, enable these new VA intrinsics for > GNUC family 64bits code build. These VA intrinsics are only > permitted use in 64bits code, so

Re: [edk2] [PATCH v2 5/5] SecurityPkg DxeTpmMeasureBootLib: Add comments in TcgMeasurePeImage()

2016-07-13 Thread Zhang, Chao B
Reviewed-by: Chao Zhang Thanks & Best regards Chao Zhang -Original Message- From: Gao, Liming Sent: Wednesday, July 13, 2016 8:28 PM To: edk2-de...@ml01.01.org Cc: Yao, Jiewen; Zhang, Chao B Subject: [PATCH v2 5/5] SecurityPkg DxeTpmMeasureBootLib: Add

Re: [edk2] [PATCH] IntelFsp2Pkg-BaseFspPlatformLib: Remove Boot Loader tempram Migration

2016-07-13 Thread Mudusuru, Giri P
Reviewed-by: Giri P Mudusuru Fix typo during submitting patch in description: fucntion to function. > -Original Message- > From: Yarlagadda, Satya P > Sent: Wednesday, July 13, 2016 6:03 AM > To: edk2-devel@lists.01.org > Cc: Mudusuru, Giri P

Re: [edk2] [PATCH] ArmPkg/ArmGicLib: manage GICv3 SPI state at the distributor

2016-07-13 Thread Ard Biesheuvel
On 7 July 2016 at 19:22, Ard Biesheuvel wrote: > Unlike SGIs and PPIs, which are private to the CPU and are managed at > the redistributor level (which is also a per-CPU construct), shared > interrupts (SPIs) are shared between all CPUs, and therefore managed at > the

[edk2] [PATCH] IntelFsp2Pkg-BaseFspPlatformLib: Remove Boot Loader tempram Migration

2016-07-13 Thread Satya Yarlagadda
In FSP2.0, Boot loader should migrate its temp ram before calling the tempramexit API to tear down the tempram. so, we don't need the fucntion to migrate the BL TempRam in the IntelFsp2Pkg. Cc: Giri P Mudusuru Cc: Jiewen Yao Contributed-under:

[edk2] [PATCH v2 1/5] SecurityPkg SecureBootConfigDxe: Add check for the external PE/COFF image.

2016-07-13 Thread Liming Gao
Use BasePeCoffLib PeCoffLoaderGetImageInfo() to check the PE/COFF image. In V2, add specific ImageRead() to make sure the PE/COFF image content read is within the image buffer. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao Reviewed-by:

[edk2] [PATCH v2 0/5] SecurityPkg: Add check for the external PE/COFF image

2016-07-13 Thread Liming Gao
External PE/COFF image may not be valid and cause memory corruption. These patches uses PeCoffLib PeCoffLoaderGetImageInfo() to check the PE format. If this API has been used to check PE format, the addtional comments will be added to describe PE image has been checked. In V2, add specific

[edk2] [PATCH v2 5/5] SecurityPkg DxeTpmMeasureBootLib: Add comments in TcgMeasurePeImage()

2016-07-13 Thread Liming Gao
The input PeImage in TcgMeasurePeImage() has been checked. Cc: Jiewen Yao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao ---

[edk2] [PATCH v2 2/5] SecurityPkg TrEEDxe: Add check for the PE/COFF image.

2016-07-13 Thread Liming Gao
Use BasePeCoffLib PeCoffLoaderGetImageInfo() to check the PE/COFF image. In V2, add specific ImageRead() to make sure the PE/COFF image content read is within the image buffer. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao Reviewed-by:

[edk2] [PATCH v2 4/5] SecurityPkg DxeImageVerificationLib: Add comments in HashPeImage()

2016-07-13 Thread Liming Gao
The input PeImage in HashPeImage() has been checked. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao Reviewed-by: Jiewen Yao Reviewed-by: Chao Zhang ---

[edk2] [PATCH v2 3/5] SecurityPkg Tcg2Dxe: Add check for the PE/COFF image

2016-07-13 Thread Liming Gao
Use BasePeCoffLib PeCoffLoaderGetImageInfo() to check the PE/COFF image. In V2, add specific ImageRead() to make sure the PE/COFF image content read is within the image buffer. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao Reviewed-by:

Re: [edk2] [Patch] UefiCpuPkg/MtrrLib: Remove MTRRs display from MtrrSetAllMtrrs()

2016-07-13 Thread Laszlo Ersek
On 07/13/16 10:27, Fan, Jeff wrote: > Laszlo, > > Yes. You are correct. MtrrSetAllMtrrs() could be used by BSP to make whole > MTRR updating. > I agree this patch will be feature drop on MtrrSetAllMtrrs() on MTRR setting > display. > > I reviewed the example you listed. > -

Re: [edk2] [PATCH v2 4/7] BaseTools-Conf:Introduce GCC5 new toolchain for x86

2016-07-13 Thread Ard Biesheuvel
On 11 July 2016 at 19:05, Jordan Justen wrote: > On 2016-07-08 01:42:41, Shi, Steven wrote: >> GCC5 enable GCC Link Time Optimization (LTO) and code size >> optimization (–Os) for aggressive code size improvement. > > Can you fix this to be a dash? (-Os) > >> GCC5 X64

Re: [edk2] [PATCH] ArmPkg/ArmMmuLib: avoid type promotion in TCR_EL1 assignment

2016-07-13 Thread Mark Rutland
On Wed, Jul 13, 2016 at 09:28:06AM +0200, Ard Biesheuvel wrote: > Commit fafb7e9c110e ("ArmPkg: correct TTBR1_EL1 settings in TCR_EL1") > introduced a symbolic constant TCR_TG1_4KB which resolves to (2 << 30), > and ORs it into the value to be written into TCR_EL1 (if executing at > EL1). Since

Re: [edk2] [PATCH] ArmPkg/ArmMmuLib: avoid type promotion in TCR_EL1 assignment

2016-07-13 Thread Leif Lindholm
On Wed, Jul 13, 2016 at 09:28:06AM +0200, Ard Biesheuvel wrote: > Commit fafb7e9c110e ("ArmPkg: correct TTBR1_EL1 settings in TCR_EL1") > introduced a symbolic constant TCR_TG1_4KB which resolves to (2 << 30), > and ORs it into the value to be written into TCR_EL1 (if executing at > EL1). Since

Re: [edk2] [Patch 1/4] SecurityPkg SecureBootConfigDxe: Add check for the external PE/COFF image.

2016-07-13 Thread Gao, Liming
Jiewen: Current report error message is that "ERROR: Unsupported file type!" L"Only supports DER-encoded X509 certificate and executable EFI image", because the return status is RETURN_UNSUPPORTED. I think this error message is also fine. Thanks Liming > -Original Message- > From:

Re: [edk2] [Patch] UefiCpuPkg/MtrrLib: Remove MTRRs display from MtrrSetAllMtrrs()

2016-07-13 Thread Fan, Jeff
Laszlo, Yes. You are correct. MtrrSetAllMtrrs() could be used by BSP to make whole MTRR updating. I agree this patch will be feature drop on MtrrSetAllMtrrs() on MTRR setting display. I reviewed the example you listed. - OvmfPkg/PlatformPei/MemDetect.c-- MTRR setting will be displayed

[edk2] [PATCH] ArmPkg/ArmMmuLib: avoid type promotion in TCR_EL1 assignment

2016-07-13 Thread Ard Biesheuvel
Commit fafb7e9c110e ("ArmPkg: correct TTBR1_EL1 settings in TCR_EL1") introduced a symbolic constant TCR_TG1_4KB which resolves to (2 << 30), and ORs it into the value to be written into TCR_EL1 (if executing at EL1). Since the constant is implicitly typed as signed int, and has the sign bit set,

Re: [edk2] [PATCH v2 4/5] OvmfPkg: include UefiCpuPkg/CpuMpPei

2016-07-13 Thread Laszlo Ersek
On 07/13/16 02:40, Fan, Jeff wrote: > Laszlo, > > Even I have r-b this patch before, I have one comment now. :-) > > It's better to move PeiCpuExceptionHandlerLib instance from CpuMpPei to > > [LibraryClasses.common.PEIM] > + >

Re: [edk2] [PATCH v2 0/4] PCI resource reservation changes for better hotpluggability

2016-07-13 Thread Laszlo Ersek
On 07/13/16 03:05, Ni, Ruiyu wrote: > All of the serials, Reviewed-by: Ruiyu Ni > > I think it's now a PCIE world. The change #2/4 should be fine though it > changes > the PciBus behavior. > #3/4 isn't conflict with the existing platform PciHotPlugInitDxe driver which >

[edk2] [Patch 0/5] UefiCpuPkg/PiSmmCpuDxeSmm: S3 resume clean ups

2016-07-13 Thread Michael Kinney
This patch series fixes a number of small issues in the S3 resume path. * Remove duplicate aligned buffer allocation on S3 resume path * Add support for MemoryMapped REGISTER_TYPE in SetProcessorRegister() * Move XD/BTS feature detection to SmmInitHandler() to improve performance. Jeff Fan (5):

[edk2] [Patch 1/5] UefiCpuPkg/PiSmmCpuDxeSmm: Remove duplicate aligned buffer on S3 path

2016-07-13 Thread Michael Kinney
From: Jeff Fan InitializeMpSyncData() invokes InitializeSmmCpuSemaphores() to allocate an aligned buffer for all locks and semaphores. However, this function is invoked on S3 resume path again to reset mSmmMpSyncData. It causes an additional aligned buffer to be allocated.

[edk2] [Patch 3/5] UefiCpuPkg/PiSmmCpuDxeSmm: Add SMM S3 boot flag

2016-07-13 Thread Michael Kinney
From: Jeff Fan It will be set to TRUE during S3 resume. Cc: Michael Kinney Cc: Feng Tian Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan ---

[edk2] [Patch 5/5] UefiCpuPkg/PiSmmCpuDxeSmm: Clean up CheckFeatureSupported()

2016-07-13 Thread Michael Kinney
From: Jeff Fan Removed EFIAPI and parameter from CheckFeatureSupported() and removed CheckProcessorFeature() totally. Cc: Michael Kinney Cc: Feng Tian Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by:

[edk2] [Patch 4/5] UefiCpuPkg/PiSmmCpuDxeSmm: Check XD/BTS features in SMM relocation

2016-07-13 Thread Michael Kinney
From: Jeff Fan CheckProcessorFeature() invokes MpService->StartupAllAps() to detect XD/BTS features on normal boot path. It's not necessary and may cause performance impact, because INIT-SIPI-SIPI must be sent to APs if APs are in hlt-loop mode. XD/BTS feature detection is

[edk2] [Patch 2/5] UefiCpuPkg/PiSmmCpuDxeSmm: Add MemoryMapped in SetProcessorRegister()

2016-07-13 Thread Michael Kinney
From: Jeff Fan REGISTER_TYPE in UefiCpuPkg/Include/AcpiCpuData.h defines a MemoryMapped enum value. However support for the MemoryMapped enum is missing from the implementation of SetProcessorRegister(). This patch adds support for MemoryMapped type SetProcessorRegister().

Re: [edk2] [Patch] UefiCpuPkg/MtrrLib: Remove MTRRs display from MtrrSetAllMtrrs()

2016-07-13 Thread Laszlo Ersek
On 07/13/16 08:20, Laszlo Ersek wrote: > - Audit all current uses of MtrrSetAllMtrrs(), and wherever it is > obviously called from the BSP, append the following explicit code: > > DEBUG_CODE (MtrrDebugPrintAllMtrrs()); Sorry, that should be DEBUG_CODE (MtrrDebugPrintAllMtrrs ());

Re: [edk2] [Patch] UefiCpuPkg/MtrrLib: Remove MTRRs display from MtrrSetAllMtrrs()

2016-07-13 Thread Laszlo Ersek
On 07/13/16 02:33, Jeff Fan wrote: > MtrrSetAllMtrrs() maybe used by APs to sync BSP's MTRR settings. BSP's MTRR > setting should be displayed if EFI_D_CACHE flag is set when MTRR updated. In > MtrrSetAllMtrrs(), it's not necessary to display MTRR setting again due to the > MTRR settings should be

[edk2] [Patch] CryptoPkg/OpensslLib: Upgrade OpenSSL version to 1.0.2h

2016-07-13 Thread Qin Long
OpenSSL 1.0.2h was released with several severity fixes at 03-May-2016 (https://www.openssl.org/news/secadv/20160503.txt). Upgrade the supported OpenSSL version in CryptoPkg/OpensslLib to catch the latest release 1.0.2h. Cc: Ting Ye Cc: David Woodhouse