Re: [edk2] [PATCH 1/3] IntelFrameworkModulePkg: Use IsZeroGuid API for zero GUID checking

Reviewed-by: Jeff Fan -Original Message- From: Wu, Hao A Sent: Tuesday, August 30, 2016 10:36 AM To: edk2-devel@lists.01.org; Gao, Liming Cc: Wu, Hao A; Fan, Jeff Subject: [PATCH 1/3] IntelFrameworkModulePkg: Use IsZeroGuid API for zero GUID checking Instead of

Re: [edk2] [PATCH 3/3] SecurityPkg: Use IsZeroGuid API for zero GUID checking

Reviewed-by: Chao Zhang Thanks & Best regards Chao Zhang -Original Message- From: Wu, Hao A Sent: Tuesday, August 30, 2016 10:36 AM To: edk2-devel@lists.01.org; Gao, Liming Cc: Wu, Hao A; Zhang, Chao B Subject: [PATCH 3/3] SecurityPkg: Use IsZeroGuid API for

Re: [edk2] [PATCH 2/3] MdeModulePkg: Use IsZeroGuid API for zero GUID checking

Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Wu, Hao A Sent: Tuesday, August 30, 2016 10:36 AM To: edk2-devel@lists.01.org; Gao, Liming Cc: Wu, Hao A ; Tian, Feng ; Zeng, Star

[edk2] [PATCH 2/3] MdeModulePkg: Use IsZeroGuid API for zero GUID checking

Instead of comparing a GUID with gZeroGuid via the CompareGuid API, the commit uses the IsZeroGuid API to check if the given GUID is a zero GUID. Cc: Feng Tian Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu

[edk2] [PATCH 1/3] IntelFrameworkModulePkg: Use IsZeroGuid API for zero GUID checking

Instead of comparing a GUID with gZeroGuid via the CompareGuid API, the commit uses the IsZeroGuid API to check if the given GUID is a zero GUID. Cc: Jeff Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu ---

[edk2] [PATCH 0/3] Use IsZeroGuid API for zero GUID checking

To check if the given GUID is a zero GUID, current codes use the CompareGuid() API (from BaseMemoryLib) with gZeroGuid. This series will use the IsZeroGuid() API (also from BaseMemoryLib) instead to do this check. Hao Wu (3): IntelFrameworkModulePkg: Use IsZeroGuid API for zero GUID checking

[edk2] [PATCH 3/3] SecurityPkg: Use IsZeroGuid API for zero GUID checking

Instead of comparing a GUID with gZeroGuid via the CompareGuid API, the commit uses the IsZeroGuid API to check if the given GUID is a zero GUID. Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu ---

[edk2] Crc32

Hi, all. Yet another dumb question from me. UEFI specification has Crc32 calculation service and uses Crc32 in several places. but it only humbly mentions in the note somewhere in the description of System Table about what exact one it wants. Namely it states that the polynomial seed is 04c11db7.

Re: [edk2] [PATCH 3/3] IntelFsp2WrapperPkg: Update pragma to use push and pop

Thanks Mike, sent updated patch v2 removing the push, pop change. Thanks, -Giri > -Original Message- > From: Kinney, Michael D > Sent: Monday, August 29, 2016 11:45 AM > To: Mudusuru, Giri P ; edk2-devel@lists.01.org; > Kinney, Michael D

[edk2] [PATCHV2 1/2] IntelFsp2Pkg: Remove pragma usage to align with UEFI Spec

UEFI spec section 2.3.1 requires all data to be naturally aligned. Remove the unnecessary pragma usage. Cc: Jiewen Yao Cc: Maurice Ma Cc: Satya Yarlagadda Cc: Michael Kinney

Re: [edk2] [PATCH 3/3] IntelFsp2WrapperPkg: Update pragma to use push and pop

Giri, Just leave this as #pragma pack(1) and #pragma pack() to follow the style used everywhere else. EDK II sources assume the default packing is natural packing. The compiler Configuration in tools_def.txt need to make sure natural packing is the default. Mike > -Original Message- >

[edk2] [PATCH 3/3] IntelFsp2WrapperPkg: Update pragma to use push and pop

Cc: Jiewen Yao Cc: Maurice Ma Cc: Satya Yarlagadda Cc: Michael Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Giri P Mudusuru ---

Re: [edk2] OVMF not booting when built with GCC5 toolset?

On 8/29/2016 12:45 AM, Shi, Steven wrote: This issue is just fixed in GCC main trunk. I tried below latest GCC trunk version and it can pass build the edk2 with GCC5 toolset. FYI. Thanks! -- Bruce ___ edk2-devel mailing list edk2-devel@lists.01.org

Re: [edk2] [EDK2] DxeCapsuleLib returns Status Issue

Ankit: It is good to record and return the SetImage status(either success or fail) for all the FMP instances matching FMP capsule payload. But how it is returned to application layer is still a platform choice Thanks & Best regards Chao Zhang -Original Message- From: Gao, Liming

[edk2] [Patch] BaseTools: UpdateImageSize include Image auth info for FMP Auth capsule

Per UEFI spec UpdateImageSize may or may not include Firmware Image Authentication information. so for FMP auth capsule, UpdateImageSize should include the Image auth info. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu

Re: [edk2] [EDK2] DxeCapsuleLib returns Status Issue

Hi That is good problem statement. Do you think we can use Capsule Status Variable to record such information? It is defined in UEFI spec - "7.5.6 UEFI variable reporting on the Success or any Errors encountered in processing of capsules after restart" The application can use this standard way

Re: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

What do you mean control goes to next boot option? Will it go to PXE boot when you select the 2nd http boot. If was, you just need to update the whole edk2 code. This issue related to the BDS and we already fixed long before, Best regards Lubo -Original Message- From: Santhapur

Re: [edk2] OVMF not booting when built with GCC5 toolset?

Hi Cran, This issue is just fixed in GCC main trunk. I tried below latest GCC trunk version and it can pass build the edk2 with GCC5 toolset. FYI. $ gcc --version gcc (GCC) 7.0.0 20160828 (experimental) Steven Shi Intel\SSG\STO\UEFI Firmware Tel: +86 021-61166522 iNet: 821-6522 From: Shi,

Re: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

Hi Lubo, I've taken the source from the location you have specified and checked. But I still get the same failure. When I select the same HTTP boot option the 2nd time, control goes to next boot option available. I guess the problem could be on my side only. I'll look into it.