On 2016-10-18 21:40:16, Zhu, Yonghong wrote:
> Hi Jordan,
>
> If we change regex to r'''DEBUG \s* \( \s* \(\s*. EFI_D_*''', it cannot
> work because we would use mo.group(1) which report IndexError.
> If we change regex to r'''DEBUG \s* \( \s* \(\s*. EFI_D_ ([A-Z_]+)''' ,
> it cannot detect the ca
Following the same approach as toolsetup.bat:
If build.exe, TargetTool.exe, Trim.exe or GenFds.exe is missing, run its
Python source instead.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Cinnamon Shia
---
Edk2Setup.bat | 33 +++--
1 file chan
Hi Jordan,
If we change regex to r'''DEBUG \s* \( \s* \(\s*. EFI_D_*''', it cannot work
because we would use mo.group(1) which report IndexError.
If we change regex to r'''DEBUG \s* \( \s* \(\s*. EFI_D_ ([A-Z_]+)''' , it
cannot detect the case "DEBUG ((DEBUG_ERROR | EFI_D_INFO, "xxx", Status));"
Support --nt32 X64 for building 64-bit NT32.
For setting up Windows environment variables requited by NT32, follow the
same approach as Edk2Setup.bat by using the get_vsvars.bat and
SetVisualStudio.bat.
Sync the help text of NT32 with Edk2Setup.bat.
Contributed-under: TianoCore Contribution Agree
It's just an experience value and has been here about 10 years...
Which usb brand/model name do you have problem on?
Thanks
Feng
-Original Message-
From: Heyi Guo [mailto:heyi@linaro.org]
Sent: Wednesday, October 19, 2016 9:57 AM
To: edk2-devel@lists.01.org
Cc: Tian, Feng ; Zeng, St
Dear experts,
Could anyone help to explain why USB_BOOT_IO_BLOCKS in
MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.h is set to 128?
We found on some platforms this value may cause USB boot failure and
*64* blocks will make them work. Though we have not got the final root
cause, it will
Reviewed-by: Eric Dong
> -Original Message-
> From: Bi, Dandan
> Sent: Monday, October 17, 2016 5:08 PM
> To: Laszlo Ersek; edk2-de...@ml01.01.org
> Cc: Dong, Eric; Gao, Liming
> Subject: RE: [edk2] [PATCH v2] MdeModulePkg/BootMaintenanceUi: Enhance the
> codes logic
>
> Hi Laszlo,
>
>
Reviewed-by: Liming Gao
> -Original Message-
> From: Zhu, Yonghong
> Sent: Monday, October 17, 2016 5:46 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [Patch] BaseTools: Enhance tool to generate
> EFI_HII_IIBT_DUPLICATE image block
>
> When *.IDF file contains multiple d
Reviewed-by: Liming Gao
> -Original Message-
> From: Zhu, Yonghong
> Sent: Thursday, October 13, 2016 5:30 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [Patch] BaseTools: support PCD value to use expression in the DEC
> file
>
> This patch add the support for Pcd value
OK,
Thank you for advice.
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Shah, Tapan
> Sent: October-18-16 11:04 AM
> To: Carsey, Jaben; Vladimir Olovyannikov; Michael Zimmermann
> Cc: Ni, Ruiyu; Arshi, Shala; edk2-devel@lists.01.org; Laszlo
> On Oct 18, 2016, at 10:40 AM, Laszlo Ersek wrote:
>
> On 10/18/16 19:18, Saqib Khan wrote:
>> Hi,
>> I can not find structure of BOOT variable, Can any one help how to
>> extract device path from BOOT variable.
>
> In UEFI-related questions, the UEFI specification has a fair chance to
On 2016-10-18 03:16:53, Yonghong Zhu wrote:
> In EDK2, DEBUG_* is recommended to be used instead of EFI_D_*. For new
> code, they should use DEBUG_* macro.
>
> Fixes:https://bugzilla.tianocore.org/show_bug.cgi?id=143
> Cc: Liming Gao
> Cc: Jordan Justen
> Contributed-under: TianoCore Contributio
On 10/18/16 20:03, Vladimir Olovyannikov wrote:
>> -Original Message-
>> From: Laszlo Ersek [mailto:ler...@redhat.com]
>> Sent: October-18-16 10:24 AM
>> To: Vladimir Olovyannikov; Shah, Tapan; Carsey, Jaben; Michael Zimmermann
>> Cc: Ni, Ruiyu; Arshi, Shala; edk2-devel@lists.01.org
>> Subj
1. Create this new shared library in MdeModulePkg.
2. For parameters: Other than standard parameters defined in Shell
specification I would suggest to follow single character flag where it makes
sense (example: -d to delete, -l to list, -c to create etc.) and if more than
one operation can be ti
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: October-18-16 10:24 AM
> To: Vladimir Olovyannikov; Shah, Tapan; Carsey, Jaben; Michael Zimmermann
> Cc: Ni, Ruiyu; Arshi, Shala; edk2-devel@lists.01.org
> Subject: Re: [edk2] [PATCH] GPT Shell Application/Library
On 10/18/16 19:18, Saqib Khan wrote:
> Hi,
> I can not find structure of BOOT variable, Can any one help how to
> extract device path from BOOT variable.
In UEFI-related questions, the UEFI specification has a fair chance to
provide useful information.
Please refer to "3.1.3 Load Options"
On 10/18/16 16:54, Carsey, Jaben wrote:
> Reviewed-by: Jaben Carsey
>
>> -Original Message-
>> From: Tim Lewis [mailto:tim.le...@insyde.com]
>> Sent: Tuesday, October 18, 2016 5:44 AM
>> To: Laszlo Ersek ; edk2-devel-01 > de...@ml01.01.org>
>> Cc: Carsey, Jaben ; Ni, Ruiyu
>> Subject: RE
On 10/18/16 18:58, Vladimir Olovyannikov wrote:
> Thank you all for comments,
>
> So to summarize the discussion:
>
> 1. I will create a Shell library which would perform all GPT operations.
> Part of PartitionDxe will also be in that library so PartitionDxe will
> be using it.
> The gp
Hi,
I can not find structure of BOOT variable, Can any one help how to
extract device path from BOOT variable.
here is code i have attempt (rEFind)
*UINT8 *Value;*
*Status = gRT->GetVariable ((CHAR16 *)Name, &gEfiGlobalVariableGuid, NULL,
&BootVariableSize, Value);//p
For the standards, I would try to use the UEFI Shell Spec for some parameters.
For Example:
-v for verbose
-h for help
-sfo for standard format output
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Vladimir Olovyannikov
> Sent: Tuesday, Oc
Thank you all for comments,
So to summarize the discussion:
1. I will create a Shell library which would perform all GPT operations.
Part of PartitionDxe will also be in that library so PartitionDxe will
be using it.
The gpt Shell tool will also be using it.
2. Refactor the parameters
On 10/14/2016 03:37 PM, Laszlo Ersek wrote:
On 10/14/16 21:39, Brian J. Johnson wrote:
On 10/12/2016 03:17 AM, Ryan Harkin wrote:
On 7 October 2016 at 16:59, Leif Lindholm
wrote:
Roy can now be found at Roy Franz (cc:d).
On Fri, Oct 07, 2016 at 05:56:26PM +0200, Laszlo Ersek wrote:
Roy, Ry
Yes, git automatically detects copying and moving files, as long as both
halves of the action (remove + add) are in the same commit. There's a
nice explanation here:
https://git-scm.com/book/en/v2/Git-Basics-Recording-Changes-to-the-Repository#_git_mv
Brian
On 10/18/2016 12:59 AM, Kinney, Mi
Never mind. Just saw patch.
> -Original Message-
> From: Carsey, Jaben
> Sent: Tuesday, October 18, 2016 7:54 AM
> To: 'Tim Lewis' ; edk2-devel@lists.01.org
> Cc: Carsey, Jaben
> Subject: RE: [shell] Problems in EfiShellGetGuidFromName
>
> I think you're right. I guess that there are no
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Tim Lewis [mailto:tim.le...@insyde.com]
> Sent: Tuesday, October 18, 2016 5:44 AM
> To: Laszlo Ersek ; edk2-devel-01 de...@ml01.01.org>
> Cc: Carsey, Jaben ; Ni, Ruiyu
> Subject: RE: [PATCH] ShellPkg/Shell: fix CopyGuid() arg order
I think you're right. I guess that there are not lots of users of this
function.
Can you submit a Bugzilla request?
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Tim Lewis
> Sent: Tuesday, October 18, 2016 3:18 AM
> To: edk2-devel@lists.
I am good with this.
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Ruiyu Ni
> Sent: Tuesday, October 18, 2016 1:46 AM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH v2 0/8] Move Shell protocols definition
Thanks for the contribution Vladimir!
Few comments:
1. It's better to refactor the code now before commit and move GPT related code
outside ShellPkg and create a shared library.
2. CLI parameters of this utility are too complex and need to be refactored to
make it similar to other existing Shell
Agree Jiewen will update it before pushing the patch.
Thanks,
-Giri
> -Original Message-
> From: Yao, Jiewen
> Sent: Tuesday, October 18, 2016 6:30 AM
> To: Mudusuru, Giri P ; edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Gao, Liming
>
> Subject: RE: [edk2] [PATCH] MdePkg: Add ACPI
HI
I recommend we just use #include .
Acpi.h includes all ACPI version. There is no need to include Acpi61.h.
With this change, reviewed-by: jiewen@intel.com
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Giri P Mudusuru
> Sent: Tuesda
Reviewed-by: Tim Lewis
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Tuesday, October 18, 2016 4:07 AM
To: edk2-devel-01
Cc: Jaben Carsey ; Ruiyu Ni ; Tim
Lewis
Subject: [PATCH] ShellPkg/Shell: fix CopyGuid() arg order in
EfiShellGetGuidFromName()
The destin
ACPI Low Power Idle Table (LPIT) Revision 001, dated July 2014
http://www.uefi.org/sites/default/files/resources/ACPI_Low_Power_Idle_Table.pdf
Cc: Michael Kinney
Cc: Liming Gao
Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Giri P Mudusuru
---
.../Includ
The destination GUID comes first; from
"MdePkg/Include/Library/BaseMemoryLib.h":
> GUID *
> EFIAPI
> CopyGuid (
> OUT GUID *DestinationGuid,
> IN CONST GUID *SourceGuid
> );
Here "NewGuid" is the GUID looked up by GetGuidFromStringName(), and
"Guid" is where EfiShellGetGuidFromName()
Thanks Jordan, I sent a V2. I update a little on the re.compile to cover the
case that EFI_D_* in the middle of the DEBUG string, and may have multiple
space between DEBUG and ( character.
Best Regards,
Zhu Yonghong
-Original Message-
From: Justen, Jordan L
Sent: Tuesday, October 18,
Did anyone have a chance to look at this EFI_SHELL_PROTOCOL bug in the EDK2
implementation?
Thanks,
Tim
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Tim Lewis
Sent: Thursday, October 13, 2016 11:16 AM
To: edk2-devel-01
Subject: [edk2] [shell
In EDK2, DEBUG_* is recommended to be used instead of EFI_D_*. For new
code, they should use DEBUG_* macro.
Fixes:https://bugzilla.tianocore.org/show_bug.cgi?id=143
Cc: Liming Gao
Cc: Jordan Justen
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Yonghong Zhu
---
BaseTool
Hello Feng,
We haven't get any feedback from USB.org yet but could you provide us with the
patch?
We found a new issue probably caused by this mismatch in our current products
and I want to check if the patch could fix the issue or not at least.
Thank you for all your support!
Kind regards,
Yo
On 18 October 2016 at 09:46, Ruiyu Ni wrote:
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ruiyu Ni
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
Reviewed-by: Ard Biesheuvel
> ---
> ArmPlatformPkg/Library/ArmShellCmdRunAxf/ArmShellCmdRunAxf.h | 6 ++
> 1 file cha
Hello Ard,
On Tue, Oct 18, 2016 at 09:40:42AM +0100, Ard Biesheuvel wrote:
> On 18 October 2016 at 03:50, Dennis Chen wrote:
> > Hello Ard,
> >
> > On Mon, Oct 17, 2016 at 06:09:00PM +0100, Ard Biesheuvel wrote:
> >> On 17 October 2016 at 09:54, Dennis Chen wrote:
> >> > Since ACPI spec defines
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni
Reviewed-by: Leif Lindholm
Cc: Ard Biesheuvel
---
ArmPkg/Application/LinuxLoader/LinuxLoader.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ArmPkg/Application/LinuxLoader/LinuxLoader.h
b/
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni
Cc: Liming Gao
---
MdePkg/Include/Protocol/{EfiShell.h => Shell.h}| 138 ++-
...ShellDynamicCommand.h => ShellDynamicCommand.h} | 11 +-
.../{EfiShellParameters.h => ShellParameters.h}| 8 +
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni
Cc: Jaben Carsey
---
ShellPkg/Application/Shell/Shell.h| 5 ++---
ShellPkg/Include/Library/ShellCommandLib.h| 5 ++---
ShellPkg/Include/Library/ShellLib.h
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni
Reviewed-by: Leif Lindholm
Cc: Ard Biesheuvel
---
EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatform.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatfo
Move Shell/ShellDynamicCommand/ShellParameters definitions from
ShellPkg to MdePkg.
The following patches will rename the header file name.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni
Cc: Jaben Carsey
Cc: Jiewen Yao
Cc: Michael D Kinney
---
{ShellPkg => Md
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni
Cc: Jaben Carsey
---
ShellPkg/Include/Protocol/EfiShell.h | 21 +
ShellPkg/Include/Protocol/EfiShellDynamicCommand.h | 21 +
ShellPkg/Include/Protocol/EfiShellPar
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni
Cc: Leif Lindholm
Cc: Ard Biesheuvel
---
ArmPlatformPkg/Library/ArmShellCmdRunAxf/ArmShellCmdRunAxf.h | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/ArmPlatformPkg/Library/ArmShellCmdRunAx
The patches moves Shell spec defined protocol definitions to
MdePkg and updates all references.
Content of ShellBase.h is moved to Protocol/Shell.h and
ShellBase.h is removed.
In V2, to keep maximum backward compatibility, the header files
in ShellPkg will not be removed until all consumers are
up
The more proper place for macro SHELL_FREE_NON_NULL is ShellLib.h
instead of ShellBase.h.
Modify Compress.c to resolve build failure due to this change.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni
Reviewed-by: Jaben Carsey
Cc: Jiewen Yao
Cc: Michael D Kinney
On 18 October 2016 at 03:50, Dennis Chen wrote:
> Hello Ard,
>
> On Mon, Oct 17, 2016 at 06:09:00PM +0100, Ard Biesheuvel wrote:
>> On 17 October 2016 at 09:54, Dennis Chen wrote:
>> > Since ACPI spec defines the GIC base addresses (CPU interface,
>> > Distributor and Redistributor*GICv3 only*) a
On 10/18/16 02:06, Bruce Cran wrote:
> I've just built both OVMF _and_ Qemu from the latest git sources, so I
> don't know which is at fault - but I'm seeing a hang in:
>
> #0 0x7f9dc030 in SetInterruptState (InterruptState=104 'h')
> at /home/bcran/workspace/edk2/MdePkg/Library/BaseL
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Mudusuru, Giri P
> Sent: Tuesday, October 18, 2016 11:23 AM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen
> Subject: [edk2] [PATCH] IntelSiliconPkg: Fixed bug in IgdOpregion spec
>
> Spec documents Mailbox3 - RM31 size as 0
51 matches
Mail list logo
