[edk2] [Patch] MdePkg BaseMemoryLibOptDxe: Add function comment for InternalMemCompareGuid

2016-10-19 Thread Liming Gao
Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- MdePkg/Library/BaseMemoryLibOptDxe/Arm/MemLibGuid.c | 13 + 1 file changed, 13 insertions(+) diff --git

[edk2] [Patch] MdeModulePkg LoadFileOnFv2: Correct the parameter name in function comment

2016-10-19 Thread Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- MdeModulePkg/Universal/LoadFileOnFv2/LoadFileOnFv2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Universal/LoadFileOnFv2/LoadFileOnFv2.c

Re: [edk2] [PATCH] MdePkg: Add ACPI Low Power Idle Table (LPIT) definitions

2016-10-19 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Mudusuru, Giri P > Sent: Tuesday, October 18, 2016 9:56 PM > To: Yao, Jiewen ; edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Gao, Liming >

Re: [edk2] [Patch] ShellPkg: update ping to use timer service instead of timer arch protocol .

2016-10-19 Thread Hegde, Nagaraj P
Thanks Siyuan. Reviewed-by: Hegde, Nagaraj P Regards, Nagaraj. -Original Message- From: Fu, Siyuan [mailto:siyuan...@intel.com] Sent: Thursday, October 20, 2016 8:32 AM To: Hegde, Nagaraj P ; edk2-devel@lists.01.org Cc: Ni, Ruiyu

Re: [edk2] [Patch] ShellPkg: update ping to use timer service instead of timer arch protocol .

2016-10-19 Thread Fu, Siyuan
Hi, Nagaraj The 0~2ms doesn't mean 0.2ms, it means 0 to 2 ms. It's not an accurate time because we are using the timer event service and gBS->Stall to estimate the system timer period, see the new added GetTimerPeriod() function. It first create a period timer with 1ms interval, and use a

Re: [edk2] [PATCH 32/33] UefiCpuPkg: Fix typos in comments

2016-10-19 Thread Fan, Jeff
Just v2 for this single patch is fine for me. I will help to commit. Thanks! Jeff -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Gary Lin Sent: Thursday, October 20, 2016 10:09 AM To: Fan, Jeff Cc: edk2-devel@lists.01.org Subject: Re: [edk2]

Re: [edk2] [PATCH 30/33] ShellPkg: Fix typos in comments and variables

2016-10-19 Thread Gary Lin
On Wed, Oct 19, 2016 at 08:29:02PM +, Carsey, Jaben wrote: > Is this required to be a patch series? By that I mean that they need to be > committed in order... > Every patch is independent. I made them a series for convenience. Thanks, Gary Lin > Reviewed-by: Jaben Carsey

Re: [edk2] [PATCH 32/33] UefiCpuPkg: Fix typos in comments

2016-10-19 Thread Gary Lin
On Thu, Oct 20, 2016 at 01:58:51AM +, Fan, Jeff wrote: > Reviewed-by: Jeff Fan > > Could you please help to fix typo *ruturn* when you commit the patch. > - @return The ruturn value of this paramter indicates > the number of > + @return

[edk2] [PATCH 3/3] MdeModulePkg/HiiDatabaseDxe.inf: Correct the GUID usages

2016-10-19 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Dandan Bi --- MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[edk2] [PATCH 0/3] Correct the metadata in UNI/INF file

2016-10-19 Thread Ruiyu Ni
The patch serials correct the meta data in UNI/INF file. For details please refer to individual patch. Ruiyu Ni (3): MdeModulePkg: Add PcdPciDegradeResourceForOptionRom prompt to UNI MdeModulePkg/GraphicsOutputDxe.inf: Correct the protocol/GUID usages MdeModulePkg/HiiDatabaseDxe.inf:

[edk2] [PATCH 1/3] MdeModulePkg: Add PcdPciDegradeResourceForOptionRom prompt to UNI

2016-10-19 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Dandan Bi --- MdeModulePkg/MdeModulePkg.uni | 9 + 1 file changed, 9 insertions(+) diff --git a/MdeModulePkg/MdeModulePkg.uni b/MdeModulePkg/MdeModulePkg.uni

[edk2] [PATCH 2/3] MdeModulePkg/GraphicsOutputDxe.inf: Correct the protocol/GUID usages

2016-10-19 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Dandan Bi --- .../Universal/Console/GraphicsOutputDxe/GraphicsOutputDxe.inf | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

Re: [edk2] [PATCH 32/33] UefiCpuPkg: Fix typos in comments

2016-10-19 Thread Fan, Jeff
Reviewed-by: Jeff Fan Could you please help to fix typo *ruturn* when you commit the patch. - @return The ruturn value of this paramter indicates the number of + @return The ruturn value of this parameter indicates the number of

Re: [edk2] Switch from cx_Freeze to PyInstaller

2016-10-19 Thread Gao, Liming
There is a bug https://bugzilla.tianocore.org/show_bug.cgi?id=55 on Python 3 migration. I suggest you add notes in it. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf > Of ? ?? > Sent: Wednesday, October 19, 2016 8:46 PM > To:

Re: [edk2] question about a compressed Ffs3 file inside FFS2 filesystem

2016-10-19 Thread Zeng, Star
As I remember, the parent FV file system type will inherit the file system type of child file or even child FV in guided section. See r2612 at https://svn.code.sf.net/p/edk2-buildtools/code/trunk/BaseTools/ that is the original BaseTools development trunk. Which revision of BaseTools is being

[edk2] [Patch] NetworkPkg: Coding style refine for IpSecDxe

2016-10-19 Thread Jiaxin Wu
Cc: Bi Dandan Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiaxin Wu --- NetworkPkg/IpSecDxe/IkeCommon.c | 10 +- NetworkPkg/IpSecDxe/IkeCommon.h | 10 +- 2 files changed, 10

Re: [edk2] Why is USB_BOOT_IO_BLOCKS set to 128?

2016-10-19 Thread Heyi Guo
It is a BMC virtual USB channel for BMC KVM. 在 10/19/2016 10:10 AM, Tian, Feng 写道: It's just an experience value and has been here about 10 years... Which usb brand/model name do you have problem on? Thanks Feng -Original Message- From: Heyi Guo [mailto:heyi@linaro.org] Sent:

[edk2] [Patch 3/3 V3] BaseTools/PatchCheck.py: Update to report error for EFI_D_*

2016-10-19 Thread Yonghong Zhu
In EDK2, DEBUG_* is recommended to be used instead of EFI_D_*. For new code, they should use DEBUG_* macro. Fixes:https://bugzilla.tianocore.org/show_bug.cgi?id=143 Cc: Liming Gao Cc: Jordan Justen Contributed-under: TianoCore Contribution

[edk2] [PATCH] ShellPkg: Added GPT Shell Application/Library

2016-10-19 Thread Vladimir Olovyannikov
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Vladimir Olovyannikov This tool allows managing (create, delete, modify, fat format) of GPT partitions from within UEFI Shell. See usage examples in the .uni file Hope that this tool can

Re: [edk2] [PATCH 11/33] IntelFrameworkPkg: Fix typos in comments

2016-10-19 Thread Fan, Jeff
Reviewed-by: Jeff Fan Thanks! -Original Message- From: Gary Lin [mailto:g...@suse.com] Sent: Wednesday, October 19, 2016 3:01 PM To: edk2-devel@lists.01.org Cc: Fan, Jeff Subject: [PATCH 11/33] IntelFrameworkPkg: Fix typos in comments - paramter -> parameter -

Re: [edk2] [PATCH 10/33] IntelFrameworkModulePkg: Fix typos in comments

2016-10-19 Thread Fan, Jeff
Reviewed-by: Jeff Fan Thanks! -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Gary Lin Sent: Wednesday, October 19, 2016 3:01 PM To: edk2-devel@lists.01.org Cc: Fan, Jeff Subject: [edk2] [PATCH 10/33] IntelFrameworkModulePkg:

Re: [edk2] question about a compressed Ffs3 file inside FFS2 filesystem

2016-10-19 Thread Kinney, Michael D
Sean, I agree this seems like a reasonable scenario. Looks like the BaseTools allows generation of this content and the FW code does not support unwrapping it, so there is a mismatch. Please enter a Bugzilla issue for this and we can investigate further. Mike > -Original Message- >

Re: [edk2] question about a compressed Ffs3 file inside FFS2 filesystem

2016-10-19 Thread Andrew Fish
> On Oct 19, 2016, at 4:59 PM, Sean Brogan wrote: > > Yes. I think the challenge in the code is the compressed section is a guided > section and the decompression is all handled transparently. > One solution might be that once a section was processed that had

Re: [edk2] question about a compressed Ffs3 file inside FFS2 filesystem

2016-10-19 Thread Sean Brogan
Yes. I think the challenge in the code is the compressed section is a guided section and the decompression is all handled transparently. One solution might be that once a section was processed that had attributes of EFI_GUIDED_SECTION_PROCESSING_REQUIRED then the check for filesystems should

Re: [edk2] question about a compressed Ffs3 file inside FFS2 filesystem

2016-10-19 Thread valerij zaporogeci
>From the specification: > A firmware volume image section is a leaf section that contains a PI Firmware Volume Image. > EFI_FIRMWARE_VOLUME_IMAGE_SECTION2 must be used if the section is 16MB or > larger. So it looks like PI wants you to use large format (FFS3, File2, Section2) when

Re: [edk2] question about a compressed Ffs3 file inside FFS2 filesystem

2016-10-19 Thread Andrew Fish
> On Oct 19, 2016, at 4:09 PM, Sean Brogan wrote: > > We have a condition that occurs when we boot where we see the following > message and our boot fails because of it. > DEBUG ((EFI_D_ERROR, "Found a FFS3 formatted section in a non-FFS3 formatted > FV.\n")); > >

Re: [edk2] [PATCH] MdeModulePkg: add ARM/AARCH64 requirements to .dsc

2016-10-19 Thread Kinney, Michael D
Leif, Yes. Please commit. I see this was rb 3 weeks ago, and was not picked up by the MdeModulePkg maintainers. Are you aware of any tools to help us notice if a commit like this is missed so we can ping the maintainers? Mike > -Original Message- > From: Leif Lindholm

Re: [edk2] [PATCH 08/33] EmulatorPkg: Fix typos in comments and variables

2016-10-19 Thread Jordan Justen
Reviewed-by: Jordan Justen Pushed EmulatorPkg and OvmfPkg patches. On 2016-10-19 00:01:13, Gary Lin wrote: > - Predfined -> Predefined > - minimue -> minimum > - predeined -> predefined > - excute -> execute > - availible -> available > - discontiguous ->

Re: [edk2] [PATCH 30/33] ShellPkg: Fix typos in comments and variables

2016-10-19 Thread Carsey, Jaben
Is this required to be a patch series? By that I mean that they need to be committed in order... Reviewed-by: Jaben Carsey > -Original Message- > From: Ni, Ruiyu > Sent: Wednesday, October 19, 2016 12:52 AM > To: Gary Lin ;

Re: [edk2] How to get BBS_BBS_DEVICE_PATH from BOOTXXXX variable

2016-10-19 Thread Saqib Khan
Hi, so i have parsed the structure as follow : *BootVariable = mGetVariable(Name, , , NULL);LDAttr = BootVariable[0];FilePathListLength = (BootVariable+2);Ptr = (BootVariable+3); // for description * *for FilePathList[] Ptr+= StrSize((CHAR16 *)Ptr); CopyMem (Ptr, DevicePath,

Re: [edk2] [PATCH] MdeModulePkg: add ARM/AARCH64 requirements to .dsc

2016-10-19 Thread Leif Lindholm
Andrew, Mike - are you OK with me committing this? On 27 September 2016 at 03:24, Ard Biesheuvel wrote: > On 26 September 2016 at 18:15, Leif Lindholm wrote: >> Some LibraryClasses entries are missing to enable standalone builds >> of

Re: [edk2] [PATCH 01/33] ArmPkg: Fix typos in comments

2016-10-19 Thread Ard Biesheuvel
On 19 October 2016 at 08:01, Gary Lin wrote: > - differnt -> different > - Libary -> Library > - intialized -> initialized > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Contributed-under: TianoCore Contribution Agreement 1.0 >

Re: [edk2] [PATCH 01/33] ArmPkg: Fix typos in comments

2016-10-19 Thread Laszlo Ersek
On 10/19/16 17:09, Ard Biesheuvel wrote: > On 19 October 2016 at 08:01, Gary Lin wrote: >> - differnt -> different >> - Libary -> Library >> - intialized -> initialized >> >> Cc: Leif Lindholm >> Cc: Ard Biesheuvel >>

Re: [edk2] [PATCH 09/33] EmbeddedPkg: Fix typos in comments

2016-10-19 Thread Ard Biesheuvel
On 19 October 2016 at 08:01, Gary Lin wrote: > - reseting -> resetting > - stoping -> stopping > - Libary -> Library > - paramter -> parameter > - availible -> available > - availble -> available > - proccessed -> processed > > Cc: Leif Lindholm > Cc: Ard

Re: [edk2] [PATCH 00/33] Fix typos in comments and variables

2016-10-19 Thread Leif Lindholm
On Wed, Oct 19, 2016 at 03:01:05PM +0800, Gary Lin wrote: > When I was reading a header file in CrytoPkg, I found some typos. Out of > curiosity, I started to search typos in some files and this is what I got. > The patch set looks huge but there are lots of typos shared across files > due to

Re: [edk2] [PATCH] ArmPlatformPkg/ArmVExpressPkg: fix the build adding '0x' prefix to hex value

2016-10-19 Thread Leif Lindholm
On Wed, Oct 19, 2016 at 02:24:34PM +0100, Sudeep Holla wrote: > Interestingly the build used to succeed even with missing leading '0x' > prefix for a hex value before the commit 0613ccbd1357 > ("CorebootPayloadPkg/PciHostBridgeLib: Fix the wrong PCI resource limit") > > With the above commit,

Re: [edk2] Build failure with latest edk2/tianocore tip

2016-10-19 Thread Sudeep Holla
On 19/10/16 14:34, Zhu, Yonghong wrote: Thanks . Actually I also need to file a bug on Bugzilla for BaseTools to enhance the error message to be more clear. It should not report such Traceback error. That would be great. I didn't expect e6 in the error message to be part of the array in

Re: [edk2] Build failure with latest edk2/tianocore tip

2016-10-19 Thread Zhu, Yonghong
Thanks . Actually I also need to file a bug on Bugzilla for BaseTools to enhance the error message to be more clear. It should not report such Traceback error. Best Regards, Zhu Yonghong -Original Message- From: Sudeep Holla [mailto:sudeep.ho...@arm.com] Sent: Wednesday, October 19,

[edk2] [PATCH] ArmPlatformPkg/ArmVExpressPkg: fix the build adding '0x' prefix to hex value

2016-10-19 Thread Sudeep Holla
Interestingly the build used to succeed even with missing leading '0x' prefix for a hex value before the commit 0613ccbd1357 ("CorebootPayloadPkg/PciHostBridgeLib: Fix the wrong PCI resource limit") With the above commit, luckily we get ... raise BadExpression(ERR_ARRAY_ELE % self._Token)

Re: [edk2] Build failure with latest edk2/tianocore tip

2016-10-19 Thread Sudeep Holla
Hi Yonghong, On 19/10/16 13:52, Zhu, Yonghong wrote: Hi Sudeep Holla, Could you help to have a check whether there have value e6 in your dec file some Pcd ' NList or Array definition ? We should use 0xe6, the prefix 0x cannot be omitted. I'd like to clone your project, but almost one hour it

Re: [edk2] Build failure with latest edk2/tianocore tip

2016-10-19 Thread Zhu, Yonghong
Hi Sudeep Holla, Could you help to have a check whether there have value e6 in your dec file some Pcd ' NList or Array definition ? We should use 0xe6, the prefix 0x cannot be omitted. I'd like to clone your project, but almost one hour it keep in 95% . BadExpression: This must be HEX value

[edk2] Switch from cx_Freeze to PyInstaller

2016-10-19 Thread Антон Кочков
Good day! Since cx_Freeze is a dead project and doesn't have support for Python 3 - what about switching to PyInstaller instead for Python tools in edk2 tree? This will help for further migration to Python 3 too. Best regards, Anton Kochkov. ___

Re: [edk2] [RFC] edksetup.sh: detect updated BaseTools templates

2016-10-19 Thread Leif Lindholm
So, this thread kind of petered out... I had an internal report of a user failing to build ArmVirtQemu, and narrowed it down to a case of outdated cached configurations. As a temporary workaround, I've now put the proposed timestamp check into my uefi-tools helper scripts, but that's hiding the

Re: [edk2] Build failure with latest edk2/tianocore tip

2016-10-19 Thread Zhu, Yonghong
Hi Sudeep Holla, Thanks for report this bug, I am in investigating it. Best Regards, Zhu Yonghong -Original Message- From: Sudeep Holla [mailto:sudeep.ho...@arm.com] Sent: Wednesday, October 19, 2016 6:06 PM To: edk2-devel (edk2-devel@lists.01.org) Cc: Sudeep

[edk2] [Patch] BaseTools: Fix the bug for OptionRom generation with different arch

2016-10-19 Thread Yonghong Zhu
The GenFds tool uses the same output for the same module with the different arch, IA32 and X64 module will have the same output. The solution is add the arch info in the output directory. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by:

Re: [edk2] [PATCH 22/33] MdePkg: Fix typos in comments

2016-10-19 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Gary Lin [mailto:g...@suse.com] > Sent: Wednesday, October 19, 2016 3:01 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Gao, Liming > > Subject:

Re: [edk2] [PATCH 16/33] MdeModulePkg: BootManagerMenuApp: Fix typos in comments

2016-10-19 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Gary Lin Sent: Wednesday, October 19, 2016 3:01 PM To: edk2-devel@lists.01.org Cc: Tian, Feng ; Zeng, Star

Re: [edk2] [PATCH 07/33] EdkCompatibilityPkg: Fix typos in comments

2016-10-19 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Gary Lin > Sent: Wednesday, October 19, 2016 3:01 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2]

Re: [edk2] [PATCH 30/33] ShellPkg: Fix typos in comments and variables

2016-10-19 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni > -Original Message- > From: Gary Lin [mailto:g...@suse.com] > Sent: Wednesday, October 19, 2016 3:02 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Ni, Ruiyu > Subject: [PATCH 30/33]

Re: [edk2] [PATCH 24/33] Nt32Pkg: Fix typos in comments and variables

2016-10-19 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Gary Lin > Sent: Wednesday, October 19, 2016 3:01 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu > Subject: [edk2] [PATCH

Re: [edk2] [PATCH 25/33] OptionRomPkg: Fix typos in comments

2016-10-19 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Gary Lin > Sent: Wednesday, October 19, 2016 3:02 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu > Subject: [edk2] [PATCH

Re: [edk2] [PATCH 06/33] DuetPkg: Fix typos in comments

2016-10-19 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni > -Original Message- > From: Gary Lin [mailto:g...@suse.com] > Sent: Wednesday, October 19, 2016 3:01 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu > Subject: [PATCH 06/33] DuetPkg: Fix typos in comments > > - TURE ->

Re: [edk2] [PATCH 31/33] SourceLevelDebugPkg: Fix typos in comments

2016-10-19 Thread Wu, Hao A
Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: Gary Lin [mailto:g...@suse.com] > Sent: Wednesday, October 19, 2016 3:02 PM > To: edk2-devel@lists.01.org > Cc: Fan, Jeff; Wu, Hao A > Subject: [PATCH 31/33] SourceLevelDebugPkg: Fix typos in

Re: [edk2] [PATCH 02/33] BaseTools: Fix typos in comments and variables

2016-10-19 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Gary Lin [mailto:g...@suse.com] Sent: Wednesday, October 19, 2016 3:01 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong ; Gao, Liming

Re: [edk2] [PATCH 00/33] Fix typos in comments and variables

2016-10-19 Thread Zeng, Star
Reviewed-by: Star Zeng to MdeModulePkg change. Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Gary Lin Sent: Wednesday, October 19, 2016 3:01 PM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH 00/33] Fix

Re: [edk2] [PATCH 14/33] IntelFsp2Pkg: Fix typos in comments

2016-10-19 Thread Mudusuru, Giri P
Reviewed-by: Giri P Mudusuru > -Original Message- > From: Gary Lin [mailto:g...@suse.com] > Sent: Wednesday, October 19, 2016 12:01 AM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Mudusuru, Giri P > >

Re: [edk2] [PATCH 15/33] IntelFsp2WrapperPkg: Fix a typo in the comment

2016-10-19 Thread Mudusuru, Giri P
Reviewed-by: Giri P Mudusuru > -Original Message- > From: Gary Lin [mailto:g...@suse.com] > Sent: Wednesday, October 19, 2016 12:01 AM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Mudusuru, Giri P > >

Re: [edk2] [PATCH 13/33] IntelFspWrapperPkg: Fix typos in comments

2016-10-19 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Gary Lin > Sent: Wednesday, October 19, 2016 3:01 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen > Subject: [edk2] [PATCH 13/33]

Re: [edk2] [PATCH 12/33] IntelFspPkg: Fix typos in comments

2016-10-19 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Gary Lin > Sent: Wednesday, October 19, 2016 3:01 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen > Subject: [edk2] [PATCH 12/33]

[edk2] [PATCH 30/33] ShellPkg: Fix typos in comments and variables

2016-10-19 Thread Gary Lin
- funciton -> function - paramter -> parameter - supresses -> suppresses - Seperator -> Separator - permenant -> permanent Cc: Jaben Carsey Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Gary Lin

[edk2] [PATCH 28/33] QuarkSocPkg: Fix typos in comments

2016-10-19 Thread Gary Lin
- paramter -> parameter - reseting -> resetting - stoping -> stopping - hanlder -> handler - boundry -> boundary - tempory -> temporary Cc: Michael D Kinney Cc: Kelly Steele Contributed-under: TianoCore Contribution Agreement 1.0

[edk2] [PATCH 33/33] Vlv2TbltDevicePkg: Fix typos in comments

2016-10-19 Thread Gary Lin
- TURE -> TRUE - stardard -> standard - aligments -> alignments - a a -> a - stoping -> stopping - defalut -> default - excute -> execute - Incude -> Include - futhure -> future - Predfined -> Predefined - minimue -> minimum - predeined -> predefined - dirver -> driver - paramter -> parameter -

[edk2] [PATCH 23/33] NetworkPkg: Fix typos in comments

2016-10-19 Thread Gary Lin
- assocated -> associated - malformated -> malformatted - mal-formated -> mal-formatted - formated -> formatted - octects -> octets - responsiblity -> responsibility - enought -> enough - immediatly -> immediately - integar -> integer - Alogrithem -> Algorithm - Initializeion -> Initialization -

[edk2] [PATCH 24/33] Nt32Pkg: Fix typos in comments and variables

2016-10-19 Thread Gary Lin
- discontiguous -> discontinuous - reloaced -> relocated - supresses -> suppresses - debuging -> debugging - suported -> supported - availble -> available - environmemt -> environment - Seperator -> Separator - remmeber -> remember - interperted -> interpreted - the a new -> the new - initailized

[edk2] [PATCH 22/33] MdePkg: Fix typos in comments

2016-10-19 Thread Gary Lin
- Resuts -> Results - outputed -> outputted - specifiecd -> specified - TURE -> TRUE - specifed -> specified - Pointion -> Position - Arrary -> Array - elasped -> elapsed - paramter -> parameter - Sumbit -> Submit Cc: Michael D Kinney Cc: Liming Gao

[edk2] [PATCH 26/33] OvmfPkg: Fix typos in comments

2016-10-19 Thread Gary Lin
- Incude -> Include - futhure -> future - Predfined -> Predefined - minimue -> minimum - predeined -> predefined - excute -> execute - dirver -> driver - inforamtion -> information Cc: Jordan Justen Cc: Laszlo Ersek Contributed-under: TianoCore

[edk2] [PATCH 20/33] MdeModulePkg/Library: Fix typos in comments and variables

2016-10-19 Thread Gary Lin
- servity -> severity - TURE -> TRUE - contiue -> continue - Pepresentation -> Representation - suported -> supported - opints -> points - sucessfully -> successfully - hexidecimal -> hexadecimal - Pacakge -> Package - Libary -> Library - successull -> successfully - reseting -> resetting -

[edk2] [PATCH 31/33] SourceLevelDebugPkg: Fix typos in comments

2016-10-19 Thread Gary Lin
- descrption -> description - Libary -> Library - funciton -> function - paramter -> parameter - triggerred -> triggered - hanlde -> handle Cc: Jeff Fan Cc: Hao Wu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Gary Lin

[edk2] [PATCH 21/33] MdeModulePkg/Universal: Fix typos in comments

2016-10-19 Thread Gary Lin
- stardard -> standard - doule -> double - defalut -> default - Pacakge -> Package - globa -> global - responsiblity -> responsibility - outputed -> outputted - specifiecd -> specified - Resuts -> Results - the a -> a - suported -> supported - assocated -> associated - TURE -> TRUE - successfull

[edk2] [PATCH 25/33] OptionRomPkg: Fix typos in comments

2016-10-19 Thread Gary Lin
- stoping -> stopping - Sumbit -> Submit - pionter -> pointer Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Gary Lin --- OptionRomPkg/AtapiPassThruDxe/AtapiPassThru.c | 6 +++---

[edk2] [PATCH 27/33] QuarkPlatformPkg: Fix typos in comments

2016-10-19 Thread Gary Lin
- TURE -> TRUE - reseting -> resetting - retore -> restore - boundry -> boundary - tempory -> temporary Cc: Michael D Kinney Cc: Kelly Steele Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Gary Lin ---

[edk2] [PATCH 19/33] MdeModulePkg/Include: Fix typos in comments

2016-10-19 Thread Gary Lin
- opints -> points - sucessfully -> successfully - suported -> supported - hexidecimal -> hexadecimal - TURE -> TRUE - servity -> severity - Moudle -> Module - contiue -> continue - infomation -> information - malformated -> malformatted - Pepresentation -> Representation - opeque -> opaque -

[edk2] [PATCH 14/33] IntelFsp2Pkg: Fix typos in comments

2016-10-19 Thread Gary Lin
- tempory -> temporary - immediatly -> immediately - permenent -> permanent - funciton -> function Cc: Jiewen Yao Cc: Giri P Mudusuru Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Gary Lin ---

[edk2] [PATCH 16/33] MdeModulePkg: BootManagerMenuApp: Fix typos in comments

2016-10-19 Thread Gary Lin
- chracter -> character - lanaguag -> language - proccessed -> processed - optin -> option Cc: Feng Tian Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Gary Lin ---

[edk2] [PATCH 17/33] MdeModulePkg/Bus: Fix typos in comments

2016-10-19 Thread Gary Lin
- TURE -> TRUE - stoping -> stopping - doule -> double - Peroidic -> Periodic - stardard -> standard - a a -> a - reseting -> resetting - excute -> execute - connectted -> connected - Sumbit -> Submit Cc: Feng Tian Cc: Star Zeng Contributed-under:

[edk2] [PATCH 13/33] IntelFspWrapperPkg: Fix typos in comments

2016-10-19 Thread Gary Lin
- inforamtion -> information - tempory -> temporary - boundry -> boundary - immediatly -> immediately - permenent -> permanent Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Gary Lin ---

[edk2] [PATCH 15/33] IntelFsp2WrapperPkg: Fix a typo in the comment

2016-10-19 Thread Gary Lin
- boundry -> boundary Cc: Jiewen Yao Cc: Giri P Mudusuru Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Gary Lin --- IntelFsp2WrapperPkg/FspWrapperNotifyDxe/LoadBelow4G.c | 2 +- 1 file changed, 1

[edk2] [PATCH 09/33] EmbeddedPkg: Fix typos in comments

2016-10-19 Thread Gary Lin
- reseting -> resetting - stoping -> stopping - Libary -> Library - paramter -> parameter - availible -> available - availble -> available - proccessed -> processed Cc: Leif Lindholm Cc: Ard Biesheuvel Contributed-under: TianoCore

[edk2] [PATCH 07/33] EdkCompatibilityPkg: Fix typos in comments

2016-10-19 Thread Gary Lin
- excute -> execute - Pacakges -> Packages - successfull -> successfully - outputed -> outputted - triggerred -> triggered - specifiecd -> specified - hexidecimal -> hexadecimal - Arrary -> Array - Pointion -> Position - paramter -> parameter - stardard -> standard - perodically -> periodically -

[edk2] [PATCH 00/33] Fix typos in comments and variables

2016-10-19 Thread Gary Lin
When I was reading a header file in CrytoPkg, I found some typos. Out of curiosity, I started to search typos in some files and this is what I got. The patch set looks huge but there are lots of typos shared across files due to copy, so it's actually not so scary. I tried to collect all fixes in

[edk2] [PATCH 01/33] ArmPkg: Fix typos in comments

2016-10-19 Thread Gary Lin
- differnt -> different - Libary -> Library - intialized -> initialized Cc: Leif Lindholm Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Gary Lin ---

[edk2] [PATCH 05/33] CryptoPkg: Fix typos in comments

2016-10-19 Thread Gary Lin
- intialized -> initialized - componenet -> component - compoents -> components - FAlSE -> FALSE - responsiblity -> responsibility - validility -> validity - procudure -> procedure - pamameter -> parameter - randome -> random - buiild -> build Cc: Ting Ye Cc: Qin Long

[edk2] [PATCH 11/33] IntelFrameworkPkg: Fix typos in comments

2016-10-19 Thread Gary Lin
- paramter -> parameter - availible -> available Cc: Jeff Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Gary Lin --- IntelFrameworkPkg/Include/Protocol/FrameworkFormCallback.h| 2 +-

[edk2] [PATCH 04/33] CorebootModulePkg: Fix typos in comments

2016-10-19 Thread Gary Lin
- inforamtion -> information - tempory -> temporary - immediatly -> immediately - permenent -> permanent Cc: Maurice Ma Cc: Prince Agyeman Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Gary Lin ---

[edk2] [PATCH 08/33] EmulatorPkg: Fix typos in comments and variables

2016-10-19 Thread Gary Lin
- Predfined -> Predefined - minimue -> minimum - predeined -> predefined - excute -> execute - availible -> available - discontiguous -> discontinuous - permenent -> permanent - immediatly -> immediately - environmemt -> environment - Seperator -> Separator - remmeber -> remember - initailized ->

[edk2] [PATCH 06/33] DuetPkg: Fix typos in comments

2016-10-19 Thread Gary Lin
- TURE -> TRUE - successull -> successfully - Libary -> Library - Incude -> Include - futhure -> future - Predfined -> Predefined - minimue -> minimum - predeined -> predefined - excute -> execute - dirver -> driver - hanlde -> handle - boundry -> boundary Cc: Ruiyu Ni

[edk2] [PATCH 12/33] IntelFspPkg: Fix typos in comments

2016-10-19 Thread Gary Lin
- tempory -> temporary - immediatly -> immediately - permenent -> permanent - paramter -> parameter - funciton -> function Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Gary Lin --- IntelFspPkg/FspSecCore/SecMain.c

[edk2] [PATCH 03/33] CorebootPayloadPkg: Fix typos in comments

2016-10-19 Thread Gary Lin
- dirver -> driver - futhure -> future Cc: Maurice Ma Cc: Prince Agyeman Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Gary Lin --- CorebootPayloadPkg/Library/PlatformBootManagerLib/PlatformConsole.c | 4

[edk2] [PATCH 02/33] BaseTools: Fix typos in comments and variables

2016-10-19 Thread Gary Lin
- Pacakge -> Package - outputed -> outputted - successull -> successfully - Libary -> Library - Pointion -> Position - paramter -> parameter Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Gary