[edk2] LocateHandle for gEfiShellProtocolGuid is failing in my application

2016-12-20 Thread GN Keshava
Hi, I'm developing a shell application. A call to LocateHandle for gEfiShellProtocolGuid is failing with Status 0x0E. Below is my code. Please let me know what I'm doing wrong. Status = gBS->LocateHandle(ByProtocol, &gEfiShellProtocolGuid, NULL, &BufferSize, Buffer); // Get BufferSize if (EFI_ER

Re: [edk2] [PATCH v7] BaseTools/Scripts/PatchCheck.py: Extended patch style check for c code

2016-12-20 Thread Jordan Justen
On 2016-12-19 00:31:13, Gao, Liming wrote: > Daniil: > This version has addressed my comments. I see Jordan also provides > some comments. Are they handled in this patch? > No, they were not addressed. Here are my replies: v5: https://lists.01.org/pipermail/edk2-devel/2016-December/005779.htm

[edk2] FDF Spec question?

2016-12-20 Thread Andrew Fish
Is it possible in the FDF syntax to make the payload of a EFI_SECTION_GUID_DEFINED (Encapsulating section) a raw binary file? I can make the contents of the GUID'ed encapsulation section a section. But when I'm processing the GUID'ed section I just end up skipping over the extra 4 byte section

Re: [edk2] [patch 2/8] FatPkg\EnhancedFatDxe: Initialize variable after declaration

2016-12-20 Thread Brian J. Johnson
On 12/08/2016 05:11 PM, Andrew Fish wrote: On Dec 8, 2016, at 9:27 AM, Kurt Kennett wrote: This seems kind of silly. Why isn't this just const data? This adds code and memory accesses that are worthless and happen on every call to the function. K2, I think this is an attempt to conform to

Re: [edk2] [patch 1/2] UefiCpuPkg: Add Pcd info to uni file

2016-12-20 Thread Kinney, Michael D
Reviewed-by: Michael Kinney > -Original Message- > From: Bi, Dandan > Sent: Monday, December 19, 2016 11:53 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Fan, Jeff > > Subject: [patch 1/2] UefiCpuPkg: Add Pcd info to uni file > > Add PcdCpuSmmStmExceptionStackSize/PcdCpuMse

Re: [edk2] [patch 2/2] UefiCpuPkg/SmmCpuFeaturesLib: Fix coding style issues

2016-12-20 Thread Kinney, Michael D
Reviewed-by: Michael Kinney > -Original Message- > From: Bi, Dandan > Sent: Monday, December 19, 2016 11:53 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Fan, Jeff > > Subject: [patch 2/2] UefiCpuPkg/SmmCpuFeaturesLib: Fix coding style issues > > Cc: Michael Kinney > Cc: J

Re: [edk2] [PATCH] ShellPkg: Add acpiview tool to dump ACPI tables

2016-12-20 Thread Yao, Jiewen
Thank you, Lloyd. Comment inline. From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Evan Lloyd Sent: Tuesday, December 20, 2016 9:21 PM To: Yao, Jiewen ; Ni, Ruiyu ; Carsey, Jaben ; Sami Mujawar Cc: Carsey, Jaben ; edk2-de...@ml01.01.org; Leif Lindholm ; ard.biesheu...@li

Re: [edk2] [PATCH] ShellPkg: Add acpiview tool to dump ACPI tables

2016-12-20 Thread Evan Lloyd
Hi Jiewen. Some responses inline below: > From: Yao, Jiewen [mailto:jiewen@intel.com] > Sent: 20 December 2016 05:54 > To: Ni, Ruiyu; Carsey, Jaben; Evan Lloyd > Cc: Carsey, Jaben; edk2-de...@ml01.01.org; Leif Lindholm; > ard.biesheu...@linaro.org > Subject: RE: [edk2] [PATCH] ShellPkg: Add a

Re: [edk2] [PATCH] ShellPkg: Add acpiview tool to dump ACPI tables

2016-12-20 Thread Evan Lloyd
Hi Ray. Comments inline below >-Original Message- >From: Ni, Ruiyu [mailto:ruiyu...@intel.com] >Sent: 20 December 2016 02:59 >To: Carsey, Jaben; Evan Lloyd >Cc: Leif Lindholm; ard.biesheu...@linaro.org; edk2-de...@ml01.01.org >Subject: RE: [edk2] [PATCH] ShellPkg: Add acpiview tool to dump

Re: [edk2] [PATCH 0/6] Refine code logics to prevent possible mis-reports by static code checkers

2016-12-20 Thread Wu, Hao A
Hi Heyi, For the warnings reported by the static checkers you mentioned, could you help to analyze those issues and find out if there are real issues exist? If there are real code issues, I think you can report them to Bugzilla with the appropriate classification (e.g. Security or Not Security Re

Re: [edk2] [Patch] SecurityPkg Tcg2ConfigDxe: Force reset when PCR Allocation changed.

2016-12-20 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: Dong, Eric Sent: Tuesday, December 20, 2016 3:57 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen ; Zeng, Star Subject: [Patch] SecurityPkg Tcg2ConfigDxe: Force reset when PCR Allocation changed. Contributed-under: TianoCore Contribution A