Re: [edk2] Pressing ESC from "PXE windows Boot manager" causes ASSERT

2017-05-23 Thread Karunakar P
Hello All, The ASSERT happens in the following function /** Internal function to free a pool entry. Caller must have the memory lock held @param Buffer The allocated pool entry to free @param PoolType Pointer to pool type @retval EFI_INVALID_PARAMETER

Re: [edk2] Pressing ESC from "PXE windows Boot manager" causes ASSERT

2017-05-23 Thread Ye, Ting
Hi Karunakar, Sorry I did not find your attached files. Would you please send them again? Besides that, do you mind telling us which code base are you using for PXE boot? Are you using some revision of EDKII main trunk or UDK release? Thanks, Ting -Original Message- From: edk2-devel

Re: [edk2] Pressing ESC from "PXE windows Boot manager" causes ASSERT

2017-05-23 Thread Andrew Fish
Karuakar, I thought the ASSERT usually contained the line number? Anyway the CR macro stands for Containment Record. Usually you have a pointer into a structure and you use the CR macro to find the start of the structure. It is common for things CR to include a signature at the start of the

[edk2] Pressing ESC from "PXE windows Boot manager" causes ASSERT

2017-05-23 Thread Karunakar P
Hi All, We have facing an issue with PXE boot. [Issue] When ESC is pressed from Windows Boot manager during PXE boot (IPv4 or IPv6) system Hangs with following ASSERT ASSERT [DxeCore] \MdeModulePkg\Core\Dxe\Mem\Pool.c : CR has Bad Signature [Reproduction Steps] 1. Perform UEFI PXEv4 or UEFI

Re: [edk2] [Patch] BaseTools: Fix the bug that different DSC file use same build output

2017-05-23 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Tuesday, May 23, 2017 5:25 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2]

Re: [edk2] [Patch V2] BaseTools: Fix incremental build bug on DynamicPcd Token Generation

2017-05-23 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Tuesday, May 23, 2017 2:43 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2]

Re: [edk2] [Patch] SourceLevelDebugPkg/SecPeiDebugAgentLib: Fix duplicate symbol

2017-05-23 Thread Fan, Jeff
Reviewed-by: Jeff Fan -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Michael Kinney Sent: Wednesday, May 24, 2017 7:21 AM To: edk2-devel@lists.01.org Cc: Wu, Hao A; Kinney, Michael D; Laszlo Ersek; Andrew Fish; Fan, Jeff

Re: [edk2] [PATCH] MdePkg: Fix undefined behavior on variadic parameters

2017-05-23 Thread Kinney, Michael D
Sergey, We also need to do a full search for use of variadic parameters to make sure we have a solution for all of them and update the EDK II C coding standard to make sure the rules for use of variadic parameters for maximum compiler compatibility are captured correctly. Did you try Andrew

Re: [edk2] [PATCH] MdePkg: Fix undefined behavior on variadic parameters

2017-05-23 Thread Gao, Liming
Sergey: This patch updates API interface. I still need to verify its functionality on other tool chain. I will give you feedback after I am done. Thanks Liming >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Friday, May 19, 2017 4:16 PM >To: Sergei

Re: [edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] BroxtonSiPkg:Fix Debug image assert issue

2017-05-23 Thread Wei, David
Reviewed-by: zwei4 Thanks, David Wei -Original Message- From: Guo, Mang Sent: Tuesday, May 23, 2017 7:01 PM To: edk2-devel@lists.01.org Cc: Wei, David Subject:

Re: [edk2] [Patch 0/2] MdeModulePkg: Fix XCODE5 build failures

2017-05-23 Thread Zeng, Star
Reviewed-by: Star Zeng to this patch series. Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Michael Kinney Sent: Wednesday, May 24, 2017 7:10 AM To: edk2-devel@lists.01.org Cc: Kinney, Michael D

Re: [edk2] [Patch] SourceLevelDebugPkg/SecPeiDebugAgentLib: Fix duplicate symbol

2017-05-23 Thread Kinney, Michael D
Andrew, I agree in this specific case, making the global variable static should also resolve this issue. In general, we do not make module global variables static, so the module global can be shared across multiple source files in the module implementation. Not sure why this issue has not

Re: [edk2] [Patch] SourceLevelDebugPkg/SecPeiDebugAgentLib: Fix duplicate symbol

2017-05-23 Thread Andrew Fish
Mike, Do the other compilers promote (or is that demote) to static? Would not making these lib globals, and private functions static solve this class of issue? Thanks, Andrew Fish > On May 23, 2017, at 4:21 PM, Michael Kinney > wrote: > >

[edk2] [Patch] SourceLevelDebugPkg/SecPeiDebugAgentLib: Fix duplicate symbol

2017-05-23 Thread Michael Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=573 The SecPeiDebugAgentLib uses the global variable mMemoryDiscoveredNotifyList for a PPI notification on the Memory Discovered PPI. This same variable name is used in the DxeIplPeim for the same PPI notification. The XCODE5 tool chain detects

[edk2] [Patch 2/2] MdeModulePkg/DebugSupportDxe: Fix XCODE5 build failure

2017-05-23 Thread Michael Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=572 Update X64 AsmFuncs.S to resolve a build failure using the XCODE5 tool chain. This change updates AsmFuncs.S to match AsmFuncs.asm and AsmFuncs.nasm. The error generated in XCODE5 build is: error: invalid instruction mnemonic 'movzxw'

[edk2] [Patch 1/2] MdeModulePkg/RegularExpressionDxe: Fix XCODE5 build failure

2017-05-23 Thread Michael Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=572 The ErrorMessage local variable in OnigurumaMatch() should be type OnigUChar instead of type CHAR8. This resolves a build failure with the XCODE5 tool chain. Cc: Andrew Fish Cc: Star Zeng Cc: Eric Dong

[edk2] [Patch 0/2] MdeModulePkg: Fix XCODE5 build failures

2017-05-23 Thread Michael Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=572 Fix local variable type in RegularExpressionDxe and an X64 GAS(.S) file assembly instructon format in DebugSupportDxe. Both of these are generatingf build failures with the XCODE5 tool chain when building MdeModulePkg.dsc. Cc: Andrew Fish

[edk2] [PATCH] Copy bus scanning workaround from ARM Juno PCIe driver.

2017-05-23 Thread Scott Telford
Copy workaround previously in ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciRootBridge.c:PciRbPciRead() to RootBridgeIoPciAccess(), to avoid spurious multiple detections when scanning buses. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Scott Telford

Re: [edk2] [PATCH v2 5/5] OvmfPkg: make the 4MB flash size the default (again)

2017-05-23 Thread Laszlo Ersek
On 05/18/17 17:14, Laszlo Ersek wrote: > The previously default 2MB can be explicitly selected with > > -D FD_SIZE_2MB > > or > > -D FD_SIZE_IN_KB=2048 > > Cc: Jordan Justen > Suggested-by: Jordan Justen > Contributed-under: TianoCore

Re: [edk2] Is: Fix for 4MB BIOS payload in hvmloader. Was:Re: [PATCH 0/5] OvmfPkg: complete the 4MB flash image support ("-bios" / emulated variables)

2017-05-23 Thread Laszlo Ersek
On 05/23/17 17:01, Jan Beulich wrote: On 23.05.17 at 16:12, wrote: >> On Thu, May 18, 2017 at 02:36:33PM +0200, Laszlo Ersek wrote: >>> The situation is further hampered by the fact that Xen is (apparently) >>> right at 4.9.0-rc5, so they likely won't commit Jan's

Re: [edk2] [PATCH] ShellPkg/UefiShellLib: Avoid reading undefined content before string

2017-05-23 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: Wu, Hao A > Sent: Monday, May 22, 2017 7:04 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Ni, Ruiyu ; > Carsey, Jaben > Subject: [PATCH]

[edk2] Is: Fix for 4MB BIOS payload in hvmloader. Was:Re: [PATCH 0/5] OvmfPkg: complete the 4MB flash image support ("-bios" / emulated variables)

2017-05-23 Thread Konrad Rzeszutek Wilk
Adding Jan (autor of patch) and Julien (Xen release manager); Pls see below. On Thu, May 18, 2017 at 02:36:33PM +0200, Laszlo Ersek wrote: > On 05/16/17 06:20, Gary Lin wrote: > > On Mon, May 15, 2017 at 05:40:59PM -0700, Jordan Justen wrote: > >> On 2017-05-12 01:40:34, Laszlo Ersek wrote: >

Re: [edk2] UEFI shell vs UEFI BIOS version compatibility

2017-05-23 Thread GN Keshava
Hi Ramesh, Thanks for the reply. But I'm facing issue when i load a driver using load command. I tried with the latest driver binary. Also, this issue is not observed on Intel Gigabit motherboard with UEFI bios version 2.4. But issue is observed on PC with UEFI 2.3.1 When I load driver.efi,

Re: [edk2] UEFI shell vs UEFI BIOS version compatibility

2017-05-23 Thread Ramesh R .
Hi, Old Shell was installing EFI_SHELL_INTERFACE and new shell is installing the EFI_SHELL_PARAMETERS_PROTOCOL on the shell application. Thanks, Ramesh -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of GN Keshava Sent: 23 May 2017 17:01 To:

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] BroxtonSiPkg:Fix Debug image assert issue

2017-05-23 Thread Guo, Mang
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Guo Mang --- Silicon/BroxtonSoC/BroxtonSiPkg/SouthCluster/ScInit/Smm/ScInitSmm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/Silicon/BroxtonSoC/BroxtonSiPkg/SouthCluster/ScInit/Smm/ScInitSmm.c

Re: [edk2] [PATCH] Arm: GICv3: Don't access GIC_ICDIPR for interrupts 0..31

2017-05-23 Thread Ard Biesheuvel
On 22 May 2017 at 10:45, Leif Lindholm wrote: > On Fri, May 19, 2017 at 05:31:36PM +0300, Sergei Temerkhanov wrote: >> On Fri, May 19, 2017 at 1:26 PM, Leif Lindholm >> wrote: >> > On Fri, May 19, 2017 at 05:37:02AM +0300, Sergei Temerkhanov

[edk2] [Patch] BaseTools: Fix the bug that different DSC file use same build output

2017-05-23 Thread Yonghong Zhu
We meet a corner case that build different DSC file, but the DSC file use same build output directory, and the different DSC file use a same PCD with different Pcd Type, it cause build failure. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0

Re: [edk2] [PATCH] MdeModulePkg SmiHandlerProfile: Use fixed data type in data structure

2017-05-23 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star > Zeng > Sent: Tuesday, May 23, 2017 1:20 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Zeng, Star >

Re: [edk2] [PATCH] MdeModulePkg MemoryProfileInfo: Use PdbStringOffset to get PDB info

2017-05-23 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Tuesday, May 23, 2017 2:27 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Yao, Jiewen > Subject: [PATCH] MdeModulePkg MemoryProfileInfo: Use PdbStringOffset

[edk2] [Patch V2] BaseTools: Fix incremental build bug on DynamicPcd Token Generation

2017-05-23 Thread Yonghong Zhu
During incremental build, we meet the bug that the different drivers use the different token for the same DynamicPcd. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu ---

[edk2] [PATCH] MdeModulePkg MemoryProfileInfo: Use PdbStringOffset to get PDB info

2017-05-23 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=570 Use PdbStringOffset to get PDB info, it will have no functional impact, and will just make the code more generic. Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng

Re: [edk2] [PATCH] MdeModulePkg SmiHandlerProfile: Fix no PDB case handling incorrectly

2017-05-23 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Tuesday, May 23, 2017 12:34 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Yao, Jiewen > Subject: [PATCH] MdeModulePkg SmiHandlerProfile: Fix no PDB case